| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-sdks - 2019-08-09 | |||
| 16:42:44 | dtroyer | mriedem: thanks, agreed | |
| 16:44:40 | openstackgerrit | Matt Riedemann proposed openstack/python-openstackclient master: Fix |
|
| 16:44:47 | openstackgerrit | Matt Riedemann proposed openstack/python-openstackclient master: Add openstack server create --boot-from-volume option https://review.opendev.org/674111 | |
| 16:45:12 | mriedem | $ openstack server create --image $IMAGE_ID --block-device-mapping vda=$IMAGE_ID:image:1:true --flavor m1.tiny --wait test-vol-backed-vm-from-image The volume cannot be assigned the same device name as the root device vda (HTTP 400) (Request-ID: req-b4569b5f-4415-4911-9119-7afd856e2714) | |
| 16:45:42 | mriedem | from my earlier testing | |
| 16:45:59 | dtroyer | yup, that's a pretty clear error message | |
| 17:23:25 | Shrews | mordred: Should we just delete the openstacksdk-functional-devstack-magnum test, or do you know a magnum expert who might want to fix it? It never passes. | |
| 17:24:37 | mordred | Shrews: wow, and it fails "has service magnum" | |
| 17:24:53 | mordred | Shrews: I'd say it's pretty useless currently | |
| 17:25:04 | Shrews | mordred: yeah. i had a quick glance at it but couldn't figure out what, exactly, was wrong | |
| 17:29:41 | openstackgerrit | Merged openstack/python-openstackclient master: Make configuration show not require auth https://review.opendev.org/673110 | |
| 17:32:50 | efried | !SHAZAM! | |
| 17:32:51 | openstack | efried: Error: "SHAZAM!" is not a valid command. | |
| 17:36:20 | mordred | efried: it's so sad that !SHAZAM! isn't a valid command | |
| 17:36:52 | efried | Maybe it doesn't work for everyone | |
| 17:37:23 | efried | Because, you see, now I *look* like a superhero, but I'm still an immature kid on the inside. | |
| 17:39:39 | Shrews | that movie disappointed me, particularly the ending | |
| 17:41:41 | efried | I went in with expectations too high, because a friend told me he really liked it. | |
| 17:42:38 | efried | mordred, Shrews: This seems... wrong: https://opendev.org/openstack/openstacksdk/src/branch/master/openstack/proxy.py#L129 | |
| 17:42:43 | efried | The *args part | |
| 17:43:07 | efried | I don't think there's a way you can call that such that `args` has anything in it. | |
| 17:43:27 | efried | (slightly surprising that python even lets you define a param list that way, but I've seen it before) | |
| 17:46:43 | mordred | efried: I *think* if you were to call it like Proxy(session, statsd_client, statsd_prefix, prometheus_counter, prometheus_historgram, foo) that foo would wind up in *args | |
| 17:47:12 | efried | mordred: But then the super() call would blow up, nah? | |
| 17:47:20 | mordred | yeah - totally. | |
| 17:47:38 | mordred | we should get rid of that *args - I don't think we want people calling things with positional args anyway tbh | |
| 17:47:55 | efried | I always ask people to name kwargs | |
| 17:47:57 | efried | even in unit tests | |
| 17:48:00 | mordred | ++ | |
| 17:48:16 | efried | but it's not especially enforceable | |
| 17:48:31 | mordred | in 3.6 it is ... foo(self, *, bar=None) | |
| 17:48:41 | mordred | defines bar as a keyword only argument | |
| 17:48:59 | mordred | so once we drop 2.7 - bob's our uncle | |
| 17:49:05 | efried | neat. | |
| 17:49:14 | efried | I had *two* uncle Bobs. | |
| 17:50:58 | mordred | HA bob | |
| 17:52:46 | efried | well, one of them failed, and hasn't been replaced, so... | |
| 17:53:57 | mordred | :( | |
| 17:58:24 | efried | As my first superhero act, I'm sending https://review.opendev.org/#/c/675135/ | |
| 18:10:31 | Shrews | mordred: Do you know if swift converts the casing of any object metadata we supply? Looks like we store in lowercase, but it comes back camel cased. This is messing with our dict.get() calls | |
| 18:17:30 | Shrews | hrm, seems so. wow, none of the object code dealing with metadata allows for this | |
| 18:26:11 | Shrews | also, the autocreate header we put on the objects has a different header value??? | |
| 18:26:19 | Shrews | HOW IS ANYTHING WORKING?!?!? | |
| 18:26:21 | Shrews | :) | |
| 18:29:08 | Shrews | returned header is: x-object-meta-x-object-meta-x-sdk-autocreated | |
| 18:29:23 | Shrews | the header we save is: x-object-meta-x-sdk-autocreated | |
| 18:29:47 | Shrews | an extra "x-object-meta" is prepended somewhere | |
| 18:30:02 | Shrews | doesn't seem to happen on the checksum headers though | |
| 18:30:27 | Shrews | can open... worms everywhere | |
| 18:32:27 | mordred | Shrews: see - I look away for a few minutes and you discover that the entire world is broken | |
| 18:32:52 | Shrews | mordred: stop letting me do things | |
| 18:33:11 | mordred | Shrews: no- do more things! the worms - they're everywhere?! | |
| 18:34:07 | Shrews | serves me right for trying to do a real-world test on my object cleanup code | |
| 18:35:53 | Shrews | i guess this means we are also missing functional tests of all this code | |
| 18:36:24 | efried | Shrews: Would you please have a look at https://review.opendev.org/#/c/674675/ when you get a chance? TIA | |
| 18:36:55 | efried | mordred: I think your patch may get rid of the warnings, but IMO we still want that ^ yah? | |
| 18:47:38 | Shrews | efried_pto: yeah, i'm gonna tackle this swift problem first while i have it paged in | |
| 18:51:25 | mordred | efried_pto: yeah - might as well | |
| 19:23:11 | Shrews | AHA! found the header bug | |
| 19:31:40 | openstackgerrit | David Shrewsbury proposed openstack/openstacksdk master: Add option to lowercase object meta keys https://review.opendev.org/675682 | |
| 19:31:41 | openstackgerrit | David Shrewsbury proposed openstack/openstacksdk master: bug: avoid unnecessary object meta prefix https://review.opendev.org/675683 | |
| 19:31:41 | openstackgerrit | David Shrewsbury proposed openstack/openstacksdk master: bug: Consider case when comparing object values https://review.opendev.org/675684 | |
| 19:31:49 | Shrews | mordred: enjoy all the things | |
| 19:32:19 | Shrews | mordred: two of those probably need tests | |
| 19:32:28 | timburke | Shrews, mordred fwiw, swift will title case header names going out, but those are case-insensitive per the rfc. i know on py2, something (mimetools? rfc822?) would lower-case them when reading the response, while py3 preserves the casing from the wire | |
| 19:32:56 | timburke | header values should preserve whatever casing you sent with the PUT/POST | |
| 19:33:04 | Shrews | timburke: well, looks like we get them back in camelcase, even though we put in lower | |
| 19:33:15 | Shrews | i'm not sure where or why that's happening | |
| 19:34:22 | Shrews | unless we camel case our debug output just to be weird? /me checks | |
| 19:35:55 | openstackgerrit | Merged openstack/openstacksdk master: Skip most service_description for unknown services https://review.opendev.org/675135 | |
| 19:39:08 | openstackgerrit | David Shrewsbury proposed openstack/openstacksdk master: Retry large object manifest upload https://review.opendev.org/675134 | |
| 19:39:10 | mordred | Shrews: so ... | |
| 19:39:40 | mordred | Shrews: the headers object on the requests.Response here: https://review.opendev.org/#/c/675682/1/openstack/cloud/_object_store.py ... should be of type CaseInsensitiveDict | |
| 19:40:25 | mordred | Shrews: that's super weird that you're having to lowercase them (although I totally believe you) | |
| 19:42:49 | Shrews | mordred: oh? i not sure that i've even heard of CaseInsensitiveDict. If that's the case, my failed dict.get() calls were probably just the extra prefix thing | |
| 19:43:17 | mordred | Shrews: it's an object from the requests library | |
| 19:43:30 | Shrews | mordred: YOU'RE an object from the requests library | |
| 19:43:31 | mordred | because http headers are theoretically case insensitive | |
| 19:43:42 | mordred | Shrews: some days I certainlky feel that way | |
| 19:44:11 | Shrews | mordred: ok. i'll get rid of the lowercase stuff then | |
| 19:47:21 | openstackgerrit | David Shrewsbury proposed openstack/openstacksdk master: bug: avoid unnecessary object meta prefix https://review.opendev.org/675683 | |
| 19:47:22 | openstackgerrit | David Shrewsbury proposed openstack/openstacksdk master: Retry large object manifest upload https://review.opendev.org/675134 | |
| 19:48:35 | Shrews | mordred: ok, that should be what we need now | |
| 20:04:12 | mordred | Shrews: that looks fantastic! | |
| 20:09:03 | Shrews | mordred: oh, oops. found a nit to fix in that | |
| 20:09:12 | mordred | doh | |
| 20:09:13 | openstackgerrit | David Shrewsbury proposed openstack/openstacksdk master: Retry large object manifest upload https://review.opendev.org/675134 | |
| 20:10:06 | Shrews | just minor cleanup i forgot to do | |
| 23:30:21 | openstackgerrit | Merged openstack/openstacksdk master: Allow limiting Connection service_types from oslo.config https://review.opendev.org/674675 | |
| #openstack-sdks - 2019-08-10 | |||
| 06:16:46 | openstackgerrit | Shubham Potale proposed openstack/openstacksdk master: Add support for nfv-orchestration service https://review.opendev.org/675604 | |
| 06:40:50 | openstackgerrit | Merged openstack/openstacksdk master: bug: avoid unnecessary object meta prefix https://review.opendev.org/675683 | |
| 07:06:20 | openstackgerrit | Shubham Potale proposed openstack/python-openstackclient master: Add command for upload vnf package API https://review.opendev.org/675612 | |
| 09:37:57 | openstackgerrit | Shubham Potale proposed openstack/openstacksdk master: Add support for nfv-orchestration service https://review.opendev.org/675604 | |
| #openstack-sdks - 2019-08-11 | |||
| 06:02:02 | openstackgerrit | Adrian Turjak proposed openstack/keystoneauth master: add support for auth_receipts and multi-method auth https://review.opendev.org/675049 | |
| #openstack-sdks - 2019-08-12 | |||
| 03:01:27 | openstackgerrit | Brin Zhang proposed openstack/python-openstackclient master: Add server migration list CLI https://review.opendev.org/675304 | |
| 04:09:22 | openstackgerrit | Brin Zhang proposed openstack/python-openstackclient master: Add server migration list CLI https://review.opendev.org/675304 | |
| 09:29:32 | dtantsur | mordred, morning, have a second for https://review.opendev.org/#/c/674298/ ? | |
| 09:32:28 | frickler | mordred: kmalloc: cmurphy: I finally found the location where ksc hardcodes using the admin endpoint: https://opendev.org/openstack/python-keystoneclient/src/branch/master/keystoneclient/httpclient.py#L251 | |
| 09:35:11 | frickler | we can do a workaround in heat, but fixing in ksc would seem better to me in the long run. seems that a lot of tests depend on the current default though | |
| 10:41:03 | openstackgerrit | Bence Romsics proposed openstack/openstacksdk master: Add router add/remove route operations https://review.opendev.org/674324 | |