| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-sdks - 2019-04-08 | |||
| 13:34:04 | cdent | \o/ | |
| 13:34:12 | mordred | sometimes setup takes a little more work - but you get to test "does this payload from the server result in the correct object behavior in the client" - which is, of course, the thing you actually care about | |
| 13:34:27 | mordred | "Does layer 1 call hidden method 2" is completely useless to know | |
| 13:34:58 | cdent | that's the same spirit that drives gabbi, on the other side | |
| 13:35:27 | mordred | ++ | |
| 13:35:28 | dtantsur | this file is awful indeed | |
| 13:36:32 | mordred | dtantsur: I keep wanting to rip out all of the unittests using it and replace them with requests-mock based tests- but it took us about 8 months to do that with shade and it was MINDNUMBING so I haven't gotten angry enough to do it with these yet | |
| 13:36:45 | dtantsur | right | |
| 13:37:30 | dtantsur | we could start with replacing it with mocking Session. it's not perfect, but tests much more. | |
| 13:37:41 | dtantsur | as you know, I tend to write my unit tests like that | |
| 13:38:41 | mordred | yeah - althuogh we've already got a Session in each unit test that is set up with requests-mock - like, the plumbing is all there, so we don't really even have to mock session | |
| 13:40:08 | mordred | with auth and catalogs already even! :) | |
| 13:40:24 | mordred | I think the real issue is that we need to dig in to "What is this test supposed to be testing" | |
| 13:54:43 | openstackgerrit | Monty Taylor proposed openstack/openstacksdk master: Add logger to Proxy object https://review.openstack.org/650901 | |
| 13:54:43 | openstackgerrit | Monty Taylor proposed openstack/openstacksdk master: Support microversion 2.61 for nova flavors https://review.openstack.org/650902 | |
| 13:54:44 | openstackgerrit | Monty Taylor proposed openstack/openstacksdk master: WIP Use resource layer for compute flavors https://review.openstack.org/650903 | |
| 13:54:59 | mordred | that stack is a bit of a mess still - but it's getting close | |
| 14:47:45 | elmiko | dtantsur: hey, just saw the conversation | |
| 14:48:03 | elmiko | i would need to read more about mdns before giving an opinion, but is it something we want to promote across openstack? | |
| 14:48:16 | dtantsur | I don't think I want to promote it :) | |
| 14:48:20 | elmiko | lol | |
| 14:48:46 | elmiko | i guess that's my position re: new guidelines, is it something we think everyone /should/ be doing? | |
| 14:49:46 | dtantsur | I don't think everyone should. My thought was: if ppl other than ironic do it, maybe they should do it consistently. | |
| 15:07:38 | elmiko | ok, i can definitely get behind that | |
| 15:08:10 | elmiko | so perhaps this is more us setting a good example through the guidance to help generate consistency if needed? | |
| 15:13:15 | dtantsur | yeah | |
| 15:21:47 | elmiko | dtantsur: given all that, i think you've made a good case for writing something about it. no objection from me =) | |
| 15:22:09 | dtantsur | cool :) I'll try to be brief | |
| 20:23:55 | openstackgerrit | Monty Taylor proposed openstack/openstacksdk master: Support microversion 2.61 for nova flavors https://review.openstack.org/650902 | |
| 20:23:56 | openstackgerrit | Monty Taylor proposed openstack/openstacksdk master: Use resource layer for compute flavors https://review.openstack.org/650903 | |
| 20:24:26 | mordred | Shrews: look! ^^ using the resource layer for flavors! | |
| #openstack-sdks - 2019-04-09 | |||
| 07:47:36 | openstackgerrit | Artem Goncharov proposed openstack/openstacksdk master: Update compute.server resource https://review.openstack.org/650868 | |
| 09:27:53 | gtema | mordred: in the image is it intended/desired (currently, and not in shade) to keep owner_specified.openstack.md5 in the root of the image, or under properties? | |
| 09:28:22 | gtema | it is currently done in the root of the image, but I guess make sence to move it under properties | |
| 09:29:00 | gtema | otherwise my change for allowing extending resource is required to properly use resource in the proxy layer | |
| 09:30:29 | openstackgerrit | Vishakha Agarwal proposed openstack/keystoneauth master: Update the min version of tox https://review.openstack.org/651149 | |
| 10:43:59 | openstackgerrit | Artem Goncharov proposed openstack/openstacksdk master: Update compute.server resource https://review.openstack.org/650868 | |
| 11:09:50 | openstackgerrit | Thomas Bechtold proposed openstack/openstacksdk master: baremetal: Add support for mkisofs and xorrisofs for configdrive https://review.openstack.org/651193 | |
| 11:19:13 | openstackgerrit | Thomas Bechtold proposed openstack/openstacksdk master: baremetal: Add support for mkisofs and xorrisofs for configdrive https://review.openstack.org/651193 | |
| 12:44:35 | openstackgerrit | Dmitry Tantsur proposed openstack/api-sig master: Add guideline on DNS-based service discovery https://review.openstack.org/651222 | |
| 12:44:40 | dtantsur | mordred, elmiko, cdent, edleafe, and here we go ^^^ | |
| 12:44:58 | mordred | dtantsur: I was hoping it would be one line "use dns" | |
| 12:45:06 | dtantsur | lol | |
| 12:45:18 | edleafe | dtantsur: thanks - will get to it soon | |
| 12:45:42 | dtantsur | mordred: I think it covers both regular DNS and mDNS pretty nicely and in line with IETF | |
| 12:47:36 | mordred | dtantsur|brb: ooh - I likey | |
| 12:47:56 | mordred | dtantsur|brb: thanks for writing that - it's very clear and not at all hard to understand | |
| 12:48:40 | elmiko | dtantsur|brb: ack, i will take a look | |
| 12:50:00 | gtema | yey, like it also | |
| 13:12:27 | gtema | mordred: in the image is it intended/desired (currently, and not in shade) to keep owner_specified.openstack.md5 in the root of the image, or under properties? | |
| 13:12:41 | openstackgerrit | Artem Goncharov proposed openstack/openstacksdk master: Update compute.server resource https://review.openstack.org/650868 | |
| 13:12:51 | gtema | and basically any other unknown property | |
| 13:13:14 | mordred | gtema: I'm more of a fan of putting it into properties | |
| 13:13:27 | mordred | gtema: even though I know the v2 api puts unknown stuff in the root of the image | |
| 13:14:16 | gtema | I also like this approach, but then I would need to mess around with finding unknown props and doing "lots" of changes in tests | |
| 13:14:30 | gtema | good, will go this way then | |
| 13:14:53 | mordred | cool. let me know if I can help poke at the magic :) | |
| 13:15:09 | mordred | I think there is a comment in Resource about "should we do something with these unknown things" | |
| 13:15:09 | gtema | ;-) | |
| 13:15:48 | gtema | yeah, I think it would make sense to return back list of unmapped props to know them in the caller | |
| 13:17:20 | gtema | hmm, does it make sense to implement this in general in Resource to put everything unknown under properties (if such prop exists)? | |
| 13:20:39 | gtema | mordred: or at least creating special flag to do this? | |
| 13:22:29 | mordred | gtema: yes - I think so - it would make it easier for the cloud-layer integration which does this already | |
| 13:22:47 | gtema | oki | |
| 14:38:09 | openstackgerrit | Thomas Bechtold proposed openstack/openstacksdk master: baremetal: Add support for mkisofs and xorrisofs for configdrive https://review.openstack.org/651193 | |
| 14:53:16 | openstackgerrit | Dmitry Tantsur proposed openstack/api-sig master: Repair building guidelines https://review.openstack.org/651260 | |
| 14:53:20 | dtantsur | cdent, elmiko, edleafe, quick review appreciated ^^ | |
| 15:00:06 | cdent | looking | |
| 15:07:18 | openstackgerrit | Dmitry Tantsur proposed openstack/api-sig master: Add guideline on DNS-based service discovery https://review.openstack.org/651222 | |
| 15:07:24 | dtantsur | updated ^^ | |
| 15:10:18 | cdent | multicast continues to feel underutilized | |
| 15:12:47 | openstackgerrit | Dmitry Tantsur proposed openstack/api-sig master: Repair building guidelines https://review.openstack.org/651260 | |
| 15:12:51 | dtantsur | next attempt ^^ | |
| 15:13:25 | openstackgerrit | Dmitry Tantsur proposed openstack/api-sig master: Add guideline on DNS-based service discovery https://review.openstack.org/651222 | |
| 15:22:04 | dtantsur | dear god, what is running python 2.7 tests still?? | |
| 15:24:22 | openstackgerrit | Dmitry Tantsur proposed openstack/api-sig master: Repair building guidelines https://review.openstack.org/651260 | |
| 15:24:49 | openstackgerrit | Dmitry Tantsur proposed openstack/api-sig master: Add guideline on DNS-based service discovery https://review.openstack.org/651222 | |
| 15:29:20 | edleafe | dtantsur: https://twitter.com/python2clock/status/1115630437865537536 | |
| 15:29:44 | dtantsur | yeaah. things start to break | |
| 15:48:07 | mordred | dtantsur: it's the api-sig repo - I betcha you could just drop the py27 job | |
| 15:48:21 | dtantsur | mordred: tried. it's probably coming from project-config | |
| 15:48:30 | dtantsur | I will figure out later, if nobody beats me to it | |
| 15:50:20 | mordred | dtantsur: remote: https://review.openstack.org/651282 Remove project config for api-sig repo | |
| 15:50:47 | dtantsur | thanks! | |
| 15:55:34 | openstackgerrit | Monty Taylor proposed openstack/api-sig master: Repair building guidelines https://review.openstack.org/651260 | |
| 15:55:47 | mordred | dtantsur: updated that just a smidge | |
| 15:56:00 | openstackgerrit | Monty Taylor proposed openstack/api-sig master: Add guideline on DNS-based service discovery https://review.openstack.org/651222 | |
| 15:57:16 | cdent | My tools for attention management aren't effective | |
| 16:47:04 | mordred | cdent: dude, you have tools for that? | |
| 16:47:25 | mordred | cdent: I just run around in circles hoping to trip over the thing I'm supposed to be paying attention to | |
| 16:52:07 | elmiko | mordred: does that work? | |
| 16:52:27 | elmiko | (asking for a friend XD) | |
| 16:53:01 | cdent | mordred: here we see the fundamental difference in our characters. I'm too tired to run. | |
| 16:57:05 | mordred | elmiko: depends on how you define "work" | |
| 16:57:39 | mordred | cdent: indeed. to be fair - this is also the problem - my process is running around in circles, but most times just laying here on the couch is much nicer | |
| 17:03:20 | mordred | cdent: I keep thinking one of these days they'll start paying us to just nod sagely from time to time | |
| 17:03:35 | cdent | I concur | |
| 17:04:40 | cdent | Surely we are old-timer enough that that's allowed, even encouraged. I'm ready for a sinecure that is of benefit to the payer. "We've got a {cdent,mordred}, we must be special" | |
| 17:05:01 | mordred | ++ | |
| 17:05:04 | cdent | roll us in, nod sagely | |