| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-sdks - 2019-03-25 | |||
| 17:20:23 | mordred | Shrews: no worries / rush | |
| 18:28:02 | openstackgerrit | Rodolfo Alonso Hernandez proposed openstack/openstacksdk master: Add "name" filter in "list" call when retrieving a single register https://review.openstack.org/637238 | |
| 19:27:07 | Shrews | mordred: other than a doc nit,lgtm | |
| 19:33:11 | openstackgerrit | Monty Taylor proposed openstack/openstacksdk master: Add support for generating form-post signatures https://review.openstack.org/639760 | |
| 19:33:23 | mordred | Shrews: sweet - thanks - fixed the nit and added a release note ^^ | |
| 19:34:46 | Shrews | mordred: oh yah, good idea | |
| #openstack-sdks - 2019-03-26 | |||
| 10:03:37 | openstackgerrit | Artem Goncharov proposed openstack/openstacksdk master: Split OpenStackCloud into reasonable pieces https://review.openstack.org/642218 | |
| 11:52:36 | openstackgerrit | Artem Goncharov proposed openstack/openstacksdk master: Split OpenStackCloud into reasonable pieces https://review.openstack.org/642218 | |
| 12:46:49 | openstackgerrit | Dmitry Tantsur proposed openstack/openstacksdk master: [WIP] Make PATCH a first class operation and support it for baremetal https://review.openstack.org/647730 | |
| 12:46:51 | dtantsur | mordred: early comments welcome ^^ | |
| 13:50:59 | mordred | dtantsur: ooh fun. will look in a bit | |
| 13:51:12 | mordred | dtantsur: (seems like a good thing to have as a first-class operation) | |
| 13:51:25 | gtema | ++ | |
| 15:20:29 | openstackgerrit | Merged openstack/openstacksdk master: add python 3.7 unit test job https://review.openstack.org/647401 | |
| 15:27:53 | openstackgerrit | Artem Goncharov proposed openstack/openstacksdk master: Split OpenStackCloud into reasonable pieces https://review.openstack.org/642218 | |
| 15:56:51 | openstackgerrit | Dmitry Tantsur proposed openstack/openstacksdk master: Make PATCH a first class operation and support it for baremetal https://review.openstack.org/647730 | |
| 15:56:54 | dtantsur | this is it, assuming the ironic CI passes ^^ | |
| 17:34:27 | dtruong | mordred I'm using openstacksdk 0.26.0 and am seeing connections that are not being closed when calling network APIs. | |
| 17:34:35 | dtruong | If you run this file: http://paste.openstack.org/show/748415/ | |
| 17:35:02 | dtruong | and watch the number of open connections of that process, it just keeps increasing and using more memory | |
| 17:36:04 | dtruong | I run that file as python blah.py | |
| 17:36:22 | dtruong | and watch the connections like this: watch -n 1 "pgrep -o -f blah | xargs sudo lsof -i 4 -a -p " | |
| 17:48:08 | dtruong | mordred It looks like this started with openstacksdk 0.18.0 | |
| 17:48:34 | dtruong | With openstacksdk 0.17.2 it only has 2 or 3 connections open when running my sample program | |
| 17:58:43 | dtantsur | regressions \o/ | |
| 18:00:40 | dtruong | actually, looks like using openstacksdk master doesn't have this problem | |
| 18:01:06 | dtruong | so I guess you something changed between 0.26.0 and currently master that fixed it? | |
| 18:06:11 | dtruong | Looking at the commit history, I'm guessing this commit fixed it: | |
| 18:06:12 | dtruong | https://opendev.org/openstack/openstacksdk/commit/e7a9b52998f23d7d7af99ecd9adb0554102f9604 | |
| 19:33:16 | openstackgerrit | Jeremy Houser proposed openstack/python-openstackclient master: Refactor test_transfer_request.py and test_snapshot.py https://review.openstack.org/647892 | |
| 19:33:33 | openstackgerrit | Jeremy Houser proposed openstack/python-openstackclient master: Refactor test_transfer_request.py and test_snapshot.py https://review.openstack.org/647892 | |
| 19:34:34 | openstackgerrit | Jeremy Houser proposed openstack/python-openstackclient master: Refactor test_transfer_request.py and test_snapshot.py https://review.openstack.org/647892 | |
| 21:34:29 | openstackgerrit | Jeremy Houser proposed openstack/python-openstackclient master: Refactor test_transfer_request.py and test_snapshot.py https://review.openstack.org/647892 | |
| 21:34:47 | openstackgerrit | Jeremy Houser proposed openstack/python-openstackclient master: Refactor test_transfer_request.py and test_snapshot.py https://review.openstack.org/647892 | |
| 22:09:19 | dtruong | mordred I created a bug report for the issue I described above: https://storyboard.openstack.org/#!/story/2005306 | |
| #openstack-sdks - 2019-03-27 | |||
| 11:43:25 | dtantsur | mordred: hi! it seems like this whole thing is broken nowadays: https://github.com/ansible/ansible/blob/devel/lib/ansible/module_utils/openstack.py#L145-L154 | |
| 11:43:40 | dtantsur | (in addition to os_ironic_node having authentication half-broken as well) | |
| 11:51:33 | dtantsur | sigh, I just wanted to fix some deprecations >_< | |
| 12:58:04 | openstackgerrit | ITD27M01 proposed openstack/openstacksdk master: Adds missing "params" attribute for creating a Mistral workflow execution https://review.openstack.org/648117 | |
| 13:00:51 | openstackgerrit | ITD27M01 proposed openstack/openstacksdk master: Adds missing "params" attribute for creating a Mistral workflow execution https://review.openstack.org/648117 | |
| 13:02:48 | openstackgerrit | ITD27M01 proposed openstack/openstacksdk master: Adds missing "params" attribute for creating a Mistral workflow execution https://review.openstack.org/648117 | |
| 14:14:45 | openstackgerrit | Jeremy Houser proposed openstack/python-openstackclient master: Refactor test_transfer_request.py and test_snapshot.py https://review.openstack.org/647892 | |
| 16:22:05 | openstackgerrit | Jeremy Houser proposed openstack/python-openstackclient master: Refactor test_transfer_request.py and test_snapshot.py https://review.openstack.org/647892 | |
| 16:40:11 | openstackgerrit | Ian Y. Choi proposed openstack/openstacksdk master: DNM - Start building pdfs of docs https://review.openstack.org/601659 | |
| 20:39:52 | openstackgerrit | Pierre Riteau proposed openstack/openstacksdk master: Do not disregard tags when updating stacks https://review.openstack.org/643195 | |
| #openstack-sdks - 2019-03-28 | |||
| 00:31:49 | dtruong | mordred Would it be possible to cut a new openstacksdk release off master branch? That would fix the connection leak problem for Senlin. | |
| 00:32:06 | dtruong | I also send an email to openstack-discuss with the same question: http://lists.openstack.org/pipermail/openstack-discuss/2019-March/004295.html | |
| 06:46:28 | mordred | dtruong: yes, I thnk that should be no problem | |
| 06:49:42 | mordred | dtantsur|afk: boo to that being broken. :( | |
| 07:02:42 | mordred | dtruong: oh - I say that - doing it as a release for stein might be harder because of the various freezes. | |
| 07:06:12 | mordred | dtruong: I'm going to ask the release team what they think | |
| 07:48:12 | openstackgerrit | Monty Taylor proposed openstack/openstacksdk master: Add support for generating form-post signatures https://review.openstack.org/639760 | |
| 07:48:25 | mordred | timburke: ^^ thanks! nice catch | |
| 07:49:17 | mordred | Shrews, dtantsur|afk: ^^ timburke found a bug in that. I fixed the bug and added unit tests to actually exercise the methods in question which would have shown how horribly broken they were | |
| 08:59:02 | openstackgerrit | Monty Taylor proposed openstack/openstacksdk master: Move set_temp_url_key logic into resource objects https://review.openstack.org/648347 | |
| 09:01:09 | gtema | mordred, dtantsur: can you please do a next quick review on https://review.openstack.org/#/c/642218/ (split openstackcloud.py) | |
| 09:01:24 | gtema | I only did a "rebase" | |
| 09:01:50 | gtema | I would like to ask you to try to integrate it soon, as rebasing in it is a terrible mess with each new change | |
| 09:16:02 | openstackgerrit | Monty Taylor proposed openstack/openstacksdk master: Remove and rearrange object bonged proxy tests https://review.openstack.org/648352 | |
| 09:16:39 | mordred | gtema: +2 from e | |
| 09:16:58 | gtema | thks mordred | |
| 09:18:36 | gtema | btw, I would like to modify service_descriptions.__set__ and __delete__ to be able to be able to override default descriptors (you know OTC case with the DNS implementation) | |
| 09:18:55 | gtema | are you ok with that? | |
| 09:20:41 | mordred | gtema: I *think* that should be ok - although my brain isn't super functional today, so I might be missing an implication :) | |
| 09:22:08 | gtema | ok, will prepare patch. My problem is that in a particular cloud a service might differ from upstream. We currently do have possibility to add service implementation in runtime, but not to "replace" the ones delivered in SDK | |
| 09:22:21 | mordred | yah | |
| 09:22:32 | gtema | so for me DNS implementation should be replaced | |
| 09:22:38 | mordred | of course, insert obligatory grumbling about clouds having incompatible services ... | |
| 09:22:50 | gtema | yupp | |
| 09:23:00 | gtema | thks | |
| 10:03:08 | dtantsur | gtema: sure thing! btw, how did you visa application go? | |
| 10:05:08 | dtantsur | and unrelated, but we need to fix the masakari job: http://logs.openstack.org/18/642218/9/check/openstacksdk-functional-devstack-masakari/bd6a050/job-output.txt.gz#_2019-03-26_16_03_12_675170 | |
| 11:49:08 | openstackgerrit | Merged openstack/openstacksdk master: Split OpenStackCloud into reasonable pieces https://review.openstack.org/642218 | |
| 11:49:09 | openstackgerrit | Merged openstack/openstacksdk master: Do not disregard tags when updating stacks https://review.openstack.org/643195 | |
| 11:57:38 | openstackgerrit | Dmitry Tantsur proposed openstack/openstacksdk master: Make PATCH a first class operation and support it for baremetal https://review.openstack.org/647730 | |
| 11:59:26 | gtema | dtantsur: thanks. Visa is there. And I was really surprised to get it on 3 days after interview | |
| 12:00:45 | gtema | s/on/in/ | |
| 12:06:56 | dtantsur | yeah, it's nice :) | |
| 13:26:18 | ITD27M01 | mordred: My name is Igor, can you please do a review on https://review.openstack.org/#/c/648117/ (missing "params" for mistral workflow execution) we are developing some utilities on-site for mistral and blocked on this change. Thank you! | |
| 13:47:48 | dtantsur | mordred, gtema, when you have a second, I had to rebase: https://review.openstack.org/#/c/647730/ | |
| 13:54:42 | gtema | yupp - done | |
| 14:02:34 | dtantsur | thx | |
| 14:39:23 | openstackgerrit | Rodolfo Alonso Hernandez proposed openstack/openstacksdk master: Add "name" filter in "list" call when retrieving a single register https://review.openstack.org/637238 | |
| 15:16:04 | openstackgerrit | Artem Goncharov proposed openstack/openstacksdk master: Cleanup split of openstackcloud https://review.openstack.org/648435 | |
| 15:21:35 | ricolin | cdent, edleafe elmiko Hi any chance we can get your help on http://lists.openstack.org/pipermail/openstack-discuss/2019-March/004246.html ?:) | |
| 15:22:12 | cdent | ricolin: I'll punt to edleafe and elmiko on that. I'm not as involved in the api-sig as I used to be | |
| 15:22:27 | edleafe | ricolin: I was going to bring that up at the office hour that starts in about 40 minutes | |
| 15:22:41 | ricolin | cdent, thanks for the help:) | |
| 15:23:10 | ricolin | edleafe, nice! where will the office hour hold, here? | |
| 15:23:14 | elmiko | ricolin: taking a look, but i agree with edleafe | |
| 15:23:27 | edleafe | ricolin: yup | |
| 15:23:37 | cdent | dr, I concur | |
| 15:23:48 | ricolin | will try to join you guys if I can:) | |
| 15:23:54 | elmiko | ah yes, i remember this email. i was kinda curious about our response | |
| 15:49:08 | mnaser | mordred: how do we go about updating patches to Ansible modules for code that recently landed in openstacksdk ? | |
| 15:49:26 | mnaser | i.e. brtknr has landed https://github.com/ansible/ansible/pull/53757 but it depends on a patch in openstacksdk | |
| 15:49:53 | mnaser | given we haven't released one (yet) afaik that includes it, do we hold off, do we push anyways and release openstacksdk when people yell? I'm a bit stuck on that | |
| 15:56:58 | mordred | mnaser: well, we've also got a request from dtruong for an sdk release containing the taskmanager patch - so I think in this case the next step is "cut an sdk release" - at which point the ansible features needing that release can check for the version and whatnot | |
| 15:57:33 | mordred | mnaser: in general we're generally pretty responsive to just cutting new sdk releases when needed - we happen to be in the middle of release freeze this week so it's slightly more complicated | |
| 15:59:33 | mordred | mnaser: I mean - I have no problem landing the ansible patch before we release sdk as long as it's protected by an "if version" - so we might want to ask brtknr to add in a check for sdk version and only add tags to the kwargs there if sdk isn't going to vomit - and maybe throw a warning if sdk is too old and tag is in params | |