Earlier  
Later
New Search
Posted Nick Remark
#openstack-sdks - 2018-12-14
00:31:58 ianw https://review.openstack.org/#/c/171456/ is where it seems to have come in
03:15:44 ianw I have updated https://storyboard.openstack.org/#!/story/2004605 and have a small test-case in an upstream issue https://github.com/sqlalchemy/dogpile.cache/issues/140
03:22:15 kmalloc weird...
03:22:24 kmalloc this is just odd
03:25:25 kmalloc ianw: i can't log into github atm, or i'd comment on your issue
03:25:39 kmalloc ianw: i think dogpile is doing the sane thing and openstacksdk is doing something very weird.
03:26:31 kmalloc ianw: i know it's a behavior change but i wonder why we didn't just raise up the invalidate instead of adding another layer of wrapping
03:29:09 ianw kmalloc: at this point i dunno, i'm going a bit cross-eyed from staring at it :) gonna switch gears to look at the pin, because we kind of need that to unblock other stuff
03:29:39 ianw we have a circular dependency in fixing nodepool jobs
03:34:49 openstackgerrit Ian Wienand proposed openstack/openstacksdk master: Avoid dogpile.cache 0.7.0 https://review.openstack.org/624485
03:37:45 openstackgerrit Ian Wienand proposed openstack/openstacksdk master: Avoid dogpile.cache 0.7.0 https://review.openstack.org/624485
03:57:09 kmalloc ianw: ++
03:57:21 kmalloc ianw: i'll poke at mordred and Shrews i'm sure they know
12:53:21 openstackgerrit melissaml proposed openstack/openstacksdk master: Change openstack-dev to openstack-discuss https://review.openstack.org/625247
13:52:17 Shrews kmalloc: i think the intent was to have an invalidate function (i don't know the history of dogpile.cache here, but latest code seems to always have an invalidate func) and to eventually support per-resource caches
13:53:09 Shrews kmalloc: i'm not familiar enough with dogpile to know how to properly get rid of our custom decorator and have things still work
13:57:05 Shrews kmalloc: i tried https://review.openstack.org/624767 but I can't remember what on earth i saw wrong with that to cause me to abandon it. i think it was not being able to support per-resource caches
13:57:22 Shrews which we don't appear to be doing anyway
13:57:59 Shrews my head was so confused trying to unravel this :/
14:39:27 kmalloc Shrews: it's always had an invalidate function
14:39:33 kmalloc Shrews: as long as we've been using it
14:39:45 kmalloc Shrews: it does require passing the "Self" to the invalidate explicitly
14:40:14 kmalloc Shrews: *shrug*. i think the quick fix is unwrap the extra layer of wrapping
14:40:41 kmalloc Shrews: brie has surgery this morning, but this afternoon i should be able to spin up and chase down a fix that undoes the wrapping
14:41:14 Shrews kmalloc: then i'm not sure what the purpose of https://review.openstack.org/171456 was then. i can't remember that far back
14:41:22 kmalloc yeah, maybe mordred knows
14:41:28 Shrews kmalloc: k, thx for helping
14:41:50 kmalloc Shrews: also i could see a order of operation issue with configuring the dogpile cache region
14:42:13 Shrews unpossible that there are more bugs
14:42:23 kmalloc well i mean with unwrapping it :P
14:42:38 kmalloc sorry it's super early here and i've been up 3 times to walk the dog already
14:42:45 Shrews oh! that's what was wrong with my attempt to unwrap it
14:42:53 kmalloc :)
14:42:54 Shrews i didn't have the region to make the wrapper call
14:42:58 kmalloc AHAH
14:43:21 kmalloc oslo_cache has a lot of mechanisms to make sure we have a region.
14:44:14 kmalloc anyway, i can help chase this down after brie is back from the dr. and she's settled sleeping off the anesthesia
14:44:22 Shrews ++
14:44:58 kmalloc Shrews: also.. "YAY YEARLY COMPLIANCE TRAINING"
14:45:01 kmalloc :P
15:37:49 kmalloc mordred: ^ cc (so you know i haven't forgotten it) :P
15:38:11 kmalloc Shrews: i'll be back sometime post noon pacific
15:38:24 kmalloc Shrews: so i'll get to work on SDK things unless someone else has hit it first.
18:57:55 kmalloc mordred: ^ do you know the reasoning for the original extra layer wrap for cache_on_arguments ?
18:58:18 kmalloc mordred: it seems superfluous as it just re-implements invalidate, which was already added?
18:58:26 kmalloc By dogpile*
18:59:26 kmalloc It's the source of the issue and exception because dogpile now expects to own the wrapping, won't work with bound methods (as method.xxx = thing doesn't work on bound methods)
18:59:37 kmalloc Nor would setattr
21:45:24 kmalloc Shrews: ok... so part of the issue with dogpile is the chicken-egg issue. we're dynamically building on instantiation of the mixin the dogpile region
21:46:05 kmalloc that is... something we can do on import. we'll just need to run the configuration at __init__ time for the region(s)
21:48:47 kmalloc Shrews: oh gah. the per-resource cache is ... the problem.
21:48:58 kmalloc maybe we can do it with a metaclass?
21:52:53 slaweq mordred: hi
21:53:04 slaweq mordred: I just opened story https://storyboard.openstack.org/#!/story/2004618 for sdk and osprofiler
21:53:36 slaweq mordred: please take a look, maybe You will have some quick idea how we can solve this issue - I don't know this parts too much TBH :)
22:19:10 kmalloc Shrews: unfortunately the whole "undecorate" for ease of debugging is also part of the issue.
22:19:55 kmalloc i'm trying to make this work with a metaclass, but since connection already has a meta, this is going to be weird... i need to look into the MRO and class traversal with super() in the cases of metaclasses.
22:20:20 kmalloc really we should stop trying to be extra dynamic and just build cache regions that make sense
22:21:00 kmalloc we can dynamically configure them at __init__ time with values, but the whole "only make some cache regions and decorate/undecorate" is way overly complex.
22:21:03 kmalloc mordred: ^ cc
22:25:39 kmalloc aha, i think i found the simplest solution...
22:52:31 openstackgerrit Morgan Fainberg proposed openstack/openstacksdk master: Fix dogpile.cache 0.7.0 interaction https://review.openstack.org/625370
22:55:51 openstackgerrit Morgan Fainberg proposed openstack/openstacksdk master: Fix dogpile.cache 0.7.0 interaction https://review.openstack.org/625370
#openstack-sdks - 2018-12-15
06:30:30 openstackgerrit Kailun Qin proposed openstack/openstacksdk master: Add network segment range resource https://review.openstack.org/625381
08:49:18 openstackgerrit Kailun Qin proposed openstack/openstacksdk master: Add network segment range resource https://review.openstack.org/625381
#openstack-sdks - 2018-12-17
10:58:29 openstackgerrit Kailun Qin proposed openstack/python-openstackclient master: Add network segment range command object https://review.openstack.org/625544
11:01:09 openstackgerrit Kailun Qin proposed openstack/python-openstackclient master: Add network segment range command object https://review.openstack.org/625544
12:36:02 openstackgerrit Benoît Knecht proposed openstack-infra/shade master: Fix grant_role() when user not in default domain https://review.openstack.org/625583
12:46:59 openstackgerrit Benoît Knecht proposed openstack-infra/shade master: Fix grant_role() when user not in default domain https://review.openstack.org/625583
13:30:46 openstackgerrit Kailun Qin proposed openstack/python-openstackclient master: Add network segment range command object https://review.openstack.org/625544
14:23:03 mordred kmalloc: wow, really? that's amazeballs
16:41:46 openstackgerrit Luigi Toscano proposed openstack/os-api-ref master: Generate stable targets rather than random https://review.openstack.org/625654
16:42:49 openstackgerrit Luigi Toscano proposed openstack/os-api-ref master: Generate stable targets rather than random https://review.openstack.org/625654
17:01:10 openstackgerrit Luigi Toscano proposed openstack/os-api-ref master: Generate stable targets rather than random https://review.openstack.org/625654
17:03:58 kmalloc mordred: yeah. super easy fix and it means no change really on how we work or how dogpile works.
17:16:58 mordred kmalloc: if you have a sec, could you make a requirements patch that removes the dogpile upper bound and bumps the lower-constraint, and then an sdk depends-on on it just so we can see that it fixes things?
17:18:24 kmalloc i think someone did
17:18:28 kmalloc but let me make sure that is in as well
17:18:58 kmalloc i should have that posted in... like ~20m at most
17:19:49 kmalloc ah. we never landed the avoid dogpile 0.7.0
17:19:58 kmalloc ahhh wait in requirements.
17:19:59 kmalloc hahaha
17:22:21 kmalloc mordred: And "Required-By:" is the inverse of depends-on, right?
17:23:38 kmalloc mordred: https://review.openstack.org/#/c/624993/ that is the unpin
17:23:50 mordred kmalloc: Needed-By
17:23:58 mordred sweet
17:23:59 kmalloc thats it.
17:24:01 kmalloc thanks
17:24:15 openstackgerrit Morgan Fainberg proposed openstack/openstacksdk master: Fix dogpile.cache 0.7.0 interaction https://review.openstack.org/625370
17:24:29 kmalloc ^ added Needed-By for the bidirectional tracking
17:24:40 mordred kmalloc: cool!
17:25:00 kmalloc yay for easy fixes
17:25:06 kmalloc though that was some dense code to traverse though
17:25:20 kmalloc the SDK stuff is doing some odd things with the decorator bits.
18:42:41 Shrews kmalloc: thx for the help in figuring that out
18:43:08 kmalloc Shrews: heck yeah
18:43:19 kmalloc it isn't something super easy :P
#openstack-sdks - 2018-12-18
00:26:40 openstackgerrit Ian Wienand proposed openstack/openstacksdk master: Avoid dogpile.cache 0.7.0 https://review.openstack.org/624485
00:27:12 ianw mordred / kmalloc : ^ as discussed in infra
00:27:19 kmalloc ianw: thanks!

Earlier   Later