Earlier  
Later
New Search
Posted Nick Remark
#openstack-sdks - 2018-12-18
00:27:19 kmalloc ianw: thanks!
00:28:00 kmalloc eventually we need to make that not hard-coded.
00:28:13 kmalloc but... we can do that separately
02:11:21 kmalloc bah mordred another thing landed and changed. i'm trying to chase it down.
02:12:02 kmalloc https://www.irccloud.com/pastebin/gsZmht6c/
02:12:05 kmalloc ianw: ^ cc
02:15:17 ianw :/
02:16:18 kmalloc ianw: mordred clearly ordered more yaks for us
02:16:42 kmalloc chasing down what merged... this one is...weirder than the last one
02:17:37 kmalloc clearly seeing an image not found...
02:19:06 kmalloc ianw: ah, think we missed a cirros thing
02:19:12 kmalloc ianw: working on it.
02:20:27 kmalloc ianw: do we use examples/connect.py in testing?
02:20:39 kmalloc it seems... like no...
02:21:31 kmalloc oh yep
02:21:32 kmalloc there it is
02:22:37 openstackgerrit Morgan Fainberg proposed openstack/openstacksdk master: Avoid dogpile.cache 0.7.0 https://review.openstack.org/624485
02:22:57 kmalloc ianw: ^ there in example/connect.py had the old cirros as well
02:23:20 ianw ahh ... doh maybe i grepped one dir too far down
02:25:27 kmalloc yeah.
02:25:29 kmalloc it happens
02:25:43 kmalloc lol there is another place with cirros 3.2 but that doesn't seem to be failing
02:25:45 kmalloc so i'm not touching it
02:26:10 kmalloc and cirros 3.4
02:26:27 kmalloc ah because they are fakes
02:26:34 kmalloc s/fakes/mocks
02:29:28 openstackgerrit Morgan Fainberg proposed openstack/openstacksdk master: Fix dogpile.cache 0.7.0 interaction https://review.openstack.org/625370
02:30:28 openstackgerrit Morgan Fainberg proposed openstack/openstacksdk master: Unpin dogpile.cache https://review.openstack.org/625759
02:32:03 openstackgerrit Morgan Fainberg proposed openstack/openstacksdk master: Unpin dogpile.cache https://review.openstack.org/625759
05:12:53 kmalloc mordred, ianw: i think i have most of the stuff ready. someone should follow up with it and get it through the door. It should be close if not good to go
05:13:03 kmalloc and with that... logging out, see you all next year
07:17:25 openstackgerrit Merged openstack/python-openstackclient master: Modify the help message for 'registered limit set' https://review.openstack.org/609985
08:38:35 openstackgerrit Merged openstack/openstacksdk master: Avoid dogpile.cache 0.7.0 https://review.openstack.org/624485
14:03:29 openstackgerrit Mário Santos proposed openstack/openstacksdk master: Adds kwargs support when creating a Neutron subnet https://review.openstack.org/625920
14:15:06 openstackgerrit Monty Taylor proposed openstack/openstacksdk master: Use munch for server security groups https://review.openstack.org/625923
15:49:42 openstackgerrit Merged openstack/openstacksdk master: Fix dogpile.cache 0.7.0 interaction https://review.openstack.org/625370
16:40:48 mriedem sdk question for a tempest change https://review.openstack.org/#/c/622316/3/tempest/config.py@347
16:40:57 mriedem about using the legacy keystone v2 *URL endpoint types
16:41:03 mriedem e.g. publicURL
16:52:56 mordred mriedem: looking
16:56:31 mordred mriedem: left comment - tl;dr I agree with you
16:59:16 mriedem THANKS
16:59:24 mriedem oops, slip o the caps
19:56:37 mordred slaweq: https://review.openstack.org/#/c/625920/ is neutron related - look ok to you?
20:22:24 openstackgerrit Monty Taylor proposed openstack/openstacksdk master: Use munch for server security groups https://review.openstack.org/625923
20:50:14 openstackgerrit Monty Taylor proposed openstack/openstacksdk master: Don't try to upload to images in saving or queued state https://review.openstack.org/624188
20:51:30 openstackgerrit Monty Taylor proposed openstack/openstacksdk master: Import code for building ironic-compatible configdrives https://review.openstack.org/624441
20:52:13 openstackgerrit Monty Taylor proposed openstack/openstacksdk master: Drop self.conn from base.TestCase https://review.openstack.org/625115
20:52:27 openstackgerrit Monty Taylor proposed openstack/openstacksdk master: Add network segment range resource https://review.openstack.org/625381
21:02:46 openstackgerrit Merged openstack/openstacksdk master: Change openstack-dev to openstack-discuss https://review.openstack.org/625247
21:10:39 slaweq mordred: yes, +W'ed already
21:10:45 mordred slaweq: sweet
21:47:02 openstackgerrit Dean Troyer proposed openstack/python-openstackclient master: More volume functional test fixes https://review.openstack.org/626020
22:50:08 openstackgerrit Merged openstack/openstacksdk master: Adds kwargs support when creating a Neutron subnet https://review.openstack.org/625920
#openstack-sdks - 2018-12-19
00:41:53 openstackgerrit Monty Taylor proposed openstack/openstacksdk master: Turn off unneeded devstack services https://review.openstack.org/626058
01:10:21 openstackgerrit Dean Troyer proposed openstack/python-openstackclient master: More volume functional test fixes https://review.openstack.org/626020
04:33:19 openstackgerrit Dean Troyer proposed openstack/python-openstackclient master: More volume functional test fixes https://review.openstack.org/626020
19:29:42 mordred Shrews: sorry for the delay - I'm sort of down a little bit of a rabbit hole poking at tests that aren't doing what we think they are
19:32:15 Shrews mordred: i don't have you on any timer
19:33:08 mordred Shrews: I ... I started pulling on some threads
19:33:29 Shrews spelunk down those rabbit holes if it entertains you :)
19:35:09 mordred Shrews: "entertain"
19:45:56 openstackgerrit Monty Taylor proposed openstack/openstacksdk master: Properly munch for resource sub-dicts https://review.openstack.org/625923
19:45:57 openstackgerrit Monty Taylor proposed openstack/openstacksdk master: Start using direct REST in normalize tests https://review.openstack.org/626379
19:45:57 openstackgerrit Monty Taylor proposed openstack/openstacksdk master: WIP Compute location properly in server https://review.openstack.org/626380
19:46:19 mordred Shrews: the first two are solid, the third is a deeper rabbit hole that needs to be done but is not essential for this moment in time
19:46:40 Shrews looking
19:48:30 Shrews mordred: what is 'original_names'?
19:49:51 mordred Shrews: it's whether you want the dict from the sdk Resource to have the keys as they came from the remote host, or whether you want it to have its already normalized names
19:50:17 mordred Shrews: right now in the shade layer we're asking for original_names so that our normalize things, which were written to normalize the unnormalized names, will still work
19:50:23 mordred but that's so many layers or normalizing
19:51:44 mordred Shrews: I was figuring that a two-step approach to getting to just returning the Resource objects directly would be a patch to say original_names=False with the update to the normalize function - then a patch to update the Resource with any missing fields, remove the normalize function and just return the resource
19:52:08 mordred Shrews: although, in reality, it's likely more confusing to do that- and just doing a patch to return the resource directly is fine...
19:52:27 mordred Shrews: at least once the test_normalize file is actually doing all requests_mock so we're testing the outcome of calling the method
19:52:38 mordred since that shoudl then let us test that we're not breaking contract over the switch
19:54:57 Shrews mordred: we should probably make tobiash's new test depend on that when it is ready to validate it fixes the nodepool issue
19:55:14 Shrews (and doesn't break something _else_)
19:55:34 mordred ++
19:58:28 Shrews mordred: https://review.openstack.org/#/c/626379/1/openstack/tests/unit/base.py <-- you don't like 'p' in your project names???? :)
19:58:40 Shrews line 216
19:58:54 mordred Shrews: p's are for lusers
19:59:11 Shrews i thought they were for posers
20:19:36 openstackgerrit Monty Taylor proposed openstack/openstacksdk master: Properly munch for resource sub-dicts https://review.openstack.org/625923
20:19:37 openstackgerrit Monty Taylor proposed openstack/openstacksdk master: Start using direct REST in normalize tests https://review.openstack.org/626379
20:19:37 openstackgerrit Monty Taylor proposed openstack/openstacksdk master: WIP Compute location properly in server https://review.openstack.org/626380
20:19:46 mordred Shrews: ok. I think that should take care of the issues
20:20:08 mordred tobiash: ^^
20:22:06 mordred Shrews: while I've got you here: https://review.openstack.org/#/c/626058/ is a copy of stuff clarkb did for nodepool
20:23:54 mordred slaweq: if you have a sec, another neutron patch for you: https://review.openstack.org/#/c/625381/3
20:25:53 openstackgerrit Monty Taylor proposed openstack/openstacksdk master: Drop self.conn from base.TestCase https://review.openstack.org/625115
20:37:18 slaweq mordred: looking
20:44:37 slaweq mordred: commented
20:45:12 slaweq mordred: basically this feature has only spec merged so far and I'm not sure if it's good time to merge it
20:58:24 mordred slaweq: cool- thanks! (This is why it's good to defer to subject matter experts :) )
21:01:19 slaweq mordred: yes, I agree :)
21:38:52 openstackgerrit Merged openstack/openstacksdk master: Import code for building ironic-compatible configdrives https://review.openstack.org/624441
21:53:55 openstackgerrit Merged openstack/openstacksdk master: Turn off unneeded devstack services https://review.openstack.org/626058
#openstack-sdks - 2018-12-20
00:33:51 openstackgerrit Monty Taylor proposed openstack/openstacksdk master: Start using direct REST in normalize tests https://review.openstack.org/626379
00:33:51 openstackgerrit Monty Taylor proposed openstack/openstacksdk master: Drop self.conn from base.TestCase https://review.openstack.org/625115
00:33:52 openstackgerrit Monty Taylor proposed openstack/openstacksdk master: WIP Compute location properly in server https://review.openstack.org/626380

Earlier   Later