| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-sdks - 2018-10-16 | |||
| 15:15:49 | openstackgerrit | Monty Taylor proposed openstack/openstacksdk master: Return both uuid and id for baremetal port https://review.openstack.org/611009 | |
| 15:16:07 | mordred | dtantsur, Shrews: ^^ I pushed up my change as a followup so that we can look at it and ponder and argue properly | |
| 15:20:45 | dtantsur | mordred: instant comment: we need the same of all bm resources | |
| 15:23:17 | mordred | dtantsur: oh - totally - whatever we decide here should apply across the board | |
| 15:23:56 | dtantsur | mordred: is it possible to hide "uuid" from the resource and only make it visible when using dict stuff? | |
| 15:24:05 | dtantsur | kind of thinking aloud | |
| 15:24:07 | mordred | dtantsur: it's python - anything is possible :) | |
| 15:24:10 | dtantsur | heh | |
| 15:24:17 | dtantsur | reasonable is a different question | |
| 15:24:38 | mordred | dtantsur: not sure - would have to poke - I thinkn work already goes in to aligning object and dict access though | |
| 15:24:53 | dtantsur | yeah, stupid idea probably... | |
| 15:25:10 | mordred | me to | |
| 15:25:12 | mordred | me too | |
| 15:25:20 | dtantsur | I'm thinking about ugly cases like creating a node with different id and uuid :D | |
| 15:27:55 | mordred | >>> p = openstack.baremetal.v1.port.PortDetail(id='123', uuid='345') | |
| 15:28:03 | mordred | >>> p._to_munch() | |
| 15:28:05 | mordred | Munch({'node_uuid': None, 'extra': None, 'pxe_enabled': None, 'id': '345', 'name': None, 'internal_info': None, 'links': None, 'local_link_connection': None, 'updated_at': None, 'created_at': None, 'portgroup_uuid': None, 'address': None, 'physical_network': None, 'location': None, 'uuid': '345'}) | |
| 15:28:09 | mordred | yeah. that's not what we want :) | |
| 15:30:18 | dtantsur | yeah, I wonder what happens if you try to create such port.. | |
| 15:30:51 | dtantsur | well, ports do not allow to specify uuid on creation, but nodes do (consistency!) | |
| 15:36:58 | openstackgerrit | Merged openstack/os-api-ref master: tests: Support Sphinx 1.8+ https://review.openstack.org/607984 | |
| 15:48:00 | openstackgerrit | weizj proposed openstack/os-service-types master: Update the hacking to latst https://review.openstack.org/611054 | |
| 15:49:50 | openstackgerrit | Merged openstack/openstacksdk master: Move wait_for_baremetal_node_lock to the baremetal proxy https://review.openstack.org/610946 | |
| 15:52:27 | dtantsur | mordred: re https://review.openstack.org/610024 are you okay with it for now? | |
| 15:52:36 | openstackgerrit | Merged openstack/openstacksdk master: Remove duplicate code https://review.openstack.org/610404 | |
| 15:54:23 | mordred | dtantsur: yeah - I thnk it's fine for today - it's not an additional issue from what today is | |
| 15:54:36 | mordred | dtantsur: I think we should solve the other question before we 1.0 | |
| 15:55:22 | dtantsur | totally | |
| 15:56:29 | dtantsur | my personal minimum plan is to get rid of every single hardcoded microversion=1.6 by the release | |
| 15:57:56 | mordred | dtantsur: yah - I agree re: 1.0 ... I think this next point release will be close enough to 1.0 that we can start working on using it more within osc (discovery and resources-as-dicts were the last two things I was worried about getting in before we started doing that) | |
| 15:58:52 | dtantsur | ++ | |
| 15:59:23 | dtantsur | and osc does not use baremetal stuff, so this is not a concern here | |
| 16:01:44 | openstackgerrit | Eric Fried proposed openstack/os-service-types master: Update the hacking to latst https://review.openstack.org/611054 | |
| 16:20:06 | openstackgerrit | Merged openstack/os-service-types master: Don't quote {posargs} in tox.ini https://review.openstack.org/608973 | |
| 16:20:06 | openstackgerrit | Merged openstack/os-service-types master: Removed older version of python added 3.5 https://review.openstack.org/606368 | |
| 16:20:41 | openstackgerrit | Merged openstack/os-service-types master: Add unittest for os_service_types.data module. https://review.openstack.org/596701 | |
| 17:12:51 | openstackgerrit | Merged openstack/openstacksdk master: Switch bare metal NIC actions in OpenStackCloud to baremetal Proxy calls https://review.openstack.org/610024 | |
| 17:41:02 | eandersson | anytime mordred ! | |
| 19:02:47 | openstackgerrit | Merged openstack/os-service-types master: Update the hacking to latst https://review.openstack.org/611054 | |
| 19:21:46 | openstackgerrit | Sean McGinnis proposed openstack/keystoneauth master: Update sphinx extension logging https://review.openstack.org/611135 | |
| 19:27:53 | openstackgerrit | Sean McGinnis proposed openstack/openstacksdk master: Update sphinx extension logging https://review.openstack.org/611138 | |
| 19:57:33 | openstackgerrit | Merged openstack/openstacksdk master: Adding two new regions and dynamic auth_url based on region name. https://review.openstack.org/610921 | |
| 20:14:45 | openstackgerrit | Sean McGinnis proposed openstack/os-api-ref master: Update sphinx extension logging https://review.openstack.org/611157 | |
| 21:36:46 | openstackgerrit | Monty Taylor proposed openstack/openstacksdk master: DNM Testing inline pep8 https://review.openstack.org/610744 | |
| 23:21:03 | openstackgerrit | Merged openstack/openstacksdk master: Update sphinx extension logging https://review.openstack.org/611138 | |
| #openstack-sdks - 2018-10-17 | |||
| 00:18:02 | openstackgerrit | Merged openstack/openstacksdk master: Convert inspect_machine to use the baremetal proxy https://review.openstack.org/610941 | |
| 10:37:36 | ShilpaSD | mordred: HI | |
| 10:42:30 | ShilpaSD | dtruong: Hi | |
| 10:44:26 | ml | samueldmq: I made some changes and answered commets after your review a few days ago, would be nice if you could have a look at it again https://review.openstack.org/#/c/604811/ | |
| 12:02:41 | Luzi | hey, it would be nice to get some ideas from osc and sdk side on the library search for image encryption: https://etherpad.openstack.org/p/library-for-image-encryption-and-decryption | |
| 13:47:46 | mordred | Luzi: I added a note to it - my vote is definitely for putting it in openstacksdk | |
| 13:53:59 | Luzi | thank you mordred :) | |
| 13:54:57 | mordred | Luzi: didn't you already write a patch for sdk for it? | |
| 13:55:28 | Luzi | that was for the signing of an image, now its about the encryption and decryption of images | |
| 13:55:37 | mordred | AH - gotcha | |
| 13:56:14 | mordred | yeah- I _definitely_ think it should go in sdk :) | |
| 13:57:53 | Luzi | mordred, we think that too, but there might be objections from nova or cinder - that's why there's an etherpad for a discussion :) | |
| 14:00:07 | openstackgerrit | Monty Taylor proposed openstack-infra/shade master: Add release note about decoupling https://review.openstack.org/611320 | |
| 14:48:43 | ShilpaSD | dtruong: Hi | |
| 16:11:35 | openstackgerrit | Merged openstack-infra/shade master: Decouple OpenStackCloud from Connection https://review.openstack.org/610981 | |
| 16:11:35 | openstackgerrit | Merged openstack-infra/shade master: Add release note about decoupling https://review.openstack.org/611320 | |
| 16:11:42 | dtruong | hi ShilpaSD | |
| 16:12:55 | ShilpaSD | dtruong: Hi, its related to https://review.openstack.org/#/c/607061/ | |
| 16:12:56 | ShilpaSD | , mordered helped me to resolve the query | |
| 16:13:23 | ShilpaSD | dtruong: query was, we have cluster related functional test cases under cloud package as well | |
| 16:13:53 | ShilpaSD | So can we move them here undr clustering package, that you have added | |
| 16:14:14 | ShilpaSD | Mordered replied that one day they should be merged | |
| 16:15:30 | dtruong | ShilpaSD: you are talking about the cluster tests in here: https://github.com/openstack/openstacksdk/blob/master/openstack/cloud/openstackcloud.py | |
| 16:17:23 | dtruong | sorry, wrong link. are you referring to the tests in here: https://github.com/openstack/openstacksdk/blob/master/openstack/tests/functional/cloud/test_clustering.py | |
| 16:17:25 | ShilpaSD | Functional tests 'test_cluster_templates.py' and 'test_clustering.py' | |
| 16:17:25 | ShilpaSD | under cloud package | |
| 16:17:31 | ShilpaSD | yes | |
| 16:20:46 | dtruong | ok, i guess i didn't realize that those tests existed | |
| 16:21:21 | dtruong | those tests are more comprehensive so i guess we can drop my functional tests in favor of those | |
| 16:24:11 | dtruong | ok, i see now. the functional tests in cloud package came from shade integration | |
| 16:24:32 | dtruong | so they test a different code path than my functional tests | |
| 16:24:32 | ShilpaSD | please elaborate this point for me | |
| 16:25:19 | mordred | dtruong: yah - that's right. we really should go through and make one set of tests - but also the plan (that we've just started on) is to get the openstackcloud.py layer things to be built on top of the things in the Proxy layer | |
| 16:26:01 | mordred | but we're still figuring out exactly what that should look like | |
| 16:27:10 | dtruong | so i think until that is done, it is useful to keep the two sets of tests | |
| 16:27:27 | mordred | dtruong: I agree | |
| 16:27:40 | mordred | dtruong: while I've got you there -- this just happened: http://logs.openstack.org/84/609984/1/gate/openstacksdk-functional-devstack-senlin/a6a39d7/testr_results.html.gz | |
| 16:27:47 | mordred | does that mean anythig to you? | |
| 16:28:28 | mordred | oh - that's stable/rocky | |
| 16:29:09 | mordred | I think it needs https://review.openstack.org/#/c/610753/ - but that is failing test | |
| 16:29:26 | mordred | *phew* I was worried something extra bad had happened | |
| 16:31:43 | dtruong | i have to look into why https://review.openstack.org/#/c/610753/ is failing | |
| 16:32:02 | dtruong | i don't see anything obvious but i'll check it out | |
| 16:35:21 | mordred | me either - and thanks! | |
| 16:37:43 | dtruong | ok, i need to backport one of my changes to rocky: https://review.openstack.org/#/c/597225/ | |
| 16:37:52 | dtruong | then it should work | |
| 16:48:44 | mordred | dtruong: awesome. I rebased my senlin patch on top of your backport, then added a depends-on to that patch for the sdk patch | |
| 16:48:50 | mordred | maybe it'll all work this time :) | |
| 17:08:51 | openstackgerrit | Merged openstack/openstacksdk master: Rearrange shade image code https://review.openstack.org/609683 | |
| 21:50:11 | openstackgerrit | Merged openstack/openstacksdk master: Add some warnings and clarifications for discovery https://review.openstack.org/606113 | |
| 23:27:41 | eandersson | mordred, I created a bug for the issue I mentioned yesterday https://bugs.launchpad.net/shade/+bug/1798489 | |
| 23:27:41 | openstack | Launchpad bug 1798489 in Shade "v4-fixed-ip / v6-fixed-ip no longer supported in shade for new vms" [Undecided,New] | |
| 23:46:04 | mordred | eandersson: thanks! I'll take a peek at that when I wake up. are you using shade directly still or are you on sdk? (the bug will be in both - mostly just curious) | |
| 23:48:21 | eandersson | This is for ansible | |
| 23:59:01 | eandersson | (so ansible -> shade) | |