| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-sdks - 2018-10-04 | |||
| 14:38:33 | smcginnis | :) | |
| 15:02:35 | brtknr | my py37 tox test is passing when i change issubclass back to isinstance... http://paste.openstack.org/show/731499/ | |
| 15:03:00 | brtknr | according to this patch | |
| 15:03:02 | brtknr | http://paste.openstack.org/show/731490/ | |
| 15:03:47 | brtknr | on the other hand, its failing without the patch: http://paste.openstack.org/show/731500/ | |
| 15:04:57 | brtknr | It also fails for py27 without the patch! | |
| 15:05:12 | brtknr | ... wait no it doesnt | |
| 15:05:18 | brtknr | ... my bad | |
| 15:13:21 | openstackgerrit | Stephen Finucane proposed openstack/os-api-ref master: tests: Support Sphinx 1.8+ https://review.openstack.org/607984 | |
| 15:14:01 | stephenfin | dhellmann: Would appreciate your Python-fu on the above. I'm not sure why a mock decorator on the class isn't working | |
| 15:14:12 | stephenfin | dhellmann: Specifically https://review.openstack.org/607984 | |
| 15:29:47 | mordred | cdent: oh - yeah, I can't stand py.test | |
| 15:31:01 | mordred | cdent: but that's not why I'd suggest not using it in an openstack context - the main thing is that we have a bunch of infrastructure that's based around subunit streams | |
| 15:31:25 | mordred | cdent: so far attempts to make a subunit output plugin for py.test have all died on the vine | |
| 15:31:51 | cdent | yeah, that's my recollection from early gabbi too: can work however, as long as it can output subunit | |
| 15:31:56 | mordred | yah | |
| 15:32:21 | dtantsur | mordred: out of curiosity: why can't you stand py.test? | |
| 15:32:21 | mordred | I thinik it would be good for the world if someone would write a good subunit plugin for py.test | |
| 15:32:51 | mordred | dtantsur: I find the way the magical fixtures work impossible to read/follow | |
| 15:33:01 | mordred | in talking about it as a unittest library | |
| 15:33:45 | mordred | but also - the 'I'm a test runner and also a unittest library' annoys me since there is a unittest discovery protocol in core python - so nose and py.test mixing the two concerns is annoying | |
| 15:34:21 | dtantsur | agreed | |
| 15:34:35 | cdent | i think the original assertion with py.test, long before it became so magic, was that unittest (as mode and as a library) is entirely unpythonic, which I agree with | |
| 15:34:44 | mordred | when we write tests that follow the standard unittest discovery protocol - then people are free to use py.test or stestr or nosetests on the command line as they feel like | |
| 15:34:45 | cdent | when it moved on from holger it got a bit out of hand | |
| 15:42:00 | mordred | many things do | |
| 15:46:15 | openstackgerrit | Monty Taylor proposed openstack/openstacksdk master: Support firewall service for SDK https://review.openstack.org/592303 | |
| 15:47:03 | mordred | ml, dtantsur, Shrews: ^^ I squashed the test fix patches into the firewall service patch - that should be green, we should be able to land it and then the gate should stop being broken | |
| 15:47:49 | dtantsur | I'm not sure what I think about squashing the fixes with a huge feature patch. Is it your way of forcing us to review it? :) | |
| 15:49:59 | mordred | dtantsur: :) ... no, it was just to avoid rebase pain since the fwaas patch also adds job config that touches the same jobs | |
| 15:50:24 | mordred | dtantsur: I could unsquash and try rebasing it into a different order if you want though | |
| 15:52:12 | dtantsur | I'd prefer the gate fix separate, to be honest, and the fwaas patch on top of it | |
| 15:56:22 | Shrews | ditto. these large changes to review are just not fun | |
| 15:56:25 | Shrews | smaller the better | |
| 15:57:06 | mordred | kk. I'll take a stab at that real quick | |
| 16:00:59 | edleafe | /me notes that API-SIG office hours have started | |
| 16:01:08 | edleafe | well, office *hour* | |
| 16:05:30 | edleafe | dtantsur: don't worry, I'll try to keep up with the volume of participants :) | |
| 16:06:16 | dtantsur | lol | |
| 16:06:48 | cdent | did you all see the discussion with rosmaita yesterday or so? | |
| 16:06:49 | openstackgerrit | Monty Taylor proposed openstack/openstacksdk master: Clean up python3 test and split networking into a job https://review.openstack.org/604517 | |
| 16:06:50 | openstackgerrit | Monty Taylor proposed openstack/openstacksdk master: Support firewall service for SDK https://review.openstack.org/592303 | |
| 16:07:02 | mordred | dtantsur, Shrews: ok - that wasn't as painful as I thought | |
| 16:07:20 | mordred | I still merged the two testing update patches since they're both just basically updating .zuul.yaml | |
| 16:07:21 | cdent | http://p.anticdent.org/3Htt | |
| 16:09:05 | dtantsur | mordred: ok, I think this is fine | |
| 16:09:11 | mordred | \o/ | |
| 16:09:21 | mordred | now here's hoping I id it right :) | |
| 16:09:43 | dtantsur | hehe | |
| 16:10:05 | edleafe | cdent: no, didn't see that | |
| 16:10:22 | dtantsur | okay, actually. My head refuses to do any thinking more. I guess I'll go for some jogging instead. | |
| 16:11:31 | smcginnis | If I were to work on adding more Cinder commands to python-openstackclient - is the plan now to put things in openstacksdk or other lib first, then expose it through osc? Or just use cinderclient within osc? | |
| 16:29:59 | mordred | smcginnis: the plan is to move osc to using sdk and off of python-*client - and hopefully we will be in a position to start doing rip-and-replace in a few weeks | |
| 16:31:07 | smcginnis | mordred: So if I were to look at adding some commands, I should first look at adding that functionality to openstacksdk? | |
| 16:35:07 | mordred | smcginnis: that would be the bestest choice - but also python-cinderclient is also currently being used, so I wouldn't block yourself on that transition | |
| 16:35:33 | smcginnis | Great, sounds reasonable. | |
| 16:35:59 | smcginnis | I'll see what works best, considering the long term plan I would like to avoid creating later work if possible. | |
| 16:57:05 | openstackgerrit | Logan V proposed openstack/openstacksdk master: Add networks to Limestone vendor https://review.openstack.org/608027 | |
| 17:15:08 | dhellmann | stephenfin : is mock failing because of import ordering or something? | |
| 17:16:41 | dhellmann | stephenfin : if you have a version of a change that wasn't working, I could poke at that a bit | |
| 20:34:15 | ml | mordred: thanks for the fix. any chance you can restore +2 CR? | |
| 20:34:43 | openstackgerrit | Matthias Lisin proposed openstack/openstacksdk master: openstackcloud.py: Implement FWaaS wrapper methods. https://review.openstack.org/604811 | |
| #openstack-sdks - 2018-10-05 | |||
| 07:43:54 | ml | ok, so now there is this openstacksdk-functional-devstack-networking run which is successful, but every other functional test run fails | |
| 07:44:06 | ml | Do I have to adjust anything on my side? | |
| 07:52:17 | frickler | ml: looks like you need to skip your tests if fwaas is not enabled. currently they are failing instead | |
| 07:57:15 | ml | like this? https://review.openstack.org/#/c/607199/4/openstack/tests/functional/network/v2/test_floating_ip.py | |
| 08:00:08 | ml | fwaas is not in the service list | |
| 08:32:19 | openstackgerrit | Matthias Lisin proposed openstack/openstacksdk master: Support firewall service for SDK https://review.openstack.org/592303 | |
| 08:32:39 | openstackgerrit | Matthias Lisin proposed openstack/openstacksdk master: openstackcloud.py: Implement FWaaS wrapper methods. https://review.openstack.org/604811 | |
| 08:53:17 | frickler | ml: something similar like that, yes. no idea how to detect fwaas, though, probably as a neutron extension? | |
| 08:54:09 | ml | that's what I did right now: https://review.openstack.org/#/c/592303/25..26/openstack/tests/functional/network/v2/test_firewall_group.py | |
| 09:23:38 | openstackgerrit | Stephen Finucane proposed openstack/os-api-ref master: tests: Support Sphinx 1.8+ https://review.openstack.org/607984 | |
| 09:23:38 | openstackgerrit | Stephen Finucane proposed openstack/os-api-ref master: DNM: Attempt to replace monkeypath with mock https://review.openstack.org/608190 | |
| 09:24:03 | stephenfin | dhellmann: I'm not sure. I've pushed up a sample of what I'm doing, if you fancy taking a look https://review.openstack.org/608190 | |
| 13:00:12 | mordred | ml: +2 looks great! I think that's the right way to go with detecting the extension | |
| 13:00:37 | ml | mordred: thanks | |
| 13:00:54 | mordred | slaweq: if you get a sec, could you re-review https://review.openstack.org/#/c/592303 ? we had to rebase around a patch to fix OOM errors in the test suite | |
| 13:01:21 | mordred | slaweq: if you feel like looking at https://review.openstack.org/#/c/604517 too that would be swell | |
| 13:01:48 | slaweq | mordred: sure, I even had it opened in brower already :) | |
| 13:06:18 | mordred | slaweq: that makes it easier :) | |
| 13:08:17 | slaweq | mordred: I have one comment in https://review.openstack.org/#/c/604517/7 - if that is fine, I will +2 on it | |
| 13:10:06 | mordred | slaweq: yah - that's intentional - mostly trying to get less things to run in that test since they're tested in other jobs ... I probably could clean this up even more - but I think I need a big whiteboard to draw on to do so :) | |
| 13:10:30 | slaweq | mordred: ok, then it's fine for me | |
| 13:11:18 | slaweq | +2'ed :) | |
| 13:11:47 | mordred | \o/ | |
| 13:14:27 | tosky | morning/afternoon/hello, any news about the branching of openstack/openstackclient.git? (to fix the check plugin jobs for older branches) | |
| 13:35:27 | openstackgerrit | Monty Taylor proposed openstack/openstacksdk master: Remove profile https://review.openstack.org/604414 | |
| 13:35:28 | openstackgerrit | Monty Taylor proposed openstack/openstacksdk master: Set endpoint_override from endpoint with noauth https://review.openstack.org/604415 | |
| 13:35:28 | openstackgerrit | Monty Taylor proposed openstack/openstacksdk master: Use discovery instead of config to create proxies https://review.openstack.org/600292 | |
| 13:35:29 | openstackgerrit | Monty Taylor proposed openstack/openstacksdk master: Remove api version default values https://review.openstack.org/600330 | |
| 13:35:30 | openstackgerrit | Monty Taylor proposed openstack/openstacksdk master: Use network proxy in openstack.cloud https://review.openstack.org/604645 | |
| 13:35:30 | openstackgerrit | Monty Taylor proposed openstack/openstacksdk master: Remove all the deprecated stuff https://review.openstack.org/605508 | |
| 13:58:51 | mordred | dtantsur: \o/ | |
| 14:27:30 | Shrews | mordred: i don't see a "self.network" in 604645 | |
| 15:10:57 | openstackgerrit | Merged openstack/openstacksdk master: Clean up python3 test and split networking into a job https://review.openstack.org/604517 | |
| 15:10:58 | openstackgerrit | Merged openstack/openstacksdk master: Support firewall service for SDK https://review.openstack.org/592303 | |
| 15:12:08 | mordred | Shrews: self is a Connection - so there's a property on self for each openstack service | |
| 15:12:26 | mordred | Shrews: (the sdk proxy layer stuff) | |
| 15:14:18 | mordred | Shrews: https://docs.openstack.org/openstacksdk/latest/user/connection.html#openstack.connection.Connection.network | |
| 15:15:32 | openstackgerrit | Stephen Finucane proposed openstack/os-api-ref master: tests: Support Sphinx 1.8+ https://review.openstack.org/607984 | |