Posted	Nick	Remark
#openstack-sdks - 2018-10-05
15:10:57	openstackgerrit	Merged openstack/openstacksdk master: Clean up python3 test and split networking into a job https://review.openstack.org/604517
15:10:58	openstackgerrit	Merged openstack/openstacksdk master: Support firewall service for SDK https://review.openstack.org/592303
15:12:08	mordred	Shrews: self is a Connection - so there's a property on self for each openstack service
15:12:26	mordred	Shrews: (the sdk proxy layer stuff)
15:14:18	mordred	Shrews: https://docs.openstack.org/openstacksdk/latest/user/connection.html#openstack.connection.Connection.network
15:15:32	openstackgerrit	Stephen Finucane proposed openstack/os-api-ref master: tests: Support Sphinx 1.8+ https://review.openstack.org/607984
15:24:05	Shrews	mordred: ??? self is an OpenStackCloud
15:27:45	mordred	Shrews: yah. but an OpenStackCloud is a Connection
15:28:03	Shrews	ah, Connection derives from OpenStackCloud
15:28:06	dtantsur	maaaaagiiiic
15:28:15	Shrews	but an OpenStackCloud is not a Connection
15:28:34	Shrews	i don't think i like that magic
15:28:44	mordred	Shrews: oh - sorry - it's backwards. a Connection is an OpenStackCloud
15:29:11	mordred	Shrews: and we only instantiate Connection ... we should reorganize that better
15:29:42	Shrews	so OpenStackCloud methods are depending on attributes in a Connection... which is weird
15:29:51	dtantsur	every proxy is an adapter, every connection is an openstacksdk, what's unclear about it? :D
15:30:31	Shrews	dtantsur: it's normal for derived classes to reference base class attributes. but not the other way around
15:30:35	mordred	Shrews: yah - end goal I think is to not have OpenStackCloud as a separate class at all - it's split currently just for hysterical raisins
15:30:55	dtantsur	just in case: I was kidding about the "what's unclear" bit. The answer is "largely everything" :)
15:31:16	dtantsur	* hysterical raisins, that's gold
15:31:59	mordred	Shrews: maybe we should make a patch that moves the content from openstack/cloud/openstackcloud into openstack/connection Connection ?
15:32:50	Shrews	mordred: i was about to suggest that, but i wasn't sure what your end goal looks like
15:33:30	Shrews	or else, make OpenStackCloud abstract but that might break things
15:33:58	mordred	Shrews: yah - end goal is to just have a Connection - the split is purely case we haven't gotten to it yet
15:34:28	Shrews	do we have *any* code in other projects directly instantiating OpenStackCloud itself?
15:34:35	Shrews	(from sdk)
15:34:50	Shrews	b/c this obviously breaks that
15:35:24	mordred	Shrews: not that I'm aware of, no
15:35:50	mordred	and shade.OpenStackCloud is a subclass of openstack.connection.Connection
15:36:06	mordred	so most of this is designed to be as confusing to you as I could make it
15:36:27	Shrews	good job
15:38:32	Shrews	ok, just reviewed the suggested connection methods in the docs, so we're good there.
15:38:32	mordred	Shrews: would it be helpful if we replaced more things with metaclasses?
15:38:59	Shrews	mordred: i think i just want to understand your plan more betterer
15:39:11	mordred	me too
15:39:54	Shrews	if the plan is "pretend OpenStackCloud is really a Connection for now and we'll move the methods later", then fine
15:39:59	Shrews	or some other thing
15:40:17	Shrews	but i didn't know what it was
15:40:28	Shrews	from just the review
15:40:37	mordred	yah. let's say that's the plan. I think that's a good plan
15:41:00	Shrews	ok
15:41:14	mordred	Shrews: maybe we should at least rename OpenStackCloud to _OpenStackCloud so it's clear it's more of a mixin than an actual standalone class
15:41:31	Shrews	or OpenStackCloudMixin
15:41:34	mordred	++
15:47:08	Shrews	i think we should move the connect* methods out of that mixin class too
15:47:28	Shrews	so it's even more clearerer
16:08:44	mordred	Shrews: ++
16:19:01	openstackgerrit	Monty Taylor proposed openstack/openstacksdk master: Add some warnings and clarifications for discovery https://review.openstack.org/606113
17:29:15	openstackgerrit	Monty Taylor proposed openstack/openstacksdk master: Start shifting cloud object-store methods to proxy https://review.openstack.org/608317
17:29:16	openstackgerrit	Monty Taylor proposed openstack/openstacksdk master: Make it clear that OpenStackCloud is a mixin https://review.openstack.org/608318
17:29:22	mordred	Shrews: ^^ just for you
20:33:50	openstackgerrit	Ruby Loo proposed openstack/python-openstackclient master: Add --property option to 'server rebuild' command https://review.openstack.org/608350
22:20:48	openstackgerrit	Merged openstack/openstacksdk master: Remove profile https://review.openstack.org/604414
22:20:48	openstackgerrit	Merged openstack/openstacksdk master: Set endpoint_override from endpoint with noauth https://review.openstack.org/604415
#openstack-sdks - 2018-10-06
12:47:57	openstackgerrit	Monty Taylor proposed openstack/openstacksdk master: Use discovery instead of config to create proxies https://review.openstack.org/600292
12:47:57	openstackgerrit	Monty Taylor proposed openstack/openstacksdk master: Remove api version default values https://review.openstack.org/600330
12:47:58	openstackgerrit	Monty Taylor proposed openstack/openstacksdk master: Use network proxy in openstack.cloud https://review.openstack.org/604645
12:47:58	openstackgerrit	Monty Taylor proposed openstack/openstacksdk master: Remove all the deprecated stuff https://review.openstack.org/605508
12:47:59	openstackgerrit	Monty Taylor proposed openstack/openstacksdk master: Start shifting cloud object-store methods to proxy https://review.openstack.org/608317
12:47:59	openstackgerrit	Monty Taylor proposed openstack/openstacksdk master: Make it clear that OpenStackCloud is a mixin https://review.openstack.org/608318
12:54:22	openstackgerrit	Monty Taylor proposed openstack/python-openstackclient master: Make use of keystoneauth service-type filtering for versions https://review.openstack.org/585030
13:27:55	openstackgerrit	Monty Taylor proposed openstack/openstacksdk master: Import rate limiting TaskManager from nodepool https://review.openstack.org/574285
13:28:20	openstackgerrit	Monty Taylor proposed openstack/openstacksdk master: Make RateLimitingTaskManager the TaskManager https://review.openstack.org/604520
13:28:49	openstackgerrit	Monty Taylor proposed openstack/openstacksdk master: Add support for per-service rate limits https://review.openstack.org/604521
13:40:09	mordred	ml: comments left on your wrapper method patch
13:40:33	openstackgerrit	Monty Taylor proposed openstack/openstacksdk master: Add some warnings and clarifications for discovery https://review.openstack.org/606113
13:49:30	ml	mordred: thanks. Will take a look
14:01:02	openstackgerrit	Monty Taylor proposed openstack/openstacksdk master: Replace TaskManager with a semaphore and lock https://review.openstack.org/604926
14:01:25	openstackgerrit	Monty Taylor proposed openstack/openstacksdk master: Replace TaskManager with a semaphore and lock https://review.openstack.org/604926
14:11:28	mordred	ml: sorry it took so long to review that - that OOM test timeout was really annoying :)
14:12:03	ml	Nah, it's fine man. It didn't block me at all.
14:14:33	ml	Actually, I'm really grateful that you could review it that quickly.
15:33:52	openstackgerrit	Merged openstack/openstacksdk master: Import rate limiting TaskManager from nodepool https://review.openstack.org/574285
15:33:52	openstackgerrit	Merged openstack/openstacksdk master: Make RateLimitingTaskManager the TaskManager https://review.openstack.org/604520
#openstack-sdks - 2018-10-08
09:27:52	openstackgerrit	Stephen Finucane proposed openstack/os-api-ref master: tests: Support Sphinx 1.8+ https://review.openstack.org/607984
11:38:55	openstackgerrit	Matthias Lisin proposed openstack/openstacksdk master: openstackcloud.py: Implement FWaaS wrapper methods. https://review.openstack.org/604811
13:43:12	openstackgerrit	Dmitry Tantsur proposed openstack/openstacksdk master: Correct updating baremetal nodes by name or ID https://review.openstack.org/608674
13:43:22	dtantsur	mordred: sigh ^^^
13:47:21	cmurphy	dtroyer: this command removal https://review.openstack.org/546924 got released in 3.16.0 instead of a 4.0, was that intentional?
13:50:31	dtroyer	cmurphy: I can't recall why I did that without waiting, I've made other things wait… is it causing trouble?
13:53:29	cmurphy	dtroyer: it caught us (suse internal) by surprise is all, we can update our automation but i wouldn't expect to have to without a major release
13:55:04	dtroyer	you are correct about that assumption, which is why I'm frustrated why I can't remember doing that…
13:55:34	dtroyer	it also points out we may need to do better at deprecation warnings
13:55:44	dtroyer	would a noiser warning have been noticed in your case?
14:00:00	cmurphy	dtroyer: probably not tbh
14:00:19	cmurphy	but that's on us
14:01:01	dtroyer	but like you said you're not expecting it now…
14:01:43	dtroyer	ok, I was just curious if my expectations/experience on scripted usage matched the real-world
14:01:44	dtroyer	thanks
15:48:49	openstackgerrit	Dmitry Tantsur proposed openstack/openstacksdk master: Correct updating baremetal nodes by name or ID https://review.openstack.org/608674
18:20:31	openstackgerrit	Sean McGinnis proposed openstack/python-openstackclient master: Add volume pool list command https://review.openstack.org/608740
21:45:21	openstackgerrit	Merged openstack/python-openstackclient master: Add --property option to 'server rebuild' command https://review.openstack.org/608350
#openstack-sdks - 2018-10-09
06:35:19	openstackgerrit	Fan Zhang proposed openstack/python-openstackclient master: Add --key-name and --key-unset option for server rebuild API. https://review.openstack.org/576422
10:54:08	openstackgerrit	Julie Pichon proposed openstack/python-openstackclient master: Allow endpoint filtering on both project and project-filtering https://review.openstack.org/608912
11:33:52	openstackgerrit	Dmitry Tantsur proposed openstack/openstacksdk master: [WIP] Wire in retries for all baremetal actions https://review.openstack.org/603427
11:43:28	openstackgerrit	Dmitry Tantsur proposed openstack/openstacksdk master: [WIP] Wire in retries for all baremetal actions https://review.openstack.org/603427
11:46:50	openstackgerrit	Dmitry Tantsur proposed openstack/openstacksdk master: [WIP] Wire in retries for all baremetal actions https://review.openstack.org/603427
13:23:55	openstackgerrit	Julie Pichon proposed openstack/python-openstackclient master: Allow endpoint filtering on both project and project-domain https://review.openstack.org/608912
13:31:17	openstackgerrit	Vieri proposed openstack/os-service-types master: Don't quote {posargs} in tox.ini https://review.openstack.org/608973
15:28:34	smcginnis	dtroyer: I had a question about the cliff autodoc you mentioned. Is there something extra that needs to be done to use that? I get the error: No commands found in the "openstack.volume.v2" namespace using the "volume capability" command name/pattern. Are you sure this is correct and the application being documented is installed?

Earlier   Later