Posted	Nick	Remark
#openstack-sdks - 2018-09-25
18:31:22	Shrews	mordred: comment on https://review.openstack.org/#/c/604521/6/openstack/connection.py
18:34:59	openstackgerrit	Samuel de Medeiros Queiroz proposed openstack/openstacksdk master: Normalize object resources https://review.openstack.org/602234
18:36:43	mordred	Shrews: your comment is correct
18:37:45	Shrews	well that's a first
18:41:41	openstackgerrit	Merged openstack/keystoneauth master: Reformat Adapter docstring https://review.openstack.org/605042
18:49:16	openstackgerrit	Monty Taylor proposed openstack-infra/shade master: Trim away the cover and py35 jobs https://review.openstack.org/605168
18:52:46	openstackgerrit	Monty Taylor proposed openstack/openstacksdk master: Clean up python3 test and remove duplicate jobs https://review.openstack.org/604517
19:01:19	openstackgerrit	Monty Taylor proposed openstack/openstacksdk master: Clean up python3 test and remove duplicate jobs https://review.openstack.org/604517
19:05:40	openstackgerrit	Monty Taylor proposed openstack/openstacksdk master: Restore timeout_scaling_factor https://review.openstack.org/604628
19:34:35	openstackgerrit	Matthias Lisin proposed openstack/openstacksdk master: Support firewall service for SDK https://review.openstack.org/592303
19:34:42	openstackgerrit	Matthias Lisin proposed openstack/openstacksdk master: openstackcloud.py: Implement FWaaS wrapper methods. https://review.openstack.org/604811
22:05:38	openstackgerrit	Samuel de Medeiros Queiroz proposed openstack/openstacksdk master: Update vendor support info for catalyst https://review.openstack.org/605245
22:11:22	openstackgerrit	Samuel de Medeiros Queiroz proposed openstack/openstacksdk master: Update vendor support info for ecs https://review.openstack.org/605248
22:16:05	openstackgerrit	Samuel de Medeiros Queiroz proposed openstack/openstacksdk master: Update vendor support info for switchengines https://review.openstack.org/605249
22:22:26	openstackgerrit	Samuel de Medeiros Queiroz proposed openstack/openstacksdk master: Update vendor support info for vexxhost https://review.openstack.org/605252
22:30:46	openstackgerrit	Samuel de Medeiros Queiroz proposed openstack/openstacksdk master: Add compute API info and fix provider names https://review.openstack.org/605253
22:31:48	samueldmq	these 5 are very neat too ^ just updating the vendor-support info
23:08:49	openstackgerrit	Merged openstack/openstacksdk master: Allow search on objects https://review.openstack.org/600683
#openstack-sdks - 2018-09-26
03:47:56	openstackgerrit	LIU Yulong proposed openstack/openstacksdk master: Support firewall service for SDK https://review.openstack.org/592303
07:56:37	openstackgerrit	Matthias Lisin proposed openstack/openstacksdk master: openstackcloud.py: Implement FWaaS wrapper methods. https://review.openstack.org/604811
11:13:22	openstackgerrit	Chen proposed openstack/python-openstackclient master: Use 2.latest compute microversion as default https://review.openstack.org/605398
13:34:53	openstackgerrit	Matthias Lisin proposed openstack/openstacksdk master: openstackcloud.py: Implement FWaaS wrapper methods. https://review.openstack.org/604811
15:07:09	openstackgerrit	Merged openstack-infra/shade master: Trim away the cover and py35 jobs https://review.openstack.org/605168
15:07:10	openstackgerrit	Merged openstack-infra/shade master: Remove the task manager https://review.openstack.org/605052
15:50:33	openstackgerrit	Monty Taylor proposed openstack/openstacksdk master: Clean up python3 test and remove duplicate jobs https://review.openstack.org/604517
17:18:30	openstackgerrit	Merged openstack/openstacksdk master: Restore timeout_scaling_factor https://review.openstack.org/604628
18:47:53	openstackgerrit	Monty Taylor proposed openstack/openstacksdk master: Remove profile https://review.openstack.org/604414
18:47:54	openstackgerrit	Monty Taylor proposed openstack/openstacksdk master: Set endpoint_override from endpoint with noauth https://review.openstack.org/604415
18:47:54	openstackgerrit	Monty Taylor proposed openstack/openstacksdk master: Use discovery instead of config to create proxies https://review.openstack.org/600292
18:47:55	openstackgerrit	Monty Taylor proposed openstack/openstacksdk master: Remove api version default values https://review.openstack.org/600330
18:47:55	openstackgerrit	Monty Taylor proposed openstack/openstacksdk master: Special case network and use it in openstack.cloud https://review.openstack.org/604645
18:47:56	openstackgerrit	Monty Taylor proposed openstack/openstacksdk master: Remove all the deprecated stuff https://review.openstack.org/605508
18:56:36	openstackgerrit	Merged openstack/openstacksdk master: Update vendor support info for catalyst https://review.openstack.org/605245
19:05:46	openstackgerrit	Merged openstack/openstacksdk master: Update vendor support info for ecs https://review.openstack.org/605248
19:05:46	openstackgerrit	Merged openstack/openstacksdk master: Update vendor support info for switchengines https://review.openstack.org/605249
19:05:47	openstackgerrit	Merged openstack/openstacksdk master: Update vendor support info for vexxhost https://review.openstack.org/605252
19:05:48	openstackgerrit	Merged openstack/openstacksdk master: Add compute API info and fix provider names https://review.openstack.org/605253
19:08:04	openstackgerrit	Monty Taylor proposed openstack/openstacksdk master: Replace TaskManager with a semaphore and lock https://review.openstack.org/604926
19:08:25	mordred	timburke: thanks for the review on that ^^ I think that should fix the logic error - but I agree, I need to write a big pile of tests
19:09:23	timburke	no problem. i remember an awful lot of staring and thinking while reviewing when we added a concurrency primitive to Swift (https://review.openstack.org/#/c/493636/)
19:10:20	timburke	tests are going to be invaluable, but we'll still need to think a whole lot about all the possible ways things could get out of order
19:10:41	timburke	(er, not "out of order" exactly... "interleaved")
19:11:16	mordred	the most fun code are the classes where there are more comments and test than code :)
19:11:48	mordred	++ yeah - interleaved, blocked, etc
19:12:45	timburke	fwiw, a co-worker of mine wrote https://github.com/swiftstack/python-stack-xray/blob/master/python-stack-xray that's proven invaluable when i suspect that i've hit a deadlock (particularly if eventlet is involved, too)
19:13:56	mordred	all the eventlet/gevent stuff totally blows my mind
19:15:04	mordred	timburke: seeing as how you have more eventlet experience than I do - my assumption with the semaphore/mutex code above is that it should work fine for eventlet callers too, right?
19:15:16	mordred	(should probaby make an eventlet test case to test that out)
19:16:40	timburke	probably? i'd need to think on it a bit more. i suspect it'll hurt if eventlet hasn't patched out threading and queue yet, though
19:17:54	mordred	that's a good point
19:17:56	timburke	(ie, one greenthread would wait on the semaphore and block the hub, so no other greenthreads in that os thread would be able to execute)
19:19:23	mordred	https://eventlet.net/doc/modules/queue.html and https://eventlet.net/doc/modules/semaphore.html exist at least - but I don't know if that means they monkeypatch those or not
19:19:34	timburke	oh... but if you've got a mix of greenthreads and os threads... you might get into a situation like https://bugs.launchpad.net/swift/+bug/1710328 ...
19:19:34	openstack	Launchpad bug 1710328 in OpenStack Object Storage (swift) "object server deadlocks when a worker thread logs something" [High,Fix released] - Assigned to Samuel Merritt (torgomatic)
19:21:12	timburke	i think the logic generally goes like this though: (1) don't mix greenthreads and os threads unless you know what you're doing. (2) no one knows what they're doing, and those that think they do are fooling themselves
19:21:29	mordred	yes. I agree with both of those
19:21:58	Shrews	hrm, this entire conversation leads to wonder if we should leave well enough alone with the TaskManager :)
19:22:05	mordred	BUT - that bug does indicate that eventlet patches out threading.RLock
19:22:19	mordred	so as long as the calling program is all threads or all mutexes life should be fine
19:23:28	mordred	Shrews: I think we're fine - we're not spawning threads or eventlets ourselves - calling code _should_ be fine from either calling convention, and we're not adding threads to the mix ourselves
19:23:59	mordred	Shrews: OR - we could just write the semaphore class in C++
19:24:00	timburke	yep, for sure eventlet can patch out threading. just gotta do something like https://github.com/openstack/swift/blob/2.19.0/swift/common/utils.py#L535
19:29:01	mordred	cool. I'll probably need that to do an eventlet test case
21:06:12	openstackgerrit	Samuel de Medeiros Queiroz proposed openstack/openstacksdk master: Format URL when updating image props in Glance v1 https://review.openstack.org/605534
21:20:05	openstackgerrit	Samuel de Medeiros Queiroz proposed openstack/openstacksdk master: Send image fields in headers for PUT in Glance v1 https://review.openstack.org/605535
22:28:50	openstackgerrit	Monty Taylor proposed openstack/openstacksdk master: Clarify error message is from nova https://review.openstack.org/605544
#openstack-sdks - 2018-09-27
03:07:51	openstackgerrit	Merged openstack/openstacksdk master: Normalize security groups when using Neutron https://review.openstack.org/602147
03:26:18	openstackgerrit	Merged openstack/openstacksdk master: Allow JMESPath on searching networking resources https://review.openstack.org/599078
10:38:31	openstackgerrit	Merged openstack/openstacksdk master: Change the method of role update https://review.openstack.org/600671
12:26:44	openstackgerrit	Monty Taylor proposed openstack/openstacksdk master: Remove all the deprecated stuff https://review.openstack.org/605508
12:27:07	dtantsur	s/links/likes/
12:27:08	mordred	\o/
12:27:19	mordred	dtantsur: I love deleting code
12:28:59	mordred	dtroyer: if you have any spare time amongst all of the starlingxing ... https://review.openstack.org/#/c/600292 is the last main big-boy before 1.0 and is ready for review. it's GIANT, so I don't blame you if you don't want to review it - but a lot of the patch is just removing unneeded lines from unit tests
12:39:22	tosky	mordred: hi! Do you remember us discussing about https://review.openstack.org/#/c/589465/ ? Apparently openstackclient-check-plugins is still failing on older stable branches
12:39:25	tosky	for example http://logs.openstack.org/36/588336/4/check/openstackclient-check-plugins/348b548/
12:47:52	mordred	tosky: oy. that's ugly
12:48:16	mordred	tosky: I remember talking about it - I don't remember what we said or if we had come up with a solution that just needed implementing
12:53:36	tosky	mordred: I think that the last discussion (before the PTG) was more or less "oh, ok, something is wrong"
12:58:29	mordred	tosky: darn.
12:58:40	mordred	tosky: well, I agree with pre-ptg us
13:10:08	tosky	mordred: could it be that openstackclient runs the tests from its master branch, thus requirement master requirements.txt, which conflicts with the requirements from a stable branch?
13:10:40	tosky	that would explain the issue with python-keystonclient 3.15.0 installed, but conflicting with the requirement of python-keystoneclient 3.17.0
13:19:37	mordred	tosky: it should be stable/queens of osc -- http://logs.openstack.org/36/588336/4/check/openstackclient-check-plugins/348b548/job-output.txt.gz#_2018-09-27_12_18_28_095085
13:20:02	mordred	oh - but openstack/openstackclient is master
13:20:03	tosky	mordred: that's python-openstackclient, not openstackclient
13:20:05	tosky	yep
13:20:08	mordred	http://logs.openstack.org/36/588336/4/check/openstackclient-check-plugins/348b548/job-output.txt.gz#_2018-09-27_12_18_31_882086
13:20:11	mordred	yeah
13:21:04	mordred	but requirements is also on stable/queens http://logs.openstack.org/36/588336/4/check/openstackclient-check-plugins/348b548/job-output.txt.gz#_2018-09-27_12_18_34_622015
13:22:19	tosky	mordred: but this requirements.txt comes from openstackclient, so from master http://git.openstack.org/cgit/openstack/openstackclient/tree/playbooks/openstackclient-check-plugins/run.yaml#n11
13:22:29	mordred	yah
13:22:39	mordred	I wonder if we need stable branch versions of that repo
13:23:01	mordred	dtroyer, dhellmann: ^^ I'm not 100% sure of how that hangs together
13:23:45	tosky	it used to have stable branches - was everything originally under openstack/openstackclient and then the main code was moved to openstack/python-openstackclient?
13:30:35	dhellmann	tosky : no, the code was always in openstack/python-openstackclient. The openstackclient repo is a meta-package for pulling in all of the extra dependencies to make it easier to install
13:30:53	dhellmann	tosky , mordred ,dtroyer : if we're testing against things that branch, we need to branch
13:31:10	dhellmann	even if we never do anything with the branches, that's just how the test machinery works
13:34:05	tosky	I guess it would make sense to keep the job definition in master only
13:34:56	tosky	so that the only thing to take care is the check_osc_commands.py

Earlier   Later