Earlier  
Later
New Search
Posted Nick Remark
#openstack-sdks - 2018-09-27
13:20:11 mordred yeah
13:21:04 mordred but requirements is also on stable/queens http://logs.openstack.org/36/588336/4/check/openstackclient-check-plugins/348b548/job-output.txt.gz#_2018-09-27_12_18_34_622015
13:22:19 tosky mordred: but this requirements.txt comes from openstackclient, so from master http://git.openstack.org/cgit/openstack/openstackclient/tree/playbooks/openstackclient-check-plugins/run.yaml#n11
13:22:29 mordred yah
13:22:39 mordred I wonder if we need stable branch versions of that repo
13:23:01 mordred dtroyer, dhellmann: ^^ I'm not 100% sure of how that hangs together
13:23:45 tosky it used to have stable branches - was everything originally under openstack/openstackclient and then the main code was moved to openstack/python-openstackclient?
13:30:35 dhellmann tosky : no, the code was always in openstack/python-openstackclient. The openstackclient repo is a meta-package for pulling in all of the extra dependencies to make it easier to install
13:30:53 dhellmann tosky , mordred ,dtroyer : if we're testing against things that branch, we need to branch
13:31:10 dhellmann even if we never do anything with the branches, that's just how the test machinery works
13:34:05 tosky I guess it would make sense to keep the job definition in master only
13:34:56 tosky so that the only thing to take care is the check_osc_commands.py
13:35:07 tosky though in openstackclient has code in stable/queens
13:38:12 tosky uh, or there is something weird in my local checkout
13:40:22 tosky for some reason I needed `git remote prune origin` in my local checkout of openstackclient
13:46:45 dtroyer it is totally possible that the openstackclient repo is not properly branched… I had wanted to move the plugin tests there but don't think that was ever completed, so it needs to be handled like the main repo
13:47:55 dtroyer mordred: I am release-branching stx today if zuul ever catches up, but that may give me an excuse to slip into a dark corner and refrsh myself with sdk :)
13:48:15 dtroyer I see how you pull the strings behind the scenes :)
13:49:32 mordred dtroyer: I've gotta do _something_ :)
16:41:18 elmiko edleafe dtantsur let me know how this strikes you https://etherpad.openstack.org/p/api-sig-newsletter
16:42:03 edleafe elmiko: that's not a python docstring :)
16:42:31 elmiko haha ;)
16:42:46 elmiko oh you... always making things so /grammatical/
16:43:43 edleafe I removed the "meeting agenda" from the bottom
16:43:52 elmiko ++ thanks
16:44:00 edleafe I guess I need to update the meeting in governance
16:44:26 elmiko i took an action for that, but if you want to no worries =)
16:44:51 edleafe oh, go ahead. I didn't know you took that action
16:45:01 elmiko i snuck it in the meeting XD
16:45:22 elmiko i was gonna follow the format for the other office hours entries, i'll make the pr shortly
16:45:37 elmiko am i good to publish on the newsletter?
16:46:37 edleafe send it
16:46:52 elmiko thanks!
16:49:52 dtantsur elmiko: LGTM
16:50:26 elmiko thanks
16:56:37 edleafe elmiko: dtantsur|afk: I updated the meetings page: https://wiki.openstack.org/wiki/Meetings/API-SIG
16:57:16 edleafe elmiko: you're going to take care of the changes in openstack-infra/irc-meetings, right?
16:58:56 elmiko edleafe: https://review.openstack.org/#/c/605808/
16:59:01 elmiko thanks ed !
17:32:56 mnaser https://review.openstack.org/#/c/589012 -- can we have eyes on this?
17:33:15 mnaser it's impossible to do live migrations without force specifying a host which isnt ideal
19:05:10 mordred mnaser: how about nargs='?' to make the argument to --live be optional
19:05:27 mnaser mordred: i like that, it doesn't break the backwards compatibility
19:06:24 mnaser mordred: i dunno.. should i respin that patch? push another one and this one can stay as an alternate when we want to further refactor things?
19:06:27 mordred mnaser: might need to also add const='<nonce>' - which will tell argparse to put '<nonce>' in as the argument to --live if none is otherwise given
19:06:39 mnaser could we use default=None?
19:06:45 mordred well, I don't think the patch in its current state is viable bdcause it's a total breaking change
19:06:46 mnaser i think that is the most preferable thing on the nova api side of things
19:06:54 mordred mnaser: maybe? it's worth a try
19:07:51 mordred mnaser: so - default is the value that will be put into the variable if --live isn't given. const is the value that is put in if --live is given with no argument
19:08:05 mnaser mordred: ah okay, so const is what we want then
19:08:10 mordred mnaser: so maybe nargs='?', const=False, default=None
19:08:20 mordred that way you can easily tell all three cases
19:08:51 mnaser ok ill try to look at that, i should be paying attention to the call i'm in.. but zzz
19:10:07 mordred mnaser: bah. calls are boring
19:10:13 mordred I left the feedback on the patch too
20:10:07 openstackgerrit Monty Taylor proposed openstack/openstacksdk master: Optimize the floating ip functional test a bit https://review.openstack.org/605860
20:56:30 openstackgerrit Monty Taylor proposed openstack/openstacksdk master: Remove all the deprecated stuff https://review.openstack.org/605508
21:54:59 openstackgerrit Brian Haley proposed openstack/python-openstackclient master: Fix some spaces in help messages https://review.openstack.org/603206
#openstack-sdks - 2018-09-28
06:11:51 openstackgerrit Merged openstack/python-openstackclient master: Fix some spaces in help messages https://review.openstack.org/603206
06:30:17 openstackgerrit Merged openstack/openstacksdk master: Implement network update https://review.openstack.org/600050
08:45:20 openstackgerrit Witold Bedyk proposed openstack/python-openstackclient master: Add monascaclient to `not plugins` list https://review.openstack.org/606002
08:48:35 openstackgerrit Witold Bedyk proposed openstack/python-openstackclient master: Remove python-ceilometerclient https://review.openstack.org/606005
10:58:39 dtantsur elmiko, edleafe, w00t! so, do we still use startmeeting/endmeeting?
11:08:34 openstackgerrit Merged openstack/python-openstackclient master: Add monascaclient to `not plugins` list https://review.openstack.org/606002
11:22:00 openstackgerrit Chen proposed openstack/python-openstackclient master: trivial: remove commented-out code https://review.openstack.org/606037
12:53:24 elmiko dtantsur: i don't think we need to
12:53:50 elmiko just be hear, ready to help =)
12:53:53 elmiko *here
13:09:54 mordred elmiko: if you do startmeeting/endmeeting, then you'll get a meeting log and can use the various # commands... but also no, you certainly don't have to
13:19:54 openstackgerrit Monty Taylor proposed openstack/openstacksdk master: Clarify error message is from nova https://review.openstack.org/605544
13:20:09 mordred dtantsur: ^^ took your advice there
13:21:13 elmiko mordred: is it common practice to do a start/end meeting for office hours?
13:21:29 elmiko i can see the rationality, just wondering
13:23:29 mordred elmiko: I dunno - I just work here :)
13:24:36 elmiko mordred: lol, ack ;)
13:29:03 edleafe dtantsur: no, we don't use those. The channel is already logged, and we don't need to be any more formal than "Hey, we're here if anyone has any issues to discuss".
13:31:15 mordred edleafe: but are you still here if people don't have issues to discuss?
13:32:05 edleafe mordred: of course. We will sit here twiddling our collective thumbs
13:36:01 dtantsur or me alone in case of the morning slot :)
13:52:34 elmiko dtantsur ++
13:55:33 openstackgerrit Monty Taylor proposed openstack/openstacksdk master: Remove profile https://review.openstack.org/604414
13:55:34 openstackgerrit Monty Taylor proposed openstack/openstacksdk master: Set endpoint_override from endpoint with noauth https://review.openstack.org/604415
13:55:34 openstackgerrit Monty Taylor proposed openstack/openstacksdk master: Use discovery instead of config to create proxies https://review.openstack.org/600292
13:55:35 openstackgerrit Monty Taylor proposed openstack/openstacksdk master: Remove api version default values https://review.openstack.org/600330
13:55:35 openstackgerrit Monty Taylor proposed openstack/openstacksdk master: Use network proxy in openstack.cloud https://review.openstack.org/604645
13:55:36 openstackgerrit Monty Taylor proposed openstack/openstacksdk master: Remove all the deprecated stuff https://review.openstack.org/605508
14:01:38 openstackgerrit Monty Taylor proposed openstack/openstacksdk master: Clean up python3 test and remove duplicate jobs https://review.openstack.org/604517
14:02:16 mordred dtantsur: ^^ reworked the network and python testing patches and took the python3 patch out of the discovery stack
14:02:31 dtantsur nice, thanks! I'll try to have another pass today
14:09:11 openstackgerrit Witold Bedyk proposed openstack/python-openstackclient master: Remove python-ceilometerclient https://review.openstack.org/606005
14:17:11 dtantsur mordred: btw I left some non-blocking comments on ps16 of https://review.openstack.org/#/c/600292/ please check them as well
14:17:35 mordred ooh, yay - reading now
15:19:27 openstackgerrit Monty Taylor proposed openstack/openstacksdk master: Add some warnings and clarifications for discovery https://review.openstack.org/606113
15:19:45 mordred dtantsur: ^^ there are the cleanups for your reviews on 600292
15:20:12 dtantsur thanks!
15:35:40 openstackgerrit Merged openstack/openstacksdk master: Format URL when updating image props in Glance v1 https://review.openstack.org/605534
16:47:58 mordred dtantsur|afk: quick reply to your commet on the RateLimitingTaskManager patch (and yes, you're right, it's even easier because we throw it back away)
16:48:23 Shrews those randomly failing tests are irritating
16:48:41 Shrews and happening quite frequently

Earlier   Later