Earlier  
Later
New Search
Posted Nick Remark
#openstack-sdks - 2018-07-03
14:03:18 dtantsur good
14:03:34 dtantsur I guess currently I can do munchify(node.to_dict()) as an ugly hack
14:04:00 dtantsur but what I'm hitting with my provisioning state patch is that I get a redundant GET call on each conversion between a Munch and a Node
14:04:07 dtantsur which is probably fine for now, but has to be fixed eventually
14:04:16 mordred yah - extra calls seem lame
14:04:26 dtantsur is it acceptable temporary?
14:06:13 mordred dtantsur: I'd be curious to discover why a GET call is being made during the conversion ...
14:07:12 openstackgerrit Monty Taylor proposed openstack/osc-lib master: Use openstack.config for config and Session objects https://review.openstack.org/579139
14:07:13 dtantsur mordred: https://review.openstack.org/#/c/570895/4/openstack/cloud/openstackcloud.py@9400 causes uuid-to-Node conversion
14:07:28 mordred dtroyer: ^^ that patch passes for me locally now, so might be not a waste of your time to review
14:07:37 dtantsur even when this call is used from e.g. register_machine where we already have a Munch
14:07:55 dtantsur because we cannot pass in a Munch, we need a UUID or a Node
14:09:55 mordred if we have a munch, we should be able to make a Node from it without an api call - I'd think Node(**munch_node) would do the trick?
14:10:47 dtantsur good idea, maybe we should generalize it as Resource.from_munch?
14:11:03 dtantsur defaulting to just cls(**munch)
14:12:55 frickler mordred: oh, that makes me wonder whether it'll fix my neutron ssl issues. will check.
14:13:49 mordred dtantsur: good idea - although maybe make it Resource._from_munch for now - since we might not need it once we finish and land the other thing
14:14:23 dtantsur mordred: okay, I'll see what I can do
14:14:42 dtroyer mordred: coolio, will have a look
14:23:42 dtroyer mordred: looks nice, thank you!
14:27:57 mordred dtroyer: yay!
16:11:18 openstackgerrit Dmitry Tantsur proposed openstack/openstacksdk master: Add Resource._from_munch class method https://review.openstack.org/579908
16:11:19 dtantsur mordred: ^^^
16:11:28 dtantsur now let's see if I can get a good use of it
16:11:40 openstackgerrit Monty Taylor proposed openstack/openstacksdk master: Use shade create_image method in image proxy layer https://review.openstack.org/579168
16:11:48 mordred dtantsur: neat. I could probably use that in that patch ^^
16:12:52 dtantsur mordred: oh, curious, I'm doing it the other way around in my patch: shade level calling baremetal proxy
16:13:02 dtantsur is there The Right approach here? or just whatever fits?
16:20:02 dtantsur hmm, and should I wire this _from_munch into Proxy._get_resource? so that all proxies support it automagically?
16:20:14 dtantsur this can be dangerous, maybe only for ironic for now..
16:22:47 dtantsur actually, from_munch can probably be implemented using the Body() fields
16:32:18 openstackgerrit Dmitry Tantsur proposed openstack/openstacksdk master: Add Resource._from_munch class method https://review.openstack.org/579908
16:43:29 openstackgerrit Dmitry Tantsur proposed openstack/openstacksdk master: Handle Munch objects in proxies https://review.openstack.org/579908
16:55:15 openstackgerrit Dmitry Tantsur proposed openstack/openstacksdk master: Handle Munch objects in proxies https://review.openstack.org/579908
17:42:37 mordred dtantsur|afk: your way is the better way - we want to get to the shade layer calling the proxy layer rather than the other way around
17:43:37 mordred dtantsur|afk: but for create_image that's going to require some surgery, so I figured invert it for now, then iterate on getting it done right as a followup
20:28:53 openstackgerrit David Shrewsbury proposed openstack-infra/shade master: Fix for passing dict for get_* methods https://review.openstack.org/579974
20:29:12 Shrews that probably could use a test
20:29:43 mordred yah. also - I'm pretty sure pep8 is going to complain about the whitespace
20:32:06 openstackgerrit David Shrewsbury proposed openstack-infra/shade master: Fix for passing dict for get_* methods https://review.openstack.org/579974
20:32:18 Shrews pep8 passed for me
20:33:56 mordred Shrews: cool
20:35:31 Shrews mordred: you want a release note for that?
20:38:51 wacuuu yyy question: are there any plans for sdk in go?
20:42:17 mordred wacuuu: the gophercloud project is basically that
20:42:22 mordred Shrews: nah
20:42:38 mordred wacuuu: https://github.com/gophercloud/gophercloud
20:47:37 Shrews oh that's interesting
20:47:55 Shrews mordred: my fav part: "Backwards-Compatibility Guarantees - None. Vendor it and write tests covering the parts you use."
20:49:22 wacuuu thanks
#openstack-sdks - 2018-07-04
02:09:42 openstackgerrit Fan Zhang proposed openstack/python-openstackclient master: Add --key-name and --key-unset option for server rebuild API. https://review.openstack.org/576422
03:00:32 openstackgerrit tianhui proposed openstack/python-openstackclient master: Compute:Support keypair set key-type https://review.openstack.org/577768
03:03:00 openstackgerrit tianhui proposed openstack/python-openstackclient master: Compute:Support keypair set key-type https://review.openstack.org/577768
07:57:49 openstackgerrit Josephine Seifert proposed openstack/openstacksdk master: Implement signature generation functionality https://review.openstack.org/580080
08:21:48 openstackgerrit Josephine Seifert proposed openstack/python-openstackclient master: [WIP] osc-included image signing (using openstacksdk) https://review.openstack.org/580086
10:21:45 openstackgerrit Mohammed Naser proposed openstack/python-openstackclient master: Allow setting volume attach status https://review.openstack.org/574719
11:17:06 openstackgerrit Monty Taylor proposed openstack/osc-lib master: Use openstack.config for config and Session objects https://review.openstack.org/579139
12:05:06 dtantsur mordred: got it. this munch vs resource thing does give me a headache..
12:05:32 dtantsur also I realized that we probably need this redundant GET now: the microversion to do an action may depend on the current state
12:07:45 dtantsur mordred: also, how does self.assert_calls() order calls? it insist PUT is run the first, while I'm pretty sure GET happens ealier..
12:13:16 dtantsur never mind me. I might have been wrong from the beginning about this redundant GET
12:42:29 mordred dtantsur: yay, glad I could help
12:42:51 mordred dtantsur: (and yes, I will be VERY happy once we've rationalized Resource and shade/munch)
13:07:02 openstackgerrit Dmitry Tantsur proposed openstack/openstacksdk master: [WIP] set_provision_state and wait_for_provision_state for baremetal Node https://review.openstack.org/570895
13:07:07 dtantsur okay, this could use more unit tests, but is reviewable ^^^
13:09:21 dtantsur TheJulia: if you have a minute ^^^
13:14:55 openstackgerrit Dmitry Tantsur proposed openstack/openstacksdk master: [WIP] set_provision_state and wait_for_provision_state for baremetal Node https://review.openstack.org/570895
#openstack-sdks - 2018-07-05
09:37:26 frickler mordred: I'm still affected by the network SSL issue, maybe you or someone else can take a look and check whether they can at least reproduce to confirm I'm not doing something dumb https://storyboard.openstack.org/#!/story/1756723
13:30:47 openstackgerrit Monty Taylor proposed openstack/osc-lib master: Use openstack.config for config and Session objects https://review.openstack.org/579139
13:30:47 openstackgerrit Monty Taylor proposed openstack/osc-lib master: Update sphinx lower-constraint to match test-requirements https://review.openstack.org/580380
14:00:47 mordred frickler: I'll look in to it - there is still a decent amount of unwinding we need to do
15:33:40 mordred dtroyer: woot! https://review.openstack.org/#/c/579139 passed tests
15:51:30 dtroyer \o/
16:26:04 mordred mriedem: does https://review.openstack.org/#/c/578960/ look ok to you now?
16:29:54 mriedem looking
16:30:38 mriedem hells yeah!
16:33:02 openstackgerrit Monty Taylor proposed openstack/openstacksdk master: Add task manager parameter to Connection https://review.openstack.org/577616
16:38:57 mordred mriedem: woot!
16:56:19 cdent dtantsur, edleafe, elmiko : a bit boring but https://etherpad.openstack.org/p/api-sig-newsletter
16:56:28 cdent also, I forgot to mention: I won't be at next week's meeting
16:58:02 dtantsur oh, nor will I
16:58:39 cdent jroll: thanks for that "that's the job of the server" response on web server headers
16:58:45 jroll :)
17:02:17 elmiko cdent dtantsur ack, might just be me and edleafe then
17:03:04 elmiko cdent: lgtm
17:03:16 edleafe cdent: ship it
17:03:19 cdent i'll wait on edleafe a bit longer, as he....
17:03:20 cdent omg
17:03:29 elmiko haha
17:22:46 openstackgerrit Merged openstack-infra/shade master: Fix for passing dict for get_* methods https://review.openstack.org/579974
18:36:27 openstackgerrit Monty Taylor proposed openstack/openstacksdk master: Import rate limiting TaskManager from nodepool https://review.openstack.org/574285
18:55:00 openstackgerrit Merged openstack/openstacksdk master: Add connection backreference to proxy instances https://review.openstack.org/579167
19:06:46 openstackgerrit Monty Taylor proposed openstack/openstacksdk master: Add task manager parameter to Connection https://review.openstack.org/577616
19:11:54 openstackgerrit Merged openstack/openstacksdk master: Only send force parameter to live migration if supported https://review.openstack.org/578960
19:15:42 openstackgerrit Monty Taylor proposed openstack-infra/shade master: Make OpenStackCloud a subclass of Connection https://review.openstack.org/577647
19:29:14 mordred wacuuu: great patch - I just clicked the approve button - but also left you some comments on things to know for next time
19:33:51 openstackgerrit Monty Taylor proposed openstack-infra/shade master: Make OpenStackCloud a subclass of Connection https://review.openstack.org/577647
19:33:52 openstackgerrit Monty Taylor proposed openstack-infra/shade master: Use the openstacksdk manager constructor argument https://review.openstack.org/580475
19:36:08 openstackgerrit Monty Taylor proposed openstack/openstacksdk master: Fix for passing dict for get_* methods https://review.openstack.org/580477
19:36:15 openstackgerrit Monty Taylor proposed openstack-infra/shade master: Make OpenStackCloud a subclass of Connection https://review.openstack.org/577647

Earlier   Later