| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-sdks - 2018-07-05 | |||
| 19:06:46 | openstackgerrit | Monty Taylor proposed openstack/openstacksdk master: Add task manager parameter to Connection https://review.openstack.org/577616 | |
| 19:11:54 | openstackgerrit | Merged openstack/openstacksdk master: Only send force parameter to live migration if supported https://review.openstack.org/578960 | |
| 19:15:42 | openstackgerrit | Monty Taylor proposed openstack-infra/shade master: Make OpenStackCloud a subclass of Connection https://review.openstack.org/577647 | |
| 19:29:14 | mordred | wacuuu: great patch - I just clicked the approve button - but also left you some comments on things to know for next time | |
| 19:33:51 | openstackgerrit | Monty Taylor proposed openstack-infra/shade master: Make OpenStackCloud a subclass of Connection https://review.openstack.org/577647 | |
| 19:33:52 | openstackgerrit | Monty Taylor proposed openstack-infra/shade master: Use the openstacksdk manager constructor argument https://review.openstack.org/580475 | |
| 19:36:08 | openstackgerrit | Monty Taylor proposed openstack/openstacksdk master: Fix for passing dict for get_* methods https://review.openstack.org/580477 | |
| 19:36:15 | openstackgerrit | Monty Taylor proposed openstack-infra/shade master: Make OpenStackCloud a subclass of Connection https://review.openstack.org/577647 | |
| 19:36:16 | openstackgerrit | Monty Taylor proposed openstack-infra/shade master: Use the openstacksdk manager constructor argument https://review.openstack.org/580475 | |
| 19:36:44 | mordred | Shrews: cherry-picked your shade patch to sdk | |
| 19:53:54 | wacuuu | mordred: anything else on my side to do? i'm used to magic submit button on my work gerrit that i don't see here | |
| 19:55:39 | mordred | wacuuu: nope - it'll merge once it passes the tests | |
| 19:56:12 | mordred | wacuuu: Zuul presses the submit button for us - once we leave a "Workflow +1" vote, it runs tests again and then merges | |
| 19:57:09 | wacuuu | ok, good to know. thanks alot for help with this | |
| 19:58:32 | mordred | wacuuu: sure thing! happy to have you contributing | |
| 20:28:47 | openstackgerrit | Merged openstack-infra/shade master: Remove shade-ansible-devel job https://review.openstack.org/570682 | |
| 20:50:46 | openstackgerrit | Merged openstack/openstacksdk master: Implementing solution for 2002563 issue from story board https://review.openstack.org/579679 | |
| 21:06:39 | openstackgerrit | Merged openstack/osc-lib master: Update sphinx lower-constraint to match test-requirements https://review.openstack.org/580380 | |
| 22:51:48 | openstackgerrit | Merged openstack/openstacksdk master: Fix for passing dict for get_* methods https://review.openstack.org/580477 | |
| #openstack-sdks - 2018-07-06 | |||
| 00:05:15 | openstackgerrit | Merged openstack/osc-lib master: Adding api_version to FakeAPP https://review.openstack.org/579523 | |
| 08:25:21 | openstackgerrit | tianhui proposed openstack/python-openstackclient master: Compute: Add tag support for server add volume https://review.openstack.org/580579 | |
| 09:34:51 | openstackgerrit | Dmitry Tantsur proposed openstack/openstacksdk master: [WIP] set_provision_state and wait_for_provision_state for baremetal Node https://review.openstack.org/570895 | |
| 10:25:08 | openstackgerrit | Jens Harbott (frickler) proposed openstack/python-openstackclient master: Retry floating IP tests https://review.openstack.org/578961 | |
| 10:26:16 | frickler | dtroyer: ^^ amended according to my comments. this is currently causing me to do a lot of rechecks for other patches, so would be great to get in soon, assuming you approve my modifications | |
| 12:36:38 | dtroyer | frickler: thank you, +W | |
| 13:47:14 | openstackgerrit | Ryan Brady proposed openstack-infra/shade master: Add support for static routes https://review.openstack.org/580661 | |
| 14:04:38 | openstackgerrit | Merged openstack/python-openstackclient master: Retry floating IP tests https://review.openstack.org/578961 | |
| 15:05:03 | dtantsur | mordred: hi! we have to decide on the critical question of a title for our talk :) I'm out next week, so we should probably submit it today, if you have time | |
| 15:32:30 | openstackgerrit | Merged openstack/osc-lib master: Use openstack.config for config and Session objects https://review.openstack.org/579139 | |
| 15:46:43 | openstackgerrit | Chris Dent proposed openstack/api-wg master: Expand schema for error.codes to reflect reality https://review.openstack.org/580703 | |
| 18:16:20 | openstackgerrit | Dean Troyer proposed openstack/python-openstackclient master: Slow down and retry aggregate create/delete to lessen race https://review.openstack.org/580732 | |
| 20:25:06 | dtroyer | mordred: I think https://review.openstack.org/#/c/579139 broke OSC's —insecure option, all of the shell integration tests with —insecure are failing since that merged | |
| #openstack-sdks - 2018-07-07 | |||
| 12:35:56 | mordred | dtroyer: piddle. I'll look and see what I can figure out | |
| 12:36:01 | mordred | how did we miss it on the osc patch? | |
| 12:36:10 | mordred | osc-lib that is | |
| 12:36:46 | mordred | ah - osc unittests | |
| 12:36:52 | mordred | awesome- that's at least easy to replicate | |
| 13:17:42 | mordred | dtroyer: ok. I found the issue - the overriding of the config options happens in the osc-lib ClientManager constructor, but then in osc prepare_to_run_command we make a new CloudRegion | |
| 13:18:17 | mordred | dtroyer: there is, happily, an easy solution - which is just to add support to openstack.config for the insecure option in the first place | |
| 13:35:08 | openstackgerrit | Monty Taylor proposed openstack/openstacksdk master: Add support for processing insecure https://review.openstack.org/580795 | |
| 13:45:22 | openstackgerrit | Monty Taylor proposed openstack/osc-lib master: Stop processing requests verify args https://review.openstack.org/580796 | |
| 13:46:12 | mordred | dtroyer: the openstacksdk patch fixes the osc unittests. I've got a release request for sdk up anyway, but I'll put a WIP on it and we can land that and get it in the release | |
| 13:53:03 | openstackgerrit | Monty Taylor proposed openstack/openstacksdk master: Add support for processing insecure https://review.openstack.org/580795 | |
| 13:53:19 | mordred | dtroyer: the osc-lib patch is not strictly required - but while we're thinking about it, it seems like a good thing to land once the sdk patch is out | |
| #openstack-sdks - 2018-07-08 | |||
| 19:04:08 | openstackgerrit | Monty Taylor proposed openstack/openstacksdk master: Add support for processing insecure https://review.openstack.org/580795 | |
| 21:17:24 | mordred | Shrews, adriant, corvus, rods_, dtroyer: I know it's a sunday, but if any of you happen to be around and feel like reviewing a fairly simple patch ^^ it would help to get it landed so we can cut an sdk release and continue streamlining the osc/sdk interaction | |
| 21:28:16 | mordred | dhellmann: ^^ | |
| 21:34:46 | openstackgerrit | Monty Taylor proposed openstack/osc-lib master: Stop processing requests verify args https://review.openstack.org/580796 | |
| 21:34:46 | openstackgerrit | Monty Taylor proposed openstack/osc-lib master: Run OSC unit test tips jobs https://review.openstack.org/580875 | |
| #openstack-sdks - 2018-07-09 | |||
| 00:18:02 | openstackgerrit | Merged openstack/osc-lib master: Add cloud to warning about domain related config https://review.openstack.org/577324 | |
| 00:30:06 | Shrews | mordred: done | |
| 03:03:26 | mordred | Shrews: thanks! | |
| 03:34:37 | openstackgerrit | Monty Taylor proposed openstack/osc-lib master: Fix exception in log warning when no cloud config exists https://review.openstack.org/580898 | |
| 03:35:18 | mordred | dtroyer, dhellmann: ^^ that patch is needed to unbreak the new osc-tips break that https://review.openstack.org/577324 caused | |
| 03:36:09 | mordred | once that lands, we can land the openstacksdk fix for the other osc-tips break, then release sdk, then we can land the patch to add osc-tips jobs to osc-lib so that we don't keep breaking osc's unittests with osc-lib patches :) | |
| 04:09:02 | openstackgerrit | Monty Taylor proposed openstack/osc-lib master: Pass prompt_for_password to OSC_Config constructor https://review.openstack.org/580900 | |
| 04:10:31 | openstackgerrit | Monty Taylor proposed openstack/python-openstackclient master: Remove local openstack.config overrides https://review.openstack.org/580901 | |
| 04:11:13 | mordred | dtroyer: then, as followups to all of that - there's a couple of patches that get rid of one of the sets of OSC_Config stuff | |
| 04:12:24 | mordred | once these bits are in and unwound, I'll start piecing apart the stuff in osc-lib OSC_Config and figuring out what needs to get added to openstacksdk | |
| 09:35:40 | openstackgerrit | tianhui proposed openstack/python-openstackclient master: Compute: Add tag support for server add port https://review.openstack.org/580977 | |
| 11:10:14 | frickler | mordred: dtroyer: someone on #openstack just reported issues running with python3.7, how do our plans to support that look like? | |
| 11:19:29 | mordred | frickler: I don't think we've made any yet | |
| 11:22:21 | frickler | mordred: ah, I just noticed that it's not even two weeks old, I was thinking it had been a couple of months. but then, yeah, maybe next cycle | |
| 11:23:01 | mordred | frickler: yeah. I think so :) | |
| 12:39:02 | frickler | mordred: dtroyer: spotz found an interesting issue, please take a look: https://bugs.launchpad.net/devstack/+bug/1780587 | |
| 12:39:02 | openstack | Launchpad bug 1780587 in devstack "Creds files in accr directory return Identity API errors" [Medium,Confirmed] - Assigned to Dr. Jens Harbott (j-harbott) | |
| 12:39:47 | mordred | frickler: what are acccr files? | |
| 12:41:35 | frickler | mordred: devstack generates these, similar in use to "openrc", but different files per account/project instead of having parameters. http://paste.openstack.org/show/725342/ | |
| 12:41:41 | mordred | oh for the love of | |
| 12:41:44 | frickler | didn't know they existed before, either | |
| 12:42:00 | mordred | well, it's still likely a real bug | |
| 12:42:16 | frickler | mordred: bug in OSC/libs? | |
| 12:42:19 | mordred | there's an osc patch I reviewed over the weekend related to identity_api version | |
| 12:42:22 | mordred | yeah | |
| 12:42:24 | mordred | somewhere | |
| 12:42:36 | mordred | there is confusion as to what identity_api_version is supposed to do | |
| 12:44:05 | mordred | there is code in osc that uses it to set some defaults for authentication - which I think we're just going to have to adopt in openstacksdk even though identity_api_versin is _supposed_ to be a setting controlling which version of the CRUD api to use - and auth_type is _supposed_ to control which version of auth one uses | |
| 12:44:43 | mordred | the thing is - literally nobody understands that - so I think the osc attempt at inferring intent from identity_api_version is better than telling people they're wrong | |
| 12:44:56 | mordred | all that said- I have NO IDEA why that would have broken just now | |
| 12:45:05 | frickler | mordred: yes, even setting auth_type=v3password doesn't solve the above issue | |
| 12:45:23 | mordred | we have not cut any releases of anything with the 'make osc-lib use sdk for session' code | |
| 12:45:49 | frickler | mordred: I tried with various older lib versions, none of them helped. so maybe spotz was confused by other clients working, and it was always broken for osc | |
| 12:46:09 | mordred | maybe so | |
| 12:46:22 | mordred | if you set OS_IDENTITY_API_VERSION=3 does it work? | |
| 12:46:28 | frickler | mordred: yes | |
| 12:46:38 | mordred | k. that's where the bug is at least | |
| 12:47:07 | mordred | openstack.config/os-client-config set a default identity_api_version to 2 - I'm betting that is confusing things | |
| 12:47:22 | mordred | we're also getting very close to being able to remove that default value too | |
| 12:48:17 | mordred | anywho - as a bugfix for devstack, adding OS_IDENTITY_API_VERSION=3 to those files will likely fix the specific bug - but we should remember this use case | |
| 14:12:31 | dhellmann | mordred : +2 on https://review.openstack.org/580898 | |
| 14:12:40 | mordred | yay! | |
| 14:12:44 | mordred | dhellmann: tyvm | |
| 14:12:55 | dhellmann | did you need another one right away or do we want to wait for that one? | |
| 14:13:02 | dhellmann | and how broken are things? should I single-approve that? | |
| 14:13:34 | mordred | nah - that's the only one - and the openstacksdk gate is broken without it, which is blocking landing the patch to unbreak the osc gate :) | |
| 14:13:50 | mordred | dhellmann: so, if you're comfortable single-coring, that would be great, but also if you're not that's cool | |
| 14:15:16 | mordred | if you're in the reviewing mood though, https://review.openstack.org/#/c/580900 is eventually needed and is one line - but *totally* non-urgent | |
| 14:16:43 | dhellmann | mordred : ok, I'll give dtroyer a little while to come online. If you need me to approve it later today I will | |
| 14:16:46 | dhellmann | and +2 on the other one | |
| 14:17:01 | dhellmann | oh, stand by, if the gate's broken I'm OK with approving it | |