Earlier  
Later
New Search
Posted Nick Remark
#openstack-sdks - 2018-06-21
16:56:06 cdent ah yeah,
16:56:49 elmiko did i send too quickly?
16:57:22 edleafe elmiko: no, it's fine
16:58:07 elmiko k
17:57:06 flwang1 mordred: still around?
17:57:28 mordred flwang1: yup!
17:57:58 mordred flwang1: and yes, I mean implement the code in openstacksdk - the shade code is in openstack/cloud/openstackcloud.py in the openstacksdk repo
17:58:08 mordred so it's basically the same thing at the moment - there's just two copies of it
17:58:26 flwang1 i think openstackclient is using the correct magnum api now
17:58:34 flwang1 ok
17:58:36 flwang1 got it
17:59:01 mordred woot
17:59:42 mordred definitely let me know if you have any issues - but we also have a magnum functional test job, so we should be set up for you
18:00:00 flwang1 fantastic, thanks
19:02:03 openstackgerrit Ken Giusti proposed openstack/cliff master: Add test case for interactive help https://review.openstack.org/576900
22:10:28 flwang1 mordred: seems shade only supports cluster template of magnum, no cluster CRUD?
22:11:45 mordred flwang1: yes - the magnum support was started by someone and then they got reassigned so it never progressed further
22:12:27 flwang1 mordred: then i'm wondering how should I name the function because I see senlin is trying to use the name like create_cluster....
22:13:41 flwang1 what's the rule in shade world for the name convention issue?
22:15:13 mordred flwang1: it's an excellent question - so far we haven't had much conflict - but when we have I think we've tried to figure out some way to distinguish the resources
22:16:25 mordred flwang1: is there a decent generic word to describe what the magnum cluster is a cluster of?
22:17:20 flwang1 mordred: i think create_cluster could be better fitting for Senlin, but the problem is Magnum has already used the xxx_cluster_template, so it's a little bit tricky
22:17:52 flwang1 otherwise, I think personally, i don't mind using xxxx_coe_cluster, xxx_coe_cluster_template, just like we did for OpenStackClient
22:17:56 mordred flwang1: well - we can rename it and make an alias for backwards compat if there's a better word
22:17:58 mordred flwang1: ++
22:19:10 flwang1 ok, then let's add the new xxx_coe_cluster_template and link it back to xxx_cluster_template, and deprecate the xxx_cluster_template in the future
22:19:15 flwang1 deal?
22:19:21 mordred sounds perfect to me
22:19:51 flwang1 mordred: fantastic, thanks, i will propose patch separately for template and cluster
22:19:59 flwang1 to make review easier
22:20:03 mordred ++
22:20:24 flwang1 magnum is deeply loved by some folks in NZ
22:21:03 flwang1 cool, see you around in all the openstack channels
22:24:48 mordred well, NZ is deeply loved by some of the folks around here ;) (why is NZ so pretty???)
23:48:49 openstackgerrit Ian Wienand proposed openstack/osc-lib master: Add cloud to warning about domain related config https://review.openstack.org/577324
#openstack-sdks - 2018-06-22
00:10:34 openstackgerrit Merged openstack/openstacksdk master: Adds Senlin support to openstacksdk https://review.openstack.org/576650
01:42:37 openstackgerrit Ian Wienand proposed openstack/osc-lib master: Add cloud to warning about domain related config https://review.openstack.org/577324
03:37:48 openstackgerrit Feilong Wang proposed openstack-infra/shade master: Improve Magnum cluster templates functions https://review.openstack.org/577342
06:47:40 openstackgerrit John Haan proposed openstack/python-openstackclient master: Implement image tag into OSC https://review.openstack.org/576804
06:50:21 openstackgerrit John Haan proposed openstack/python-openstackclient master: Implement image tag into OSC https://review.openstack.org/576804
09:03:36 openstackgerrit Jens Harbott (frickler) proposed openstack/python-openstackclient master: Fix volume type functional tests https://review.openstack.org/575448
09:11:03 openstackgerrit lvxianguo proposed openstack/openstacksdk master: fix misspelling of 'server' https://review.openstack.org/577375
09:22:09 openstackgerrit Jens Harbott (frickler) proposed openstack/python-openstackclient master: Fix volume type functional tests https://review.openstack.org/575448
11:00:43 frickler dtroyer: ^^ seems the functional-tips test doesn't install python-cinderclient from git, so the dependency doesn't work there. do we want to add it and also the other clients osc still includes?
12:20:40 openstackgerrit Jens Harbott (frickler) proposed openstack/python-openstackclient master: Fix volume type functional tests https://review.openstack.org/575448
12:20:41 openstackgerrit Jens Harbott (frickler) proposed openstack/python-openstackclient master: DNM: Test tips with python-cinderclient from git https://review.openstack.org/577404
12:24:10 frickler dtroyer: found another small glitch, in my local testing I'm down to two failures in v3.test_volume_types now. hoping the second patch will show these
14:47:17 dtroyer frickler: in https://review.openstack.org/#/c/577404/ depends-on is a URL not a commit-id, does that work? I don't think I've ever done it that way...
14:47:47 Shrews dtroyer: yes, that's a new feature of zuulv3
14:47:54 dtroyer nice
14:48:08 dtroyer and rats, I was hoping that was why it wasn't behaving as expected :)
14:48:58 dtroyer Shrews: now that my mental cache is warming up I'm beginning to recall that was to allow github urls?
14:49:09 Shrews yeah
14:49:29 Shrews dtroyer: https://zuul-ci.org/docs/zuul/user/gating.html#cross-project-dependencies
14:49:56 Shrews note the "note" about deprecation
14:50:08 dtroyer not only is it supported but change-id is deprecated…
14:50:10 dtroyer jinz
14:50:13 dtroyer jinx
14:50:20 dtroyer damn, it's not even monday
14:50:30 dtroyer thanks for the pointer
14:50:53 Shrews np
15:05:47 openstackgerrit Dean Troyer proposed openstack/python-openstackclient master: Fix volume type functional tests https://review.openstack.org/575448
18:35:38 openstackgerrit Merged openstack/openstacksdk master: fix misspelling of 'server' https://review.openstack.org/577375
#openstack-sdks - 2018-06-23
13:33:43 openstackgerrit Monty Taylor proposed openstack/openstacksdk master: Add task manager parameter to Connection https://review.openstack.org/577616
15:52:45 openstackgerrit Monty Taylor proposed openstack/openstacksdk master: Switch to providing created_at field for servers https://review.openstack.org/577619
15:53:06 openstackgerrit Monty Taylor proposed openstack/openstacksdk master: Switch to providing created_at field for servers https://review.openstack.org/577619
22:22:15 openstackgerrit Merged openstack/python-openstackclient master: Fix volume type functional tests https://review.openstack.org/575448
#openstack-sdks - 2018-06-24
00:26:58 openstackgerrit Sami Makki proposed openstack/python-openstackclient master: Fix the `role implies list` command. https://review.openstack.org/557359
03:38:57 openstackgerrit Merged openstack/python-openstackclient master: Fix the `role implies list` command. https://review.openstack.org/557359
03:46:00 openstackgerrit Steve Martinelli proposed openstack/python-openstackclient master: Add --key-name option for server rebuild API. https://review.openstack.org/576422
03:47:23 openstackgerrit Steve Martinelli proposed openstack/python-openstackclient master: Adding api_version to FakeApp https://review.openstack.org/576833
05:03:05 openstackgerrit Merged openstack/python-openstackclient master: Fix subnet host_routes error https://review.openstack.org/540568
12:38:51 openstackgerrit Monty Taylor proposed openstack-infra/shade master: Make OpenStackCloud a subclass of Connection https://review.openstack.org/577647
13:28:44 openstackgerrit Merged openstack/python-openstackclient master: compute: limit the service's force down command above 2.10 https://review.openstack.org/576514
14:10:18 openstackgerrit Monty Taylor proposed openstack/openstacksdk master: Move clustering additions from shade directories https://review.openstack.org/577654
14:41:34 openstackgerrit Merged openstack/openstacksdk master: Add testing of availability_zones() "details" argument https://review.openstack.org/575868
14:47:29 openstackgerrit Merged openstack/openstacksdk master: Add hypervisor details to hypervisors list if requested https://review.openstack.org/575869
16:45:11 wacuuu Hi. when i implement something new, it is on my side to provide proper ut right?
16:45:33 mordred wacuuu: yes, that's right
16:46:41 mordred wacuuu: it's preferrable to use requests-mock based unittests (you can see examples of them in the tree by looking for self.register_uris) - but a bunch of the tests for existing sdk functionality haven't been migrated to requests-mock yet
16:48:58 wacuuu propably i misshear something on my question; crappy internet. so. my question is because of this https://storyboard.openstack.org/#!/story/2002563
16:49:26 wacuuu i guess i should add ut case tha covers extra domain right?
16:50:24 mordred wacuuu: yes - it would be preferred
16:50:30 wacuuu ok, thanks
17:31:21 openstackgerrit Monty Taylor proposed openstack-infra/shade master: Make OpenStackCloud a subclass of Connection https://review.openstack.org/577647
17:31:22 openstackgerrit Monty Taylor proposed openstack-infra/shade master: Use RequestsMockTestCase everywhere https://review.openstack.org/577658
17:31:22 openstackgerrit Monty Taylor proposed openstack-infra/shade master: Convert domain params tests to requests_mock https://review.openstack.org/577659
17:31:23 openstackgerrit Monty Taylor proposed openstack-infra/shade master: Convert test_caching to requests-mock https://review.openstack.org/577660
17:31:23 openstackgerrit Monty Taylor proposed openstack-infra/shade master: Convert image_client mocks in test_shade_operator https://review.openstack.org/577661
17:31:24 openstackgerrit Monty Taylor proposed openstack-infra/shade master: Finish migrating image tests to requests-mock https://review.openstack.org/577662
18:45:12 openstackgerrit Monty Taylor proposed openstack/openstacksdk master: Move clustering additions from shade directories https://review.openstack.org/577654
18:45:13 openstackgerrit Monty Taylor proposed openstack/openstacksdk master: Convert domain params tests to requests_mock https://review.openstack.org/577663
18:45:13 openstackgerrit Monty Taylor proposed openstack/openstacksdk master: Convert test_caching to requests-mock https://review.openstack.org/577664
18:45:14 openstackgerrit Monty Taylor proposed openstack/openstacksdk master: Convert image_client mocks in test_shade_operator https://review.openstack.org/577665
18:45:14 openstackgerrit Monty Taylor proposed openstack/openstacksdk master: Finish migrating image tests to requests-mock https://review.openstack.org/577666
18:46:08 mordred Shrews: ^^ if you get bored, those two stacks get rid of the last places where we were mocking clients rather than using requests-mock
21:33:30 openstackgerrit Monty Taylor proposed openstack/openstacksdk master: Move clustering additions from shade directories https://review.openstack.org/577654
21:42:27 openstackgerrit Monty Taylor proposed openstack-infra/shade master: Finish migrating image tests to requests-mock https://review.openstack.org/577662
21:42:27 openstackgerrit Monty Taylor proposed openstack-infra/shade master: Make OpenStackCloud a subclass of Connection https://review.openstack.org/577647
21:49:48 openstackgerrit Monty Taylor proposed openstack/openstacksdk master: Switch to providing created_at field for servers https://review.openstack.org/577619

Earlier   Later