Earlier  
Later
New Search
Posted Nick Remark
#openstack-sdks - 2018-06-24
14:47:29 openstackgerrit Merged openstack/openstacksdk master: Add hypervisor details to hypervisors list if requested https://review.openstack.org/575869
16:45:11 wacuuu Hi. when i implement something new, it is on my side to provide proper ut right?
16:45:33 mordred wacuuu: yes, that's right
16:46:41 mordred wacuuu: it's preferrable to use requests-mock based unittests (you can see examples of them in the tree by looking for self.register_uris) - but a bunch of the tests for existing sdk functionality haven't been migrated to requests-mock yet
16:48:58 wacuuu propably i misshear something on my question; crappy internet. so. my question is because of this https://storyboard.openstack.org/#!/story/2002563
16:49:26 wacuuu i guess i should add ut case tha covers extra domain right?
16:50:24 mordred wacuuu: yes - it would be preferred
16:50:30 wacuuu ok, thanks
17:31:21 openstackgerrit Monty Taylor proposed openstack-infra/shade master: Make OpenStackCloud a subclass of Connection https://review.openstack.org/577647
17:31:22 openstackgerrit Monty Taylor proposed openstack-infra/shade master: Use RequestsMockTestCase everywhere https://review.openstack.org/577658
17:31:22 openstackgerrit Monty Taylor proposed openstack-infra/shade master: Convert domain params tests to requests_mock https://review.openstack.org/577659
17:31:23 openstackgerrit Monty Taylor proposed openstack-infra/shade master: Convert test_caching to requests-mock https://review.openstack.org/577660
17:31:23 openstackgerrit Monty Taylor proposed openstack-infra/shade master: Convert image_client mocks in test_shade_operator https://review.openstack.org/577661
17:31:24 openstackgerrit Monty Taylor proposed openstack-infra/shade master: Finish migrating image tests to requests-mock https://review.openstack.org/577662
18:45:12 openstackgerrit Monty Taylor proposed openstack/openstacksdk master: Move clustering additions from shade directories https://review.openstack.org/577654
18:45:13 openstackgerrit Monty Taylor proposed openstack/openstacksdk master: Convert domain params tests to requests_mock https://review.openstack.org/577663
18:45:13 openstackgerrit Monty Taylor proposed openstack/openstacksdk master: Convert test_caching to requests-mock https://review.openstack.org/577664
18:45:14 openstackgerrit Monty Taylor proposed openstack/openstacksdk master: Convert image_client mocks in test_shade_operator https://review.openstack.org/577665
18:45:14 openstackgerrit Monty Taylor proposed openstack/openstacksdk master: Finish migrating image tests to requests-mock https://review.openstack.org/577666
18:46:08 mordred Shrews: ^^ if you get bored, those two stacks get rid of the last places where we were mocking clients rather than using requests-mock
21:33:30 openstackgerrit Monty Taylor proposed openstack/openstacksdk master: Move clustering additions from shade directories https://review.openstack.org/577654
21:42:27 openstackgerrit Monty Taylor proposed openstack-infra/shade master: Finish migrating image tests to requests-mock https://review.openstack.org/577662
21:42:27 openstackgerrit Monty Taylor proposed openstack-infra/shade master: Make OpenStackCloud a subclass of Connection https://review.openstack.org/577647
21:49:48 openstackgerrit Monty Taylor proposed openstack/openstacksdk master: Switch to providing created_at field for servers https://review.openstack.org/577619
22:20:58 openstackgerrit Feilong Wang proposed openstack-infra/shade master: Add Magnum cluster support https://review.openstack.org/577673
23:06:08 openstackgerrit Feilong Wang proposed openstack-infra/shade master: Add Magnum cluster support https://review.openstack.org/577673
#openstack-sdks - 2018-06-25
04:03:23 openstackgerrit Feilong Wang proposed openstack-infra/shade master: Support Magnum /certificates API https://review.openstack.org/577720
09:48:54 openstackgerrit tianhui proposed openstack/python-openstackclient master: Compute:Support keypair set key-type https://review.openstack.org/577768
13:19:30 Shrews mordred: all of those seem to be failing tests
13:36:52 mordred Shrews: and you don't think we should land failing tests?
13:39:21 openstackgerrit Monty Taylor proposed openstack/openstacksdk master: Move clustering additions from shade directories https://review.openstack.org/577654
13:39:45 mordred Shrews: https://review.openstack.org/#/c/577662 through https://review.openstack.org/#/c/577658 are all green - hopefully that ^^ will also be green and if so I'll rebase the rest of the sdk version of the stack
13:58:23 Shrews mordred: obviously *I* think we should land failing tests. would make things so much easier
13:58:45 mordred Shrews: ++
13:59:13 Shrews apparently i was only looking at the sdk results. landing the shade things now
14:00:09 mordred Shrews: thanks! the last patch in the shade stack is expected to fail until we cut an sdk release containing https://review.openstack.org/#/c/577619/
14:00:25 mordred Shrews: the tips jobs should show it'll work once that's released
14:01:05 Shrews mordred: line 501 in https://review.openstack.org/#/c/577660/1/shade/tests/unit/test_caching.py seems to be the same as the line above it
14:01:47 mordred Shrews: yes - it's calling it twice to show that the caching works- the REST calls for that are only in the register_uris once
14:02:00 Shrews oh
14:02:22 Shrews should have read the line below it
14:02:40 mordred Shrews: bah. reading is for wimps
14:37:06 openstackgerrit Merged openstack/openstacksdk master: Switch to providing created_at field for servers https://review.openstack.org/577619
15:01:47 dtantsur mordred, TheJulia DriverNotFoundInEntrypoint: Could not find the following items in the 'ironic.drivers' entrypoint: agent_ilo, pxe_ilo
15:01:55 dtantsur these are gone for real, yeah
15:02:08 dtantsur hence the conductor fails to start, hence the 503 error
15:03:32 mordred dtantsur: well, that does seem like a real error
15:04:03 dtantsur mordred: yep, and it seems like bifrost still enables a bunch of drivers we're removing this week
15:04:18 dtantsur I'll try to do something about it with my limited ansible skills....
15:04:42 mordred dtantsur: does ironic not gate on bifrost I suppose?
15:04:58 dtantsur mordred: nope. was on my radar, but never happened
15:06:08 mordred gotcha. so it might be safer for us to turn it to non-voting for shade/sdk - since patches to ironic can break it?
15:08:28 openstackgerrit Monty Taylor proposed openstack-infra/shade master: Switch bifrost jobs to nonvoting https://review.openstack.org/577846
15:08:34 mordred Shrews: ^^ re: scrollback
15:09:36 Shrews hrm, if ironic doesn't gate on it, yeah...
15:15:47 dtantsur TheJulia: we should maybe add a bifrost job and revert ^^^
15:16:05 openstackgerrit Merged openstack/python-openstackclient master: Network: Add tag support for security group https://review.openstack.org/547733
15:41:00 dtantsur mordred, TheJulia, https://review.openstack.org/#/c/577848/ seems to pass the same set of jobs that used to pass before pxe_ilo removal
15:45:47 mordred dtantsur: \o/
15:54:24 openstackgerrit Monty Taylor proposed openstack/openstacksdk master: Move clustering additions from shade directories https://review.openstack.org/577654
15:54:24 openstackgerrit Monty Taylor proposed openstack/openstacksdk master: Re-enable clustering functional tests https://review.openstack.org/577852
15:58:24 openstackgerrit Monty Taylor proposed openstack/openstacksdk master: Move clustering additions from shade directories https://review.openstack.org/577654
15:58:42 openstackgerrit Monty Taylor proposed openstack/openstacksdk master: Re-enable clustering functional tests https://review.openstack.org/577852
16:47:10 openstackgerrit Merged openstack-infra/shade master: Switch bifrost jobs to nonvoting https://review.openstack.org/577846
17:43:35 TheJulia just now able to context switch over, but I concur
18:51:53 openstackgerrit Merged openstack-infra/shade master: Use RequestsMockTestCase everywhere https://review.openstack.org/577658
18:52:28 openstackgerrit Merged openstack-infra/shade master: Convert domain params tests to requests_mock https://review.openstack.org/577659
18:59:27 TheJulia mordred: not a cat? :(
19:03:16 openstackgerrit Merged openstack-infra/shade master: Convert test_caching to requests-mock https://review.openstack.org/577660
19:25:40 mordred TheJulia: well, it might not be a puppet either
19:27:34 openstackgerrit Monty Taylor proposed openstack/openstacksdk master: Convert domain params tests to requests_mock https://review.openstack.org/577663
19:27:40 openstackgerrit Monty Taylor proposed openstack/openstacksdk master: Convert test_caching to requests-mock https://review.openstack.org/577664
19:27:45 openstackgerrit Monty Taylor proposed openstack/openstacksdk master: Convert image_client mocks in test_shade_operator https://review.openstack.org/577665
19:27:50 openstackgerrit Monty Taylor proposed openstack/openstacksdk master: Finish migrating image tests to requests-mock https://review.openstack.org/577666
21:27:11 flwang mordred: around? i'm a little bit confusing about the openstack support in ansible. based on the code of ansible, seems it's using both openstacksdk and shade, but mainly it's openstacksdk, right?
21:32:27 TheJulia mordred: that was a really bad joke ;)
21:33:15 TheJulia flwang: in the process of migrating as shade was imported into openstacksdk to superceed shade
21:33:28 mnaser flwang: https://docs.openstack.org/openstacksdk/latest/#a-brief-history might be a fun read
21:34:19 openstackgerrit Merged openstack-infra/shade master: Convert image_client mocks in test_shade_operator https://review.openstack.org/577661
21:35:08 openstackgerrit Merged openstack-infra/shade master: Finish migrating image tests to requests-mock https://review.openstack.org/577662
21:39:12 flwang mnaser: so currently, i'm trying to support magnum in ansible, should I just contribute to openstacksdk directly?
21:40:26 flwang TheJulia: mnaser: thanks, that's the thing i want to figure out though I have to some brief answers from mordred
21:41:46 mnaser flwang: step 1 would be to make openstacksdk support it and step 2 would be to add ansible support
21:42:35 flwang mnaser: for step 1, i assume it means a new folder under https://github.com/openstack/openstacksdk/tree/master/openstack like containerinfra, right?
21:42:57 mnaser that's the part where i am not as useful :)
21:42:59 flwang instead of putting code into https://github.com/openstack/openstacksdk/tree/master/openstack/cloud/openstackcloud.py ？
22:30:22 TheJulia flwang: i am also not current pn the desired process, but in the past i've just proposed the desired methods to the main file.
22:35:22 flwang TheJulia: actually, i don't mind adding magnum support for both shade and cloud/openstackcloud.py, and even adding a new folder like /openstack/containerinfra, but I do need to understand in ansible which will be the way ansible calling
22:35:42 flwang not sure if there is a confirmed direction i can follow now
22:54:08 TheJulia flwang: i believe the desired direction is just openstacksdk, fwiw
22:55:53 flwang TheJulia: cheers, that's helpful
#openstack-sdks - 2018-06-26
06:00:45 openstackgerrit tianhui proposed openstack/python-openstackclient master: Compute:Support keypair set key-type https://review.openstack.org/577768
12:46:04 mordred flwang: just openstacksdk in openstack/cloud/openstackcloud.py - we can cherry-pick that shade patch you already wrote over
13:08:12 mordred at some point it would also probably be good to add a container_infrastructure_management directory and flesh out sdk-level support - but for now the shade-style methods are the only ones you need for ansible
13:09:06 mordred Shrews: for yourmorning reviewing pleasure - yesterday's shade patches are now green on sdk: https://review.openstack.org/577654 through https://review.openstack.org/577666
13:12:50 openstackgerrit Monty Taylor proposed openstack/openstacksdk master: Add Magnum cluster support https://review.openstack.org/578097
13:13:44 openstackgerrit Monty Taylor proposed openstack/openstacksdk master: Add Magnum cluster support https://review.openstack.org/578097
13:13:56 mordred flwang: ^^ there's a cherry-pick of your patch
13:20:31 openstackgerrit Monty Taylor proposed openstack/openstacksdk master: Add Magnum cluster support https://review.openstack.org/578097
14:52:58 openstackgerrit Monty Taylor proposed openstack/openstacksdk master: Improve Magnum cluster templates functions https://review.openstack.org/578119

Earlier   Later