Earlier  
Later
New Search
Posted Nick Remark
#openstack-sdks - 2018-05-07
16:54:15 openstackgerrit Clark Boylan proposed openstack/python-openstackclient master: Use entrypoints lib instead of pkg_resources https://review.openstack.org/473954
17:03:57 openstackgerrit Matt Smith (_alastor_) proposed openstack/openstacksdk master: Fixing bug where original and new dicts would always be the same https://review.openstack.org/566683
17:06:04 openstackgerrit Clark Boylan proposed openstack/python-openstackclient master: Hack out pbr versioninfo to test entrypoints cost https://review.openstack.org/566685
17:17:19 _alastor_ mordred: It also seems to be ignoring the OS_VOLUME_API_VERSION environment variable and always using v3
17:37:01 _alastor_ This SDK is kind of hard to unravel
17:56:34 _alastor_ It's somewhere in the Connection constructor, because volume_api_version is '2' when returned from 'get_one'
17:56:57 _alastor_ but then it it gets passed into OpenStackCloud and that module is kinda big
18:49:16 openstackgerrit Matt Smith (_alastor_) proposed openstack/openstacksdk master: Adding block_storage v3 API support https://review.openstack.org/566355
20:43:22 openstackgerrit Merged openstack/openstacksdk master: pypy is not checked at gate https://review.openstack.org/564729
21:14:51 openstackgerrit Matt Smith (_alastor_) proposed openstack/openstacksdk master: Bugfix for block_storage not selecting the correct proxy https://review.openstack.org/566740
#openstack-sdks - 2018-05-08
12:02:16 openstackgerrit Merged openstack/keystoneauth master: Implement service_type alias lookups https://review.openstack.org/462218
12:03:53 openstackgerrit Merged openstack/keystoneauth master: Add methods to get all of the version data https://review.openstack.org/559154
14:48:34 mordred _alastor_: thanks for 566355 ... that actually shows a flaw in config loading that I need to fix in https://review.openstack.org/#/c/564494/ ... and also in words I said to you
14:49:39 mordred the correct variable is block_storage_api_version and OS_BLOCK_STORAGE_API_VERSION ... however, we need to honor people using old aliases such as volume_api_Version
14:51:37 mordred _alastor_: i'll land your patch for now then work on alias support
14:51:53 _alastor_ mordred: awesome. Thanks!
15:12:12 openstackgerrit Merged openstack/keystoneauth master: Make VersionData class https://review.openstack.org/564469
15:12:14 openstackgerrit Merged openstack/keystoneauth master: Turn normalize_status into a class https://review.openstack.org/564110
15:40:14 openstackgerrit Merged openstack/keystoneauth master: Use Status variables in tests https://review.openstack.org/564258
15:40:16 openstackgerrit Merged openstack/keystoneauth master: Infer version from old versioned service type aliases https://review.openstack.org/564299
15:47:03 openstackgerrit Monty Taylor proposed openstack/openstacksdk master: Honor service-type aliases in config https://review.openstack.org/566929
15:47:18 mordred _alastor_: ^^
15:48:14 mordred there's still one more patch to write for discovery to be fully plumbed through - and with my wrist being hurt I'm going to defer that for a few days
15:50:57 _alastor_ mordred: That's cool. I didn't even realize we had a definition set like that
15:51:14 _alastor_ defition mapping
15:51:32 _alastor_ definition
15:51:35 _alastor_ Can't type today
15:52:42 mordred _alastor_: it's a newish thing that we're still getting rolled out everywhere
15:53:06 mordred https://service-types.openstack.org/ is sort of the root of everything if you haven't seen it
17:27:26 openstackgerrit Monty Taylor proposed openstack/openstacksdk master: Unbreak pep8 tests from new pycodestyle https://review.openstack.org/566954
17:27:38 mordred Shrews: ^^ sigh
20:37:20 openstackgerrit Merged openstack/keystoneauth master: Reference class variable in Status https://review.openstack.org/564262
20:39:43 openstackgerrit Monty Taylor proposed openstack/openstacksdk master: Clean up floating ip tests https://review.openstack.org/566320
22:41:21 openstackgerrit Harald Jensås proposed openstack/python-openstackclient master: Allow setting network-segment on subnet update https://review.openstack.org/523974
#openstack-sdks - 2018-05-09
01:27:40 chenyb4 Qiming, Can you help me review this patch ? https://review.openstack.org/#/c/566510/
09:27:33 openstackgerrit Nobuto Murata proposed openstack/python-openstackclient master: Support --community in openstack image list https://review.openstack.org/565152
13:44:24 mordred Shrews, slaweq: fell like re-approving https://review.openstack.org/#/c/566320/ ? I bundled in the pep8 fixes too
13:44:56 mordred frickler: ^^ I will do a followup for your comment
13:53:39 frickler mordred: o.k., I'll give you a +2, then ;)
13:55:34 mordred frickler: \o/
14:03:15 mnaser mordred: so i think going by the ML list from gerard about his issues with openstacksdk that they've found a bug
14:03:24 frickler mordred: did you move os-client-config bugs to storyboard now, too? tried to mark https://bugs.launchpad.net/os-client-config/+bug/1768813 as "Fix Released" but that doesn't seem possible anymore
14:03:24 openstack Launchpad bug 1768813 in os-client-config "config.get_cache_expiration_time() function missing in 1.31.0 release" [Critical,Fix committed] - Assigned to Monty Taylor (mordred)
14:03:55 mnaser mordred: comparing a resource to None raises an exception because https://github.com/openstack/openstacksdk/blob/master/openstack/resource.py#L356-L360
14:04:06 mnaser comparand = None, Exception: <class 'AttributeError'> 'NoneType' object has no attribute '_body'
14:04:24 mnaser (if you have if some_resource != None)
14:04:26 slaweq mordred: +W :)
14:04:51 mnaser would simply returning false if comparand = None be an appropriate fix there?
14:04:56 mnaser (i can push up a patch)
14:06:02 mnaser well, i'll do that and then follow up the discussion in reviews :)
14:11:08 openstackgerrit Mohammed Naser proposed openstack/openstacksdk master: Avoid raising exception when comparing resource to None https://review.openstack.org/567230
14:22:33 openstackgerrit Monty Taylor proposed openstack/openstacksdk master: Fix F405 errors https://review.openstack.org/567234
14:22:33 openstackgerrit Monty Taylor proposed openstack/openstacksdk master: Add comment about W503 being skipped https://review.openstack.org/567235
14:22:34 openstackgerrit Monty Taylor proposed openstack/openstacksdk master: Remove D exclusions from flake8 config https://review.openstack.org/567236
14:22:34 openstackgerrit Monty Taylor proposed openstack/openstacksdk master: Fix H103 Apache license header check https://review.openstack.org/567237
14:22:47 mordred frickler: ^^ see what you made me go and do :)
14:22:58 mordred frickler: yes! it's in storyboard
14:23:29 mordred mnaser: yes - good call
14:24:21 mordred mnaser: patch looks great - but you should always use 'is' when comparing against None
14:24:33 mnaser mordred: that totally ran through my mind but i was like
14:24:38 mnaser "is none.. that's sql"
14:25:23 mordred :)
14:25:38 mnaser mordred: ill update that and also try to add a small test
14:26:17 mordred fwiw, it's because None is a singleton - is checks object identity
14:28:32 mnaser oh i see
14:30:55 openstackgerrit Monty Taylor proposed openstack/openstacksdk master: Defer all endpoint discovery to keystoneauth https://review.openstack.org/564494
14:30:55 openstackgerrit Monty Taylor proposed openstack/openstacksdk master: Honor service-type aliases in config https://review.openstack.org/566929
14:32:43 mordred Qiming: re: chenyb4's patch above, the floating ip job and pep8 errors should be handled by https://review.openstack.org/566320
14:32:50 mordred when it lands we can recheck and all should be good
14:34:03 mnaser mordred: i wonder if this is a bug that happens in python3 only
14:34:29 mnaser i just made a simple test with "foo is None" and commenting out my patch.. it passes, so i'm setting up python3 right now
14:34:36 mnaser not sure if there's something i don't understand or know
14:34:55 mordred oh fun
14:41:20 openstackgerrit Monty Taylor proposed openstack/openstacksdk master: Pass default_microversion to adapter constructor https://review.openstack.org/557935
14:41:21 openstackgerrit Monty Taylor proposed openstack/openstacksdk master: Throw an error on missing support for default microversion https://review.openstack.org/557938
14:41:21 openstackgerrit Monty Taylor proposed openstack/openstacksdk master: Rename service_key to service_type https://review.openstack.org/558049
14:46:13 openstackgerrit Monty Taylor proposed openstack/openstacksdk master: Pass default_microversion to adapter constructor https://review.openstack.org/557935
14:46:13 openstackgerrit Monty Taylor proposed openstack/openstacksdk master: Throw an error on missing support for default microversion https://review.openstack.org/557938
14:46:14 openstackgerrit Monty Taylor proposed openstack/openstacksdk master: Rename service_key to service_type https://review.openstack.org/558049
14:47:54 mnaser ok, found it
14:48:11 openstackgerrit Mohammed Naser proposed openstack/openstacksdk master: Avoid raising exception when comparing resource to None https://review.openstack.org/567230
14:48:33 mnaser mordred: ^ should be okay, commenting out my patch makes tests fail so yay
14:49:36 mordred \o/
14:50:30 mordred frickler: updated version of that look good to you?
14:51:13 mordred mnaser: frickler had a suggestion on ps1 about doing an isinstance(comparand, Resource) that might still be a good idea
14:51:21 mnaser oh oops
14:51:24 mnaser i didnt see that
14:51:38 mnaser i like that idea
14:52:47 openstackgerrit Monty Taylor proposed openstack/openstacksdk master: Defer all endpoint discovery to keystoneauth https://review.openstack.org/564494
14:52:48 openstackgerrit Monty Taylor proposed openstack/openstacksdk master: Honor service-type aliases in config https://review.openstack.org/566929
14:52:48 openstackgerrit Monty Taylor proposed openstack/openstacksdk master: Pass default_microversion to adapter constructor https://review.openstack.org/557935
14:52:49 openstackgerrit Monty Taylor proposed openstack/openstacksdk master: Throw an error on missing support for default microversion https://review.openstack.org/557938
14:52:49 openstackgerrit Monty Taylor proposed openstack/openstacksdk master: Rename service_key to service_type https://review.openstack.org/558049
14:55:05 openstackgerrit Mohammed Naser proposed openstack/openstacksdk master: Avoid raising exception when comparing resource to None https://review.openstack.org/567230
14:55:09 mnaser frickler, mordred: update with isinstance usage
15:00:45 mordred mnaser: +2
15:03:52 mnaser tyvm
15:18:38 openstackgerrit Monty Taylor proposed openstack/openstacksdk master: Add nodepool-functional-py35-src job https://review.openstack.org/567254
15:18:39 openstackgerrit Monty Taylor proposed openstack/openstacksdk master: Add python 3.6 jobs https://review.openstack.org/567255
15:42:21 openstackgerrit Monty Taylor proposed openstack/openstacksdk master: Clean up floating ip tests https://review.openstack.org/566320

Earlier   Later