Earlier  
Later
New Search
Posted Nick Remark
#openstack-sdks - 2018-05-09
14:04:51 mnaser would simply returning false if comparand = None be an appropriate fix there?
14:04:56 mnaser (i can push up a patch)
14:06:02 mnaser well, i'll do that and then follow up the discussion in reviews :)
14:11:08 openstackgerrit Mohammed Naser proposed openstack/openstacksdk master: Avoid raising exception when comparing resource to None https://review.openstack.org/567230
14:22:33 openstackgerrit Monty Taylor proposed openstack/openstacksdk master: Fix F405 errors https://review.openstack.org/567234
14:22:33 openstackgerrit Monty Taylor proposed openstack/openstacksdk master: Add comment about W503 being skipped https://review.openstack.org/567235
14:22:34 openstackgerrit Monty Taylor proposed openstack/openstacksdk master: Remove D exclusions from flake8 config https://review.openstack.org/567236
14:22:34 openstackgerrit Monty Taylor proposed openstack/openstacksdk master: Fix H103 Apache license header check https://review.openstack.org/567237
14:22:47 mordred frickler: ^^ see what you made me go and do :)
14:22:58 mordred frickler: yes! it's in storyboard
14:23:29 mordred mnaser: yes - good call
14:24:21 mordred mnaser: patch looks great - but you should always use 'is' when comparing against None
14:24:33 mnaser mordred: that totally ran through my mind but i was like
14:24:38 mnaser "is none.. that's sql"
14:25:23 mordred :)
14:25:38 mnaser mordred: ill update that and also try to add a small test
14:26:17 mordred fwiw, it's because None is a singleton - is checks object identity
14:28:32 mnaser oh i see
14:30:55 openstackgerrit Monty Taylor proposed openstack/openstacksdk master: Defer all endpoint discovery to keystoneauth https://review.openstack.org/564494
14:30:55 openstackgerrit Monty Taylor proposed openstack/openstacksdk master: Honor service-type aliases in config https://review.openstack.org/566929
14:32:43 mordred Qiming: re: chenyb4's patch above, the floating ip job and pep8 errors should be handled by https://review.openstack.org/566320
14:32:50 mordred when it lands we can recheck and all should be good
14:34:03 mnaser mordred: i wonder if this is a bug that happens in python3 only
14:34:29 mnaser i just made a simple test with "foo is None" and commenting out my patch.. it passes, so i'm setting up python3 right now
14:34:36 mnaser not sure if there's something i don't understand or know
14:34:55 mordred oh fun
14:41:20 openstackgerrit Monty Taylor proposed openstack/openstacksdk master: Pass default_microversion to adapter constructor https://review.openstack.org/557935
14:41:21 openstackgerrit Monty Taylor proposed openstack/openstacksdk master: Throw an error on missing support for default microversion https://review.openstack.org/557938
14:41:21 openstackgerrit Monty Taylor proposed openstack/openstacksdk master: Rename service_key to service_type https://review.openstack.org/558049
14:46:13 openstackgerrit Monty Taylor proposed openstack/openstacksdk master: Pass default_microversion to adapter constructor https://review.openstack.org/557935
14:46:13 openstackgerrit Monty Taylor proposed openstack/openstacksdk master: Throw an error on missing support for default microversion https://review.openstack.org/557938
14:46:14 openstackgerrit Monty Taylor proposed openstack/openstacksdk master: Rename service_key to service_type https://review.openstack.org/558049
14:47:54 mnaser ok, found it
14:48:11 openstackgerrit Mohammed Naser proposed openstack/openstacksdk master: Avoid raising exception when comparing resource to None https://review.openstack.org/567230
14:48:33 mnaser mordred: ^ should be okay, commenting out my patch makes tests fail so yay
14:49:36 mordred \o/
14:50:30 mordred frickler: updated version of that look good to you?
14:51:13 mordred mnaser: frickler had a suggestion on ps1 about doing an isinstance(comparand, Resource) that might still be a good idea
14:51:21 mnaser oh oops
14:51:24 mnaser i didnt see that
14:51:38 mnaser i like that idea
14:52:47 openstackgerrit Monty Taylor proposed openstack/openstacksdk master: Defer all endpoint discovery to keystoneauth https://review.openstack.org/564494
14:52:48 openstackgerrit Monty Taylor proposed openstack/openstacksdk master: Honor service-type aliases in config https://review.openstack.org/566929
14:52:48 openstackgerrit Monty Taylor proposed openstack/openstacksdk master: Pass default_microversion to adapter constructor https://review.openstack.org/557935
14:52:49 openstackgerrit Monty Taylor proposed openstack/openstacksdk master: Throw an error on missing support for default microversion https://review.openstack.org/557938
14:52:49 openstackgerrit Monty Taylor proposed openstack/openstacksdk master: Rename service_key to service_type https://review.openstack.org/558049
14:55:05 openstackgerrit Mohammed Naser proposed openstack/openstacksdk master: Avoid raising exception when comparing resource to None https://review.openstack.org/567230
14:55:09 mnaser frickler, mordred: update with isinstance usage
15:00:45 mordred mnaser: +2
15:03:52 mnaser tyvm
15:18:38 openstackgerrit Monty Taylor proposed openstack/openstacksdk master: Add nodepool-functional-py35-src job https://review.openstack.org/567254
15:18:39 openstackgerrit Monty Taylor proposed openstack/openstacksdk master: Add python 3.6 jobs https://review.openstack.org/567255
15:42:21 openstackgerrit Monty Taylor proposed openstack/openstacksdk master: Clean up floating ip tests https://review.openstack.org/566320
16:09:50 openstackgerrit Monty Taylor proposed openstack/openstacksdk master: Clean up floating ip tests https://review.openstack.org/566320
16:10:28 openstackgerrit Monty Taylor proposed openstack/openstacksdk master: Fix F405 errors https://review.openstack.org/567234
16:54:11 openstackgerrit Monty Taylor proposed openstack/openstacksdk master: Add nodepool-functional-py35-src job https://review.openstack.org/567254
16:54:11 openstackgerrit Monty Taylor proposed openstack/openstacksdk master: Add python 3.6 jobs https://review.openstack.org/567255
16:54:30 openstackgerrit Monty Taylor proposed openstack/openstacksdk master: Add comment about W503 being skipped https://review.openstack.org/567235
16:54:36 openstackgerrit Monty Taylor proposed openstack/openstacksdk master: Remove D exclusions from flake8 config https://review.openstack.org/567236
16:54:42 openstackgerrit Monty Taylor proposed openstack/openstacksdk master: Fix H103 Apache license header check https://review.openstack.org/567237
17:06:58 openstackgerrit Julie Pichon proposed openstack/python-openstackclient master: Prevent "server migrate --wait" from hanging https://review.openstack.org/567289
17:22:40 Shrews mordred: comment on https://review.openstack.org/567234
17:24:28 mordred Shrews: good call ... I'll do a followup cleanup patch there (we can honestly get rid of most of thatfile)
18:37:38 dtantsur elmiko, cdent, edleafe, FYI tomorrow is a public holiday in Germany, so I'm unlikely to show up at the meeting
18:38:56 cdent ✔
18:40:13 edleafe dtantsur: ack
19:36:32 openstackgerrit Merged openstack/openstacksdk master: Clean up floating ip tests https://review.openstack.org/566320
20:49:26 openstackgerrit Merged openstack/openstacksdk master: Fix F405 errors https://review.openstack.org/567234
21:05:37 openstackgerrit Merged openstack/openstacksdk master: Add comment about W503 being skipped https://review.openstack.org/567235
22:13:54 openstackgerrit Merged openstack/openstacksdk master: Change clustering example test create parameter https://review.openstack.org/566510
22:35:36 openstackgerrit Merged openstack/openstacksdk master: add missing attribute in LBaaS v2 Pool API https://review.openstack.org/566434
23:50:56 mnaser mordred: if you're around, should i recheck or rebase my change about the none comparision?
23:51:10 mnaser it looks like its failing with some unrelated pep8 stuff, is there a change i should go on top of?
23:54:44 openstackgerrit Merged openstack/openstacksdk master: close files after open in unit/base https://review.openstack.org/566321
#openstack-sdks - 2018-05-10
02:49:11 openstackgerrit chenyb4 proposed openstack/openstacksdk master: Add function examples test for clustering https://review.openstack.org/555762
04:49:37 openstackgerrit chenyb4 proposed openstack/openstacksdk master: Add function examples test for clustering https://review.openstack.org/555762
07:47:10 openstackgerrit chenyb4 proposed openstack/openstacksdk master: Add function examples test for clustering https://review.openstack.org/555762
08:45:33 openstackgerrit Pavlo Shchelokovskyy proposed openstack/python-openstackclient master: Support locking user password https://review.openstack.org/564200
09:25:29 openstackgerrit chenyb4 proposed openstack/openstacksdk master: Add function examples test for clustering https://review.openstack.org/555762
11:30:46 openstackgerrit chenyb4 proposed openstack/openstacksdk master: Add function examples test for clustering https://review.openstack.org/555762
13:12:46 mordred mnaser: yah - pep8 fix should have landed yesterday, so recheck/rebase is great
13:41:14 mnaser https://review.openstack.org/#/c/567230/ <- ready to be landed whenever someone wants to push it through
13:55:44 mordred frickler: ^^ wanna do the honors?
14:22:59 openstackgerrit Monty Taylor proposed openstack/os-client-config master: Remove service-type override tests https://review.openstack.org/567602
14:41:03 openstackgerrit Slawek Kaplonski proposed openstack/openstacksdk master: Remove default values of router's is_ha and is_distributed arguments https://review.openstack.org/567606
14:50:36 openstackgerrit Monty Taylor proposed openstack/openstacksdk master: Defer all endpoint discovery to keystoneauth https://review.openstack.org/564494
14:50:36 openstackgerrit Monty Taylor proposed openstack/openstacksdk master: Honor service-type aliases in config https://review.openstack.org/566929
14:50:37 openstackgerrit Monty Taylor proposed openstack/openstacksdk master: Pass default_microversion to adapter constructor https://review.openstack.org/557935
14:50:37 openstackgerrit Monty Taylor proposed openstack/openstacksdk master: Throw an error on missing support for default microversion https://review.openstack.org/557938
14:50:38 openstackgerrit Monty Taylor proposed openstack/openstacksdk master: Rename service_key to service_type https://review.openstack.org/558049
14:50:38 openstackgerrit Monty Taylor proposed openstack/openstacksdk master: Add ipaddress and futures to lower-constraints https://review.openstack.org/567611
15:12:00 openstackgerrit Pavlo Shchelokovskyy proposed openstack/keystoneauth master: Use defusedxml for XML parsing in SAML https://review.openstack.org/536761
15:26:50 openstackgerrit Slawek Kaplonski proposed openstack/python-openstackclient master: Don't display router's is_ha and is_distributed attributes always https://review.openstack.org/567620
15:27:27 slaweq ajo: https://review.openstack.org/567606/ and https://review.openstack.org/567620
15:27:51 slaweq ajo: those are patches to fix display of is_ha and is_distributed attributes
15:33:55 slaweq wrong channel :)
16:18:50 cdent edleafe: very short https://etherpad.openstack.org/p/api-sig-newsletter
16:22:40 edleafe cdent: ship it
16:23:21 cdent word
16:48:35 openstackgerrit Merged openstack/openstacksdk master: Remove D exclusions from flake8 config https://review.openstack.org/567236

Earlier   Later