Earlier  
Later
New Search
Posted Nick Remark
#openstack-sdks - 2018-04-12
16:38:46 edleafe ok, sending it to the clouds...
16:58:39 openstackgerrit Merged openstack/os-client-config master: Remove DataCentred from list of vendors https://review.openstack.org/560894
17:07:43 cdent elmiko, edleafe: the merge of the http split has broken the gate jobs: https://review.openstack.org/#/c/554921/
17:08:04 cdent I'm on the phone right now, but if nobody steps up I'll see if I can make it go
17:12:23 elmiko cdent: does it just need a kick?
17:14:47 elmiko ok, those errors look a little beyond my current knowledge of the system. i think you better check it when you can cdent
17:19:01 cdent elmiko: roger elmiko
17:19:49 elmiko cdent: sorry, wish i could be more helpful =(
17:19:54 cdent no problem
17:23:53 edleafe the error on that doesn't make sense, does it?
17:24:10 elmiko it didn't to me, but then i'm really out of touch with this stuff
17:24:28 edleafe it just says that the docs have to end in .rst or .json
17:26:48 cdent elmiko, edleafe: it is reading the dir 'http' as a file, yes? (still on phone)
17:27:57 elmiko hmm, maybe
17:29:44 edleafe cdent: how did the http patch ever make it through, then?
17:30:26 edleafe oh, it didn't run the py27 tests on that
17:32:03 edleafe Unknow directive type "toctree" - http://logs.openstack.org/21/554921/1/gate/openstack-tox-py27/f3ef842/job-output.txt.gz#_2018-04-12_17_00_26_938269
17:36:08 edleafe Yeah, I just checked that test. It's doing glob.glob("guidelines/*"), which pulls in the 'guidelines/http' entry
17:36:16 edleafe Want me to push a fix?
17:40:32 cdent edleafe: if you can that would be dandy
17:43:05 openstackgerrit Ed Leafe proposed openstack/api-wg master: Fix the checking of directories for extensions https://review.openstack.org/560984
17:43:16 edleafe cdent: ^^
17:43:37 edleafe Do we have to revert the HTTP merge first?
17:43:47 cdent I don't think so
17:44:41 cdent edleafe: I assume you tried it locally and was fine?
17:44:57 edleafe yep
17:46:56 openstackgerrit Jens Harbott (frickler) proposed openstack/openstacksdk master: WIP: Add functional tests for Neutron DNS extension https://review.openstack.org/559068
17:48:56 edleafe cdent: looking at that test, it bugs me that we use the builtin name 'file' as a local variable name. I'll push a fix for that, but no rush on that
17:49:23 cdent yeah, that stuff is super old, predates us I think
17:55:29 openstackgerrit Ed Leafe proposed openstack/api-wg master: Remove use of Python builtin name for variables https://review.openstack.org/560994
17:55:39 edleafe cdent: no rush on this ^^
17:55:50 cdent yay!
17:57:34 edleafe looks like etowes is the culprit, from Idf0dc2aa1fd1e10ed3dfb953838e6ea469c76933
17:58:26 edleafe but cdent +1'd that one! :-P
17:58:57 cdent oh the humanity
17:59:12 cdent but in a tool, it's a good opportunity for a newbie to come along and clean up later...newbie
18:00:42 edleafe I always hated giving interviewees live coding challenges. IMO, they are a terrible predictor of what they know and how they work. Instead, I wrote some code with varying degrees of wrongness buried within.
18:01:24 edleafe I then asked them to review the code, and that showed how well they understood Python better than pretty much anything else I could come up with
18:02:51 cdent that seems a reasonable too
18:02:54 cdent l
18:03:05 cdent did you contextualize the environment?
18:03:14 cdent I fear that in openstack we fail to do that
18:03:19 cdent and tend to overshoot
18:05:40 edleafe "contextualize the environment" - you and your big city words
18:18:45 cdent says the man wh spent a lot of time in new york
19:53:30 openstackgerrit Merged openstack/api-wg master: Fix the checking of directories for extensions https://review.openstack.org/560984
20:00:57 edleafe cdent: elmiko: ^^
20:28:46 elmiko edleafe: \o/
20:36:47 openstackgerrit Chris Dent proposed openstack/api-wg master: Update the errors guidance to use service-type for code https://review.openstack.org/554921
20:47:44 openstackgerrit Chris Dent proposed openstack/api-wg master: Add guidance on needing cache-control headers https://review.openstack.org/550468
20:52:07 cdent elmiko, edleafe ^ fixed the merge conflict
20:53:18 edleafe w00t!
22:46:56 elmiko cdent: nice, thanks!
#openstack-sdks - 2018-04-13
00:15:24 openstackgerrit Monty Taylor proposed openstack-infra/shade master: Fix _get_entity to accept a dict https://review.openstack.org/561078
00:16:00 mordred ianw: ^^ there it is in patach form
00:18:01 openstackgerrit Monty Taylor proposed openstack-infra/shade master: Abort waiting for image on 404 https://review.openstack.org/561080
00:26:29 openstackgerrit Monty Taylor proposed openstack-infra/shade master: Fix _get_entity to accept a dict https://review.openstack.org/561078
00:32:09 openstackgerrit Monty Taylor proposed openstack-infra/shade master: Abort waiting for image on 404 https://review.openstack.org/561080
00:32:09 openstackgerrit Monty Taylor proposed openstack-infra/shade master: Don't throw errors when deleting nonexistant images https://review.openstack.org/561081
00:33:13 mordred ianw: ^^ three different patches that should make image deleting better
00:33:33 mordred ianw: one of them was already half-written locally - I'd just forgotten about it
07:39:22 openstackgerrit Jens Harbott (frickler) proposed openstack/openstacksdk master: Fix DNS Recordset CRUD https://review.openstack.org/560477
11:35:04 openstackgerrit Jens Harbott (frickler) proposed openstack/openstacksdk master: WIP: Add functional tests for Neutron DNS extension https://review.openstack.org/559068
13:27:58 openstackgerrit Monty Taylor proposed openstack/keystoneauth master: Add methods to get all of the version data https://review.openstack.org/559154
13:33:25 frickler mugsie: seems there are two issues still with 560477: a) we need different zone names because the func tests seem to run in parallel. maybe autogenerate random zone names?
13:34:01 mugsie frickler: yeah, I was looking at that. I think a random name is a good idea.
13:34:03 frickler b) get_recordset doesn't work with a name and I'm not sure whether we really want to fix that, might get more complicated than it's worth
13:34:24 frickler http://logs.openstack.org/68/559068/7/check/openstacksdk-functional-devstack-tips/9d04dba/testr_results.html.gz
13:35:13 mugsie damn. I think that could be s follow up patch in anycase
13:35:17 mugsie be a*
13:35:34 frickler the third failure is on me, I'll look into that
13:35:52 mugsie sounds like a plan
13:41:31 frickler oh, that's because the rebase rebased me off my other patch
13:42:22 frickler mugsie: maybe after mordred already kind-of approved this, you can merge https://review.openstack.org/560831 into your patch so that it becomes self-testing
13:45:33 mugsie oh - yeah, that seems easier
13:51:48 mugsie frickler: for the name parameter, we could do what we did in the client - and if you provide a name without a trailing '.' we append the zone name
13:52:27 mugsie does that seem sane? that way people who actually have it working would have needed the '.' and people who want to add a bare label going forward can?
13:53:27 frickler mugsie: we do that in the client? if so, then yes, that would be another option, though I have a bit of an uneasy feeling about doing such magic
13:54:00 mugsie yeah - we had people complaining about not being able to add "www" as a name, so we added it
13:54:38 frickler mugsie: mostly worried what happens if people just forget the "." at the end, that will give them "www.test.org.test.org"
13:54:58 mugsie yeah, that is an issue
13:55:13 mugsie lets worry about that later then
14:11:32 kimamisa Hi there ! Just some promotion for this MR: https://review.openstack.org/#/c/557359/
14:18:04 openstackgerrit Paul Belanger proposed openstack-infra/shade master: Build universal wheels https://review.openstack.org/561234
14:18:46 pabelanger remote: https://review.openstack.org/561234 Build universal wheels
14:19:10 pabelanger mordred: ^I can't see a reason not to do universal wheels, do you?
14:19:18 pabelanger or others :)
14:21:54 openstackgerrit Monty Taylor proposed openstack/keystoneauth master: Implement service_type alias lookups https://review.openstack.org/462218
14:21:55 openstackgerrit Monty Taylor proposed openstack/keystoneauth master: Add methods to get all of the version data https://review.openstack.org/559154
14:34:58 mordred pabelanger: no reason at all
14:35:22 pabelanger mordred: danke!
15:31:19 openstackgerrit Graham Hayes proposed openstack/openstacksdk master: Fix DNS Recordset CRUD https://review.openstack.org/560477
15:46:12 openstackgerrit Monty Taylor proposed openstack/keystoneauth master: Expose version status in EndpointData https://review.openstack.org/559125
15:46:13 openstackgerrit Monty Taylor proposed openstack/keystoneauth master: Implement service_type alias lookups https://review.openstack.org/462218
15:46:14 openstackgerrit Monty Taylor proposed openstack/keystoneauth master: Add methods to get all of the version data https://review.openstack.org/559154
15:47:40 openstackgerrit Monty Taylor proposed openstack/keystoneauth master: Expose version status in EndpointData https://review.openstack.org/559125
15:47:41 openstackgerrit Monty Taylor proposed openstack/keystoneauth master: Implement service_type alias lookups https://review.openstack.org/462218
15:47:42 openstackgerrit Monty Taylor proposed openstack/keystoneauth master: Add methods to get all of the version data https://review.openstack.org/559154
15:47:43 openstackgerrit Monty Taylor proposed openstack/keystoneauth master: Fix W503 line-break-before-binary-operator https://review.openstack.org/561259
15:58:06 openstackgerrit Merged openstack-infra/shade master: Build universal wheels https://review.openstack.org/561234

Earlier   Later