Earlier  
Later
New Search
Posted Nick Remark
#openstack-sdks - 2018-04-12
17:46:56 openstackgerrit Jens Harbott (frickler) proposed openstack/openstacksdk master: WIP: Add functional tests for Neutron DNS extension https://review.openstack.org/559068
17:48:56 edleafe cdent: looking at that test, it bugs me that we use the builtin name 'file' as a local variable name. I'll push a fix for that, but no rush on that
17:49:23 cdent yeah, that stuff is super old, predates us I think
17:55:29 openstackgerrit Ed Leafe proposed openstack/api-wg master: Remove use of Python builtin name for variables https://review.openstack.org/560994
17:55:39 edleafe cdent: no rush on this ^^
17:55:50 cdent yay!
17:57:34 edleafe looks like etowes is the culprit, from Idf0dc2aa1fd1e10ed3dfb953838e6ea469c76933
17:58:26 edleafe but cdent +1'd that one! :-P
17:58:57 cdent oh the humanity
17:59:12 cdent but in a tool, it's a good opportunity for a newbie to come along and clean up later...newbie
18:00:42 edleafe I always hated giving interviewees live coding challenges. IMO, they are a terrible predictor of what they know and how they work. Instead, I wrote some code with varying degrees of wrongness buried within.
18:01:24 edleafe I then asked them to review the code, and that showed how well they understood Python better than pretty much anything else I could come up with
18:02:51 cdent that seems a reasonable too
18:02:54 cdent l
18:03:05 cdent did you contextualize the environment?
18:03:14 cdent I fear that in openstack we fail to do that
18:03:19 cdent and tend to overshoot
18:05:40 edleafe "contextualize the environment" - you and your big city words
18:18:45 cdent says the man wh spent a lot of time in new york
19:53:30 openstackgerrit Merged openstack/api-wg master: Fix the checking of directories for extensions https://review.openstack.org/560984
20:00:57 edleafe cdent: elmiko: ^^
20:28:46 elmiko edleafe: \o/
20:36:47 openstackgerrit Chris Dent proposed openstack/api-wg master: Update the errors guidance to use service-type for code https://review.openstack.org/554921
20:47:44 openstackgerrit Chris Dent proposed openstack/api-wg master: Add guidance on needing cache-control headers https://review.openstack.org/550468
20:52:07 cdent elmiko, edleafe ^ fixed the merge conflict
20:53:18 edleafe w00t!
22:46:56 elmiko cdent: nice, thanks!
#openstack-sdks - 2018-04-13
00:15:24 openstackgerrit Monty Taylor proposed openstack-infra/shade master: Fix _get_entity to accept a dict https://review.openstack.org/561078
00:16:00 mordred ianw: ^^ there it is in patach form
00:18:01 openstackgerrit Monty Taylor proposed openstack-infra/shade master: Abort waiting for image on 404 https://review.openstack.org/561080
00:26:29 openstackgerrit Monty Taylor proposed openstack-infra/shade master: Fix _get_entity to accept a dict https://review.openstack.org/561078
00:32:09 openstackgerrit Monty Taylor proposed openstack-infra/shade master: Abort waiting for image on 404 https://review.openstack.org/561080
00:32:09 openstackgerrit Monty Taylor proposed openstack-infra/shade master: Don't throw errors when deleting nonexistant images https://review.openstack.org/561081
00:33:13 mordred ianw: ^^ three different patches that should make image deleting better
00:33:33 mordred ianw: one of them was already half-written locally - I'd just forgotten about it
07:39:22 openstackgerrit Jens Harbott (frickler) proposed openstack/openstacksdk master: Fix DNS Recordset CRUD https://review.openstack.org/560477
11:35:04 openstackgerrit Jens Harbott (frickler) proposed openstack/openstacksdk master: WIP: Add functional tests for Neutron DNS extension https://review.openstack.org/559068
13:27:58 openstackgerrit Monty Taylor proposed openstack/keystoneauth master: Add methods to get all of the version data https://review.openstack.org/559154
13:33:25 frickler mugsie: seems there are two issues still with 560477: a) we need different zone names because the func tests seem to run in parallel. maybe autogenerate random zone names?
13:34:01 mugsie frickler: yeah, I was looking at that. I think a random name is a good idea.
13:34:03 frickler b) get_recordset doesn't work with a name and I'm not sure whether we really want to fix that, might get more complicated than it's worth
13:34:24 frickler http://logs.openstack.org/68/559068/7/check/openstacksdk-functional-devstack-tips/9d04dba/testr_results.html.gz
13:35:13 mugsie damn. I think that could be s follow up patch in anycase
13:35:17 mugsie be a*
13:35:34 frickler the third failure is on me, I'll look into that
13:35:52 mugsie sounds like a plan
13:41:31 frickler oh, that's because the rebase rebased me off my other patch
13:42:22 frickler mugsie: maybe after mordred already kind-of approved this, you can merge https://review.openstack.org/560831 into your patch so that it becomes self-testing
13:45:33 mugsie oh - yeah, that seems easier
13:51:48 mugsie frickler: for the name parameter, we could do what we did in the client - and if you provide a name without a trailing '.' we append the zone name
13:52:27 mugsie does that seem sane? that way people who actually have it working would have needed the '.' and people who want to add a bare label going forward can?
13:53:27 frickler mugsie: we do that in the client? if so, then yes, that would be another option, though I have a bit of an uneasy feeling about doing such magic
13:54:00 mugsie yeah - we had people complaining about not being able to add "www" as a name, so we added it
13:54:38 frickler mugsie: mostly worried what happens if people just forget the "." at the end, that will give them "www.test.org.test.org"
13:54:58 mugsie yeah, that is an issue
13:55:13 mugsie lets worry about that later then
14:11:32 kimamisa Hi there ! Just some promotion for this MR: https://review.openstack.org/#/c/557359/
14:18:04 openstackgerrit Paul Belanger proposed openstack-infra/shade master: Build universal wheels https://review.openstack.org/561234
14:18:46 pabelanger remote: https://review.openstack.org/561234 Build universal wheels
14:19:10 pabelanger mordred: ^I can't see a reason not to do universal wheels, do you?
14:19:18 pabelanger or others :)
14:21:54 openstackgerrit Monty Taylor proposed openstack/keystoneauth master: Implement service_type alias lookups https://review.openstack.org/462218
14:21:55 openstackgerrit Monty Taylor proposed openstack/keystoneauth master: Add methods to get all of the version data https://review.openstack.org/559154
14:34:58 mordred pabelanger: no reason at all
14:35:22 pabelanger mordred: danke!
15:31:19 openstackgerrit Graham Hayes proposed openstack/openstacksdk master: Fix DNS Recordset CRUD https://review.openstack.org/560477
15:46:12 openstackgerrit Monty Taylor proposed openstack/keystoneauth master: Expose version status in EndpointData https://review.openstack.org/559125
15:46:13 openstackgerrit Monty Taylor proposed openstack/keystoneauth master: Implement service_type alias lookups https://review.openstack.org/462218
15:46:14 openstackgerrit Monty Taylor proposed openstack/keystoneauth master: Add methods to get all of the version data https://review.openstack.org/559154
15:47:40 openstackgerrit Monty Taylor proposed openstack/keystoneauth master: Expose version status in EndpointData https://review.openstack.org/559125
15:47:41 openstackgerrit Monty Taylor proposed openstack/keystoneauth master: Implement service_type alias lookups https://review.openstack.org/462218
15:47:42 openstackgerrit Monty Taylor proposed openstack/keystoneauth master: Add methods to get all of the version data https://review.openstack.org/559154
15:47:43 openstackgerrit Monty Taylor proposed openstack/keystoneauth master: Fix W503 line-break-before-binary-operator https://review.openstack.org/561259
15:58:06 openstackgerrit Merged openstack-infra/shade master: Build universal wheels https://review.openstack.org/561234
18:36:22 openstackgerrit Graham Hayes proposed openstack/openstacksdk master: Fix DNS Recordset CRUD https://review.openstack.org/560477
#openstack-sdks - 2018-04-14
03:47:52 openstackgerrit Jacky Hu proposed openstack/openstacksdk master: Allow members to be set as "backup" https://review.openstack.org/561386
04:17:38 openstackgerrit Merged openstack/openstacksdk master: Allow cascade deletion of load balancer https://review.openstack.org/553404
08:49:48 openstackgerrit Graham Hayes proposed openstack/openstacksdk master: Fix DNS Recordset CRUD https://review.openstack.org/560477
11:17:38 openstackgerrit Jacky Hu proposed openstack/openstacksdk master: Add timeout options for listener https://review.openstack.org/561401
15:41:29 openstackgerrit Merged openstack/openstacksdk master: create_subnet: Add filter on tenant_id if specified https://review.openstack.org/558052
15:51:08 openstackgerrit Merged openstack/openstacksdk master: Remove the need for OpenStackConfig in CloudRegion https://review.openstack.org/547488
16:05:25 openstackgerrit Monty Taylor proposed openstack/openstacksdk master: Temporarily disable neutron-grenade https://review.openstack.org/561419
16:06:20 openstackgerrit Monty Taylor proposed openstack/openstacksdk master: Revert "Temporarily disable neutron-grenade" https://review.openstack.org/561420
21:43:21 openstackgerrit Merged openstack/openstacksdk master: Add release note for added masakari support https://review.openstack.org/558051
#openstack-sdks - 2018-04-15
03:23:16 openstackgerrit Akihiro Motoki proposed openstack/python-openstackclient master: Clean up W503 and E402 pep8 errors https://review.openstack.org/560132
12:30:30 openstackgerrit Monty Taylor proposed openstack/openstacksdk master: Temporarily disable neutron-grenade https://review.openstack.org/561419
12:30:30 openstackgerrit Monty Taylor proposed openstack/openstacksdk master: Revert "Temporarily disable neutron-grenade" https://review.openstack.org/561420
#openstack-sdks - 2018-04-16
00:11:14 openstackgerrit Merged openstack/openstacksdk master: Temporarily disable neutron-grenade https://review.openstack.org/561419
04:12:50 openstackgerrit ayoung proposed openstack/python-openstackclient master: Add system role functionality https://review.openstack.org/524416
09:31:56 openstackgerrit Jens Harbott (frickler) proposed openstack/openstacksdk master: Add functional tests for Neutron DNS extension https://review.openstack.org/559068
10:41:41 openstackgerrit Merged openstack/openstacksdk master: Fix DNS Recordset CRUD https://review.openstack.org/560477
12:23:23 openstackgerrit Jens Harbott (frickler) proposed openstack/openstacksdk master: Add support for DNS attributes for floating IPs https://review.openstack.org/558820
12:23:29 openstackgerrit Jens Harbott (frickler) proposed openstack/openstacksdk master: Add functional tests for Neutron DNS extension https://review.openstack.org/559068
15:02:15 openstackgerrit ayoung proposed openstack/python-openstackclient master: Add system role functionality https://review.openstack.org/524416
15:51:45 cdent elmiko, edleafe : I'm getting asked by the foundation if the api-sig wants working group/bof/etc space at summit. I'm going to respond "no" unless you object. This is separate from forum space. I figure if we decide we need to make some time we can organize on the fly?
16:05:25 edleafe I'm really meh about it, so a response of "no" seems fine
16:05:46 cdent thans
16:05:48 cdent k
17:12:44 cdent edleafe: response from Jimmy: "Just to double check, it looks like Ed Leafe submitted a spot for an API-SIG BoF. That's not needed?"
17:27:12 edleafe I grabbed one JIC we needed it. But I think we should give it up.

Earlier   Later