Posted	Nick	Remark
#openstack-sdks - 2018-03-21
15:18:58	openstackgerrit	Chris Dent proposed openstack/microversion-parse master: Correct docstring on Version(0, 0) test https://review.openstack.org/554937
15:24:47	cdent	edleafe, elmiko: do you know: Is the guideline publishing job async from the guideline merging?
15:25:29	elmiko	cdent: i /think/ yes, i know it is often delayed from the merge
15:25:43	cdent	good, otherwise something is wrong :)
15:26:03	elmiko	iirc from the last time, it took a few hours for my merge to make it onto the site
15:31:56	openstackgerrit	Merged openstack/microversion-parse master: Improve Version.matches() method https://review.openstack.org/550251
15:45:52	openstackgerrit	Saju M proposed openstack/os-client-config master: pypy is not checked at gate https://review.openstack.org/554955
16:04:53	edleafe	elmiko: need your input on https://review.openstack.org/#/c/550252/.
16:05:42	elmiko	edleafe: ack, looking
16:31:25	edleafe	cdent: looks like the whole stack is queued up with +Ws
16:31:43	cdent	hurrah! thank you
16:43:19	openstackgerrit	Merged openstack/microversion-parse master: Add MicroversionMiddleware https://review.openstack.org/550252
16:43:20	openstackgerrit	Merged openstack/microversion-parse master: Allow passing a json_error_formatter to the middleware https://review.openstack.org/550263
16:43:21	openstackgerrit	Merged openstack/microversion-parse master: Clean up package version and python version support https://review.openstack.org/550264
16:43:22	openstackgerrit	Merged openstack/microversion-parse master: Do not use redundant attr check for keys in fold_headers https://review.openstack.org/554547
16:43:23	openstackgerrit	Merged openstack/microversion-parse master: Correct docstring on Version(0, 0) test https://review.openstack.org/554937
16:48:16	elmiko	cdent: ++
17:40:22	openstackgerrit	Chris Dent proposed openstack/microversion-parse master: Enable universal wheels for microversion-parse https://review.openstack.org/555001
17:40:35	cdent	elmiko, edleafe : one more!
17:45:05	elmiko	cdent: what are you, some sort of review pushing machine!
17:45:12	elmiko	dang! right as he quit
17:59:06	frickler	dtroyer: seems https://review.openstack.org/552140 causes the neutron segment failures , pinged neutron folk about it
17:59:38	frickler	dtroyer: the fip error appears to happen sporadic only
18:19:41	openstackgerrit	Merged openstack/microversion-parse master: Enable universal wheels for microversion-parse https://review.openstack.org/555001
18:41:48	frickler	dtroyer: the segment patch will get reverted and this is the followup https://bugs.launchpad.net/neutron/+bug/1757513
18:41:49	openstack	Launchpad bug 1757513 in neutron "standardattrdescription clobbers existing description API attr" [Undecided,New]
19:22:57	mordred	Shrews: got a second to +A https://review.openstack.org/#/c/554615/ real quick?
19:24:25	Shrews	mordred: hopefully in a bit. all I have is my phone. My computer networking is unhappy
19:24:39	mordred	Shrews: ew gross
19:24:44	Shrews	No idea what I broke
19:29:45	rods	mordred I can give a look in a minute
19:31:07	mordred	rods: thanks!
19:34:31	Shrews	ok, that was weird. ubuntu totally decided to eliminate one of my net interfaces and screwed up everything. sorry mordred, thx rods
19:34:45	mordred	Shrews: you didn't need that net interface anyway
19:35:46	Shrews	yeah, who needs the nets
19:36:25	Shrews	apparently doing anything beyond basic things with libvirt is dangerous
20:37:34	openstackgerrit	Merged openstack/python-openstacksdk master: Provide OpenStackConfigException backwards compat https://review.openstack.org/554615
#openstack-sdks - 2018-03-22
01:07:27	adriant	mordred: I don't know if we can make it nicer, but having to pass in the service itself when calling actions on the resources is a pain:
01:07:27	adriant	test_project.assign_role_to_user(conn.identity, test_user, member_role)
01:08:15	adriant	not to mention, having those kind of calls directly on the proxy might be nicer, since I don't always want to have to query for the project first if I know what the ids are of all the resources I want to act on are.
01:08:26	adriant	*also on the proxy
02:42:46	adriant	mordred: an error this time. Trying to see what response the sdk gives me when trying to create a keystone user that already exists: HttpException: HttpException: Unknown error
02:44:58	adriant	mordred: looks like an easy one. We aren't catching 409s in the raise from exception function
02:45:08	adriant	I'll throw up a patch for that
03:06:39	adriant	mordred: https://github.com/openstack/python-openstacksdk/blob/master/openstack/exceptions.py#L63 is evaluating as false... expect I KNOW there is a response with status 409...
03:06:45	adriant	except*
03:07:44	adriant	if I print response.text in that very place I get: "{"error": {"message": "Conflict occurred attempting to store user - Duplicate Entry", "code": 409, "title": "Conflict"}}"
03:08:02	adriant	so I have no clue what magic is making a response of type 409 eval to false...
03:16:20	adriant	wait... wtf response always evals to false
03:16:27	adriant	OH
03:16:48	adriant	it is false when it isn't a safe status code... I'm willing to bet that's it
03:17:39	adriant	mordred: we're using it wrong: https://github.com/requests/requests/blob/master/requests/models.py#L663-L671
03:31:01	openstackgerrit	Adrian Turjak proposed openstack/python-openstacksdk master: Add 409 ConflictException https://review.openstack.org/555142
03:37:34	openstackgerrit	Adrian Turjak proposed openstack/python-openstacksdk master: Fix response always being False https://review.openstack.org/555143
04:14:58	openstackgerrit	Adrian Turjak proposed openstack/python-openstacksdk master: Fix response always being False https://review.openstack.org/555143
08:23:35	openstackgerrit	Andreas Jaeger proposed openstack/keystoneauth master: Remove tox_install.sh and align with constraints consumption https://review.openstack.org/550837
09:42:51	openstackgerrit	Adrian Turjak proposed openstack/python-openstacksdk master: Add 409 ConflictException https://review.openstack.org/555142
10:03:47	openstackgerrit	chenyb4 proposed openstack/python-openstacksdk master: Fix api request in header miss microversions https://review.openstack.org/555231
10:07:03	openstackgerrit	OpenStack Proposal Bot proposed openstack/python-openstackclient master: Updated from global requirements https://review.openstack.org/553257
10:08:02	openstackgerrit	chenyb4 proposed openstack/python-openstacksdk master: Fix api request in header miss microversions https://review.openstack.org/555231
10:47:46	mordred	adriant: you do find all the best bugs!
10:55:11	openstackgerrit	Monty Taylor proposed openstack/keystoneauth master: Remove tox_install.sh and align with constraints consumption https://review.openstack.org/550837
10:59:44	openstackgerrit	Merged openstack-infra/shade master: Updated from global requirements https://review.openstack.org/552305
11:57:41	openstackgerrit	Merged openstack/python-openstacksdk master: Fix TypeError in case of FloatingIP add and remove https://review.openstack.org/552112
12:07:06	openstackgerrit	Monty Taylor proposed openstack/python-openstacksdk master: Fix response always being False https://review.openstack.org/555143
12:08:10	mordred	rods, slaweq: if you have a sec, https://review.openstack.org/#/c/555142 and https://review.openstack.org/#/c/555143 are both nice bugfixes
12:09:50	slaweq	mordred: both +W
12:10:20	mordred	does anyone know if chenyb4 / Yuanbin.Chen is on IRC?
12:11:37	adriant	mordred: that requests response is not none fix is gonna fail zuul after that rebase
12:12:04	adriant	since... the second is not none... doesn't catch the empty dict
12:12:04	mordred	adriant: oh yeah?
12:12:11	mordred	oh - fun
12:12:18	adriant	and somewhere someone is passing in a empty dict
12:12:47	adriant	so we may have to be silly and do if type(response) is Response:
12:12:56	mordred	adriant: like, somewhere something is passing an empty dict instead of an actual Response object?
12:13:05	adriant	mordred: looks like
12:13:21	adriant	that's what the test failure looked like
12:13:34	adriant	I'm just about to run it locally and check again
12:13:40	mordred	adriant: have I mentioned recently that I really miss strong typing?
12:14:14	adriant	yeah... normally I don't hit these issues, but every now and again you wish we had it
12:14:23	mordred	adriant: cool - I'd love to find/fix the calling location if we can - but yeah, I can see maybe needing to do isinstance(type, Response) ... but that just seems so sad
12:15:11	adriant	isinstance! of course, silly me I use that one but always forget it
12:15:19	mordred	:)
12:15:24	mordred	I have to remind myself of it all the time
12:15:38	adriant	is this and instance to use it? ;)
12:15:43	adriant	an*
12:18:14	adriant	mordred: self.request_id = response.headers.get('x-openstack-request-id')"
12:18:14	adriant	b"AttributeError: 'dict' object has no attribute 'headers'"
12:18:25	adriant	yeah, somewhere it's a dict
12:23:07	openstackgerrit	Merged openstack/os-client-config master: pypy is not checked at gate https://review.openstack.org/554955
12:23:16	openstackgerrit	Adrian Turjak proposed openstack/python-openstacksdk master: Fix response always being False https://review.openstack.org/555143
12:25:13	openstackgerrit	Adrian Turjak proposed openstack/python-openstacksdk master: Fix response always being False https://review.openstack.org/555143
12:28:46	adriant	mordred: a better fix was found so (to try that pun again), this isn't an instance where we type check. :P
12:33:01	mordred	adriant: \o/
13:07:23	openstackgerrit	Doug Hellmann proposed openstack-infra/requestsexceptions master: add lower-constraints job https://review.openstack.org/555298
13:07:30	openstackgerrit	Doug Hellmann proposed openstack-infra/shade master: add lower-constraints job https://review.openstack.org/555299
13:18:43	openstackgerrit	Merged openstack/python-openstacksdk master: Add 409 ConflictException https://review.openstack.org/555142
13:26:55	amotoki	dtroyer: regarding storyboard migration along with SDK in the dev list, do you have any specific concern? In general, I can take care of the migration if it happens.
13:27:02	dhellmann	mordred : what's up with requestsexceptions? I don't see any of the unit test jobs running against https://review.openstack.org/#/c/555298/
13:28:05	dtroyer	amotoki: the only thing I thought we should do would be a pass through the bugs and clean up obsolete ones, but IIRc all get migrated anyway so I'm not sure that is important

Earlier   Later