| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-sdks - 2018-03-21 | |||
| 19:35:46 | Shrews | yeah, who needs the nets | |
| 19:36:25 | Shrews | apparently doing anything beyond basic things with libvirt is dangerous | |
| 20:37:34 | openstackgerrit | Merged openstack/python-openstacksdk master: Provide OpenStackConfigException backwards compat https://review.openstack.org/554615 | |
| #openstack-sdks - 2018-03-22 | |||
| 01:07:27 | adriant | mordred: I don't know if we can make it nicer, but having to pass in the service itself when calling actions on the resources is a pain: | |
| 01:07:27 | adriant | test_project.assign_role_to_user(conn.identity, test_user, member_role) | |
| 01:08:15 | adriant | not to mention, having those kind of calls directly on the proxy might be nicer, since I don't always want to have to query for the project first if I know what the ids are of all the resources I want to act on are. | |
| 01:08:26 | adriant | *also on the proxy | |
| 02:42:46 | adriant | mordred: an error this time. Trying to see what response the sdk gives me when trying to create a keystone user that already exists: HttpException: HttpException: Unknown error | |
| 02:44:58 | adriant | mordred: looks like an easy one. We aren't catching 409s in the raise from exception function | |
| 02:45:08 | adriant | I'll throw up a patch for that | |
| 03:06:39 | adriant | mordred: https://github.com/openstack/python-openstacksdk/blob/master/openstack/exceptions.py#L63 is evaluating as false... expect I KNOW there is a response with status 409... | |
| 03:06:45 | adriant | except* | |
| 03:07:44 | adriant | if I print response.text in that very place I get: "{"error": {"message": "Conflict occurred attempting to store user - Duplicate Entry", "code": 409, "title": "Conflict"}}" | |
| 03:08:02 | adriant | so I have no clue what magic is making a response of type 409 eval to false... | |
| 03:16:20 | adriant | wait... wtf response always evals to false | |
| 03:16:27 | adriant | OH | |
| 03:16:48 | adriant | it is false when it isn't a safe status code... I'm willing to bet that's it | |
| 03:17:39 | adriant | mordred: we're using it wrong: https://github.com/requests/requests/blob/master/requests/models.py#L663-L671 | |
| 03:31:01 | openstackgerrit | Adrian Turjak proposed openstack/python-openstacksdk master: Add 409 ConflictException https://review.openstack.org/555142 | |
| 03:37:34 | openstackgerrit | Adrian Turjak proposed openstack/python-openstacksdk master: Fix response always being False https://review.openstack.org/555143 | |
| 04:14:58 | openstackgerrit | Adrian Turjak proposed openstack/python-openstacksdk master: Fix response always being False https://review.openstack.org/555143 | |
| 08:23:35 | openstackgerrit | Andreas Jaeger proposed openstack/keystoneauth master: Remove tox_install.sh and align with constraints consumption https://review.openstack.org/550837 | |
| 09:42:51 | openstackgerrit | Adrian Turjak proposed openstack/python-openstacksdk master: Add 409 ConflictException https://review.openstack.org/555142 | |
| 10:03:47 | openstackgerrit | chenyb4 proposed openstack/python-openstacksdk master: Fix api request in header miss microversions https://review.openstack.org/555231 | |
| 10:07:03 | openstackgerrit | OpenStack Proposal Bot proposed openstack/python-openstackclient master: Updated from global requirements https://review.openstack.org/553257 | |
| 10:08:02 | openstackgerrit | chenyb4 proposed openstack/python-openstacksdk master: Fix api request in header miss microversions https://review.openstack.org/555231 | |
| 10:47:46 | mordred | adriant: you do find all the best bugs! | |
| 10:55:11 | openstackgerrit | Monty Taylor proposed openstack/keystoneauth master: Remove tox_install.sh and align with constraints consumption https://review.openstack.org/550837 | |
| 10:59:44 | openstackgerrit | Merged openstack-infra/shade master: Updated from global requirements https://review.openstack.org/552305 | |
| 11:57:41 | openstackgerrit | Merged openstack/python-openstacksdk master: Fix TypeError in case of FloatingIP add and remove https://review.openstack.org/552112 | |
| 12:07:06 | openstackgerrit | Monty Taylor proposed openstack/python-openstacksdk master: Fix response always being False https://review.openstack.org/555143 | |
| 12:08:10 | mordred | rods, slaweq: if you have a sec, https://review.openstack.org/#/c/555142 and https://review.openstack.org/#/c/555143 are both nice bugfixes | |
| 12:09:50 | slaweq | mordred: both +W | |
| 12:10:20 | mordred | does anyone know if chenyb4 / Yuanbin.Chen is on IRC? | |
| 12:11:37 | adriant | mordred: that requests response is not none fix is gonna fail zuul after that rebase | |
| 12:12:04 | adriant | since... the second is not none... doesn't catch the empty dict | |
| 12:12:04 | mordred | adriant: oh yeah? | |
| 12:12:11 | mordred | oh - fun | |
| 12:12:18 | adriant | and somewhere someone is passing in a empty dict | |
| 12:12:47 | adriant | so we may have to be silly and do if type(response) is Response: | |
| 12:12:56 | mordred | adriant: like, somewhere something is passing an empty dict instead of an actual Response object? | |
| 12:13:05 | adriant | mordred: looks like | |
| 12:13:21 | adriant | that's what the test failure looked like | |
| 12:13:34 | adriant | I'm just about to run it locally and check again | |
| 12:13:40 | mordred | adriant: have I mentioned recently that I really miss strong typing? | |
| 12:14:14 | adriant | yeah... normally I don't hit these issues, but every now and again you wish we had it | |
| 12:14:23 | mordred | adriant: cool - I'd love to find/fix the calling location if we can - but yeah, I can see maybe needing to do isinstance(type, Response) ... but that just seems so sad | |
| 12:15:11 | adriant | isinstance! of course, silly me I use that one but always forget it | |
| 12:15:19 | mordred | :) | |
| 12:15:24 | mordred | I have to remind myself of it all the time | |
| 12:15:38 | adriant | is this and instance to use it? ;) | |
| 12:15:43 | adriant | an* | |
| 12:18:14 | adriant | mordred: self.request_id = response.headers.get('x-openstack-request-id')" | |
| 12:18:14 | adriant | b"AttributeError: 'dict' object has no attribute 'headers'" | |
| 12:18:25 | adriant | yeah, somewhere it's a dict | |
| 12:23:07 | openstackgerrit | Merged openstack/os-client-config master: pypy is not checked at gate https://review.openstack.org/554955 | |
| 12:23:16 | openstackgerrit | Adrian Turjak proposed openstack/python-openstacksdk master: Fix response always being False https://review.openstack.org/555143 | |
| 12:25:13 | openstackgerrit | Adrian Turjak proposed openstack/python-openstacksdk master: Fix response always being False https://review.openstack.org/555143 | |
| 12:28:46 | adriant | mordred: a better fix was found so (to try that pun again), this isn't an instance where we type check. :P | |
| 12:33:01 | mordred | adriant: \o/ | |
| 13:07:23 | openstackgerrit | Doug Hellmann proposed openstack-infra/requestsexceptions master: add lower-constraints job https://review.openstack.org/555298 | |
| 13:07:30 | openstackgerrit | Doug Hellmann proposed openstack-infra/shade master: add lower-constraints job https://review.openstack.org/555299 | |
| 13:18:43 | openstackgerrit | Merged openstack/python-openstacksdk master: Add 409 ConflictException https://review.openstack.org/555142 | |
| 13:26:55 | amotoki | dtroyer: regarding storyboard migration along with SDK in the dev list, do you have any specific concern? In general, I can take care of the migration if it happens. | |
| 13:27:02 | dhellmann | mordred : what's up with requestsexceptions? I don't see any of the unit test jobs running against https://review.openstack.org/#/c/555298/ | |
| 13:28:05 | dtroyer | amotoki: the only thing I thought we should do would be a pass through the bugs and clean up obsolete ones, but IIRc all get migrated anyway so I'm not sure that is important | |
| 13:28:37 | dtroyer | amotoki: if you want to handle the migration, that would be awesome, thanks! | |
| 13:32:20 | amotoki | dtroyer: honestly I don't know what kind of tools we actually have. On obsolete bugs, I think we can look thru them even after the migration. | |
| 13:33:24 | amotoki | dtroyer: tags in storyboard looks like global (from my limited experience), but it needs to be clarified. | |
| 13:34:13 | amotoki | I only have experiences on storyboard around octavia migration. | |
| 13:34:47 | dtroyer | amotoki: sure, that is more than I have with Storyboard :) | |
| 13:40:27 | amotoki | dtroyer: from my impressions so far, it seems we have no big concern on osc migration to storyboard. | |
| 13:40:30 | amotoki | dtroyer: I can care things during migrations and discuss broader topics with mordred and/or infra team. | |
| 13:40:46 | amotoki | dtroyer: i will send a follow-up mail to the list | |
| 13:42:25 | dtroyer | amotoki: sounds good, thanks | |
| 13:42:39 | mnaser | i think the openstackclient gate is broken? | |
| 13:42:52 | mnaser | osc-functional-devstack seems to always fail | |
| 13:43:47 | amotoki | mordred: in my understanding so far, we have a tool to support migration from launchpad to storyboard, right? | |
| 13:44:25 | mnaser | it looks like creating a network segment now does not have a description of 'None' but an empty string | |
| 13:45:25 | amotoki | mordred: based on chats with dtroyer here, there is no big blocking issue to block OSC storyboard migration. the remaining thing is how we can automate it. | |
| 13:45:41 | dtroyer | mnaser: frickler chased that down yesterday to a neutron commit that is being reverted | |
| 13:47:19 | frickler | dtroyer: mnaser: yes and the revert is failing due to some stackviz issue, see current discussion in -qa | |
| 13:47:30 | dtroyer | mnaser: revert: https://review.openstack.org/#/c/555016/ | |
| 13:49:02 | mnaser | okay, awesome, thanks frickler and dtroyer :) | |
| 13:49:59 | amotoki | slaweq and me need to understand how we can prevent this kind of breakage outside of neutron. I haven't figured out the whole picture | |
| 13:50:29 | amotoki | slaweq: sorry for pinging you :( | |
| 13:50:42 | slaweq | amotoki: no problem :) | |
| 13:50:52 | amotoki | hehe | |
| 13:52:01 | mnaser | amotoki: have neutron run that devstack osc job in gate? | |
| 13:52:11 | mnaser | assuming that job is fairly stable | |
| 13:54:47 | amotoki | mnaser: no, it is not part of neutron gate jobs. | |
| 13:55:13 | amotoki | mnaser: I am checking the relationship of osc-functional-devstack and neutron repo | |
| 13:55:54 | amotoki | basically they are not related directly | |
| 13:56:45 | mnaser | this type of thing can help catch things .. aka "hi im neutron and is my change breaking osc" seems like a reasonable thing | |
| 13:57:57 | dtroyer | for a Neutron change like that to break OSC means it is an API breakage, Using osc's functional tests as API tests is one way to catch that, it could also be done with stronger API testing in Neutron | |
| 13:58:50 | dtroyer | osc's functional tests do not exercise the APIs as thoroughly as I would hope dedicated API tests would do. | |
| 14:06:25 | amotoki | as my neutron hat, I believe neutron and tempest teams expect this should be caught in tempest/neutron-tempest-plugin should catch it. | |
| 14:06:41 | amotoki | i will investigate more tomorrow | |
| 14:14:03 | SamYaple | mordred: would a "think about using openstacksdk" warning be a good thing for shade? | |
| 14:14:37 | SamYaple | ran into someone who thought the shade/openstacksdk merger was going into shade instead of openstacksdk being the place for future dev | |