| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-sdks - 2018-03-19 | |||
| 21:13:30 | cdent | elmiko: you should probalby tell Gilles that, otherwise it might seem he's standing sort of solo, which is not the case | |
| 21:23:28 | elmiko | cdent: ack, i will reply. any suggestions for replying from a digest copy of the email? | |
| 21:24:39 | elmiko | ah, nvm. i'll reply the individual email | |
| 21:24:47 | cdent | you have both? | |
| 21:26:45 | elmiko | yeah, i think my email filter separated them out somehow | |
| 21:26:56 | elmiko | (i just switched to our new hosted email, it's driving me nuts) | |
| 21:28:08 | elmiko | well, we'll see if you actually get it lol. bbl, dinner | |
| #openstack-sdks - 2018-03-20 | |||
| 00:21:58 | EmilienM | hi, any chance to have a review on https://review.openstack.org/#/c/553374/ please | |
| 02:50:08 | openstackgerrit | chenyb4 proposed openstack/python-openstacksdk master: Fix 'block_store' aliases define error https://review.openstack.org/554403 | |
| 07:09:02 | openstackgerrit | chenyb4 proposed openstack/python-openstacksdk master: Fix 'block_store' aliases define error https://review.openstack.org/554403 | |
| 07:25:15 | openstackgerrit | Peter Balogh proposed openstack/python-openstacksdk master: Fix TypeError in case of FloatingIP add and remove https://review.openstack.org/552112 | |
| 07:26:56 | openstackgerrit | chenyb4 proposed openstack/python-openstacksdk master: Fix 'block_store' aliases define error https://review.openstack.org/554403 | |
| 10:28:06 | openstackgerrit | chenyb4 proposed openstack/python-openstacksdk master: Use defined version instead of service.version parameter https://review.openstack.org/554223 | |
| 12:36:21 | mugsie | elmiko: if you have any questions, please give me a ping :) | |
| 12:38:52 | elmiko | mugsie: ack, will do! | |
| 12:45:18 | cdent | elmiko, edleafe, anything blocking merging those microversion-parse changes? You guys +1d, but you should have the power to +2 if you want. I'd like to release a new version, even if its not yet perfect (as long as it doesn't break stuf, that's good enough) | |
| 12:49:28 | elmiko | cdent: nothing blocking from me | |
| 12:49:52 | elmiko | gimme like an hour and i can start adding the +2s | |
| 12:50:01 | elmiko | unless edleafe gets to it first ;) | |
| 12:50:16 | cdent | cool, thanks, no huge rush, just got reminded of it by my to do list | |
| 12:59:17 | elmiko | ack | |
| 13:08:45 | edleafe | cdent: elmiko: I had one little comment, but added a +2. elmiko, if you agree, wanna push it through? | |
| 13:09:50 | elmiko | edleafe: sounds good! | |
| 13:53:25 | elmiko | cdent: i +w to the 2 that had other support | |
| 13:53:38 | elmiko | i'd prefer more than just my lone review on these: | |
| 13:53:40 | elmiko | https://review.openstack.org/#/c/550251/3 | |
| 13:53:51 | elmiko | https://review.openstack.org/#/c/550263/3 | |
| 13:54:01 | elmiko | https://review.openstack.org/#/c/550264/3 | |
| 13:54:27 | openstackgerrit | Chris Dent proposed openstack/microversion-parse master: Do not use redundant attr check for keys in fold_headers https://review.openstack.org/554547 | |
| 13:55:11 | cdent | elmiko: yeah. edleafe I added another patch to the end fixing the bug. | |
| 13:55:29 | elmiko | cool | |
| 13:55:36 | elmiko | is that the one you just posted? | |
| 13:55:39 | cdent | yeah | |
| 13:55:44 | elmiko | looked sensible | |
| 13:59:29 | edleafe | cdent: cool. I would have just fixed it in place, but... meh | |
| 13:59:43 | openstackgerrit | Merged openstack/microversion-parse master: Provide a helper method to get headers from environ https://review.openstack.org/495356 | |
| 13:59:49 | cdent | edleafe: for a change that didn't check that method at all? dirty! | |
| 14:00:31 | openstackgerrit | Merged openstack/microversion-parse master: Import functions from placement https://review.openstack.org/496212 | |
| 14:01:17 | edleafe | Guess I'm a dirty guy | |
| 14:02:18 | cdent | Newflash: edleafe states well known fact, wins t-shirt | |
| 14:02:46 | edleafe | \o/ | |
| 14:02:56 | edleafe | My wardrobe needs sprucing up | |
| 14:04:12 | openstackgerrit | Jens Harbott (frickler) proposed openstack/keystoneauth master: Be more verbose when version discovery fails https://review.openstack.org/554044 | |
| 14:05:29 | frickler | kmalloc: ^^ just for you ;) | |
| 14:10:25 | elmiko | cdent: LOL | |
| 14:20:45 | cdent | edleafe: use your dirty old guy wisdom to fix that attribute problem on Version, I responded | |
| 14:28:20 | elmiko | that sounds like the best super power ever | |
| 14:36:58 | openstackgerrit | Merged openstack/os-client-config master: Add image_format for VEXXHOST profile https://review.openstack.org/554351 | |
| 14:47:23 | mnaser | mordred: did you ever get around this? https://specs.openstack.org/openstack/openstack-specs/specs/clouds-yaml-support.html | |
| 14:47:50 | mnaser | i have a user who likes using python-openstackclient because clouds.yaml, but image member list is missing from it right now, so they have to use glanceclient | |
| 14:48:49 | mordred | mnaser: we should just fix python-openstackclient - I've given up on that spec in favor of thinking we should delete python-*client | |
| 14:49:21 | mnaser | mordred: ok cool, i'll try to push a patch to add that support i guess | |
| 14:49:30 | mnaser | mordred: accepting and rejecting memberships is there, just listing is missing | |
| 14:49:53 | edleafe | cdent: who said I'm old?? | |
| 14:49:59 | mordred | edleafe: who didn't? | |
| 14:50:30 | edleafe | cdent: answered | |
| 14:56:31 | kmalloc | frickler: fantastic! | |
| 14:56:36 | kmalloc | frickler: thanks for the test! | |
| 14:57:06 | kmalloc | mordred: can we please delete python-*-client? | |
| 14:57:10 | kmalloc | mordred: please? :) | |
| 14:57:22 | mordred | kmalloc: ++ | |
| 15:02:04 | dtantsur | elmiko: office hours is not a bad idea, but I also think that we should encourage people to talk async and on public ML | |
| 15:02:28 | dtantsur | e.g. I won't be able to attend apac-friendly times, I suspect | |
| 15:02:36 | dtantsur | or rather: either me or the US | |
| 15:03:39 | edleafe | dtantsur: early APAC is late for me | |
| 15:04:37 | openstackgerrit | Chris Dent proposed openstack/microversion-parse master: Improve Version.matches() method https://review.openstack.org/550251 | |
| 15:04:38 | openstackgerrit | Chris Dent proposed openstack/microversion-parse master: Add MicroversionMiddleware https://review.openstack.org/550252 | |
| 15:04:38 | openstackgerrit | Chris Dent proposed openstack/microversion-parse master: Allow passing a json_error_formatter to the middleware https://review.openstack.org/550263 | |
| 15:04:39 | openstackgerrit | Chris Dent proposed openstack/microversion-parse master: Clean up package version and python version support https://review.openstack.org/550264 | |
| 15:04:39 | openstackgerrit | Chris Dent proposed openstack/microversion-parse master: Do not use redundant attr check for keys in fold_headers https://review.openstack.org/554547 | |
| 15:04:50 | cdent | there ya go edleafe, I think. and thanks. | |
| 15:07:39 | mnaser | i'm working on adding support for glance image list | |
| 15:07:53 | mnaser | i'm getting this when trying to run commands in tox venv (tox -evenv -- openstack image list) | |
| 15:07:54 | mnaser | 'module' object has no attribute 'OpenStackConfigException' | |
| 15:07:55 | mnaser | any ideas? | |
| 15:08:21 | mnaser | http://paste.openstack.org/show/706188/ | |
| 15:08:44 | mnaser | unless im doing something wrong, i dont think anything should be causing an excpetion like that | |
| 15:10:20 | mnaser | ok looks like it tries to get occ_exceptions from openstack.config and fallback to os_client_config if it cant find it | |
| 15:10:28 | mnaser | os_client_config has OpenStackConfigException but i have no idea what 'openstack.config' comes from | |
| 15:11:27 | mnaser | dtroyer: | |
| 15:11:31 | mnaser | https://github.com/openstack/osc-lib/commit/86129e6f88289ef14bfaa3f7c9cdfbea8d9fc944 looks like this might be related? | |
| 15:12:37 | mnaser | or actually, mordred: https://github.com/openstack/python-openstacksdk/commit/80716c144203a37edc7ddd324e0bc6be6cfda1e5 the renaming of OpenStackConfigException => ConfigException here broke things | |
| 15:12:59 | dtroyer | mnaser: what SDk version do you have? | |
| 15:13:33 | mnaser | dtroyer: working on master using tox, so i assume whatever the latest thing it'll pull | |
| 15:14:07 | mnaser | dtroyer: requirements.txt looks like it points to openstacksdk>=0.11.2 -- let me see what wasa pulled i | |
| 15:14:43 | dtroyer | I think there is a 0.12.0 now | |
| 15:15:15 | dtroyer | this spanning multiple versions during the changeover is getting long and painful | |
| 15:20:07 | mnaser | dtroyer: sorry, got a call, openstacksdk==0.12.0 indeed | |
| 15:20:41 | mnaser | i think the best 'compatible' way to take care of this would be to subclass ConfigException in openstacksdk as a 'compatibility' shim in the meantime | |
| 15:21:05 | mnaser | i can push up a patch if that's the best way of taking care of it for now | |
| 15:23:31 | cdent | edleafe: since you're my python wisdom source today, how do you feel about iterating over a set and popping members out of it? | |
| 15:23:43 | dtroyer | mnaser: in theory this should have been caught by the -tips jobs, did it get missed because OSc functional tests don't touch that command? | |
| 15:24:14 | elmiko | dtantsur: ack, and yeah, it will be a team effort to provide what the community might want. in general i agree with the notion of promoting async comms | |
| 15:24:14 | mnaser | dtroyer: well, im just writing this command now (list image members) | |
| 15:24:36 | mnaser | but i think this is probably broken with any command over all | |
| 15:26:42 | dtroyer | ok, I'm finally catching up on the exact problem | |
| 15:27:42 | EmilienM | hello, can someone review https://review.openstack.org/#/c/553374/ please? | |
| 15:27:44 | dtroyer | that's a gap in the functional tests, ie no negative tests there | |
| 15:28:06 | EmilienM | I'm ok to send free mapple sirup | |
| 15:29:16 | dtroyer | mnaser: I'd probably lean toward restoring the compatibility in the SDK for that exception, we're going to have to go through a lot of code to change all those over someday anyway but really can't do that yet | |