| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-sdks - 2018-03-20 | |||
| 13:55:39 | cdent | yeah | |
| 13:55:44 | elmiko | looked sensible | |
| 13:59:29 | edleafe | cdent: cool. I would have just fixed it in place, but... meh | |
| 13:59:43 | openstackgerrit | Merged openstack/microversion-parse master: Provide a helper method to get headers from environ https://review.openstack.org/495356 | |
| 13:59:49 | cdent | edleafe: for a change that didn't check that method at all? dirty! | |
| 14:00:31 | openstackgerrit | Merged openstack/microversion-parse master: Import functions from placement https://review.openstack.org/496212 | |
| 14:01:17 | edleafe | Guess I'm a dirty guy | |
| 14:02:18 | cdent | Newflash: edleafe states well known fact, wins t-shirt | |
| 14:02:46 | edleafe | \o/ | |
| 14:02:56 | edleafe | My wardrobe needs sprucing up | |
| 14:04:12 | openstackgerrit | Jens Harbott (frickler) proposed openstack/keystoneauth master: Be more verbose when version discovery fails https://review.openstack.org/554044 | |
| 14:05:29 | frickler | kmalloc: ^^ just for you ;) | |
| 14:10:25 | elmiko | cdent: LOL | |
| 14:20:45 | cdent | edleafe: use your dirty old guy wisdom to fix that attribute problem on Version, I responded | |
| 14:28:20 | elmiko | that sounds like the best super power ever | |
| 14:36:58 | openstackgerrit | Merged openstack/os-client-config master: Add image_format for VEXXHOST profile https://review.openstack.org/554351 | |
| 14:47:23 | mnaser | mordred: did you ever get around this? https://specs.openstack.org/openstack/openstack-specs/specs/clouds-yaml-support.html | |
| 14:47:50 | mnaser | i have a user who likes using python-openstackclient because clouds.yaml, but image member list is missing from it right now, so they have to use glanceclient | |
| 14:48:49 | mordred | mnaser: we should just fix python-openstackclient - I've given up on that spec in favor of thinking we should delete python-*client | |
| 14:49:21 | mnaser | mordred: ok cool, i'll try to push a patch to add that support i guess | |
| 14:49:30 | mnaser | mordred: accepting and rejecting memberships is there, just listing is missing | |
| 14:49:53 | edleafe | cdent: who said I'm old?? | |
| 14:49:59 | mordred | edleafe: who didn't? | |
| 14:50:30 | edleafe | cdent: answered | |
| 14:56:31 | kmalloc | frickler: fantastic! | |
| 14:56:36 | kmalloc | frickler: thanks for the test! | |
| 14:57:06 | kmalloc | mordred: can we please delete python-*-client? | |
| 14:57:10 | kmalloc | mordred: please? :) | |
| 14:57:22 | mordred | kmalloc: ++ | |
| 15:02:04 | dtantsur | elmiko: office hours is not a bad idea, but I also think that we should encourage people to talk async and on public ML | |
| 15:02:28 | dtantsur | e.g. I won't be able to attend apac-friendly times, I suspect | |
| 15:02:36 | dtantsur | or rather: either me or the US | |
| 15:03:39 | edleafe | dtantsur: early APAC is late for me | |
| 15:04:37 | openstackgerrit | Chris Dent proposed openstack/microversion-parse master: Improve Version.matches() method https://review.openstack.org/550251 | |
| 15:04:38 | openstackgerrit | Chris Dent proposed openstack/microversion-parse master: Add MicroversionMiddleware https://review.openstack.org/550252 | |
| 15:04:38 | openstackgerrit | Chris Dent proposed openstack/microversion-parse master: Allow passing a json_error_formatter to the middleware https://review.openstack.org/550263 | |
| 15:04:39 | openstackgerrit | Chris Dent proposed openstack/microversion-parse master: Clean up package version and python version support https://review.openstack.org/550264 | |
| 15:04:39 | openstackgerrit | Chris Dent proposed openstack/microversion-parse master: Do not use redundant attr check for keys in fold_headers https://review.openstack.org/554547 | |
| 15:04:50 | cdent | there ya go edleafe, I think. and thanks. | |
| 15:07:39 | mnaser | i'm working on adding support for glance image list | |
| 15:07:53 | mnaser | i'm getting this when trying to run commands in tox venv (tox -evenv -- openstack image list) | |
| 15:07:54 | mnaser | 'module' object has no attribute 'OpenStackConfigException' | |
| 15:07:55 | mnaser | any ideas? | |
| 15:08:21 | mnaser | http://paste.openstack.org/show/706188/ | |
| 15:08:44 | mnaser | unless im doing something wrong, i dont think anything should be causing an excpetion like that | |
| 15:10:20 | mnaser | ok looks like it tries to get occ_exceptions from openstack.config and fallback to os_client_config if it cant find it | |
| 15:10:28 | mnaser | os_client_config has OpenStackConfigException but i have no idea what 'openstack.config' comes from | |
| 15:11:27 | mnaser | dtroyer: | |
| 15:11:31 | mnaser | https://github.com/openstack/osc-lib/commit/86129e6f88289ef14bfaa3f7c9cdfbea8d9fc944 looks like this might be related? | |
| 15:12:37 | mnaser | or actually, mordred: https://github.com/openstack/python-openstacksdk/commit/80716c144203a37edc7ddd324e0bc6be6cfda1e5 the renaming of OpenStackConfigException => ConfigException here broke things | |
| 15:12:59 | dtroyer | mnaser: what SDk version do you have? | |
| 15:13:33 | mnaser | dtroyer: working on master using tox, so i assume whatever the latest thing it'll pull | |
| 15:14:07 | mnaser | dtroyer: requirements.txt looks like it points to openstacksdk>=0.11.2 -- let me see what wasa pulled i | |
| 15:14:43 | dtroyer | I think there is a 0.12.0 now | |
| 15:15:15 | dtroyer | this spanning multiple versions during the changeover is getting long and painful | |
| 15:20:07 | mnaser | dtroyer: sorry, got a call, openstacksdk==0.12.0 indeed | |
| 15:20:41 | mnaser | i think the best 'compatible' way to take care of this would be to subclass ConfigException in openstacksdk as a 'compatibility' shim in the meantime | |
| 15:21:05 | mnaser | i can push up a patch if that's the best way of taking care of it for now | |
| 15:23:31 | cdent | edleafe: since you're my python wisdom source today, how do you feel about iterating over a set and popping members out of it? | |
| 15:23:43 | dtroyer | mnaser: in theory this should have been caught by the -tips jobs, did it get missed because OSc functional tests don't touch that command? | |
| 15:24:14 | elmiko | dtantsur: ack, and yeah, it will be a team effort to provide what the community might want. in general i agree with the notion of promoting async comms | |
| 15:24:14 | mnaser | dtroyer: well, im just writing this command now (list image members) | |
| 15:24:36 | mnaser | but i think this is probably broken with any command over all | |
| 15:26:42 | dtroyer | ok, I'm finally catching up on the exact problem | |
| 15:27:42 | EmilienM | hello, can someone review https://review.openstack.org/#/c/553374/ please? | |
| 15:27:44 | dtroyer | that's a gap in the functional tests, ie no negative tests there | |
| 15:28:06 | EmilienM | I'm ok to send free mapple sirup | |
| 15:29:16 | dtroyer | mnaser: I'd probably lean toward restoring the compatibility in the SDK for that exception, we're going to have to go through a lot of code to change all those over someday anyway but really can't do that yet | |
| 15:30:07 | dtroyer | and yes, that potentially affects any command that needs auth | |
| 15:32:35 | openstackgerrit | Mohammed Naser proposed openstack/python-openstackclient master: Add support to list image members https://review.openstack.org/554590 | |
| 15:32:56 | mnaser | ^ my first osc change so it probably is mising a whole lot of stuff (and couldn't find a sample to iterate on) | |
| 15:33:26 | mnaser | dtroyer: so what would be the best direction (aka, can i help with that?) | |
| 15:35:01 | dtroyer | mnaser: my gut says to put in a compat exception back into the SDK since that is what changed. It appears, though, that osc-lib _may_ be the only casualty, but it'll be messier to fix there until we rip out the os-client-config imports | |
| 15:35:26 | dtroyer | which is not going to happen until we get an SDK 1.0 release | |
| 15:35:33 | mnaser | dtroyer: and the concern is how do you make sure that gets removed eventually and doesn't sit ther forever, but i cant imagine that being very harmful | |
| 15:36:11 | mnaser | unless, well, people start relying on it. | |
| 15:36:30 | mordred | mnaser: sorry - on phone, will help in just a few | |
| 15:36:33 | mnaser | which they probably will if thats what is bubbling up the excpetion in osc_lib | |
| 15:36:36 | mnaser | np :) | |
| 15:36:46 | dtroyer | I would expect it to get caught when cleaning up the o-c-c stuff | |
| 15:37:13 | mordred | in the shade layer we made the old exception classes aliases for the new ones - we should defintely do that here | |
| 15:37:37 | dtroyer | I'm planning to rip out much of that module for OSC 4 anyway so we'll default to doing basically the same thing that all other SDK consumers do WRT auth and special cases | |
| 15:38:34 | mordred | mnaser: if we just put a OpenStackConfigException = ConfigException in openstack/config/exceptions.py it should be happier | |
| 15:38:50 | edleafe | cdent: it *can* be ok to do that; depends on what you're doing with the members of the set | |
| 15:39:23 | edleafe | cdent: generally I use a 'to_remove' var to hold the ones to remove, and then remove 'em after the iteration | |
| 15:39:37 | mnaser | mordred: ok cool, i'd nominate myself to push up a patch for that but i think it would be useful to have the context of that in a note/commit message which i'm probably not the best at writing given i dont know the whole relationship between all these clients :) | |
| 15:39:42 | cdent | edleafe: I'll put it up for people to think about. I'm pretty sure it works for the case I've got, but we'll see | |
| 15:40:46 | cdent | edleafe: it's basically this: http://paste.openstack.org/show/706227/ | |
| 15:42:58 | cdent | (untested) | |
| 15:44:21 | edleafe | cdent: did you run that? | |
| 15:44:27 | cdent | untested | |
| 15:44:35 | cdent | I'm getting ready to test it | |
| 15:44:59 | cdent | but I hadn't gotten that far because I realized it may very well be to dirty, so I thought I'd ask the dirty guy before I kept moving | |
| 15:45:43 | dtroyer | mnaser: regarding the new command, stevemar points out a prior attempt and the objection then that "image member" is not currently a resource in OSC. I don't like that name, the only place OSC uses "member" at all is in the image set command options —accept, —reject and —pending, there phrased as "project membership status". So we treat this as an image property already, not as a top-level resource | |
| 15:46:02 | edleafe | cdent: Generally you can't change the size of a set during an iteration over it | |
| 15:46:57 | dtroyer | Adding a —member (or —membership or —project) option to image show seems more natural, except that the nested structure of a list of data inside a field is always messy | |
| 15:47:19 | cdent | edleafe: ooops, I misread the docs for set.pop() for one thing | |
| 15:48:13 | edleafe | cdent: Since they're sets, I'd just grab the set of forbidden, and then do difference_update() to remove the forbidden traits | |
| 15:48:22 | cdent | yeah, I'll do that | |
| 15:48:41 | mnaser | dtroyer: i see.. so what is it that you'd recommend, i think ideally image member should be a resource and things like 'image member add' and 'image member remove' should be how things are | |