Earlier  
Later
New Search
Posted Nick Remark
#openstack-sdks - 2017-06-03
01:06:18 openstackgerrit Merged openstack/python-openstackclient master: Updated from global requirements https://review.openstack.org/470552
05:43:54 openstackgerrit Vu Cong Tuan proposed openstack/python-openstacksdk master: Replace assertRaisesRegexp with assertRaisesRegex https://review.openstack.org/470592
06:14:49 openstackgerrit Vu Cong Tuan proposed openstack/python-openstacksdk master: Replace assertRaisesRegexp with assertRaisesRegex https://review.openstack.org/470592
12:58:08 openstackgerrit OpenStack Proposal Bot proposed openstack/python-openstackclient master: Updated from global requirements https://review.openstack.org/470626
23:24:25 openstackgerrit Merged openstack/keystoneauth master: Updated from global requirements https://review.openstack.org/470100
#openstack-sdks - 2017-06-04
04:56:57 openstackgerrit Vu Cong Tuan proposed openstack/keystoneauth master: Fix html_last_updated_fmt for Python3 https://review.openstack.org/470663
#openstack-sdks - 2017-06-05
02:34:22 openstackgerrit Tuan Luong-Anh proposed openstack/keystoneauth master: Replace assertTrue(isinstance()) with assertIsInstance() https://review.openstack.org/470812
03:34:45 openstackgerrit Takashi NATSUME proposed openstack/python-openstackclient master: List/show all server migration types https://review.openstack.org/450119
05:45:42 openstackgerrit ZhangHongtao proposed openstack/python-openstackclient master: Add optional parameter "user_id" and "type" to list credentials https://review.openstack.org/468256
06:34:52 amotoki Qiming: could you review a patch of network tag support https://review.openstack.org/#/c/461194/ ?
06:35:06 amotoki Qiming: This is the last piece of neutron-to-osc migration and this SDK review blocks the whole work.
06:35:29 Qiming on it now
06:35:59 amotoki Qiming: appreciated
06:36:08 Qiming np
06:42:38 Qiming amotoki, patch looks good to me, :)
06:42:55 Qiming thanks for working on this
06:43:37 amotoki Qiming: thanks. Honestly speaking the current API implements the tag operation as a sub resource. This makes SDK support a bit tricky
06:43:59 Qiming I like your mixin approach
06:44:06 amotoki Qiming: as further improvement, we can explore a way to implement 'tags' as a regular resource in SDK side
06:45:37 amotoki Qiming: I explored it a bit during implementing the tag support, but it seems it needs to change resource2.Resource, so I decided not to do it now.
06:47:10 Qiming em, sounds like a long way to go considering that project teams may choose to ignore or decrease the priority of api guideline conformance
06:48:05 Qiming in an ideal case, metadata, tags, common query strings ... etc all should be standardized across all project APIs
06:48:19 amotoki or update the API-WG guideline itself
06:50:56 Qiming it won't be much help unless project teams treat API-WG guidelines seriously
11:54:23 openstackgerrit Merged openstack/keystoneauth master: Replace assertTrue(isinstance()) with assertIsInstance() https://review.openstack.org/470812
12:07:09 openstackgerrit OpenStack Proposal Bot proposed openstack/python-openstackclient master: Updated from global requirements https://review.openstack.org/470626
12:28:51 Dinesh_Bhor briancurtin: Hi, you there? It will be great if you take a look at this: https://review.openstack.org/#/c/319054/ It's already having one +2.
12:48:20 edleafe Qiming: Existing APIs don't have to change to conform to the guidelines, but new APIs definitely should.
12:49:05 Qiming thanks for the hints, edleafe
12:50:11 Qiming but I do feel a lot resistence from people to bump APIs for better conformance
12:50:53 Qiming those reluctance are justified, but ... it means the APIs will never converge
13:11:22 edleafe Qiming: that's unfortunate, of course. But projects have to prioritize changes that they feel they need.
13:11:58 edleafe Qiming: I'd love to have all the APIs be consistent, but at least we can make sure that all *new* APIs are consistent.
13:14:35 Qiming I share the same love with you, :)
13:21:18 edleafe Qiming: :)
15:56:59 openstackgerrit chenyb4 proposed openstack/python-openstacksdk master: Add compute support server backup operation https://review.openstack.org/471038
16:33:02 openstackgerrit chenyb4 proposed openstack/python-openstacksdk master: Add compute support server backup operation https://review.openstack.org/471038
20:10:56 openstackgerrit Merged openstack/python-openstackclient master: Replace "Display Name" by "Name" in volume list https://review.openstack.org/423081
21:58:45 openstackgerrit OpenStack Proposal Bot proposed openstack/python-openstackclient master: Updated from global requirements https://review.openstack.org/470626
#openstack-sdks - 2017-06-06
00:58:46 openstackgerrit qtlu proposed openstack/osc-lib master: Replace six.iteritems() with .items() https://review.openstack.org/445273
01:12:42 openstackgerrit Merged openstack/python-openstackclient master: Updated from global requirements https://review.openstack.org/470626
01:38:05 openstackgerrit Akihiro Motoki proposed openstack/python-openstackclient master: volume functest: ensure snapshots deleted when volume delete https://review.openstack.org/466507
01:58:35 openstackgerrit Vu Cong Tuan proposed openstack/keystoneauth master: Fix html_last_updated_fmt for Python3 https://review.openstack.org/470663
02:06:37 openstackgerrit Akihiro Motoki proposed openstack/python-openstackclient master: Use cliff formattable columns in network commands https://review.openstack.org/462170
02:06:38 openstackgerrit Akihiro Motoki proposed openstack/python-openstackclient master: Use cliff formattable columns in image commands https://review.openstack.org/464638
04:10:28 openstackgerrit Daniel Speichert proposed openstack/python-openstacksdk master: Fix py3 compatibility (dict.iteritems()) in object_store https://review.openstack.org/471198
04:48:47 openstackgerrit Merged openstack/python-openstackclient master: volume functest: ensure snapshots deleted when volume delete https://review.openstack.org/466507
10:18:42 openstackgerrit Stephen Finucane proposed openstack/cliff master: sphinxext: Allow configuration of ignorable options https://review.openstack.org/469064
10:45:33 openstackgerrit Stephen Finucane proposed openstack/python-openstackclient master: Start using 'cliff.sphinxext' https://review.openstack.org/452861
10:45:34 openstackgerrit Stephen Finucane proposed openstack/python-openstackclient master: Convert 'server' commands to use autoprogram https://review.openstack.org/458452
12:12:45 openstackgerrit Merged openstack/python-openstacksdk master: Fix py3 compatibility (dict.iteritems()) in object_store https://review.openstack.org/471198
12:25:14 openstackgerrit OpenStack Proposal Bot proposed openstack/python-openstacksdk master: Updated from global requirements https://review.openstack.org/464477
13:11:07 openstackgerrit Rui Chen proposed openstack/python-openstackclient master: Clean up the changes of os.environ in functional tests https://review.openstack.org/471341
13:18:53 Dinesh_Bhor briancurtin: Hi, you there? It will be great if you take a look at this: https://review.openstack.org/#/c/319054/ It's already having one +2.
14:28:11 openstackgerrit Merged openstack/python-openstacksdk master: Updated from global requirements https://review.openstack.org/464477
16:15:23 openstackgerrit Reedip proposed openstack/python-openstackclient master: Add default-quota to subnet pool commands https://review.openstack.org/437367
16:53:31 stevemar sfinucan: merged your stuff
18:24:47 openstackgerrit Merged openstack/cliff master: sphinxext: Generate better usage examples https://review.openstack.org/469063
18:24:55 openstackgerrit Merged openstack/cliff master: sphinxext: Allow configuration of ignorable options https://review.openstack.org/469064
#openstack-sdks - 2017-06-07
03:39:29 openstackgerrit Vu Cong Tuan proposed openstack/python-openstacksdk master: Remove support for py34 https://review.openstack.org/471571
03:40:30 reedip stevemar : o/
04:03:53 openstackgerrit Reedip proposed openstack/python-openstackclient master: Add default-quota to subnet pool commands https://review.openstack.org/437367
05:11:56 stevemar hey reedip
09:08:25 openstackgerrit Merged openstack/keystoneauth master: Fix html_last_updated_fmt for Python3 https://review.openstack.org/470663
09:56:01 openstackgerrit Rui Chen proposed openstack/python-openstackclient master: Clean up the changes of os.environ in functional tests https://review.openstack.org/471341
11:31:28 openstackgerrit Akihiro Motoki proposed openstack/cliff master: sphinxext: Add 'application' option to the autoprogram directive https://review.openstack.org/469726
12:24:20 openstackgerrit Dinesh Bhor proposed openstack/python-openstacksdk master: Fix update_image unsupported media type https://review.openstack.org/319054
12:26:27 openstackgerrit Merged openstack/python-openstacksdk master: Remove support for py34 https://review.openstack.org/471571
12:35:26 Dinesh_Bhor briancurtin, Qiming: thanks for review. Addressed the review comments: https://review.openstack.org/#/c/319054/5
12:36:12 briancurtin Dinesh_Bhor: my question was more about why line 162 in _proxy.py is even needed. is it?
12:37:44 Dinesh_Bhor briancurtin: yes, otherwise how can I get the image to update
12:39:07 briancurtin Dinesh_Bhor: in all cases in all other update calls across all other services around the whole SDK, there is an assumption that if you’re calling update on something, you’re calling it with either a resource instance that you obtained in some other way or you have the ID of a resource you obtained in some other way
12:39:36 briancurtin you would have done `x = get_blah(…); update_blah(x, name=“foo”)`
12:40:08 briancurtin so update doing an extra get on that line is what I’m wondering about. i guess it could be necessary if there’s something i don’t understand about it, but that’s what i’d like to know
12:52:07 Dinesh_Bhor briancurtin: sorry but right now I am not able to visualize what you are trying to say. I will check this part.
12:53:20 briancurtin Dinesh_Bhor: for example, update_server just updates a server. it doesn’t do a get. same with anything in there named update_* — https://github.com/openstack/python-openstacksdk/blob/master/openstack/compute/v2/_proxy.py#L414
12:54:14 briancurtin Dinesh_Bhor: actually, i think i know what you’re trying to do now. 1 sec
12:55:54 briancurtin Dinesh_Bhor: you should do something like https://github.com/openstack/python-openstacksdk/blob/master/openstack/compute/v2/_proxy.py#L343 — so `img = self._get_resource(_image.Image, image); img.update_image(self._session, img, **attrs)
12:57:50 briancurtin the way you have it would be doing an extra HTTP GET call, when we can just use the internal method self._get_resource to construct a resource instance from a string ID if that’s what we have (or it just returns the resource instance if it was given an instance), which avoids the extra roundtrip
12:58:26 Dinesh_Bhor briancurtin: ohh, now I got your point.
13:00:41 briancurtin Dinesh_Bhor: you might want to change the update_image name in image/v2/image.py to just update(…). that way we don’t have the proxy update_image calling into image.update_image. it gets a bit wordy that way
13:01:31 Dinesh_Bhor briancurtin: yeah, I will change that
13:01:58 briancurtin Dinesh_Bhor: otherwise i think this is good. i’ll take a look again after your next changes
13:02:41 Dinesh_Bhor briancurtin: yes, thanks. I will update the patch soon
13:17:58 openstackgerrit Rui Chen proposed openstack/python-openstackclient master: Clean up the changes of os.environ in functional tests https://review.openstack.org/471341
13:46:52 openstackgerrit Dinesh Bhor proposed openstack/python-openstacksdk master: Fix update_image unsupported media type https://review.openstack.org/319054
14:04:29 Dinesh_Bhor briancurtin: ^^ Please take a look at it when you get time
14:11:35 briancurtin Dinesh_Bhor: that looks good! i assume the tests will pass but will wait for them to show up and then it’s a +2
16:12:31 openstackgerrit Akihiro Motoki proposed openstack/cliff master: sphinxext: Add 'application' option to the autoprogram directive https://review.openstack.org/469726
16:22:55 openstackgerrit Reedip proposed openstack/python-openstackclient master: Add default-quota to subnet pool commands https://review.openstack.org/437367
17:00:46 openstackgerrit Merged openstack/python-openstacksdk master: Fix update_image unsupported media type https://review.openstack.org/319054
20:15:30 dhellmann dtroyer, stevemar : do the cliff tests pass for you on master? I'm seeing a failure with the smart help formatter
20:18:06 dtroyer dhellmann: I'll check
20:18:57 dhellmann dtroyer : oh, it fails for me because I have a wide terminal
20:19:04 dhellmann and it's not forcing the width
20:19:07 dhellmann the test, that is
21:06:59 openstackgerrit Doug Hellmann proposed openstack/cliff master: make smart help formatter test deterministic https://review.openstack.org/471916
21:06:59 openstackgerrit Doug Hellmann proposed openstack/cliff master: add --fit-width option to table formatter https://review.openstack.org/471917
#openstack-sdks - 2017-06-08
01:17:03 openstackgerrit Lingyong Xu proposed openstack/cliff master: Optimize the link address https://review.openstack.org/471981
01:52:19 openstackgerrit Lingyong Xu proposed openstack/cliff master: Optimize the link address https://review.openstack.org/471981

Earlier   Later