Earlier  
Later
New Search
Posted Nick Remark
#openstack-sdks - 2017-06-07
12:35:26 Dinesh_Bhor briancurtin, Qiming: thanks for review. Addressed the review comments: https://review.openstack.org/#/c/319054/5
12:36:12 briancurtin Dinesh_Bhor: my question was more about why line 162 in _proxy.py is even needed. is it?
12:37:44 Dinesh_Bhor briancurtin: yes, otherwise how can I get the image to update
12:39:07 briancurtin Dinesh_Bhor: in all cases in all other update calls across all other services around the whole SDK, there is an assumption that if you’re calling update on something, you’re calling it with either a resource instance that you obtained in some other way or you have the ID of a resource you obtained in some other way
12:39:36 briancurtin you would have done `x = get_blah(…); update_blah(x, name=“foo”)`
12:40:08 briancurtin so update doing an extra get on that line is what I’m wondering about. i guess it could be necessary if there’s something i don’t understand about it, but that’s what i’d like to know
12:52:07 Dinesh_Bhor briancurtin: sorry but right now I am not able to visualize what you are trying to say. I will check this part.
12:53:20 briancurtin Dinesh_Bhor: for example, update_server just updates a server. it doesn’t do a get. same with anything in there named update_* — https://github.com/openstack/python-openstacksdk/blob/master/openstack/compute/v2/_proxy.py#L414
12:54:14 briancurtin Dinesh_Bhor: actually, i think i know what you’re trying to do now. 1 sec
12:55:54 briancurtin Dinesh_Bhor: you should do something like https://github.com/openstack/python-openstacksdk/blob/master/openstack/compute/v2/_proxy.py#L343 — so `img = self._get_resource(_image.Image, image); img.update_image(self._session, img, **attrs)
12:57:50 briancurtin the way you have it would be doing an extra HTTP GET call, when we can just use the internal method self._get_resource to construct a resource instance from a string ID if that’s what we have (or it just returns the resource instance if it was given an instance), which avoids the extra roundtrip
12:58:26 Dinesh_Bhor briancurtin: ohh, now I got your point.
13:00:41 briancurtin Dinesh_Bhor: you might want to change the update_image name in image/v2/image.py to just update(…). that way we don’t have the proxy update_image calling into image.update_image. it gets a bit wordy that way
13:01:31 Dinesh_Bhor briancurtin: yeah, I will change that
13:01:58 briancurtin Dinesh_Bhor: otherwise i think this is good. i’ll take a look again after your next changes
13:02:41 Dinesh_Bhor briancurtin: yes, thanks. I will update the patch soon
13:17:58 openstackgerrit Rui Chen proposed openstack/python-openstackclient master: Clean up the changes of os.environ in functional tests https://review.openstack.org/471341
13:46:52 openstackgerrit Dinesh Bhor proposed openstack/python-openstacksdk master: Fix update_image unsupported media type https://review.openstack.org/319054
14:04:29 Dinesh_Bhor briancurtin: ^^ Please take a look at it when you get time
14:11:35 briancurtin Dinesh_Bhor: that looks good! i assume the tests will pass but will wait for them to show up and then it’s a +2
16:12:31 openstackgerrit Akihiro Motoki proposed openstack/cliff master: sphinxext: Add 'application' option to the autoprogram directive https://review.openstack.org/469726
16:22:55 openstackgerrit Reedip proposed openstack/python-openstackclient master: Add default-quota to subnet pool commands https://review.openstack.org/437367
17:00:46 openstackgerrit Merged openstack/python-openstacksdk master: Fix update_image unsupported media type https://review.openstack.org/319054
20:15:30 dhellmann dtroyer, stevemar : do the cliff tests pass for you on master? I'm seeing a failure with the smart help formatter
20:18:06 dtroyer dhellmann: I'll check
20:18:57 dhellmann dtroyer : oh, it fails for me because I have a wide terminal
20:19:04 dhellmann and it's not forcing the width
20:19:07 dhellmann the test, that is
21:06:59 openstackgerrit Doug Hellmann proposed openstack/cliff master: make smart help formatter test deterministic https://review.openstack.org/471916
21:06:59 openstackgerrit Doug Hellmann proposed openstack/cliff master: add --fit-width option to table formatter https://review.openstack.org/471917
#openstack-sdks - 2017-06-08
01:17:03 openstackgerrit Lingyong Xu proposed openstack/cliff master: Optimize the link address https://review.openstack.org/471981
01:52:19 openstackgerrit Lingyong Xu proposed openstack/cliff master: Optimize the link address https://review.openstack.org/471981
03:53:46 openstackgerrit Rui Chen proposed openstack/python-openstackclient master: Clean up the changes of os.environ in functional tests https://review.openstack.org/471341
06:24:30 openstackgerrit Rui Chen proposed openstack/python-openstackclient master: Clean up the changes of os.environ in functional tests https://review.openstack.org/471341
07:29:28 openstackgerrit Lingyong Xu proposed openstack/cliff master: Optimize the link address https://review.openstack.org/471981
11:00:50 openstackgerrit Stephen Finucane proposed openstack/cliff master: sphinxext: Use 'argparse.description', 'argparse.epilog' https://review.openstack.org/472206
11:00:51 openstackgerrit Stephen Finucane proposed openstack/cliff master: sphinext: Use metavar where possible https://review.openstack.org/472207
11:45:23 openstackgerrit M V P Nitesh proposed openstack/python-openstackclient master: Now OSC can filter image list by owner name https://review.openstack.org/472223
13:11:06 cdent mordred: is https://review.openstack.org/#/c/455774/ dead in the face of the related things you've written in api-wg?
13:11:36 mordred cdent: yes. that was draft 0 of the api-wg change stack
13:11:49 cdent ✔
13:12:02 mordred abandoned for clarity
13:12:13 cdent rad
13:26:38 elmiko cdent, edleafe, strong possibility i'll be late for the meeting today. i've got a 30 minute overlap
13:26:50 cdent roger that
14:42:06 openstackgerrit Pavlo Shchelokovskyy proposed openstack/keystoneauth master: Add 'none' identity plugin https://review.openstack.org/469863
14:46:13 jkilpatr ok so I'm confused what actually provides the openstack baremetal * commands
14:46:23 jkilpatr I've had them work some places but not others
16:16:44 reedip_ dtroyer : if you are free, can you please let me know if anything is required in https://review.openstack.org/437367 ?
16:28:15 openstackgerrit OpenStack Proposal Bot proposed openstack/python-openstackclient master: Updated from global requirements https://review.openstack.org/472328
16:47:28 cdent elmiko, edleafe : proof please? https://etherpad.openstack.org/p/api-wg-newsletter
17:00:05 cdent too late, sent
19:19:22 openstackgerrit Monty Taylor proposed openstack/keystoneauth master: Expose getting EndpointData on adapter and session https://review.openstack.org/469091
19:19:23 openstackgerrit Monty Taylor proposed openstack/keystoneauth master: Add support for version ranges https://review.openstack.org/469090
19:19:24 openstackgerrit Monty Taylor proposed openstack/keystoneauth master: Support explicitly requesting the 'latest' version https://review.openstack.org/469089
19:19:25 openstackgerrit Monty Taylor proposed openstack/keystoneauth master: Add flags to turn discovery on and off https://review.openstack.org/469088
19:19:26 openstackgerrit Monty Taylor proposed openstack/keystoneauth master: Plumb endpoint_override through get_endpoint_data https://review.openstack.org/469092
19:19:27 openstackgerrit Monty Taylor proposed openstack/keystoneauth master: Rename discover_versions to fetch_version_info https://review.openstack.org/470275
19:19:28 openstackgerrit Monty Taylor proposed openstack/keystoneauth master: Add returning EndpointData objects from discovery https://review.openstack.org/469084
19:19:29 openstackgerrit Monty Taylor proposed openstack/keystoneauth master: Optimize matching version no microversion needed https://review.openstack.org/470274
19:19:30 openstackgerrit Monty Taylor proposed openstack/keystoneauth master: Rework EndpointData construction to normalize catalog first https://review.openstack.org/469085
19:19:31 openstackgerrit Monty Taylor proposed openstack/keystoneauth master: Move version discovery logic to keystoneauth1.discover https://review.openstack.org/469086
19:19:32 openstackgerrit Monty Taylor proposed openstack/keystoneauth master: Add url manipulation and microversion collection https://review.openstack.org/469087
19:35:40 openstackgerrit Merged openstack/python-openstackclient master: Updated from global requirements https://review.openstack.org/472328
23:02:14 openstackgerrit Morgan Fainberg proposed openstack/keystoneauth master: Fix removed "Self" https://review.openstack.org/472469
23:02:41 openstackgerrit Morgan Fainberg proposed openstack/keystoneauth master: Fix removed "Self" https://review.openstack.org/472469
23:29:22 openstackgerrit Jamie Lennox proposed openstack/keystoneauth master: Port the missing version data discovery tests from ksc https://review.openstack.org/458286
#openstack-sdks - 2017-06-09
02:23:08 openstackgerrit liusheng proposed openstack/python-openstackclient master: Make the --limit option work in "image list" command https://review.openstack.org/463648
08:53:16 openstackgerrit Hong Hui Xiao proposed openstack/python-openstackclient master: Don't show hint about vlan transparent in network set https://review.openstack.org/466002
13:36:26 openstackgerrit Monty Taylor proposed openstack/keystoneauth master: Rework EndpointData construction to normalize catalog first https://review.openstack.org/469085
19:10:30 openstackgerrit Phil Hopkins proposed openstack/python-openstackclient master: Fix Mapping Guide Error https://review.openstack.org/472780
22:16:16 openstackgerrit Merged openstack/python-openstackclient master: Fix Mapping Guide Error https://review.openstack.org/472780
#openstack-sdks - 2017-06-11
04:26:54 openstackgerrit Merged openstack/python-openstackclient master: Updated from global requirements https://review.openstack.org/472921
05:27:42 openstackgerrit Lingyong Xu proposed openstack/cliff master: Optimize the link address https://review.openstack.org/471981
#openstack-sdks - 2017-06-12
00:34:05 openstackgerrit Lingyong Xu proposed openstack/cliff master: Optimize the link address https://review.openstack.org/471981
02:52:29 openstackgerrit Reedip proposed openstack/python-openstackclient master: Add default-quota to subnet pool commands https://review.openstack.org/437367
03:01:54 openstackgerrit Monty Taylor proposed openstack/keystoneauth master: Expose getting EndpointData on adapter and session https://review.openstack.org/469091
03:01:55 openstackgerrit Monty Taylor proposed openstack/keystoneauth master: Add support for version ranges https://review.openstack.org/469090
03:01:56 openstackgerrit Monty Taylor proposed openstack/keystoneauth master: Support explicitly requesting the 'latest' version https://review.openstack.org/469089
03:01:57 openstackgerrit Monty Taylor proposed openstack/keystoneauth master: Add flags to turn discovery on and off https://review.openstack.org/469088
03:01:58 openstackgerrit Monty Taylor proposed openstack/keystoneauth master: Plumb endpoint_override through get_endpoint_data https://review.openstack.org/469092
03:01:59 openstackgerrit Monty Taylor proposed openstack/keystoneauth master: Rename discover_versions to fetch_version_info https://review.openstack.org/470275
03:02:00 openstackgerrit Monty Taylor proposed openstack/keystoneauth master: Optimize matching version no microversion needed https://review.openstack.org/470274
03:02:01 openstackgerrit Monty Taylor proposed openstack/keystoneauth master: Rework EndpointData construction to normalize catalog first https://review.openstack.org/469085
03:02:02 openstackgerrit Monty Taylor proposed openstack/keystoneauth master: Move version discovery logic to keystoneauth1.discover https://review.openstack.org/469086
03:02:03 openstackgerrit Monty Taylor proposed openstack/keystoneauth master: Add url manipulation and microversion collection https://review.openstack.org/469087
04:16:44 openstackgerrit Reedip proposed openstack/python-openstackclient master: Add extra dhcp option to 'port create/set/unset' https://review.openstack.org/356263
05:46:37 bhagyashri_s Qiming: Hi,
05:47:23 Qiming yes?
05:49:16 bhagyashri_s Qiming: I have one question regarding the compute update_volume_attachment api. On the current master the allow_upate is set as false for update_volume_attachment api so is there any reason?
05:50:03 Qiming looking
05:50:12 bhagyashri_s Qiming: ok.
05:50:51 bhagyashri_s Qiming: just for reference: https://github.com/openstack/python-openstacksdk/blame/master/openstack/compute/v2/volume_attachment.py#L26
05:53:02 Qiming bhagyashri_s, looks to me not unsafe to set to true, though I'm not aware of any particular reason why it was set to false currently
05:53:23 Qiming I'd be supportive to change it to true
05:54:59 bhagyashri_s Qiming: ok.
05:55:24 bhagyashri_s Qiming: So should I work on it?
05:56:03 Qiming that would be great!
05:57:23 bhagyashri_s ok, I will report this issue in LP and will submit a review ASAP
05:57:32 bhagyashri_s thank you for your input

Earlier   Later