| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-sdks - 2017-02-28 | |||
| 19:28:37 | jkilpatr | oh I guess I should say that a 400 is being returned by keystone, which is odd because I'm just using the oepnstack sdk to make the request and all other calls work | |
| 19:29:06 | jkilpatr | code here https://github.com/jkilpatr/ostag | |
| 19:29:08 | briancurtin | there is no node_update method in the bare_metal part of openstacksdk | |
| 19:29:43 | jkilpatr | https://developer.openstack.org/sdks/python/openstacksdk/users/proxies/bare_metal.html | |
| 19:29:45 | jkilpatr | sorry update_node | |
| 19:30:24 | briancurtin | i guess you’ll need some sort of logs or example code. i don’t know how/why a 400 would be returned by whatever it is that you’re doing | |
| 19:30:54 | rabel_b1 | reedip, ankur-gupta-f1: what about doc/source/command-object/image.rst ? | |
| 19:31:00 | rabel_b1 | shouldn't it be adjusted to what openstack help image create gives? | |
| 19:31:27 | briancurtin | jkilpatr: enable the logs and then run what you’re doing: https://developer.openstack.org/sdks/python/openstacksdk/users/utils.html#openstack.utils.enable_logging | |
| 19:31:29 | reedip | rabel_b1 : Just min | |
| 19:31:45 | jkilpatr | briancurtin, ok | |
| 19:32:06 | stevemar | ankur-gupta-f1: should i convert the spread sheet to a csv and upload it now? | |
| 19:32:26 | ankur-gupta-f1 | stevemar: yea and add me so i can double check. but it looks updated thus far | |
| 19:32:27 | reedip | No need to update the rst but a release note may be required to specify that now -file and --volume cannot be specified each other | |
| 19:32:40 | briancurtin | jkilpatr: or does the exception message say what exactly about the request returning a 400 is bad? I’m guessing we’re probably sending something we shouldnt | |
| 19:33:03 | briancurtin | (that might have to come out of the logs though) | |
| 19:38:59 | reedip | is the gate OK ? Its taking longer than avg to process patches | |
| 19:39:52 | rabel_b1 | reedip : the behaviour actually did not change. it was not possible before my patch either. but now it is handled by the exclusive_group. the only real difference is, that now --file and --volume are shown as exclusive in the "openstack help image create" output. that's why I thought about changing the rst as well, so it fits again. | |
| 19:43:45 | reedip | rabel_b1 : https://github.com/openstack/python-openstackclient/blob/master/doc/source/command-objects/image.rst , yes change it | |
| 19:44:02 | jkilpatr | briancurtin, https://paste.fedoraproject.org/paste/NYk1V7ShVeenT3qbEsl9oV5M1UNdIGYhyRLivL9gydE= | |
| 19:44:09 | jkilpatr | that's the error. | |
| 19:44:24 | rabel_b1 | reedip : thank you | |
| 19:44:40 | jkilpatr | briancurtin, it's caused by these lines | |
| 19:45:19 | jkilpatr | https://paste.fedoraproject.org/paste/kzWamEQ4InhEP5MHqRa~gF5M1UNdIGYhyRLivL9gydE= | |
| 19:46:09 | reedip | rabel_b1 : glad to help | |
| 19:51:35 | briancurtin | jkilpatr: something about your capabilities string makes it not a valid list. i don’t work on ironic and the documentation isn’t very helpful on that (“capabilities” doesnt even appear in the REST API docs). id maybe check with that team to figure out what kind of request should actually be sent | |
| 19:52:00 | dhellmann | dtroyer, stevemar : I just added you to this review to install OSC under python3 by default in python3 jobs: https://review.openstack.org/#/c/439112/ | |
| 19:55:41 | jkilpatr | briancurtin, happens with the same error if I try to lets say modify the node name, https://paste.fedoraproject.org/paste/mihOWmmHMQzcWfSr47zOaF5M1UNdIGYhyRLivL9gydE= | |
| 19:55:59 | jkilpatr | so that's just bare_metal.node_update(uuid, name="test") | |
| 19:56:10 | jkilpatr | nothing fancy, no list shenenegans simpliest possible call | |
| 19:56:35 | rabel_b1 | reedip : is there a way to automatically generate those files? because it looks like the file (image.rst) does not distinguish between v1 v2 for "image set" and "image create" while they actually do differ. | |
| 19:56:59 | reedip | Nope, manual is the way to go :P | |
| 19:57:09 | briancurtin | jkilpatr: i guess submit a bug to https://bugs.launchpad.net/python-openstacksdk and maybe someone will know what any of that means | |
| 19:57:39 | dtroyer | rabel_b1: v1 and v2 should be as identical as possible, with the differences noted in the doc | |
| 19:58:50 | dtroyer | dhellmann: cool, trying it now | |
| 20:00:20 | rabel_b1 | reedip, dtroyer : wouldn't it be a good idea to write a little script that parses output of "openstack help ..." to generate those files? in the long term it's less duplicate work and less error-prone. | |
| 20:01:12 | reedip | rabel_b1 : I dont know if such a script exists , but if it doesnt, please be our guest . That would be greatly appreciated :) | |
| 20:01:13 | dtroyer | rabel_b1: be my guest… but inlcude all of the text that explains the options (we really should have a LOT more of that) too | |
| 20:01:47 | rabel_b1 | ls | |
| 20:01:53 | rabel_b1 | sry, wrong window | |
| 20:02:24 | dtroyer | FWIW, there are also syntax things that can not be expressed in apgparse that is in the docs... | |
| 20:02:40 | reedip | dtroyer ; agreed | |
| 20:03:20 | reedip | rabel_b1 : if there is a lot of difference between v1 and v2 of image, please log a bug for that for verification | |
| 20:04:35 | rabel_b1 | reedip : there are already TODOs in v2/image.py . maybe there is already a bug open for this? | |
| 20:05:45 | rabel_b1 | reedip, dtroyer : i would like to write such a script or at least help writing it. | |
| 20:06:46 | reedip | rabel_b1 : you can definetly start working on this, if you have bandwidth | |
| 20:07:48 | reedip | rabel_b1 : the todo in image.py may not correspond to the text mismatch in image,rst | |
| 20:07:56 | dtroyer | rabel_b1: that is a pretty low priority for us overall, and will have a fair number of exceptions | |
| 20:12:38 | openstackgerrit | Reedip proposed openstack/python-openstackclient master: Introduce quota unset command https://review.openstack.org/376311 | |
| 20:12:55 | reedip | ankur-gupta-f1 : done ^^^ | |
| 20:16:40 | reedip | stevemar : is this https://review.openstack.org/#/c/367673/9 going to move forward? | |
| 20:18:33 | rabel_b1 | reedip, dtroyer : well, i probably shouldn't start working on such a script right now. but i will think about it. for now i will just adjust image.rst . thank you two | |
| 20:19:26 | rabel_b1 | one last question: how to indicate a difference between v2 and v1 in image.rst? | |
| 20:20:07 | dtroyer | there are examp[les in nearly every non-network resource file… similar to: **XXX API v1 only** notes | |
| 20:22:37 | rabel_b1 | ah, thanks | |
| 20:29:39 | stevemar | reedip: i have no idea :) | |
| 20:30:02 | stevemar | reedip: i think dtroyer wants https://review.openstack.org/#/c/367673/ but he hasn't reviewed it at all :P | |
| 20:30:03 | briancurtin | stevemar: can i release a new SDK version? | |
| 20:32:59 | reedip | stevemar ( come back ) , ankur-gupta-f1, sindhu : review requested in https://review.openstack.org/383025 | |
| 20:33:29 | reedip | oh, TC meeting, stevemar, nevermind ! | |
| 20:33:31 | reedip | :) | |
| 20:33:46 | ankur-gupta-f1 | reedip: the only thing holding that patch back is the gate. Its has looked good for awhile. just a matter of getting functional passing | |
| 20:33:54 | reedip | passed ! | |
| 20:34:02 | reedip | That was what I was checking :D | |
| 20:34:48 | reedip | http://logs.openstack.org/25/383025/52/check/gate-osc-dsvm-functional-ubuntu-xenial/9cf94b6/console.html | |
| 20:35:20 | dtroyer | briancurtin: looks like the master OSC + master SDK job is green… | |
| 20:36:22 | openstackgerrit | David Rabel proposed openstack/python-openstackclient master: Update doc/source/command-objects/image.rst https://review.openstack.org/439142 | |
| 20:37:32 | stevemar | briancurtin: i think you're OK to release a new version | |
| 20:46:36 | sindhu | reedip: yay! finally | |
| 20:46:43 | reedip | hehehe :) | |
| 20:46:58 | reedip | Yeah ! its ALIVE ! | |
| 20:52:40 | openstackgerrit | Steve Martinelli proposed openstack/python-openstackclient master: add neutron CLI to decoder https://review.openstack.org/439148 | |
| 20:53:00 | stevemar | reedip: ^ | |
| 20:53:05 | stevemar | ankur-gupta-f1: ^ | |
| 20:53:13 | ankur-gupta-f1 | stevemar: yup looking over now | |
| 20:56:16 | reedip | stevemar : Line#231, and232, we do not need the --tag option in the second column, do we? | |
| 20:57:09 | stevemar | reedip: i thought we did? | |
| 20:57:10 | reedip | the second column is the OSC equivalent | |
| 20:58:33 | ankur-gupta-f1 | it should be there | |
| 20:59:11 | reedip | ok goit it | |
| 20:59:14 | ankur-gupta-f1 | reedip: note glance CLI for image-tag-delete | |
| 20:59:30 | ankur-gupta-f1 | going to implemented similarly. once i figure out the best way to do it :) | |
| 20:59:37 | reedip | lol | |
| 20:59:42 | reedip | U will sooner ! | |
| 21:04:04 | openstackgerrit | Ankur proposed openstack/python-openstackclient master: add neutron CLI to decoder https://review.openstack.org/439148 | |
| 21:04:33 | ankur-gupta-f1 | stevemar: looks good just added reedips tapflow commands | |
| 21:20:15 | briancurtin | Qiming: fyi i just released https://pypi.python.org/pypi/openstacksdk/0.9.14 | |
| 21:42:39 | openstackgerrit | Justin A Wilson proposed openstack/python-openstackclient master: Add support for Cinder API 3.3/3.5 into OSC https://review.openstack.org/421585 | |
| 21:45:08 | reedip | stevemar : any suggestions on https://review.openstack.org/383025 if u r not busy ? | |
| 21:47:20 | openstackgerrit | Justin A Wilson proposed openstack/python-openstackclient master: Add support for Cinder API 3.3/3.5 into OSC https://review.openstack.org/421585 | |
| 22:14:33 | openstackgerrit | Dean Troyer proposed openstack/python-openstackclient master: Simplify logic around option lists in port set https://review.openstack.org/439048 | |
| 22:25:31 | dtroyer | thingee: FWIW huanxuan and I both left responses to your comments in https://review.openstack.org/#/c/434094/ about OSC plurals and the —no-XXXX options, in case the history is useful. | |
| 23:03:13 | thingee | mordred: can you update https://review.openstack.org/#/c/434372/ before a dependency merges? | |
| 23:04:22 | thingee | dtroyer: ack I'll remember this in the future | |
| 23:04:38 | ankur-gupta-f4 | +1 | |
| 23:05:48 | thingee | dtroyer: still don't agree with it, but I'll let it go. | |
| 23:05:51 | mordred | thingee: the file that you reference is actually in a different repo | |
| 23:06:00 | thingee | mordred: doh | |
| 23:06:08 | thingee | mordred: sorry | |
| 23:06:33 | thingee | mordred: +1 | |