| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-sdks - 2017-02-28 | |||
| 19:04:35 | ankur-gupta-f1 | stevemar: its okay. Ignorance is bliss, readding now | |
| 19:04:44 | stevemar | :) | |
| 19:05:29 | reedip | stevemar, ankur-gupta-f1 : the doc needs to be updated, aint it ? Seems like its missing some things maybe from network side | |
| 19:06:44 | reedip | Note : I dont think we would be migrating LBaaS v1 to OSC | |
| 19:06:51 | reedip | confirming the same from lbaas team | |
| 19:07:10 | ankur-gupta-f1 | yea | |
| 19:07:16 | ankur-gupta-f1 | waiting for Lbaasv2 | |
| 19:07:21 | ankur-gupta-f1 | reedip: ^^ | |
| 19:07:43 | reedip | So we can remove the LBaaS v1 from the sheet | |
| 19:08:08 | reedip | as per johnsom: neutron-lbaas v1 API will not be supported by OSC, you will have to use the legacy neutron client ] | |
| 19:08:18 | ankur-gupta-f1 | thats what I was saying. It won't be done probably this cycle either | |
| 19:09:03 | johnsom | Yeah, no nlbaas v1 API support in OSC | |
| 19:09:05 | reedip | so we can remove that from the sheet, to get a better report | |
| 19:09:31 | reedip | I mean we do not need to track what we do not want to move , aint it ? | |
| 19:10:43 | ankur-gupta-f1 | agreed. Plus it takes up so much space haha | |
| 19:11:07 | reedip | updated the sheet , please check | |
| 19:11:31 | reedip | I am not removing them though, changed their status for now : stevemar, please confirm :) | |
| 19:12:05 | ankur-gupta-f1 | reedip: also the 'lbaas-*' commands | |
| 19:13:13 | reedip | ankur-gupta-f1 : that we need to track | |
| 19:13:23 | reedip | that would be the basis of our movement from NC to OSC | |
| 19:13:55 | ankur-gupta-f1 | fine :| | |
| 19:14:09 | reedip | what ?? dissapointed ?? :D | |
| 19:16:42 | ankur-gupta-f1 | never :P | |
| 19:17:51 | reedip | Updated the sheet, now we are 42% complete ! | |
| 19:17:53 | mordred | thingee: it's a new flag and I just didn't get through checking all of them - not having a setting should be safe, since that's the current "I dunno, you go figure it out" situation. adding positive attestations should allow us to optimize calling code to not have to figure out | |
| 19:17:56 | mordred | thingee: I hope | |
| 19:18:53 | openstackgerrit | Monty Taylor proposed openstack/os-client-config master: Pass ironic microversion through from api_version https://review.openstack.org/439118 | |
| 19:18:55 | openstackgerrit | Monty Taylor proposed openstack/os-client-config master: Add support for bailing on invalid service versions https://review.openstack.org/439119 | |
| 19:18:56 | openstackgerrit | Monty Taylor proposed openstack/os-client-config master: Add helper factory functions for use in OpenStack services https://review.openstack.org/439120 | |
| 19:21:57 | rabel_b1 | hi there, is this the right place for questions regarding the development of python-openstackclient? | |
| 19:22:09 | ankur-gupta-f1 | rabel_b1: indeed. fire away | |
| 19:22:13 | reedip | rabel_b1 : fire | |
| 19:22:16 | reedip | hehehe | |
| 19:23:19 | rabel_b1 | I submitted a patch a few days ago and it got merged. https://review.openstack.org/#/c/437335/ Now I wanted to ask if I have to change something in the docs, too | |
| 19:24:08 | ankur-gupta-f1 | rabel_b1: no need. You just changed the logic of an existing command | |
| 19:24:17 | reedip | Not for this | |
| 19:24:30 | reedip | ankur-gupta-f1 : you are beating me on the keyboard ! | |
| 19:24:38 | rabel_b1 | :D | |
| 19:25:18 | rabel_b1 | what about doc/source/command-object/image.rst ? | |
| 19:25:44 | rabel_b1 | shouldn't it be adjusted to what openstack help image create gives? | |
| 19:26:39 | openstackgerrit | Monty Taylor proposed openstack/os-client-config master: Add helper factory functions for use in OpenStack services https://review.openstack.org/439120 | |
| 19:27:53 | jkilpatr | hey I'm getting keystone errors when running some openstack sdk calls, but I'm authed as admin so I'm trying to figure out if it's a perms issue or if the api call (bare_metal.node_update(id, **kwargs)) is the culprit. | |
| 19:28:37 | jkilpatr | oh I guess I should say that a 400 is being returned by keystone, which is odd because I'm just using the oepnstack sdk to make the request and all other calls work | |
| 19:29:06 | jkilpatr | code here https://github.com/jkilpatr/ostag | |
| 19:29:08 | briancurtin | there is no node_update method in the bare_metal part of openstacksdk | |
| 19:29:43 | jkilpatr | https://developer.openstack.org/sdks/python/openstacksdk/users/proxies/bare_metal.html | |
| 19:29:45 | jkilpatr | sorry update_node | |
| 19:30:24 | briancurtin | i guess you’ll need some sort of logs or example code. i don’t know how/why a 400 would be returned by whatever it is that you’re doing | |
| 19:30:54 | rabel_b1 | reedip, ankur-gupta-f1: what about doc/source/command-object/image.rst ? | |
| 19:31:00 | rabel_b1 | shouldn't it be adjusted to what openstack help image create gives? | |
| 19:31:27 | briancurtin | jkilpatr: enable the logs and then run what you’re doing: https://developer.openstack.org/sdks/python/openstacksdk/users/utils.html#openstack.utils.enable_logging | |
| 19:31:29 | reedip | rabel_b1 : Just min | |
| 19:31:45 | jkilpatr | briancurtin, ok | |
| 19:32:06 | stevemar | ankur-gupta-f1: should i convert the spread sheet to a csv and upload it now? | |
| 19:32:26 | ankur-gupta-f1 | stevemar: yea and add me so i can double check. but it looks updated thus far | |
| 19:32:27 | reedip | No need to update the rst but a release note may be required to specify that now -file and --volume cannot be specified each other | |
| 19:32:40 | briancurtin | jkilpatr: or does the exception message say what exactly about the request returning a 400 is bad? I’m guessing we’re probably sending something we shouldnt | |
| 19:33:03 | briancurtin | (that might have to come out of the logs though) | |
| 19:38:59 | reedip | is the gate OK ? Its taking longer than avg to process patches | |
| 19:39:52 | rabel_b1 | reedip : the behaviour actually did not change. it was not possible before my patch either. but now it is handled by the exclusive_group. the only real difference is, that now --file and --volume are shown as exclusive in the "openstack help image create" output. that's why I thought about changing the rst as well, so it fits again. | |
| 19:43:45 | reedip | rabel_b1 : https://github.com/openstack/python-openstackclient/blob/master/doc/source/command-objects/image.rst , yes change it | |
| 19:44:02 | jkilpatr | briancurtin, https://paste.fedoraproject.org/paste/NYk1V7ShVeenT3qbEsl9oV5M1UNdIGYhyRLivL9gydE= | |
| 19:44:09 | jkilpatr | that's the error. | |
| 19:44:24 | rabel_b1 | reedip : thank you | |
| 19:44:40 | jkilpatr | briancurtin, it's caused by these lines | |
| 19:45:19 | jkilpatr | https://paste.fedoraproject.org/paste/kzWamEQ4InhEP5MHqRa~gF5M1UNdIGYhyRLivL9gydE= | |
| 19:46:09 | reedip | rabel_b1 : glad to help | |
| 19:51:35 | briancurtin | jkilpatr: something about your capabilities string makes it not a valid list. i don’t work on ironic and the documentation isn’t very helpful on that (“capabilities” doesnt even appear in the REST API docs). id maybe check with that team to figure out what kind of request should actually be sent | |
| 19:52:00 | dhellmann | dtroyer, stevemar : I just added you to this review to install OSC under python3 by default in python3 jobs: https://review.openstack.org/#/c/439112/ | |
| 19:55:41 | jkilpatr | briancurtin, happens with the same error if I try to lets say modify the node name, https://paste.fedoraproject.org/paste/mihOWmmHMQzcWfSr47zOaF5M1UNdIGYhyRLivL9gydE= | |
| 19:55:59 | jkilpatr | so that's just bare_metal.node_update(uuid, name="test") | |
| 19:56:10 | jkilpatr | nothing fancy, no list shenenegans simpliest possible call | |
| 19:56:35 | rabel_b1 | reedip : is there a way to automatically generate those files? because it looks like the file (image.rst) does not distinguish between v1 v2 for "image set" and "image create" while they actually do differ. | |
| 19:56:59 | reedip | Nope, manual is the way to go :P | |
| 19:57:09 | briancurtin | jkilpatr: i guess submit a bug to https://bugs.launchpad.net/python-openstacksdk and maybe someone will know what any of that means | |
| 19:57:39 | dtroyer | rabel_b1: v1 and v2 should be as identical as possible, with the differences noted in the doc | |
| 19:58:50 | dtroyer | dhellmann: cool, trying it now | |
| 20:00:20 | rabel_b1 | reedip, dtroyer : wouldn't it be a good idea to write a little script that parses output of "openstack help ..." to generate those files? in the long term it's less duplicate work and less error-prone. | |
| 20:01:12 | reedip | rabel_b1 : I dont know if such a script exists , but if it doesnt, please be our guest . That would be greatly appreciated :) | |
| 20:01:13 | dtroyer | rabel_b1: be my guest… but inlcude all of the text that explains the options (we really should have a LOT more of that) too | |
| 20:01:47 | rabel_b1 | ls | |
| 20:01:53 | rabel_b1 | sry, wrong window | |
| 20:02:24 | dtroyer | FWIW, there are also syntax things that can not be expressed in apgparse that is in the docs... | |
| 20:02:40 | reedip | dtroyer ; agreed | |
| 20:03:20 | reedip | rabel_b1 : if there is a lot of difference between v1 and v2 of image, please log a bug for that for verification | |
| 20:04:35 | rabel_b1 | reedip : there are already TODOs in v2/image.py . maybe there is already a bug open for this? | |
| 20:05:45 | rabel_b1 | reedip, dtroyer : i would like to write such a script or at least help writing it. | |
| 20:06:46 | reedip | rabel_b1 : you can definetly start working on this, if you have bandwidth | |
| 20:07:48 | reedip | rabel_b1 : the todo in image.py may not correspond to the text mismatch in image,rst | |
| 20:07:56 | dtroyer | rabel_b1: that is a pretty low priority for us overall, and will have a fair number of exceptions | |
| 20:12:38 | openstackgerrit | Reedip proposed openstack/python-openstackclient master: Introduce quota unset command https://review.openstack.org/376311 | |
| 20:12:55 | reedip | ankur-gupta-f1 : done ^^^ | |
| 20:16:40 | reedip | stevemar : is this https://review.openstack.org/#/c/367673/9 going to move forward? | |
| 20:18:33 | rabel_b1 | reedip, dtroyer : well, i probably shouldn't start working on such a script right now. but i will think about it. for now i will just adjust image.rst . thank you two | |
| 20:19:26 | rabel_b1 | one last question: how to indicate a difference between v2 and v1 in image.rst? | |
| 20:20:07 | dtroyer | there are examp[les in nearly every non-network resource file… similar to: **XXX API v1 only** notes | |
| 20:22:37 | rabel_b1 | ah, thanks | |
| 20:29:39 | stevemar | reedip: i have no idea :) | |
| 20:30:02 | stevemar | reedip: i think dtroyer wants https://review.openstack.org/#/c/367673/ but he hasn't reviewed it at all :P | |
| 20:30:03 | briancurtin | stevemar: can i release a new SDK version? | |