| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-sdks - 2018-03-21 | |||
| 12:56:22 | openstackgerrit | Mohammed Naser proposed openstack/python-openstackclient master: Add support to list image members https://review.openstack.org/554590 | |
| 12:56:35 | mnaser | dtroyer: addressed comments ^ :) | |
| 13:06:20 | openstackgerrit | OpenStack Proposal Bot proposed openstack/os-service-types master: Updated from OpenStack Service Type Authority https://review.openstack.org/554910 | |
| 13:23:46 | openstackgerrit | Chris Dent proposed openstack/api-wg master: Update the errors guidance to use service-type for code https://review.openstack.org/554921 | |
| 14:00:05 | cdent | elmiko, edleafe: if you could traverse this stack once again, now that I've fixed (simply thanks to edleafe) the Version issues, please and thank you: https://review.openstack.org/#/c/550251/ | |
| 14:01:02 | cdent | with cherries and cookies and other nice things | |
| 14:03:10 | edleafe | cdent: Can you explain why we want version 0.0 to match? | |
| 14:03:34 | cdent | heh, my irc client turned that into a smiley | |
| 14:03:45 | cdent | a scared smiley | |
| 14:03:52 | edleafe | I can see that! | |
| 14:04:50 | cdent | because say you're experimenting with building your microversion service, and you just decide to make your first version a non-version, but you want the code to work, thus (0, 0) | |
| 14:06:31 | edleafe | so is that just something that you thought about, or is it some kind of microversion standard? | |
| 14:06:54 | cdent | the former | |
| 14:07:19 | cdent | or at least if it is a standard, I wasn't aware of it | |
| 14:08:12 | edleafe | well, I can see it being useful, but only if that behavior is, you know, mentioned somewhere | |
| 14:08:37 | cdent | perfection is the enemy of the done | |
| 14:08:44 | cdent | this isn't the end game, it is the start | |
| 14:08:52 | cdent | $cliche the $cliche | |
| 14:09:32 | cdent | I'd really just like to release early and often, and spread the audience | |
| 14:10:19 | edleafe | yeah, I wasn't talking about holding things up; I just wanted to share the love at some point. | |
| 14:10:35 | elmiko | cdent: ack, added to the queue | |
| 14:11:43 | cdent | thanks, both of you | |
| 14:12:07 | elmiko | and ++ to edleafe, i totally was not nearly snarky enough on those reviews XD | |
| 14:13:55 | cdent | /o\ | |
| 14:15:40 | openstackgerrit | Monty Taylor proposed openstack/python-openstacksdk master: Provide OpenStackConfigException backwards compat https://review.openstack.org/554615 | |
| 14:15:56 | mordred | frickler: ^^ added closes-bug footer if you have a second to re-approve | |
| 14:19:36 | frickler | mordred: sure, thx | |
| 14:23:10 | frickler | mordred: I'm seeing seemingly unrelated network test failures on this patch to which I only added a reno. looks like there may be a timing issue in the first test at least http://logs.openstack.org/33/540633/3/check/osc-functional-devstack/456e2b0/job-output.txt.gz#_2018-03-21_13_02_19_573915 | |
| 14:23:46 | frickler | dtroyer: also related to your recent novaclient workarounding I think ^^ | |
| 14:25:36 | elmiko | cdent: the test_version_zero_no_defaults test, am i reading that docstring wrong, it says "we want to it be able to match" but the test is assertFalse. i'm a little confused | |
| 14:26:05 | cdent | elmiko: it's a pasto, I'll fix it in a follow up if that's cool | |
| 14:26:10 | cdent | it's basically the wrong docstring | |
| 14:26:15 | elmiko | ahh, cool | |
| 14:26:18 | elmiko | thought so | |
| 14:29:13 | openstackgerrit | Merged openstack/os-service-types master: Updated from global requirements https://review.openstack.org/551598 | |
| 14:29:14 | openstackgerrit | Merged openstack/os-service-types master: Updated from OpenStack Service Type Authority https://review.openstack.org/554910 | |
| 14:30:16 | openstackgerrit | Chris Dent proposed openstack/api-wg master: Correct header on time based filtering https://review.openstack.org/554935 | |
| 14:30:29 | cdent | elmiko, edleafe that ^ is a pretty important and probably fast merge fix | |
| 14:33:37 | edleafe | cdent: elmiko: +W | |
| 14:33:50 | edleafe | Strange that that happened | |
| 14:36:57 | cdent | yeah, it was rather out of the blue | |
| 14:37:24 | openstackgerrit | Chris Dent proposed openstack/microversion-parse master: Correct docstring on Version(0, 0) test https://review.openstack.org/554937 | |
| 14:37:31 | cdent | elmiko: the promised followup | |
| 14:43:21 | openstackgerrit | Merged openstack/api-wg master: Correct header on time based filtering https://review.openstack.org/554935 | |
| 15:06:58 | dtroyer | frickler: I started seeing that network segment failure yesterday, haven't sorted it out yet | |
| 15:18:58 | openstackgerrit | Chris Dent proposed openstack/microversion-parse master: Correct docstring on Version(0, 0) test https://review.openstack.org/554937 | |
| 15:24:47 | cdent | edleafe, elmiko: do you know: Is the guideline publishing job async from the guideline merging? | |
| 15:25:29 | elmiko | cdent: i /think/ yes, i know it is often delayed from the merge | |
| 15:25:43 | cdent | good, otherwise something is wrong :) | |
| 15:26:03 | elmiko | iirc from the last time, it took a few hours for my merge to make it onto the site | |
| 15:31:56 | openstackgerrit | Merged openstack/microversion-parse master: Improve Version.matches() method https://review.openstack.org/550251 | |
| 15:45:52 | openstackgerrit | Saju M proposed openstack/os-client-config master: pypy is not checked at gate https://review.openstack.org/554955 | |
| 16:04:53 | edleafe | elmiko: need your input on https://review.openstack.org/#/c/550252/. | |
| 16:05:42 | elmiko | edleafe: ack, looking | |
| 16:31:25 | edleafe | cdent: looks like the whole stack is queued up with +Ws | |
| 16:31:43 | cdent | hurrah! thank you | |
| 16:43:19 | openstackgerrit | Merged openstack/microversion-parse master: Add MicroversionMiddleware https://review.openstack.org/550252 | |
| 16:43:20 | openstackgerrit | Merged openstack/microversion-parse master: Allow passing a json_error_formatter to the middleware https://review.openstack.org/550263 | |
| 16:43:21 | openstackgerrit | Merged openstack/microversion-parse master: Clean up package version and python version support https://review.openstack.org/550264 | |
| 16:43:22 | openstackgerrit | Merged openstack/microversion-parse master: Do not use redundant attr check for keys in fold_headers https://review.openstack.org/554547 | |
| 16:43:23 | openstackgerrit | Merged openstack/microversion-parse master: Correct docstring on Version(0, 0) test https://review.openstack.org/554937 | |
| 16:48:16 | elmiko | cdent: ++ | |
| 17:40:22 | openstackgerrit | Chris Dent proposed openstack/microversion-parse master: Enable universal wheels for microversion-parse https://review.openstack.org/555001 | |
| 17:40:35 | cdent | elmiko, edleafe : one more! | |
| 17:45:05 | elmiko | cdent: what are you, some sort of review pushing machine! | |
| 17:45:12 | elmiko | dang! right as he quit | |
| 17:59:06 | frickler | dtroyer: seems https://review.openstack.org/552140 causes the neutron segment failures , pinged neutron folk about it | |
| 17:59:38 | frickler | dtroyer: the fip error appears to happen sporadic only | |
| 18:19:41 | openstackgerrit | Merged openstack/microversion-parse master: Enable universal wheels for microversion-parse https://review.openstack.org/555001 | |
| 18:41:48 | frickler | dtroyer: the segment patch will get reverted and this is the followup https://bugs.launchpad.net/neutron/+bug/1757513 | |
| 18:41:49 | openstack | Launchpad bug 1757513 in neutron "standardattrdescription clobbers existing description API attr" [Undecided,New] | |
| 19:22:57 | mordred | Shrews: got a second to +A https://review.openstack.org/#/c/554615/ real quick? | |
| 19:24:25 | Shrews | mordred: hopefully in a bit. all I have is my phone. My computer networking is unhappy | |
| 19:24:39 | mordred | Shrews: ew gross | |
| 19:24:44 | Shrews | No idea what I broke | |
| 19:29:45 | rods | mordred I can give a look in a minute | |
| 19:31:07 | mordred | rods: thanks! | |
| 19:34:31 | Shrews | ok, that was weird. ubuntu totally decided to eliminate one of my net interfaces and screwed up everything. sorry mordred, thx rods | |
| 19:34:45 | mordred | Shrews: you didn't need that net interface anyway | |
| 19:35:46 | Shrews | yeah, who needs the nets | |
| 19:36:25 | Shrews | apparently doing anything beyond basic things with libvirt is dangerous | |
| 20:37:34 | openstackgerrit | Merged openstack/python-openstacksdk master: Provide OpenStackConfigException backwards compat https://review.openstack.org/554615 | |
| #openstack-sdks - 2018-03-22 | |||
| 01:07:27 | adriant | test_project.assign_role_to_user(conn.identity, test_user, member_role) | |
| 01:07:27 | adriant | mordred: I don't know if we can make it nicer, but having to pass in the service itself when calling actions on the resources is a pain: | |
| 01:08:15 | adriant | not to mention, having those kind of calls directly on the proxy might be nicer, since I don't always want to have to query for the project first if I know what the ids are of all the resources I want to act on are. | |
| 01:08:26 | adriant | *also on the proxy | |
| 02:42:46 | adriant | mordred: an error this time. Trying to see what response the sdk gives me when trying to create a keystone user that already exists: HttpException: HttpException: Unknown error | |
| 02:44:58 | adriant | mordred: looks like an easy one. We aren't catching 409s in the raise from exception function | |
| 02:45:08 | adriant | I'll throw up a patch for that | |
| 03:06:39 | adriant | mordred: https://github.com/openstack/python-openstacksdk/blob/master/openstack/exceptions.py#L63 is evaluating as false... expect I KNOW there is a response with status 409... | |
| 03:06:45 | adriant | except* | |
| 03:07:44 | adriant | if I print response.text in that very place I get: "{"error": {"message": "Conflict occurred attempting to store user - Duplicate Entry", "code": 409, "title": "Conflict"}}" | |
| 03:08:02 | adriant | so I have no clue what magic is making a response of type 409 eval to false... | |
| 03:16:20 | adriant | wait... wtf response always evals to false | |
| 03:16:27 | adriant | OH | |
| 03:16:48 | adriant | it is false when it isn't a safe status code... I'm willing to bet that's it | |
| 03:17:39 | adriant | mordred: we're using it wrong: https://github.com/requests/requests/blob/master/requests/models.py#L663-L671 | |
| 03:31:01 | openstackgerrit | Adrian Turjak proposed openstack/python-openstacksdk master: Add 409 ConflictException https://review.openstack.org/555142 | |
| 03:37:34 | openstackgerrit | Adrian Turjak proposed openstack/python-openstacksdk master: Fix response always being False https://review.openstack.org/555143 | |
| 04:14:58 | openstackgerrit | Adrian Turjak proposed openstack/python-openstacksdk master: Fix response always being False https://review.openstack.org/555143 | |