| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2025-12-15 | |||
| 18:03:41 | opendevreview | Merged openstack/nova master: api: Add response body schemas for tenant network APIs https://review.opendev.org/c/openstack/nova/+/956088 | |
| 18:19:05 | opendevreview | Merged openstack/nova master: api: Add response body schemas for simple tenant usage APIs https://review.opendev.org/c/openstack/nova/+/956096 | |
| #openstack-nova - 2025-12-16 | |||
| 02:59:14 | gmaan | gibi: while reviewing the tpool_wrap series, I have one comment but +w this first change. I did not want to block the whole series as this comment is not something can break but I think this is good to do as follow up - https://review.opendev.org/c/openstack/nova/+/956089/17/nova/tests/unit/test_utils.py#240 | |
| 03:00:25 | gmaan | will continue review the remaining one tomorrow | |
| 04:11:38 | opendevreview | Masahito Muroi proposed openstack/nova master: Add check_instance_state validation to lock API https://review.opendev.org/c/openstack/nova/+/946223 | |
| 04:11:38 | opendevreview | Masahito Muroi proposed openstack/nova master: Add bug 2106085 reproducer test case https://review.opendev.org/c/openstack/nova/+/971153 | |
| 04:49:42 | opendevreview | Merged openstack/nova master: Make RBD Tpool usage conditional https://review.opendev.org/c/openstack/nova/+/956089 | |
| 04:49:55 | opendevreview | Merged openstack/nova master: Make libvirt Tpool proxying conditional https://review.opendev.org/c/openstack/nova/+/956090 | |
| 08:40:35 | opendevreview | Balazs Gibizer proposed openstack/nova stable/2025.2: Collect result of _live_migration_operation https://review.opendev.org/c/openstack/nova/+/971156 | |
| 08:48:30 | opendevreview | Balazs Gibizer proposed openstack/nova master: Remove eventlet from CacheConcurrencyTestCase https://review.opendev.org/c/openstack/nova/+/970069 | |
| 08:48:30 | opendevreview | Balazs Gibizer proposed openstack/nova master: Remove eventlet from libvirt/test_driver https://review.opendev.org/c/openstack/nova/+/970070 | |
| 08:48:31 | opendevreview | Balazs Gibizer proposed openstack/nova master: Remove eventlet from libvirt/volume/test_mount https://review.opendev.org/c/openstack/nova/+/970071 | |
| 09:09:53 | opendevreview | Balazs Gibizer proposed openstack/nova master: Enable mypy on nova/utils.py https://review.opendev.org/c/openstack/nova/+/969936 | |
| 11:19:50 | opendevreview | Balazs Gibizer proposed openstack/nova master: Rally job for eventlet-removal https://review.opendev.org/c/openstack/nova/+/960130 | |
| 11:41:20 | opendevreview | Balazs Gibizer proposed openstack/nova master: Follow up test change for 8c8047ce2afae https://review.opendev.org/c/openstack/nova/+/971171 | |
| 11:44:46 | gibi | gmaan: ^^ that is a followup based on your comment on the first tpool change you approved yesterday | |
| 11:44:53 | gibi | thanks for all the reviews | |
| 12:26:01 | opendevreview | Dominik proposed openstack/nova master: NUMA Topology with Resource Providers: Scheduler changes https://review.opendev.org/c/openstack/nova/+/971176 | |
| 12:27:18 | opendevreview | Dominik proposed openstack/nova master: NUMA Topology with Resource Providers: Libvirt NUMA Migrate https://review.opendev.org/c/openstack/nova/+/971177 | |
| 13:27:32 | opendevreview | Merged openstack/nova master: Make guestfs' Tpool usage optional https://review.opendev.org/c/openstack/nova/+/965821 | |
| 14:37:38 | jayaanand | Hello Everyone, I am from NetApp. One of our client is looking for ephemeral volumes solution with FlexGroup similar to Ceph. Can i look at current Ceph ephemeral volumes solution and come up with similar solution for NetApp. Is there any recommendation from Nova community. Please let me know. Thank you! your response is greatly appreciated. Also, i am seeing new framework proposals from community for Ephemeral volumes. | |
| 14:37:38 | jayaanand | Do we have to follow those recommandations? | |
| 15:46:09 | opendevreview | Johannes Kulik proposed openstack/nova master: WIP: Attaching a volume returns HTTP 202 https://review.opendev.org/c/openstack/nova/+/971068 | |
| 16:03:48 | gmaan | gibi: ack, thanks | |
| 17:26:02 | opendevreview | sean mooney proposed openstack/os-vif master: Add pyroute2 tap device creation support https://review.opendev.org/c/openstack/os-vif/+/971231 | |
| 17:29:31 | opendevreview | Lajos Katona proposed openstack/nova master: blueprint: iothreads-for-instances https://review.opendev.org/c/openstack/nova/+/939254 | |
| 19:29:45 | opendevreview | Merged openstack/nova master: Make image upload tpool usage conditional https://review.opendev.org/c/openstack/nova/+/966505 | |
| #openstack-nova - 2025-12-17 | |||
| 00:46:23 | cardoe | sean-k-mooney: what do ya need from me on the spec? You want me to actually create the base 2026.2 file? | |
| 00:46:44 | cardoe | Cause it failed cause it says 2026.2 is not opened yet. | |
| 08:33:37 | opendevreview | Marius Leustean proposed openstack/nova master: Faults from cell DB missing in GET /servers/detail https://review.opendev.org/c/openstack/nova/+/699176 | |
| 08:44:29 | jkulik | melwitt, sean-k-mooney you left -1 on ^ before. would be nice if you could take another look | |
| 08:53:34 | sean-k-mooney | jkulik: looks form 1000 feet the patch looks more or less correct minor comment inline | |
| 08:54:24 | jkulik | thank you! | |
| 08:54:42 | sean-k-mooney | jkulik: its nice ot have a functional reporudcer test for most bug but its not alwasy required so if you had time to add one following the repoduce and fix patther that would be nice but not strictly required. | |
| 09:35:24 | opendevreview | Taketani Ryo proposed openstack/nova master: mem-enc: create generic check for mem encryption support by host https://review.opendev.org/c/openstack/nova/+/967969 | |
| 09:35:24 | opendevreview | Taketani Ryo proposed openstack/nova master: mem-enc: stop using _get_mem_encryption_config() for SEV checks https://review.opendev.org/c/openstack/nova/+/967970 | |
| 09:35:25 | opendevreview | Taketani Ryo proposed openstack/nova master: mem-enc: remove explicit SEV dependency from nova.scheduler.utils https://review.opendev.org/c/openstack/nova/+/967971 | |
| 09:35:25 | opendevreview | Taketani Ryo proposed openstack/nova master: mem-enc: make RP creation independent of specific encryption models https://review.opendev.org/c/openstack/nova/+/967972 | |
| 09:35:26 | opendevreview | Taketani Ryo proposed openstack/nova master: mem-enc: refactor _guest_configure_mem_encryption() for extensibility https://review.opendev.org/c/openstack/nova/+/967973 | |
| 09:35:26 | opendevreview | Taketani Ryo proposed openstack/nova master: mem-enc: adjust requirement checks for mem_encryption guests https://review.opendev.org/c/openstack/nova/+/967974 | |
| 09:35:27 | opendevreview | Taketani Ryo proposed openstack/nova master: mem-enc: introduce a check between mem_encryption and locked_memory https://review.opendev.org/c/openstack/nova/+/971300 | |
| 09:51:48 | opendevreview | Marius Leustean proposed openstack/nova master: Faults from cell DB missing in GET /servers/detail https://review.opendev.org/c/openstack/nova/+/699176 | |
| 10:17:09 | sean-k-mooney | cardoe: often that is doen by the first person to propsoe a spec for the cycle in a sperate commit yes | |
| 10:17:39 | sean-k-mooney | cardoe: but we can do that quickly to unblock you or you can just create teh dir lik https://review.opendev.org/c/openstack/nova-specs/+/970298/3/specs/2026.2/approved/refine-network-setup-procedure-in-live-migrations.rst | |
| 14:28:07 | gibi | bauzas, stephenfin this is a trivial unit test change that needs second core (gmaan is already +2) https://review.opendev.org/c/openstack/nova/+/971171 | |
| 14:35:12 | opendevreview | Balazs Gibizer proposed openstack/nova master: Compute manager to use thread pools selectively https://review.opendev.org/c/openstack/nova/+/966016 | |
| 14:35:13 | opendevreview | Balazs Gibizer proposed openstack/nova master: Libvirt event handling without eventlet https://review.opendev.org/c/openstack/nova/+/965949 | |
| 14:35:13 | opendevreview | Balazs Gibizer proposed openstack/nova master: Run nova-compute in native threading mode https://review.opendev.org/c/openstack/nova/+/965467 | |
| 14:40:28 | bauzas | gibi: sent to the gate | |
| 14:44:52 | gibi | bauzas: thank you | |
| 14:57:48 | opendevreview | Julia Kreger proposed openstack/nova master: Add VNC console support for the Ironic driver https://review.opendev.org/c/openstack/nova/+/942528 | |
| 15:10:44 | opendevreview | Merged openstack/nova master: Follow up test change for 8c8047ce2afae https://review.opendev.org/c/openstack/nova/+/971171 | |
| 15:17:22 | opendevreview | Balazs Gibizer proposed openstack/nova master: Libvirt event handling without eventlet https://review.opendev.org/c/openstack/nova/+/965949 | |
| 15:17:22 | opendevreview | Balazs Gibizer proposed openstack/nova master: Run nova-compute in native threading mode https://review.opendev.org/c/openstack/nova/+/965467 | |
| 15:30:08 | gibi | this year's last eventlet sync https://meet.google.com/bcy-uqoz-hje | |
| 18:51:18 | rm_work[m] | sean-k-mooney: hey, I'm struggling with this issue I think, hoping I might be able to pick your brain: https://github.com/canonical/cloud-init/issues/5221 | |
| 18:53:11 | rm_work[m] | I don't need cloud-init to actually RUN any code, but I DID expect the result of the call (the JSON my vendordata2 endpoint returned) to show up in /var/lib/cloud/ somewhere... but /var/lib/cloud/instance/vendor-data2.txt is just empty | |
| 22:40:16 | sean-k-mooney | rm_work[m]: if your using config drve then yes it can be mounted there althoguh its possible that it was not automounted for some reason | |
| #openstack-nova - 2025-12-18 | |||
| 03:03:49 | rm_work | sean-k-mooney: So the issue I guess was that A) it doesn't get everything, only things set to be "cloud-init", and then also it doesn't accept JSON, it has to be a pure string, which is kinda dumb but it "works", I just `json.dumps` my json before I send it and have to load it up on the other side T_T | |
| 03:03:58 | rm_work | but did get it working finally. like... an hour ago lol | |
| 05:41:44 | opendevreview | Rajesh Tailor proposed openstack/nova master: Update api-ref for server create https://review.opendev.org/c/openstack/nova/+/937534 | |
| 06:15:51 | rm_work | It’s weird that “DynamicJSON” type vendor data endpoint can’t return JSON 😅 | |
| 06:16:22 | rm_work | But will cloud-init run code if I return a code block the same way as user data? | |
| 06:25:19 | opendevreview | Rajesh Tailor proposed openstack/nova master: Update api-ref for server create https://review.opendev.org/c/openstack/nova/+/937534 | |
| 09:39:56 | jkulik | sean-k-mooney: if you have some time left, https://review.opendev.org/c/openstack/nova/+/699176 got updated again (faults from cell DB) to address your comments. if not, happy holidays :) | |
| 11:30:24 | sean-k-mooney | jkulik: +2 from me but im not sure if melwitt or gibi will have time to review before the go on pto for the year | |
| 11:31:07 | jkulik | thank you. that's fine, I'll keep on bugging people next year then. but if it looks finished to you, that's already very helpful feedback :) | |
| 11:33:23 | sean-k-mooney | we can always ad dmore testing liek fucnitonal test ectra but i think what you have proesed is good enough and i think it sovles the orginal reported porblem without changing things unessisarlly | |
| 11:33:58 | sean-k-mooney | so to me it looks good as a single atomic commit that is self contained and backportable | |
| 12:55:31 | opendevreview | huanhongda proposed openstack/nova master: WIP: NUMA fit instance to host with cpu/ram_allocation_ratio https://review.opendev.org/c/openstack/nova/+/971409 | |
| 12:59:55 | opendevreview | huanhongda proposed openstack/nova master: WIP: NUMA fit instance to host with cpu/ram_allocation_ratio https://review.opendev.org/c/openstack/nova/+/971409 | |
| 13:46:54 | opendevreview | Dmitriy Rabotyagov proposed openstack/nova-specs master: Add 2026.2 spec structure https://review.opendev.org/c/openstack/nova-specs/+/971413 | |
| 14:04:35 | gibi | Uggla: gmaan: FYI I filed the bug for the py312-threading intermittent failure I mentioned yesterday https://bugs.launchpad.net/nova/+bug/2136815 I have a good idea now why it is happening so I will probably able to fix it. | |
| 14:05:34 | Uggla | gibi 👍 | |
| 14:41:23 | opendevreview | Balazs Gibizer proposed openstack/nova master: [DNM]Show issue with loopingcall in threading mode https://review.opendev.org/c/openstack/nova/+/971431 | |
| 14:59:35 | stephenfin | gibi: random question on https://github.com/openstack/nova/blob/master/nova/virt/libvirt/driver.py#L2680-L2685 | |
| 14:59:50 | stephenfin | that assumes the device has an alias. Will devices always have an alias? | |
| 15:01:20 | stephenfin | I ask because we have tests validating behavior of functions with devices with and without the alias attribute, e.g. https://github.com/openstack/nova/blob/master/nova/tests/unit/virt/libvirt/test_driver.py#L10725 | |
| 15:01:31 | stephenfin | I don't know if those are valid tests or not | |
| 15:02:44 | gibi | stephenfin: I assuem that libvirt always assign alias as that is what coming back from libvirt in the event. Nova might or might not explicitly set the alias | |
| 15:03:23 | stephenfin | Yes, that's my thinking also (and my experience from brief local testing) | |
| 15:03:56 | gibi | i think that test covers the case when nova request the detach by using an alias or by not using the alias | |
| 15:04:09 | gibi | that is independent from the device having an alias in libvirt | |
| 15:04:50 | stephenfin | right, but will be ever attempt to detach without using an alias, given an alias is always present? | |
| 15:04:58 | stephenfin | and if not, does that mean that code is dead code? | |
| 15:06:08 | stephenfin | fwiw, the context of this a rework of the mypy configuration that I'm working on: mypy is complaining because create_waiter expects the dev.alias arg to be a string (which I think is correct) but our tests explicitly set it to null is some places | |
| 15:13:16 | gibi | this is where the two codepath is coming from https://github.com/openstack/nova/blob/3e5a2dbad73ff61d27db8750480e2c0b52133676/nova/virt/libvirt/driver.py#L2818-L2825 | |
| 15:14:09 | gibi | so when the detach checks that the device is really gone it uses a callable to query the device from libvirt, and that callable has two modes for disks | |
| 15:15:07 | gibi | so the question is do we ever create a partiall callable from _get_guest_disk_device in a way that volume_uuid is not provided | |
| 15:15:18 | gibi | and passing that to detach | |
| 15:16:10 | gibi | https://github.com/openstack/nova/blob/3e5a2dbad73ff61d27db8750480e2c0b52133676/nova/virt/libvirt/driver.py#L2856-L2864 | |
| 15:16:27 | gibi | if volume_uuid is not None here then we will go with the alias path for sure during detach | |
| 15:17:35 | gibi | unfortunately the code might return non for that volume id above | |
| 15:17:39 | gibi | https://github.com/openstack/nova/blob/3e5a2dbad73ff61d27db8750480e2c0b52133676/nova/virt/block_device.py#L1031 | |
| 15:19:11 | gibi | it feels strange that we don't have a connectin_info for a disk we want to detach, but I have no proof that we always have | |
| 15:19:14 | gibi | so meh | |
| 15:43:28 | stephenfin | sorry, got distracted by CI woes elsewhere /o\ | |
| 15:46:15 | stephenfin | I suspect libvirt might auto-generate aliases (without the ua- prefix) if a user doesn't provide one. That would explain why we need the ua- prefix in the first place. Just trying to find the smoking gun for that | |
| 15:47:16 | stephenfin | If so, I think that instead of not setting an alias, tests like that should be setting a non-ua prefixed alias | |
| 15:50:31 | gibi | the problem in my eyes that the code might use a non-alias based device lookup that depends on if the volume id is available for the disk being detached or not | |