| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2025-12-18 | |||
| 15:04:09 | gibi | that is independent from the device having an alias in libvirt | |
| 15:04:50 | stephenfin | right, but will be ever attempt to detach without using an alias, given an alias is always present? | |
| 15:04:58 | stephenfin | and if not, does that mean that code is dead code? | |
| 15:06:08 | stephenfin | fwiw, the context of this a rework of the mypy configuration that I'm working on: mypy is complaining because create_waiter expects the dev.alias arg to be a string (which I think is correct) but our tests explicitly set it to null is some places | |
| 15:13:16 | gibi | this is where the two codepath is coming from https://github.com/openstack/nova/blob/3e5a2dbad73ff61d27db8750480e2c0b52133676/nova/virt/libvirt/driver.py#L2818-L2825 | |
| 15:14:09 | gibi | so when the detach checks that the device is really gone it uses a callable to query the device from libvirt, and that callable has two modes for disks | |
| 15:15:07 | gibi | so the question is do we ever create a partiall callable from _get_guest_disk_device in a way that volume_uuid is not provided | |
| 15:15:18 | gibi | and passing that to detach | |
| 15:16:10 | gibi | https://github.com/openstack/nova/blob/3e5a2dbad73ff61d27db8750480e2c0b52133676/nova/virt/libvirt/driver.py#L2856-L2864 | |
| 15:16:27 | gibi | if volume_uuid is not None here then we will go with the alias path for sure during detach | |
| 15:17:35 | gibi | unfortunately the code might return non for that volume id above | |
| 15:17:39 | gibi | https://github.com/openstack/nova/blob/3e5a2dbad73ff61d27db8750480e2c0b52133676/nova/virt/block_device.py#L1031 | |
| 15:19:11 | gibi | it feels strange that we don't have a connectin_info for a disk we want to detach, but I have no proof that we always have | |
| 15:19:14 | gibi | so meh | |
| 15:43:28 | stephenfin | sorry, got distracted by CI woes elsewhere /o\ | |
| 15:46:15 | stephenfin | I suspect libvirt might auto-generate aliases (without the ua- prefix) if a user doesn't provide one. That would explain why we need the ua- prefix in the first place. Just trying to find the smoking gun for that | |
| 15:47:16 | stephenfin | If so, I think that instead of not setting an alias, tests like that should be setting a non-ua prefixed alias | |
| 15:50:31 | gibi | the problem in my eyes that the code might use a non-alias based device lookup that depends on if the volume id is available for the disk being detached or not | |
| 15:51:09 | gibi | so to get rid of the extra codepath you would need to ensure that the code always uses an alias and not a device path for lookup | |
| 15:51:28 | opendevreview | Balazs Gibizer proposed openstack/nova master: Do not mock threading.Event.wait https://review.opendev.org/c/openstack/nova/+/971448 | |
| 15:51:56 | gibi | Uggla: gmaan: ^^ that is the fix for the py312-threading instability | |
| 15:52:17 | gibi | I will push some followups as well to prevent it to happen again | |
| 16:23:50 | gmaan | gibi: ack. will check | |
| 16:25:05 | stephenfin | gibi: https://github.com/libvirt/libvirt/blob/dad8b0fc527b37e072d8baaace45ae6a29394f27/src/qemu/qemu_alias.c#L692-L786 | |
| 16:25:14 | stephenfin | devices will *always* have an alias | |
| 16:25:27 | stephenfin | but that may or may not be user-defined | |
| 16:28:30 | stephenfin | ...and has done so for a very long time (I went back as far as 2010 and decided that was good enough :)) | |
| 16:42:53 | opendevreview | Stephen Finucane proposed openstack/nova master: trivial: Use functools.wraps https://review.opendev.org/c/openstack/nova/+/971450 | |
| 16:42:53 | opendevreview | Stephen Finucane proposed openstack/nova master: tests: Set disk alias in libvirt fixture https://review.opendev.org/c/openstack/nova/+/971451 | |
| 16:42:54 | opendevreview | Stephen Finucane proposed openstack/nova master: tests: Always set device aliases https://review.opendev.org/c/openstack/nova/+/971452 | |
| 16:43:08 | stephenfin | and there are fixes for tests and a runtime check so we fail early | |
| 16:50:59 | gibi | stephenfin: if the device's alias is not set by nova, can nova still know that alias and can use it to look up the device? | |
| 16:52:08 | stephenfin | that I don't know, so I have touched the detach code otherwise | |
| 16:53:01 | stephenfin | I just know that we need *an* alias for the device event handler, and that we will always *an* alias | |
| 16:53:02 | gibi | OK so you are not removing the fallback code path. Then I think it is OK | |
| 16:53:33 | opendevreview | Balazs Gibizer proposed openstack/nova master: [hacking]Do not mock threading.Event.wait https://review.opendev.org/c/openstack/nova/+/971454 | |
| 17:23:53 | opendevreview | Merged openstack/nova master: Do not mock threading.Event.wait https://review.opendev.org/c/openstack/nova/+/971448 | |
| 17:33:01 | gmaan | gibi: +1 on hacking rule, but it seems it needs to be fixed in other places also and we should see how much time it increase unless you add some timeout like you did for detach | |
| 17:34:16 | gibi | gmaan: yepp I'm on it | |
| 17:34:33 | gmaan | k | |
| 17:34:44 | gibi | fixed most of it locally there is one that needs more attention tomorrow | |
| 17:35:25 | gmaan | ++ | |
| 17:40:30 | opendevreview | Balazs Gibizer proposed openstack/nova master: [hacking]Do not mock threading.Event.wait https://review.opendev.org/c/openstack/nova/+/971454 | |
| 17:40:49 | gibi | ^^ I pushed it but it still has one functional test that needs a fix now | |
| 17:40:58 | gibi | anyhow that is all from me today. o/ | |
| 17:41:38 | gmaan | k, o/ | |
| 17:45:05 | sean-k-mooney | gibi: is that the cause fo the race? | |
| 17:45:55 | sean-k-mooney | by the way i have not mention my ai code review ci job much lately | |
| 17:46:24 | sean-k-mooney | but one of the thing im plannign to impelment next year is making it read and follow the guidnce in HACKING.rst if that file exsits in a repo | |
| 17:52:50 | opendevreview | Stephen Finucane proposed openstack/nova master: libvirt: Ensure device alias is present https://review.opendev.org/c/openstack/nova/+/971452 | |
| 17:59:13 | opendevreview | Stephen Finucane proposed openstack/nova master: libvirt: Remove import hacks https://review.opendev.org/c/openstack/nova/+/971460 | |
| 18:10:17 | JayF | If folks have time, https://review.opendev.org/c/openstack/nova/+/969321 could still use a review. Follow-up for a previous bugfix. | |
| 22:39:53 | opendevreview | Merged openstack/nova master: Remove tpool_execute as it is unused https://review.opendev.org/c/openstack/nova/+/966552 | |
| 23:37:07 | sean-k-mooney | gmaan: stephenfin i finsihed the openapi serice. i think they are mostly all readytto merge. | |
| 23:38:52 | sean-k-mooney | im finsihing for the year now | |
| 23:39:09 | sean-k-mooney | JayF: the use of ddt looks fine to me too | |
| 23:39:50 | JayF | sean-k-mooney: honestly I care more about unifying those states files, I have an ironic-side commit waiting with a comment to keep 'em synced | |
| #openstack-nova - 2025-12-19 | |||
| 07:32:02 | opendevreview | huanhongda proposed openstack/nova master: WIP: NUMA fit instance to host with cpu/ram_allocation_ratio https://review.opendev.org/c/openstack/nova/+/971409 | |
| 07:43:03 | opendevreview | Nicolai Ruckel proposed openstack/nova master: Preserve UEFI NVRAM variable store https://review.opendev.org/c/openstack/nova/+/959682 | |
| 07:46:18 | nicolairuckel | sean-k-mooney: I removed all the unfinished code regarding the cold migration as you suggested. The only unresolved comment is the one from Takashi Kajinami now but I *think* this would concern the next patch and not this one. | |
| 13:53:10 | opendevreview | Balazs Gibizer proposed openstack/nova master: [hacking]Do not mock threading.Event.wait https://review.opendev.org/c/openstack/nova/+/971454 | |
| 15:33:58 | opendevreview | Balazs Gibizer proposed openstack/nova master: Libvirt event handling without eventlet https://review.opendev.org/c/openstack/nova/+/965949 | |
| 15:33:59 | opendevreview | Balazs Gibizer proposed openstack/nova master: Run nova-compute in native threading mode https://review.opendev.org/c/openstack/nova/+/965467 | |
| 15:36:16 | opendevreview | Balazs Gibizer proposed openstack/nova master: Run nova-compute in native threading mode https://review.opendev.org/c/openstack/nova/+/965467 | |
| 16:05:17 | opendevreview | Balazs Gibizer proposed openstack/nova master: Enable mypy on nova/utils.py https://review.opendev.org/c/openstack/nova/+/969936 | |
| 16:11:06 | gmaan | sean-k-mooney: ack, yeah, I am working next week and will try to catch up on that | |
| 18:32:03 | opendevreview | Stephen Finucane proposed openstack/nova master: libvirt: Remove import hacks https://review.opendev.org/c/openstack/nova/+/971460 | |
| #openstack-nova - 2025-12-22 | |||
| 08:59:56 | opendevreview | Artem Vasilyev proposed openstack/nova master: Fix functional tests and mypy on macOS https://review.opendev.org/c/openstack/nova/+/937727 | |
| 14:11:01 | opendevreview | Dmitriy Chubinidze proposed openstack/nova master: doc: Enabling of using LibvirtDriver for compute node https://review.opendev.org/c/openstack/nova/+/939325 | |
| 15:11:13 | opendevreview | Dmitriy Chubinidze proposed openstack/nova master: doc: Enabling of using LibvirtDriver for compute node https://review.opendev.org/c/openstack/nova/+/939325 | |
| 15:39:14 | opendevreview | Dmitriy Chubinidze proposed openstack/nova master: doc: Enabling of using LibvirtDriver for compute node https://review.opendev.org/c/openstack/nova/+/939325 | |
| 16:45:37 | opendevreview | Zhan Zhang proposed openstack/nova-specs master: Refine network setup procedure in live migrations https://review.opendev.org/c/openstack/nova-specs/+/970298 | |
| 16:55:42 | opendevreview | Zhan Zhang proposed openstack/nova-specs master: Refine network setup procedure in live migrations https://review.opendev.org/c/openstack/nova-specs/+/970298 | |
| #openstack-nova - 2025-12-23 | |||
| 12:30:32 | opendevreview | huanhongda proposed openstack/nova master: WIP: NUMA fit instance to host with cpu/ram_allocation_ratio https://review.opendev.org/c/openstack/nova/+/971409 | |
| #openstack-nova - 2025-12-24 | |||
| 01:07:21 | opendevreview | Ghanshyam proposed openstack/nova master: PoC: Graceful shutodwn of nova services https://review.opendev.org/c/openstack/nova/+/967261 | |
| 01:37:52 | opendevreview | Ghanshyam proposed openstack/nova master: Fix ProviderTree copying with threading Lock https://review.opendev.org/c/openstack/nova/+/956091 | |
| 01:37:52 | opendevreview | Ghanshyam proposed openstack/nova master: [test]Further categorization of disabled unit tests https://review.opendev.org/c/openstack/nova/+/956092 | |
| 01:37:53 | opendevreview | Ghanshyam proposed openstack/nova master: Do not fork compute workers in native threading mode https://review.opendev.org/c/openstack/nova/+/965466 | |
| 01:37:53 | opendevreview | Ghanshyam proposed openstack/nova master: Compute manager to use thread pools selectively https://review.opendev.org/c/openstack/nova/+/966016 | |
| 01:37:54 | opendevreview | Ghanshyam proposed openstack/nova master: Libvirt event handling without eventlet https://review.opendev.org/c/openstack/nova/+/965949 | |
| 01:37:54 | opendevreview | Ghanshyam proposed openstack/nova master: Run nova-compute in native threading mode https://review.opendev.org/c/openstack/nova/+/965467 | |
| 01:37:55 | opendevreview | Ghanshyam proposed openstack/nova master: PoC: Graceful shutodwn of nova services https://review.opendev.org/c/openstack/nova/+/967261 | |
| 10:09:17 | opendevreview | Will Szumski proposed openstack/nova master: WIP: Adds regression test for bug LP#2132984 https://review.opendev.org/c/openstack/nova/+/969380 | |
| 10:09:17 | opendevreview | Will Szumski proposed openstack/nova master: WIP: Fix race betweem instance claim and anti affinity check https://review.opendev.org/c/openstack/nova/+/969894 | |
| 16:32:34 | gmaan | gibi: once you are online and notice, i rebased the eventlet series to make graceful shutdown changes on top of it (implementing and testing on top of compute service in threading mode also). It was giving me merge conflict so need to rebase eventlet series also. | |
| 17:41:54 | opendevreview | Will Szumski proposed openstack/nova master: Adds regression test for bug LP#2132984 https://review.opendev.org/c/openstack/nova/+/969380 | |
| 17:41:55 | opendevreview | Will Szumski proposed openstack/nova master: Fix race betweem instance claim and anti affinity check https://review.opendev.org/c/openstack/nova/+/969894 | |
| #openstack-nova - 2025-12-26 | |||
| 06:05:35 | opendevreview | Takashi Kajinami proposed openstack/nova master: Use oslo.utils to parse cell URL https://review.opendev.org/c/openstack/nova/+/971810 | |
| 06:07:14 | opendevreview | Takashi Kajinami proposed openstack/nova master: Use oslo.utils to parse cell URL https://review.opendev.org/c/openstack/nova/+/971810 | |
| 06:36:04 | opendevreview | Rajesh Tailor proposed openstack/nova master: Standardize nova-manage options to use hyphens https://review.opendev.org/c/openstack/nova/+/971811 | |
| #openstack-nova - 2025-12-29 | |||
| 10:19:57 | zigo | FYI, nova test_matchers.py is incompatible with testtools 2.8.2: | |
| 10:19:57 | zigo | bugs.debian.org/1124185 | |
| 10:19:57 | zigo | I've patched the test_matchers.py with the help of chatgpt, so I wouldn't recommend importing my patch, though i'd be good if somone had a (deeper) look. | |
| 10:29:24 | zigo | Also, I'd appreciate reviews on https://review.opendev.org/c/openstack/nova/+/969745 | |
| 10:34:14 | opendevreview | Thomas Goirand proposed openstack/nova master: Python 3.14: fix assertRaises https://review.opendev.org/c/openstack/nova/+/971885 | |
| 14:34:56 | opendevreview | Max proposed openstack/nova master: revert: remove populate_missing_availability_zones https://review.opendev.org/c/openstack/nova/+/971894 | |
| #openstack-nova - 2025-12-31 | |||
| 17:56:57 | opendevreview | Will Szumski proposed openstack/nova master: Adds regression test for bug LP#2132984 https://review.opendev.org/c/openstack/nova/+/969380 | |
| 17:58:56 | opendevreview | Will Szumski proposed openstack/nova master: Fix race betweem instance claim and anti affinity check https://review.opendev.org/c/openstack/nova/+/969894 | |
| 18:10:30 | opendevreview | Will Szumski proposed openstack/nova master: Adds regression test for bug LP#2132984 https://review.opendev.org/c/openstack/nova/+/969380 | |
| 18:10:31 | opendevreview | Will Szumski proposed openstack/nova master: Fix race between instance claim and anti affinity check https://review.opendev.org/c/openstack/nova/+/969894 | |