| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2025-12-01 | |||
| 16:54:34 | sean-k-mooney | so im ok with moving forward with that and we can disucss more in the impelation if that what we want ot keep | |
| 16:55:08 | sean-k-mooney | i dont think i was able to attend the ptg session so i dont know the geneal outcome of that | |
| 16:55:35 | sean-k-mooney | but if that was the general feeling cool | |
| 16:56:50 | Uggla | ok | |
| 16:57:01 | Uggla | something else to discuss ? | |
| 16:57:15 | kgube | Hi, just wanted to mention again that I rewrote my spec to address the input from the the PTG, and I would be happy to get any feedback on it: https://review.opendev.org/c/openstack/nova-specs/+/949504 | |
| 16:58:52 | sean-k-mooney | kgube: its been a while but all the cinder bits are in placean right and you need the nova aprt to be added with teh call back to cinder before the end to end fucntionality works | |
| 16:59:44 | sean-k-mooney | kgube: i belive there was a quition on the cidner side about how long to wiat for nova is that still an open? | |
| 17:00:33 | sean-k-mooney | ill admin i have not looked at your spec slicne last cycle so perhaps that already captured. | |
| 17:01:10 | kgube | sean-k-mooney: i have had to rewrite it significantly | |
| 17:01:47 | sean-k-mooney | ok so we shoudl read it fresh rather then a repoposal | |
| 17:02:19 | kgube | sean-k-mooney: there was some fundamental critique on using the external server event to trigger the extend operatoion | |
| 17:02:39 | kgube | so it now it proposes a new API | |
| 17:03:02 | kgube | for that purpose. So yes, it's basically a new spec. | |
| 17:04:28 | sean-k-mooney | ok soyour mirroing the exsitng os-assisted-volume-snapshots aprpoch aby adding /assisted-volume-extend | |
| 17:04:47 | kgube | yes | |
| 17:04:52 | sean-k-mooney | i tought we dicsued that last cycle by maybe i imgangied that | |
| 17:05:07 | sean-k-mooney | i dont know if other have had a change to look at it or have any questions? | |
| 17:05:15 | sean-k-mooney | we are over time for the meeting | |
| 17:06:06 | Uggla | yep, we need to move on. | |
| 17:06:22 | sean-k-mooney | skiming it the new spec seam sto elimianate a rondtrip to cinder and a race condtion so over all it sound liek an improvmeent | |
| 17:06:22 | Uggla | #topic Bug scrubbing | |
| 17:06:35 | Uggla | #info up to 199 (+1) | |
| 17:06:41 | Uggla | #link: https://etherpad.opendev.org/p/nova-bug-triage-roster | |
| 17:06:49 | Uggla | #info 2 bugs assigned to each volunteer. | |
| 17:07:42 | Uggla | so we can start to deal again with all these open bugs. | |
| 17:07:51 | Uggla | Thanks for the volunteers btw. | |
| 17:08:13 | Uggla | As mentioned we are over time, so time to close. | |
| 17:08:24 | Uggla | Thanks for joining this meeting. Have a nice day/evening. | |
| 17:08:28 | Uggla | #endmeeting | |
| 17:08:28 | opendevmeet | Meeting ended Mon Dec 1 17:08:28 2025 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) | |
| 17:08:28 | opendevmeet | Minutes: https://meetings.opendev.org/meetings/nova/2025/nova.2025-12-01-16.04.html | |
| 17:08:28 | opendevmeet | Minutes (text): https://meetings.opendev.org/meetings/nova/2025/nova.2025-12-01-16.04.txt | |
| 17:08:28 | opendevmeet | Log: https://meetings.opendev.org/meetings/nova/2025/nova.2025-12-01-16.04.log.html | |
| 17:08:34 | elodilles | thanks o/ | |
| 17:10:08 | tkajinam | thanks ! | |
| 17:30:35 | gibi | Uggla: thanks. I will check the bugs assigned for triage o/ | |
| 17:45:18 | opendevreview | Takashi Kajinami proposed openstack/nova master: libvirt: Add capability to load ssm feature from existing xml https://review.opendev.org/c/openstack/nova/+/969131 | |
| 17:45:19 | opendevreview | Takashi Kajinami proposed openstack/nova master: libvirt: Use firmeare auto-selection by libvirt https://review.opendev.org/c/openstack/nova/+/969132 | |
| 17:58:05 | opendevreview | Takashi Kajinami proposed openstack/nova master: Use consistent program name for wsgi scripts and entry points https://review.opendev.org/c/openstack/nova/+/942605 | |
| #openstack-nova - 2025-12-02 | |||
| 02:15:33 | opendevreview | Takashi Kajinami proposed openstack/nova master: libvirt: Add capability to load loader and nvram from xml https://review.opendev.org/c/openstack/nova/+/969086 | |
| 02:15:34 | opendevreview | Takashi Kajinami proposed openstack/nova master: libvirt: Add capability to load ssm feature from existing xml https://review.opendev.org/c/openstack/nova/+/969131 | |
| 02:15:34 | opendevreview | Takashi Kajinami proposed openstack/nova master: libvirt: Use firmeare auto-selection by libvirt https://review.opendev.org/c/openstack/nova/+/969132 | |
| 04:55:30 | opendevreview | Ghanshyam proposed openstack/nova-specs master: Add backlog spec for Graceful shutodwn of nova services https://review.opendev.org/c/openstack/nova-specs/+/967469 | |
| 04:58:26 | opendevreview | Takashi Kajinami proposed openstack/nova master: libvirt: Use firmeare auto-selection by libvirt https://review.opendev.org/c/openstack/nova/+/969132 | |
| 08:02:14 | opendevreview | Ahmad Hassan proposed openstack/nova-specs master: Offline VM migration using https https://review.opendev.org/c/openstack/nova-specs/+/964444 | |
| 08:03:16 | opendevreview | Ahmad Hassan proposed openstack/nova-specs master: Cold VM migration using Webdav https https://review.opendev.org/c/openstack/nova-specs/+/964444 | |
| 08:10:05 | DominikDanelski[m] | Hi, it's my first patch to the self-filled bug report, so I don't fully get the process. Should I just wait or ask someone responsible to verify my approach? I refer to https://bugs.launchpad.net/nova/+bug/2132020 and https://review.opendev.org/c/openstack/nova/+/968446 | |
| 09:11:11 | frickler | DominikDanelski[m]: in general, you do not need to do anything further, reviewers should find your submission and give feedback. if that doesn't happen in a timely manner, you can ask here or maybe in the weekly meeting (also happening in this channel on Mondays) | |
| 09:45:11 | DominikDanelski[m] | frickler: Thank you. I understand that there's probably no fixed timeline, but approximately when should I reach back? | |
| 09:48:20 | frickler | DominikDanelski[m]: well I'd be hoping that your above message could already generate enough interest, otherwise asking again in a couple of days should be fine | |
| 10:19:40 | bauzas | sean-k-mooney: if you're OK, I'll +W tkajinam's spec given we already discussed in the nova meeting | |
| 10:19:46 | bauzas | https://review.opendev.org/c/openstack/nova-specs/+/966584 | |
| 10:22:49 | sean-k-mooney | bauzas: sure | |
| 10:25:29 | sean-k-mooney | DominikDanelski[m]: so today we clean up the vm allocation when the errored vm is deleted | |
| 10:26:09 | sean-k-mooney | DominikDanelski[m]: im not agaist doing that eairlier if we can guarentee that vm will never be resureected | |
| 10:26:32 | sean-k-mooney | DominikDanelski[m]: my inital feedback is its greate you added a functional reguression test but you skipped a step | |
| 10:27:14 | sean-k-mooney | you added https://review.opendev.org/c/openstack/nova/+/968446/1/nova/tests/functional/regressions/test_bug_2132020.py but you ahoudl have an addtional patch before this that demonstrate the allocation is leaked then you fix patch demonstrates that its fixed | |
| 10:27:59 | sean-k-mooney | DominikDanelski[m]: would you mind creatign a secodn review to demonstrate the issue just with the regression test, then rebase your currnt patch on top | |
| 10:28:33 | sean-k-mooney | DominikDanelski[m]: on other question which quota was being exceeded? | |
| 10:29:46 | sean-k-mooney | the server quota included server in error but for all the qutoa corralted with placement allcotion the bug you described sounds valid to me | |
| 10:31:28 | sean-k-mooney | or put another way, its correct for the instance to go to error if a quota would be exceeded but its also correct that we should free the placement allcoation for that instance provide we burry the instance in cell0 or otherwise make sure instnace.host is not set | |
| 10:32:16 | opendevreview | Merged openstack/nova-specs master: libvirt: Use built-in firmware auto-selection for UEFI firmware https://review.opendev.org/c/openstack/nova-specs/+/966584 | |
| 11:22:02 | opendevreview | Konrad Gube proposed openstack/nova-specs master: Propose assisted-volume-extend API https://review.opendev.org/c/openstack/nova-specs/+/949504 | |
| 11:48:15 | DominikDanelski[m] | sean-k-mooney: Thank you for the review. 1. I observed DISK_GB quota violation leaving non-disk allocations. 2. As for the instance.host, I understand from https://opendev.org/openstack/nova/src/branch/master/nova/tests/functional/regressions/test_bug_1806064.py#L119 that it should already be unset at that stage. 3. Could you expand on the second review? Should I create a completely new review attached (via Closes-Bug) to the | |
| 11:48:15 | DominikDanelski[m] | bug-report with my regression test but without the fix, wait for the pipelines to fail, and only then update it with the fix? | |
| 12:00:27 | sean-k-mooney | DominikDanelski[m]: our standard process for buts is to create an intiall review that demonstrate the bug ideally with a fuctional regression test. in this case teh one you created is good but instead of asserting the allcotion is deleted you will assert that its not cleaned up. we will merge that commit to demonstrate teh issue and in a second commit and review we fix the | |
| 12:00:29 | sean-k-mooney | bug. normally when we create teh repoducer regress test we comment out an assert that demonstrated the desire behvaior so that when you fix the issue all you have to do is uncommnet the assert that demonstrates the desired behavior and delete the assert that demostrates the bug | |
| 12:01:29 | sean-k-mooney | DominikDanelski[m]: in other words for most bug fixes we try to have 2 commits and 2 reviews the first commits shows what broken and hte scond commit fixes the issue and updates the regression test to assert the correct behvior | |
| 12:02:23 | sean-k-mooney | we do not need ot wait for the first patch to merge to propose and review the second, we often propsoe and review them at the same time | |
| 12:04:56 | DominikDanelski[m] | All right, but in the end that's still the same regression test in functional/regressions, just with the changed assertions as you described above? | |
| 12:05:41 | DominikDanelski[m] | I think I get the process, I'll create the second review. Should it also be marked with Closes-Bug or something else since it doesn't really fix it? | |
| 12:06:32 | sean-k-mooney | the repoducer patch shoudl have either Partial-Bug: or Related-Bug: | |
| 12:06:47 | sean-k-mooney | the fix should have Closes-Bug: | |
| 12:07:20 | sean-k-mooney | i thend to use Related-Bug for the repoducer | |
| 12:07:37 | sean-k-mooney | Partial-Bug is more for the case that the bugfix requries multiple commits to fix | |
| 12:07:55 | sean-k-mooney | but either woudl be fine | |
| 12:08:20 | sean-k-mooney | only once commit should have Closes-Bug and that shoudl be the final commit in the series | |
| 12:08:50 | sean-k-mooney | well assuming the last commit is the one that actully fixes the bug :) | |
| 12:09:36 | sean-k-mooney | DominikDanelski[m]: and yes its still the saem regression test in the repoducer patch | |
| 12:11:39 | sean-k-mooney | the logic behaind this approch is to prove that your patch is correct and fixes the problem that was reported by first repoducing it, if yoru fix patch did nto require the regression test to be updated then it woudl show either it does not fix the problem or the regression test was orginally incorrect or incomplete | |
| 12:17:56 | DominikDanelski[m] | sean-k-mooney: Understood, thank you! | |
| 13:13:58 | opendevreview | sean mooney proposed openstack/nova-specs master: Repropose and update cyborg vGPU (mdev) support https://review.opendev.org/c/openstack/nova-specs/+/967515 | |
| 14:11:41 | opendevreview | sean mooney proposed openstack/nova-specs master: Repropose and update cyborg vGPU (mdev) support https://review.opendev.org/c/openstack/nova-specs/+/967515 | |
| 14:24:20 | opendevreview | Dominik proposed openstack/nova master: Regression test for Placement allocations remaining during failed schedule (bug #2132020) https://review.opendev.org/c/openstack/nova/+/969251 | |
| 14:28:38 | DominikDanelski[m] | sean-k-mooney: That's the one. If you find time, please tell me if that's what you intended and if the bug reference in the commit message is too redundant. | |
| 14:33:36 | opendevreview | Takashi Kajinami proposed openstack/nova master: libvirt: Use firmeare auto-selection by libvirt https://review.opendev.org/c/openstack/nova/+/969132 | |
| 14:37:41 | opendevreview | Dhruv Shah proposed openstack/nova master: [trivial][doc] Fix auth_url definitions in install guides https://review.opendev.org/c/openstack/nova/+/969253 | |
| 14:41:22 | opendevreview | Dhruv Shah proposed openstack/nova master: [trivial][doc] Fix auth_url definitions in install guides https://review.opendev.org/c/openstack/nova/+/969253 | |
| 15:03:23 | opendevreview | Takashi Kajinami proposed openstack/nova master: libvirt: Use firmeare auto-selection by libvirt https://review.opendev.org/c/openstack/nova/+/969132 | |
| 15:35:09 | opendevreview | Takashi Kajinami proposed openstack/nova master: libvirt: Add basic xml generation for firmware auto selection https://review.opendev.org/c/openstack/nova/+/969085 | |
| 15:35:09 | opendevreview | Takashi Kajinami proposed openstack/nova master: libvirt: Add capability to load loader and nvram from xml https://review.opendev.org/c/openstack/nova/+/969086 | |
| 15:35:10 | opendevreview | Takashi Kajinami proposed openstack/nova master: libvirt: Add capability to load ssm feature from existing xml https://review.opendev.org/c/openstack/nova/+/969131 | |
| 15:35:10 | opendevreview | Takashi Kajinami proposed openstack/nova master: libvirt: Use firmeare auto-selection by libvirt https://review.opendev.org/c/openstack/nova/+/969132 | |
| 15:35:11 | opendevreview | Takashi Kajinami proposed openstack/nova master: libvirt: Extend functional test coverage of UEFI boot guests https://review.opendev.org/c/openstack/nova/+/969263 | |
| 16:07:12 | melwitt | gibi: hey, I had pushed an update to https://review.opendev.org/c/openstack/nova/+/964848 that you reviewed to add a reno, fyi when you get a chance | |
| 16:09:14 | dansmith | oh yeah I want to hit that too | |
| 16:34:48 | opendevreview | sean mooney proposed openstack/nova-specs master: add spec for resouce notifications https://review.opendev.org/c/openstack/nova-specs/+/967712 | |
| 16:35:13 | opendevreview | Ivan Anfimov proposed openstack/nova master: Remove openSUSE/SLES from install guide https://review.opendev.org/c/openstack/nova/+/949324 | |
| 16:35:17 | opendevreview | Ivan Anfimov proposed openstack/nova master: Remove openSUSE/SLES from install guide https://review.opendev.org/c/openstack/nova/+/949324 | |