| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2025-12-02 | |||
| 09:45:11 | DominikDanelski[m] | frickler: Thank you. I understand that there's probably no fixed timeline, but approximately when should I reach back? | |
| 09:48:20 | frickler | DominikDanelski[m]: well I'd be hoping that your above message could already generate enough interest, otherwise asking again in a couple of days should be fine | |
| 10:19:40 | bauzas | sean-k-mooney: if you're OK, I'll +W tkajinam's spec given we already discussed in the nova meeting | |
| 10:19:46 | bauzas | https://review.opendev.org/c/openstack/nova-specs/+/966584 | |
| 10:22:49 | sean-k-mooney | bauzas: sure | |
| 10:25:29 | sean-k-mooney | DominikDanelski[m]: so today we clean up the vm allocation when the errored vm is deleted | |
| 10:26:09 | sean-k-mooney | DominikDanelski[m]: im not agaist doing that eairlier if we can guarentee that vm will never be resureected | |
| 10:26:32 | sean-k-mooney | DominikDanelski[m]: my inital feedback is its greate you added a functional reguression test but you skipped a step | |
| 10:27:14 | sean-k-mooney | you added https://review.opendev.org/c/openstack/nova/+/968446/1/nova/tests/functional/regressions/test_bug_2132020.py but you ahoudl have an addtional patch before this that demonstrate the allocation is leaked then you fix patch demonstrates that its fixed | |
| 10:27:59 | sean-k-mooney | DominikDanelski[m]: would you mind creatign a secodn review to demonstrate the issue just with the regression test, then rebase your currnt patch on top | |
| 10:28:33 | sean-k-mooney | DominikDanelski[m]: on other question which quota was being exceeded? | |
| 10:29:46 | sean-k-mooney | the server quota included server in error but for all the qutoa corralted with placement allcotion the bug you described sounds valid to me | |
| 10:31:28 | sean-k-mooney | or put another way, its correct for the instance to go to error if a quota would be exceeded but its also correct that we should free the placement allcoation for that instance provide we burry the instance in cell0 or otherwise make sure instnace.host is not set | |
| 10:32:16 | opendevreview | Merged openstack/nova-specs master: libvirt: Use built-in firmware auto-selection for UEFI firmware https://review.opendev.org/c/openstack/nova-specs/+/966584 | |
| 11:22:02 | opendevreview | Konrad Gube proposed openstack/nova-specs master: Propose assisted-volume-extend API https://review.opendev.org/c/openstack/nova-specs/+/949504 | |
| 11:48:15 | DominikDanelski[m] | sean-k-mooney: Thank you for the review. 1. I observed DISK_GB quota violation leaving non-disk allocations. 2. As for the instance.host, I understand from https://opendev.org/openstack/nova/src/branch/master/nova/tests/functional/regressions/test_bug_1806064.py#L119 that it should already be unset at that stage. 3. Could you expand on the second review? Should I create a completely new review attached (via Closes-Bug) to the | |
| 11:48:15 | DominikDanelski[m] | bug-report with my regression test but without the fix, wait for the pipelines to fail, and only then update it with the fix? | |
| 12:00:27 | sean-k-mooney | DominikDanelski[m]: our standard process for buts is to create an intiall review that demonstrate the bug ideally with a fuctional regression test. in this case teh one you created is good but instead of asserting the allcotion is deleted you will assert that its not cleaned up. we will merge that commit to demonstrate teh issue and in a second commit and review we fix the | |
| 12:00:29 | sean-k-mooney | bug. normally when we create teh repoducer regress test we comment out an assert that demonstrated the desire behvaior so that when you fix the issue all you have to do is uncommnet the assert that demonstrates the desired behavior and delete the assert that demostrates the bug | |
| 12:01:29 | sean-k-mooney | DominikDanelski[m]: in other words for most bug fixes we try to have 2 commits and 2 reviews the first commits shows what broken and hte scond commit fixes the issue and updates the regression test to assert the correct behvior | |
| 12:02:23 | sean-k-mooney | we do not need ot wait for the first patch to merge to propose and review the second, we often propsoe and review them at the same time | |
| 12:04:56 | DominikDanelski[m] | All right, but in the end that's still the same regression test in functional/regressions, just with the changed assertions as you described above? | |
| 12:05:41 | DominikDanelski[m] | I think I get the process, I'll create the second review. Should it also be marked with Closes-Bug or something else since it doesn't really fix it? | |
| 12:06:32 | sean-k-mooney | the repoducer patch shoudl have either Partial-Bug: or Related-Bug: | |
| 12:06:47 | sean-k-mooney | the fix should have Closes-Bug: | |
| 12:07:20 | sean-k-mooney | i thend to use Related-Bug for the repoducer | |
| 12:07:37 | sean-k-mooney | Partial-Bug is more for the case that the bugfix requries multiple commits to fix | |
| 12:07:55 | sean-k-mooney | but either woudl be fine | |
| 12:08:20 | sean-k-mooney | only once commit should have Closes-Bug and that shoudl be the final commit in the series | |
| 12:08:50 | sean-k-mooney | well assuming the last commit is the one that actully fixes the bug :) | |
| 12:09:36 | sean-k-mooney | DominikDanelski[m]: and yes its still the saem regression test in the repoducer patch | |
| 12:11:39 | sean-k-mooney | the logic behaind this approch is to prove that your patch is correct and fixes the problem that was reported by first repoducing it, if yoru fix patch did nto require the regression test to be updated then it woudl show either it does not fix the problem or the regression test was orginally incorrect or incomplete | |
| 12:17:56 | DominikDanelski[m] | sean-k-mooney: Understood, thank you! | |
| 13:13:58 | opendevreview | sean mooney proposed openstack/nova-specs master: Repropose and update cyborg vGPU (mdev) support https://review.opendev.org/c/openstack/nova-specs/+/967515 | |
| 14:11:41 | opendevreview | sean mooney proposed openstack/nova-specs master: Repropose and update cyborg vGPU (mdev) support https://review.opendev.org/c/openstack/nova-specs/+/967515 | |
| 14:24:20 | opendevreview | Dominik proposed openstack/nova master: Regression test for Placement allocations remaining during failed schedule (bug #2132020) https://review.opendev.org/c/openstack/nova/+/969251 | |
| 14:28:38 | DominikDanelski[m] | sean-k-mooney: That's the one. If you find time, please tell me if that's what you intended and if the bug reference in the commit message is too redundant. | |
| 14:33:36 | opendevreview | Takashi Kajinami proposed openstack/nova master: libvirt: Use firmeare auto-selection by libvirt https://review.opendev.org/c/openstack/nova/+/969132 | |
| 14:37:41 | opendevreview | Dhruv Shah proposed openstack/nova master: [trivial][doc] Fix auth_url definitions in install guides https://review.opendev.org/c/openstack/nova/+/969253 | |
| 14:41:22 | opendevreview | Dhruv Shah proposed openstack/nova master: [trivial][doc] Fix auth_url definitions in install guides https://review.opendev.org/c/openstack/nova/+/969253 | |
| 15:03:23 | opendevreview | Takashi Kajinami proposed openstack/nova master: libvirt: Use firmeare auto-selection by libvirt https://review.opendev.org/c/openstack/nova/+/969132 | |
| 15:35:09 | opendevreview | Takashi Kajinami proposed openstack/nova master: libvirt: Add basic xml generation for firmware auto selection https://review.opendev.org/c/openstack/nova/+/969085 | |
| 15:35:09 | opendevreview | Takashi Kajinami proposed openstack/nova master: libvirt: Add capability to load loader and nvram from xml https://review.opendev.org/c/openstack/nova/+/969086 | |
| 15:35:10 | opendevreview | Takashi Kajinami proposed openstack/nova master: libvirt: Add capability to load ssm feature from existing xml https://review.opendev.org/c/openstack/nova/+/969131 | |
| 15:35:10 | opendevreview | Takashi Kajinami proposed openstack/nova master: libvirt: Use firmeare auto-selection by libvirt https://review.opendev.org/c/openstack/nova/+/969132 | |
| 15:35:11 | opendevreview | Takashi Kajinami proposed openstack/nova master: libvirt: Extend functional test coverage of UEFI boot guests https://review.opendev.org/c/openstack/nova/+/969263 | |
| 16:07:12 | melwitt | gibi: hey, I had pushed an update to https://review.opendev.org/c/openstack/nova/+/964848 that you reviewed to add a reno, fyi when you get a chance | |
| 16:09:14 | dansmith | oh yeah I want to hit that too | |
| 16:34:48 | opendevreview | sean mooney proposed openstack/nova-specs master: add spec for resouce notifications https://review.opendev.org/c/openstack/nova-specs/+/967712 | |
| 16:35:13 | opendevreview | Ivan Anfimov proposed openstack/nova master: Remove openSUSE/SLES from install guide https://review.opendev.org/c/openstack/nova/+/949324 | |
| 16:35:17 | opendevreview | Ivan Anfimov proposed openstack/nova master: Remove openSUSE/SLES from install guide https://review.opendev.org/c/openstack/nova/+/949324 | |
| 16:35:42 | opendevreview | Ivan Anfimov proposed openstack/nova master: Remove openSUSE/SLES from install guide https://review.opendev.org/c/openstack/nova/+/949324 | |
| 16:37:48 | opendevreview | Ivan Anfimov proposed openstack/nova master: docs: update installation documentation https://review.opendev.org/c/openstack/nova/+/938680 | |
| 16:37:52 | opendevreview | Ivan Anfimov proposed openstack/nova master: docs: update installation documentation https://review.opendev.org/c/openstack/nova/+/938680 | |
| 18:14:43 | opendevreview | Ghanshyam proposed openstack/nova-specs master: Add backlog spec for Graceful shutodwn of nova services https://review.opendev.org/c/openstack/nova-specs/+/967469 | |
| 19:01:45 | opendevreview | Lajos Katona proposed openstack/nova master: Use SDK for Neutron networks https://review.opendev.org/c/openstack/nova/+/928022 | |
| 19:01:46 | opendevreview | Lajos Katona proposed openstack/nova master: Use SDK for Neutron subnets https://review.opendev.org/c/openstack/nova/+/962190 | |
| 19:01:46 | opendevreview | Lajos Katona proposed openstack/nova master: Use SDK for Neutron extensions https://review.opendev.org/c/openstack/nova/+/962270 | |
| 19:01:47 | opendevreview | Lajos Katona proposed openstack/nova master: Use SDK for Neutron floating IPs https://review.opendev.org/c/openstack/nova/+/962604 | |
| 19:01:47 | opendevreview | Lajos Katona proposed openstack/nova master: WIP: Use SDK for Neutron Ports https://review.opendev.org/c/openstack/nova/+/969298 | |
| 19:05:02 | opendevreview | Ghanshyam proposed openstack/nova-specs master: Propose Spec 1 of Graceful shutodwn for 2026.1 https://review.opendev.org/c/openstack/nova-specs/+/969299 | |
| 19:05:54 | opendevreview | Ghanshyam proposed openstack/nova-specs master: Propose Spec 1 of Graceful shutodwn for 2026.1 https://review.opendev.org/c/openstack/nova-specs/+/969299 | |
| 21:35:00 | opendevreview | Jay Faulkner proposed openstack/nova master: WIP: [ironic] Use states constants from Ironic, update test for ddt https://review.opendev.org/c/openstack/nova/+/969321 | |
| 22:19:32 | opendevreview | Ghanshyam proposed openstack/nova-specs master: Add backlog spec for Graceful shutodwn of nova services https://review.opendev.org/c/openstack/nova-specs/+/967469 | |
| 22:55:47 | gmaan | gibi: dansmith sean-k-mooney ^^ updated spec for periodic tasks, please recheck | |
| 22:58:54 | opendevreview | Ghanshyam proposed openstack/nova-specs master: Propose Spec 1 of Graceful shutodwn for 2026.1 https://review.opendev.org/c/openstack/nova-specs/+/969299 | |
| 22:59:48 | gmaan | dansmith: to propose the spec1 from backlog for this cycle, I am copy the same content from backlog and proposing for this cycle spec ^^, is that right way or any other better way to propose it per cycle? | |
| 23:02:28 | gmaan | or instead of copy the whole content, we can just include a single line referring to backlog spec and tell what all it will implement? | |
| 23:27:03 | opendevreview | Ghanshyam proposed openstack/nova-specs master: Add backlog spec for Graceful shutodwn of nova services https://review.opendev.org/c/openstack/nova-specs/+/967469 | |
| #openstack-nova - 2025-12-03 | |||
| 01:45:24 | opendevreview | melanie witt proposed openstack/nova master: TPM: support instances with `deployment` secret security https://review.opendev.org/c/openstack/nova/+/942021 | |
| 01:45:24 | opendevreview | melanie witt proposed openstack/nova master: Add vtpm_secret_(uuid|value) to LibvirtLiveMigrateData https://review.opendev.org/c/openstack/nova/+/952628 | |
| 01:45:25 | opendevreview | melanie witt proposed openstack/nova master: TPM: prepare to bump service version for live migration https://review.opendev.org/c/openstack/nova/+/962051 | |
| 01:45:25 | opendevreview | melanie witt proposed openstack/nova master: TPM: support live migration of `host` secret security https://review.opendev.org/c/openstack/nova/+/941483 | |
| 01:45:26 | opendevreview | melanie witt proposed openstack/nova master: TPM: support live migration of `deployment` secret security https://review.opendev.org/c/openstack/nova/+/925771 | |
| 01:45:26 | opendevreview | melanie witt proposed openstack/nova master: TPM: test live migration between hosts with different security https://review.opendev.org/c/openstack/nova/+/952629 | |
| 01:45:27 | opendevreview | melanie witt proposed openstack/nova master: TPM: add late check for supported TPM secret security https://review.opendev.org/c/openstack/nova/+/956975 | |
| 01:45:27 | opendevreview | melanie witt proposed openstack/nova master: TPM: opt-in to new TPM secret security via resize https://review.opendev.org/c/openstack/nova/+/962052 | |
| 01:45:28 | opendevreview | melanie witt proposed openstack/nova master: DNM vtpm tempest https://review.opendev.org/c/openstack/nova/+/957477 | |
| 02:32:55 | opendevreview | Takashi Kajinami proposed openstack/nova master: libvirt: Drop redundant chown of tpm data directory https://review.opendev.org/c/openstack/nova/+/962446 | |
| 02:34:06 | opendevreview | Takashi Kajinami proposed openstack/nova master: libvirt: Extend functional test coverage of UEFI boot guests https://review.opendev.org/c/openstack/nova/+/969263 | |
| 02:34:17 | opendevreview | Takashi Kajinami proposed openstack/nova master: libvirt: Add basic xml generation for firmware auto selection https://review.opendev.org/c/openstack/nova/+/969085 | |
| 02:34:27 | opendevreview | Takashi Kajinami proposed openstack/nova master: libvirt: Add capability to load loader and nvram from xml https://review.opendev.org/c/openstack/nova/+/969086 | |
| 02:36:01 | opendevreview | Takashi Kajinami proposed openstack/nova master: libvirt: Add capability to load loader and nvram from xml https://review.opendev.org/c/openstack/nova/+/969086 | |
| 02:36:11 | opendevreview | Takashi Kajinami proposed openstack/nova master: libvirt: Add capability to load ssm feature from existing xml https://review.opendev.org/c/openstack/nova/+/969131 | |
| 02:36:22 | opendevreview | Takashi Kajinami proposed openstack/nova master: libvirt: Use firmeare auto-selection by libvirt https://review.opendev.org/c/openstack/nova/+/969132 | |
| 02:36:58 | opendevreview | Takashi Kajinami proposed openstack/nova master: libvirt: Use firmeare auto-selection by libvirt https://review.opendev.org/c/openstack/nova/+/969132 | |
| 03:37:27 | opendevreview | melanie witt proposed openstack/nova master: TPM: prepare to bump service version for live migration https://review.opendev.org/c/openstack/nova/+/962051 | |
| 03:37:27 | opendevreview | melanie witt proposed openstack/nova master: TPM: support live migration of `host` secret security https://review.opendev.org/c/openstack/nova/+/941483 | |
| 03:37:28 | opendevreview | melanie witt proposed openstack/nova master: TPM: support live migration of `deployment` secret security https://review.opendev.org/c/openstack/nova/+/925771 | |
| 03:37:28 | opendevreview | melanie witt proposed openstack/nova master: TPM: test live migration between hosts with different security https://review.opendev.org/c/openstack/nova/+/952629 | |
| 03:37:29 | opendevreview | melanie witt proposed openstack/nova master: TPM: add late check for supported TPM secret security https://review.opendev.org/c/openstack/nova/+/956975 | |
| 03:37:29 | opendevreview | melanie witt proposed openstack/nova master: TPM: opt-in to new TPM secret security via resize https://review.opendev.org/c/openstack/nova/+/962052 | |
| 03:37:30 | opendevreview | melanie witt proposed openstack/nova master: DNM vtpm tempest https://review.opendev.org/c/openstack/nova/+/957477 | |
| 11:35:58 | sean-k-mooney | DominikDanelski[m]: so you shoudl rebase on top of https://review.opendev.org/c/openstack/nova/+/969251 | |
| 11:38:50 | sean-k-mooney | i dont have time to do a detailed review but the content looks reasonable at first glance. the only think i wasould imedially say could be imporved is expelcity defining the flavor to be use dith the server. your currently relying impleictly on the behavior fo self._build_server(networks='none') so without diging inot the defautl flavor that that is usign tis not apprent why | |
| 11:38:52 | sean-k-mooney | it woudl violate quota | |
| 11:52:12 | opendevreview | Will Szumski proposed openstack/nova master: WIP: Try and reproduce nova scheduler race https://review.opendev.org/c/openstack/nova/+/969380 | |
| 12:06:57 | MaxLamprecht[m] | Hey, I have https://review.opendev.org/c/openstack/nova/+/934984(+regression test), which has already +2 by sean-mooney. Anyone available for more review/merge? | |
| 12:08:02 | MaxLamprecht[m] | * have https://review.opendev.org/c/openstack/nova/+/934984 (+regression test), | |
| 12:08:47 | MaxLamprecht[m] | Additionally I have a really small MR that adds missing db indices for better db performance. https://review.opendev.org/c/openstack/nova/+/958556 | |