Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2025-04-01
15:05:53 gibi dansmith: you probably need to extend our assert to check for the reserved value on the inventory here https://github.com/openstack/nova/blob/98226b60f3fe7b20e8d7f208c12f8d0086cd83d0/nova/tests/functional/libvirt/test_pci_sriov_servers.py#L182-L188
15:06:31 gibi as today only total and max_unit is asserted
15:07:08 Uggla Meeting in around 1h
15:08:14 dansmith ack
15:09:25 Uggla @artom, ok I have seen the cross session needs.
15:18:52 dansmith gibi: I'm not sure I can write those functional tests
15:27:06 dansmith well, the delay has messed up the joke.. I was going to say "I can't bring myself to waste enough vertical space to fit the style in that file"
15:27:52 dansmith Uggla: can we do an os-traits release to get the new one that merged this morning? we can't really test functionally until that's available in our reqs/venvs
15:29:43 Uggla @dansmith, yes I think so. I'll propose a patch for it right after the Epoxy release. Will it be ok for you ?
15:30:13 dansmith gibi: don't get me started
15:30:42 gibi :)
15:30:51 dansmith Uggla: I guess I'll put these in a separate patch since they won't pass until then. I already have a local patch to add just the trait reporting thing to a functional test, which can't work in CI until the os-traits release
15:31:07 dansmith so I'll just add some more in there and push that up with the caveat that it won't work until that releases
15:32:02 dansmith gibi: ^ re: functionals in a separate patch, at least for the moment
15:32:17 Uggla @dansmith, ok lgtm
15:32:53 gibi dansmith: works for me too
15:33:43 dansmith I had stopped looking at the functional stuff since I had to hack my local env with the trait to get even basic stuff working, but I'll just do that so I can make some progress there
15:34:13 dansmith gibi: unfortunately, the '\n' bytes are free, it's the screen real estate and the burning feeling in my eyeballs that is not
15:36:12 gibi true
15:37:53 gibi what if you add a new test_ file for otu and use your own style? I would totally accept that
15:38:34 gibi the current file is already 2000 LOC so it is reasonable to split
15:40:59 dansmith I already hate that nova has grown this very-different style from it's reasonably-consistent-just-not-machine-formatted style before this madeness
15:41:43 dansmith so further splitting and being different to all the other PCI-in-placement tests here doesn't seem beneficial, except for my eyeballs
15:42:27 dansmith I will attempt to hold my tongue and just do it, but if I can't stand it I'll split
15:42:42 dansmith I don't *think* there will be a lot of OTU tests here
15:42:48 dansmith there's just not that much to do I think
15:47:32 gibi dansmith: understood
15:47:58 gibi I'm not sure how nova kept the resonably consistent style in the past
15:48:27 gibi were there stricter reviewers back then?
15:49:13 gibi less hippy devs?
15:49:49 dansmith a lot of existing code and people copying the style that was there
15:50:24 dansmith we also had some guidelines like breaking lines with parens instead of backslashes, and several of the pep8 style guidelines which were not machine enforced
15:50:39 dansmith a lot of people wrote a lot of reasonably-consistent code before machine formatting made everything reliably ugly :)
15:55:45 Uggla Meeting in 5mn.
16:01:42 Uggla #startmeeting nova
16:01:42 opendevmeet Meeting started Tue Apr 1 16:01:42 2025 UTC and is due to finish in 60 minutes. The chair is Uggla. Information about MeetBot at http://wiki.debian.org/MeetBot.
16:01:42 opendevmeet Useful Commands: #action #agreed #help #info #idea #link #topic #startvote.
16:01:42 opendevmeet The meeting name has been set to 'nova'
16:01:50 Uggla Hello everyone
16:02:23 masahito o/
16:02:26 dansmith o/
16:02:42 gibi o/
16:02:52 sean-k-mooney o/
16:03:00 elodilles o/
16:03:41 bauzas o/
16:03:44 Uggla #topic Bugs (stuck/critical)
16:03:54 Uggla #info No Critical bug
16:04:05 Uggla #info Add yourself in the team bug roster if you want to help https://etherpad.opendev.org/p/nova-bug-triage-roster
16:04:26 Uggla anything about bugs ?
16:05:22 Uggla #topic Gate status
16:05:32 Uggla #link https://bugs.launchpad.net/nova/+bugs?field.tag=gate-failure Nova gate bugs
16:05:38 Uggla #link https://etherpad.opendev.org/p/nova-ci-failures-minimal
16:05:52 Uggla #link https://zuul.openstack.org/builds?project=openstack%2Fnova&project=openstack%2Fplacement&branch=stable%2F*&branch=master&pipeline=periodic-weekly&skip=0 Nova&Placement periodic jobs status
16:05:59 Uggla #info Please look at the gate failures and file a bug report with the gate-failure tag.
16:06:04 sean-k-mooney so technially osc-placment gate is blocked without https://review.opendev.org/c/openstack/osc-placement/+/946031
16:06:05 Uggla #info Please try to provide meaningful comment when you recheck
16:06:33 sean-k-mooney we need that on master and stable/2025.1
16:06:52 sean-k-mooney tldr without a bindep file the tox-docs job fails on noble
16:07:22 sean-k-mooney specificly because libpcre3-dev is not installed
16:07:41 sean-k-mooney it only affect the jobs so not blocking the release
16:08:08 elodilles sean-k-mooney: add me as reviewer to the stable patch and I'll +2 it o:)
16:08:29 elodilles and thanks for the fix!
16:08:44 sean-k-mooney sure. ill propsoe it once its on master. it came up when reviewing https://review.opendev.org/c/openstack/osc-placement/+/943759
16:08:51 elodilles +1
16:08:58 Uggla thx for the fix sean-k-mooney !
16:09:06 sean-k-mooney we didnt have any osc-placement change this cycle that im aware of
16:09:17 sean-k-mooney so not have release notes for a few days is pretty low impact
16:09:33 elodilles sean-k-mooney: ACK
16:09:42 sean-k-mooney so no need to rush but good to do before we forget about it
16:10:53 Uggla sure, anything else about the gate topic ?
16:11:07 sean-k-mooney not form me, we can move on i think
16:11:14 Uggla yep
16:11:14 bauzas I'll try to review the bindep patch
16:11:27 bauzas we did this before iirc
16:11:45 sean-k-mooney we had to fix a diffent bindep issue for nova
16:11:53 sean-k-mooney it was not including the test profile
16:12:01 sean-k-mooney that got fixed a few weeks ago
16:12:49 Uggla #topic Release Planning
16:12:57 Uggla #link https://releases.openstack.org/epoxy/schedule.html
16:13:25 Uggla #info Nova deadlines are set in the above schedule
16:13:38 Uggla #link 945904: 2025.1 Epoxy final releases for cycle-with-rc projects | https://review.opendev.org/c/openstack/releases/+/945904
16:13:50 Uggla #link https://releases.openstack.org/flamingo/schedule.html
16:14:05 Uggla #info Remaining post RC1: update min servion version for a SLURP or non-SLURP release : https://review.opendev.org/c/openstack/nova/+/944018/
16:14:28 Uggla #info Nova Flamingo deadlines will be discussed at the PTG.
16:15:19 Uggla Epoxy should be released tomorrow if I'm not wrong.
16:15:27 Uggla \o/
16:15:37 elodilles ~o~
16:15:41 gibi nice
16:16:13 elodilles yepp, we start the machinery tomorrow
16:16:32 Uggla btw @elodilles I have +1 the patch above.
16:16:45 elodilles thanks Uggla o/
16:18:01 Uggla #topic Review priorities
16:18:13 Uggla #info Flamingo priorities will be discussed at the PTG.
16:18:45 Uggla #topic PTG planning
16:18:53 Uggla #info Next PTG will be held on Apr 7-11
16:19:14 Uggla #link https://etherpad.opendev.org/p/nova-2025.2-ptg
16:19:55 Uggla I think we have collected all the topics, the agenda is draft for the moment. I think I will finalize it tomorrow.
16:20:38 Uggla Today, there's a new and rather unexpected topic on the table for the PTG.
16:20:45 Uggla Rumor has it that it originates from a secret TC meeting focused on improving our resilience against supply chain attacks.
16:20:52 dansmith Uggla: the glance ptl was just pinging me about a session with glance about location api and a couple other things

Earlier   Later