| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2025-02-27 | |||
| 23:48:13 | sean-k-mooney | but i think haveign empty sting woudl be fine too | |
| 23:48:43 | Callum027 | When implementing it I would probably check both for existence and empty string of the uuid field, yeah | |
| 23:49:04 | Callum027 | And in that case just set base_image_ref on the Ceilometer side to empty string to match the Nova notifications | |
| 23:49:37 | sean-k-mooney | if i was doign thei chagne i woudl also add the flavor extra spec too for my usecase | |
| 23:49:49 | sean-k-mooney | that a bit beyond what you orgnally needed | |
| 23:49:50 | Callum027 | Yep, I can do that | |
| 23:50:06 | sean-k-mooney | but my orgianl motivation was to aide in debugging | |
| 23:50:10 | Callum027 | It's beyond what I needed but it would address another major issue with Ceilometer because it needs to do a Nova API to get that info | |
| 23:50:19 | Callum027 | And adding the image UUID would eliminate that | |
| 23:50:45 | sean-k-mooney | ya so often when im looking at custoemr or upsteam bug reports | |
| 23:50:59 | sean-k-mooney | we are given the xml or a log with an error | |
| 23:51:16 | sean-k-mooney | btu we do not nessiarly have access to a db dump or the image/flavor defintions | |
| 23:51:26 | sean-k-mooney | so we ofthen have to ask for this info | |
| 23:51:44 | sean-k-mooney | just having it in the xml woudl hlep make that less painful | |
| 23:51:57 | Callum027 | Yes it would, exactly | |
| 23:52:49 | opendevreview | Takashi Kajinami proposed openstack/nova master: libvirt: Add new option to enforce multipath volume connections https://review.opendev.org/c/openstack/nova/+/845660 | |
| 23:53:14 | Callum027 | Anything else you can think of at this point in time? I'll update the blueprint and the patch in accordance with what we've discussed this afternoon | |
| 23:54:19 | sean-k-mooney | no that would solve my wishlist items too but dont feel pressrued ot extend the scope if you dont feeel it useful | |
| 23:55:33 | sean-k-mooney | if you do feel like adding that extra info and adjusting the format however i think it could be a very nice little enhancment | |
| 23:55:38 | tkajinam | sean-k-mooney dansmith bauzas, updated https://review.opendev.org/c/openstack/nova/+/845660 . thanks for the review ! | |
| 23:56:21 | Callum027 | Yes, I think there is scope to add the flavour UUID here as well, as it addressed a semi-unrelated but also significant pain point in Ceilometer's compute agent | |
| 23:57:05 | opendevreview | Merged openstack/placement master: Drop SQLALCHEMY_WARN_20 https://review.opendev.org/c/openstack/placement/+/929397 | |
| 23:57:41 | sean-k-mooney | Callum027: back in the dark old days the domain uuid did nto use to be the nova uuid either | |
| 23:58:22 | sean-k-mooney | Callum027: we added that because orgianly celiometer and thinks like colelctd had to lookup the isntance by name which was not alwasy unique | |
| 23:58:39 | sean-k-mooney | so if we can add small things to make that better and avoid more rest calls that win win | |
| 23:59:10 | sean-k-mooney | it removes load for mthe nova api and keeps things local to the agent | |
| #openstack-nova - 2025-02-28 | |||
| 00:00:25 | sean-k-mooney | tkajinam: readded my +2 | |
| 00:01:03 | sean-k-mooney | tkajinam: i think we can pretent thid mergd today and if bauzas and dansmith agree merge it tomorrow | |
| 00:01:19 | Callum027 | Yep, exactly, I'm happy to hear that. Looks like Ceilometer also does an API lookup to get `server.metadata` as well, I think I'll add that to the blueprint as well and we can call this a "add everything missing that Ceilometer needs" | |
| 00:01:51 | sean-k-mooney | so that a littel diffent | |
| 00:02:19 | sean-k-mooney | the peroblem with server.metadat is tha tcan change at any time since its the metadta proved to the end user within the metadta api | |
| 00:02:38 | sean-k-mooney | Callum027: that not exactly private data but it shoudl not really be in the xml | |
| 00:02:49 | Callum027 | Oh, that's too bad then | |
| 00:03:12 | Callum027 | In that case that might be a topic to discuss on the Ceilometer side on how to handle that in the future | |
| 00:03:26 | sean-k-mooney | we coudl perhaps dicusss that as a follow up but i susptec that woudl get pushback on privacy grounds | |
| 00:04:34 | Callum027 | Fair enough. For my use case it's not required, there might be scope to simply disable fetching that inside Ceilometer if the administrator doesn't require it, especially if it could cause privacy issues by exposing it. | |
| 00:04:39 | sean-k-mooney | Callum027: ill put it to you this way. while you would never pass a password via server metadata you might pass the lookup keey to pull applciation config form vault via metadata | |
| 00:05:28 | sean-k-mooney | Callum027: it proably shoud be configurable yes | |
| 00:05:54 | dansmith | sean-k-mooney: tkajinam I am EOD but I will be glad to look tomorrow.. That said, this seems like a bug fix (or at least mitigation) to me, so I'm not worried about merging it later | |
| 00:06:01 | Callum027 | Yep. Thanks for letting me know about that, wasn't aware of the full implications of exposing that | |
| 00:06:45 | sean-k-mooney | dansmith: enforcign multi path ya i can see that angle | |
| 00:07:24 | sean-k-mooney | i just logged in to check something so i should proably call it there too o/ | |
| 01:04:17 | opendevreview | Merged openstack/placement master: requirements: Remove setuptools https://review.opendev.org/c/openstack/placement/+/932398 | |
| 01:04:19 | opendevreview | Merged openstack/placement master: reno: Update master for unmaintained/2023.1 https://review.opendev.org/c/openstack/placement/+/935123 | |
| 01:41:34 | opendevreview | Merged openstack/placement master: Adapt cmd unit test depending on python version https://review.opendev.org/c/openstack/placement/+/939637 | |
| 01:42:55 | opendevreview | Merged openstack/nova master: Switch to using oslo.utils secretutils https://review.opendev.org/c/openstack/nova/+/939721 | |
| 01:43:04 | opendevreview | Merged openstack/nova master: Replace oslo_utils.encodeutils.exception_to_unicode https://review.opendev.org/c/openstack/nova/+/940619 | |
| 01:43:07 | opendevreview | Merged openstack/placement master: Changed OS version CentOS to CentOS Stream. https://review.opendev.org/c/openstack/placement/+/940492 | |
| 01:43:12 | opendevreview | Merged openstack/nova master: Correctly patch get_by_flavor_id https://review.opendev.org/c/openstack/nova/+/939722 | |
| 01:43:22 | opendevreview | Merged openstack/nova master: Add managed flag to PCI device specification https://review.opendev.org/c/openstack/nova/+/937649 | |
| 02:14:08 | opendevreview | Merged openstack/nova master: Add support for showing scheduler_hints in server details https://review.opendev.org/c/openstack/nova/+/938604 | |
| 02:22:58 | opendevreview | zhou zhong proposed openstack/nova master: Logging exception when query servers for further debug https://review.opendev.org/c/openstack/nova/+/942897 | |
| 02:42:55 | opendevreview | Ghanshyam proposed openstack/nova master: Fix microversion 2.96 for update/rebuild APIs https://review.opendev.org/c/openstack/nova/+/942875 | |
| 02:43:28 | opendevreview | Ghanshyam proposed openstack/nova master: Fix microversion 2.98 doc/tests for update/rebuild APIs https://review.opendev.org/c/openstack/nova/+/942878 | |
| 04:12:25 | opendevreview | Callum Dickinson proposed openstack/nova master: Fix image ID in libvirt metadata when unshelving https://review.opendev.org/c/openstack/nova/+/942973 | |
| 04:59:17 | opendevreview | Callum Dickinson proposed openstack/nova master: Add flavor ID to libvirt guest XML https://review.opendev.org/c/openstack/nova/+/942974 | |
| 05:04:04 | opendevreview | Callum Dickinson proposed openstack/nova master: Fix image ID in libvirt metadata when unshelving https://review.opendev.org/c/openstack/nova/+/942973 | |
| 07:23:37 | opendevreview | Merged openstack/placement master: Replace deprecated FormatChecker.cls_checks https://review.opendev.org/c/openstack/placement/+/935734 | |
| 07:26:54 | opendevreview | Ivan Anfimov proposed openstack/nova master: doc: Enabling of using LibvirtDriver for compute node. https://review.opendev.org/c/openstack/nova/+/939325 | |
| 07:26:59 | opendevreview | Ivan Anfimov proposed openstack/nova master: doc: Enabling of using LibvirtDriver for compute node. https://review.opendev.org/c/openstack/nova/+/939325 | |
| 07:27:15 | opendevreview | Ivan Anfimov proposed openstack/nova master: doc: Enabling of using LibvirtDriver for compute node. https://review.opendev.org/c/openstack/nova/+/939325 | |
| 08:53:53 | opendevreview | Tobias Urdin proposed openstack/nova master: Retry more volume API functions on server error https://review.opendev.org/c/openstack/nova/+/942981 | |
| 09:12:40 | opendevreview | Callum Dickinson proposed openstack/nova master: Add image meta to libvirt XML metadata https://review.opendev.org/c/openstack/nova/+/942766 | |
| 09:17:46 | Callum027 | sean-k-mooney: I've updated the blueprint and the existing patch with the changes from our discussion. I've also proposed two new changes, one for implementing the flavor ID in metadata as discussed (https://review.opendev.org/c/openstack/nova/+/942974), and other that fixes an issue where the wrong image ID gets inserted into libvirt metadata if | |
| 09:17:46 | Callum027 | an ephemeral instance is unshelved (https://review.opendev.org/c/openstack/nova/+/942973). Hopefully everything looks good. | |
| 10:01:34 | opendevreview | Rajesh Tailor proposed openstack/nova master: Add support for showing finish_time https://review.opendev.org/c/openstack/nova/+/928933 | |
| 10:12:59 | opendevreview | Tobias Urdin proposed openstack/nova master: wip: Reserve volumes when doing instance resize https://review.opendev.org/c/openstack/nova/+/942985 | |
| 10:43:55 | sean-k-mooney | Callum027: nice find on the unshelve issue. can you file a bug for that so it could be backported? | |
| 11:22:27 | Callum027 | Yep, can do | |
| 11:46:18 | opendevreview | Callum Dickinson proposed openstack/nova master: Fix image ID in libvirt metadata when unshelving https://review.opendev.org/c/openstack/nova/+/942973 | |
| 11:48:03 | Callum027 | sean-k-mooney: Created bug: https://bugs.launchpad.net/nova/+bug/2100588 - The current patch *should* be able to be cherry-picked into 2024.2 cleanly, I think 2024.1 will need some changes though | |
| 11:52:48 | sean-k-mooney | Callum027: ya we can asses that when we get to that point | |
| 12:56:19 | opendevreview | Tobias Urdin proposed openstack/nova master: wip: Reserve volumes when doing instance resize https://review.opendev.org/c/openstack/nova/+/942985 | |
| 14:43:30 | dansmith | sean-k-mooney: bauzas are you around to +W this? https://review.opendev.org/c/openstack/nova/+/845660 | |
| 14:43:50 | sean-k-mooney | sure | |
| 14:46:07 | sean-k-mooney | by the way i am around but ill be finishing early today i.e. in the next hour or so | |
| 14:46:24 | sean-k-mooney | dansmith: i assume your glance series is not going to be there this cycle | |
| 14:46:34 | sean-k-mooney | so we dont need to land the gpt change? | |
| 14:46:58 | sean-k-mooney | i.e. this https://review.opendev.org/c/openstack/nova/+/933928 | |
| 14:47:02 | dansmith | sean-k-mooney: yeah >:( .. the glance part of that has been sitting since november | |
| 14:47:28 | sean-k-mooney | this just future proofs us for when it is aviable | |
| 14:48:18 | sean-k-mooney | i assume there is no point in merging that in nova first? | |
| 14:48:54 | sean-k-mooney | i know you have a wip patch follwoing it | |
| 14:49:55 | dansmith | yeah I mean, if that other thing never merges (or someone complains about the format name or something) it would be kinda silly to have pre-merged that in nova | |
| 14:50:12 | dansmith | and it would be an easy backport if we needed to for some reason, so no real need to jump the gun I think | |
| 15:14:27 | opendevreview | Tobias Urdin proposed openstack/nova master: Retry more volume API functions on server error https://review.opendev.org/c/openstack/nova/+/942981 | |
| 15:14:28 | opendevreview | Tobias Urdin proposed openstack/nova master: wip: Reserve volumes when doing instance resize https://review.opendev.org/c/openstack/nova/+/942985 | |
| 17:06:19 | opendevreview | Ghanshyam proposed openstack/nova master: Fix microversion 2.96 for update/rebuild APIs https://review.opendev.org/c/openstack/nova/+/942875 | |
| 17:13:12 | opendevreview | Ghanshyam proposed openstack/nova master: Fix microversion 2.98 doc/tests for update/rebuild APIs https://review.opendev.org/c/openstack/nova/+/942878 | |
| 17:14:00 | opendevreview | Ghanshyam proposed openstack/nova master: Fix microversion 2.98 doc/tests for update/rebuild APIs https://review.opendev.org/c/openstack/nova/+/942878 | |
| #openstack-nova - 2025-03-01 | |||
| 06:16:04 | opendevreview | Takashi Kajinami proposed openstack/nova master: Drop direct dependency on iso8601 https://review.opendev.org/c/openstack/nova/+/943083 | |
| 07:58:07 | opendevreview | Takashi Kajinami proposed openstack/nova master: Drop direct dependency on iso8601 https://review.opendev.org/c/openstack/nova/+/943083 | |
| 14:09:11 | opendevreview | Merged openstack/nova master: libvirt: Add new option to enforce multipath volume connections https://review.opendev.org/c/openstack/nova/+/845660 | |
| 14:47:41 | tkajinam | \o/ | |
| 15:08:26 | opendevreview | Takashi Kajinami proposed openstack/nova master: Migrate MEM_ENCRYPTION_CONTEXT from root provider https://review.opendev.org/c/openstack/nova/+/921814 | |
| 15:08:26 | opendevreview | Takashi Kajinami proposed openstack/nova master: Detect AMD SEV-ES support https://review.opendev.org/c/openstack/nova/+/925685 | |
| 15:10:13 | opendevreview | Takashi Kajinami proposed openstack/nova master: Add hw_mem_encryption_model image property https://review.opendev.org/c/openstack/nova/+/927706 | |
| 15:10:22 | opendevreview | Takashi Kajinami proposed openstack/nova master: libvirt: Launch instances with SEV-ES memory encryption https://review.opendev.org/c/openstack/nova/+/926106 | |
| #openstack-nova - 2025-03-02 | |||
| 23:49:31 | opendevreview | ribaudr proposed openstack/nova master: Update driver to deal with managed flag https://review.opendev.org/c/openstack/nova/+/938405 | |
| 23:49:32 | opendevreview | ribaudr proposed openstack/nova master: Augment the LiveMigrateData object https://review.opendev.org/c/openstack/nova/+/942143 | |