| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2025-02-28 | |||
| 00:05:54 | dansmith | sean-k-mooney: tkajinam I am EOD but I will be glad to look tomorrow.. That said, this seems like a bug fix (or at least mitigation) to me, so I'm not worried about merging it later | |
| 00:06:01 | Callum027 | Yep. Thanks for letting me know about that, wasn't aware of the full implications of exposing that | |
| 00:06:45 | sean-k-mooney | dansmith: enforcign multi path ya i can see that angle | |
| 00:07:24 | sean-k-mooney | i just logged in to check something so i should proably call it there too o/ | |
| 01:04:17 | opendevreview | Merged openstack/placement master: requirements: Remove setuptools https://review.opendev.org/c/openstack/placement/+/932398 | |
| 01:04:19 | opendevreview | Merged openstack/placement master: reno: Update master for unmaintained/2023.1 https://review.opendev.org/c/openstack/placement/+/935123 | |
| 01:41:34 | opendevreview | Merged openstack/placement master: Adapt cmd unit test depending on python version https://review.opendev.org/c/openstack/placement/+/939637 | |
| 01:42:55 | opendevreview | Merged openstack/nova master: Switch to using oslo.utils secretutils https://review.opendev.org/c/openstack/nova/+/939721 | |
| 01:43:04 | opendevreview | Merged openstack/nova master: Replace oslo_utils.encodeutils.exception_to_unicode https://review.opendev.org/c/openstack/nova/+/940619 | |
| 01:43:07 | opendevreview | Merged openstack/placement master: Changed OS version CentOS to CentOS Stream. https://review.opendev.org/c/openstack/placement/+/940492 | |
| 01:43:12 | opendevreview | Merged openstack/nova master: Correctly patch get_by_flavor_id https://review.opendev.org/c/openstack/nova/+/939722 | |
| 01:43:22 | opendevreview | Merged openstack/nova master: Add managed flag to PCI device specification https://review.opendev.org/c/openstack/nova/+/937649 | |
| 02:14:08 | opendevreview | Merged openstack/nova master: Add support for showing scheduler_hints in server details https://review.opendev.org/c/openstack/nova/+/938604 | |
| 02:22:58 | opendevreview | zhou zhong proposed openstack/nova master: Logging exception when query servers for further debug https://review.opendev.org/c/openstack/nova/+/942897 | |
| 02:42:55 | opendevreview | Ghanshyam proposed openstack/nova master: Fix microversion 2.96 for update/rebuild APIs https://review.opendev.org/c/openstack/nova/+/942875 | |
| 02:43:28 | opendevreview | Ghanshyam proposed openstack/nova master: Fix microversion 2.98 doc/tests for update/rebuild APIs https://review.opendev.org/c/openstack/nova/+/942878 | |
| 04:12:25 | opendevreview | Callum Dickinson proposed openstack/nova master: Fix image ID in libvirt metadata when unshelving https://review.opendev.org/c/openstack/nova/+/942973 | |
| 04:59:17 | opendevreview | Callum Dickinson proposed openstack/nova master: Add flavor ID to libvirt guest XML https://review.opendev.org/c/openstack/nova/+/942974 | |
| 05:04:04 | opendevreview | Callum Dickinson proposed openstack/nova master: Fix image ID in libvirt metadata when unshelving https://review.opendev.org/c/openstack/nova/+/942973 | |
| 07:23:37 | opendevreview | Merged openstack/placement master: Replace deprecated FormatChecker.cls_checks https://review.opendev.org/c/openstack/placement/+/935734 | |
| 07:26:54 | opendevreview | Ivan Anfimov proposed openstack/nova master: doc: Enabling of using LibvirtDriver for compute node. https://review.opendev.org/c/openstack/nova/+/939325 | |
| 07:26:59 | opendevreview | Ivan Anfimov proposed openstack/nova master: doc: Enabling of using LibvirtDriver for compute node. https://review.opendev.org/c/openstack/nova/+/939325 | |
| 07:27:15 | opendevreview | Ivan Anfimov proposed openstack/nova master: doc: Enabling of using LibvirtDriver for compute node. https://review.opendev.org/c/openstack/nova/+/939325 | |
| 08:53:53 | opendevreview | Tobias Urdin proposed openstack/nova master: Retry more volume API functions on server error https://review.opendev.org/c/openstack/nova/+/942981 | |
| 09:12:40 | opendevreview | Callum Dickinson proposed openstack/nova master: Add image meta to libvirt XML metadata https://review.opendev.org/c/openstack/nova/+/942766 | |
| 09:17:46 | Callum027 | sean-k-mooney: I've updated the blueprint and the existing patch with the changes from our discussion. I've also proposed two new changes, one for implementing the flavor ID in metadata as discussed (https://review.opendev.org/c/openstack/nova/+/942974), and other that fixes an issue where the wrong image ID gets inserted into libvirt metadata if | |
| 09:17:46 | Callum027 | an ephemeral instance is unshelved (https://review.opendev.org/c/openstack/nova/+/942973). Hopefully everything looks good. | |
| 10:01:34 | opendevreview | Rajesh Tailor proposed openstack/nova master: Add support for showing finish_time https://review.opendev.org/c/openstack/nova/+/928933 | |
| 10:12:59 | opendevreview | Tobias Urdin proposed openstack/nova master: wip: Reserve volumes when doing instance resize https://review.opendev.org/c/openstack/nova/+/942985 | |
| 10:43:55 | sean-k-mooney | Callum027: nice find on the unshelve issue. can you file a bug for that so it could be backported? | |
| 11:22:27 | Callum027 | Yep, can do | |
| 11:46:18 | opendevreview | Callum Dickinson proposed openstack/nova master: Fix image ID in libvirt metadata when unshelving https://review.opendev.org/c/openstack/nova/+/942973 | |
| 11:48:03 | Callum027 | sean-k-mooney: Created bug: https://bugs.launchpad.net/nova/+bug/2100588 - The current patch *should* be able to be cherry-picked into 2024.2 cleanly, I think 2024.1 will need some changes though | |
| 11:52:48 | sean-k-mooney | Callum027: ya we can asses that when we get to that point | |
| 12:56:19 | opendevreview | Tobias Urdin proposed openstack/nova master: wip: Reserve volumes when doing instance resize https://review.opendev.org/c/openstack/nova/+/942985 | |
| 14:43:30 | dansmith | sean-k-mooney: bauzas are you around to +W this? https://review.opendev.org/c/openstack/nova/+/845660 | |
| 14:43:50 | sean-k-mooney | sure | |
| 14:46:07 | sean-k-mooney | by the way i am around but ill be finishing early today i.e. in the next hour or so | |
| 14:46:24 | sean-k-mooney | dansmith: i assume your glance series is not going to be there this cycle | |
| 14:46:34 | sean-k-mooney | so we dont need to land the gpt change? | |
| 14:46:58 | sean-k-mooney | i.e. this https://review.opendev.org/c/openstack/nova/+/933928 | |
| 14:47:02 | dansmith | sean-k-mooney: yeah >:( .. the glance part of that has been sitting since november | |
| 14:47:28 | sean-k-mooney | this just future proofs us for when it is aviable | |
| 14:48:18 | sean-k-mooney | i assume there is no point in merging that in nova first? | |
| 14:48:54 | sean-k-mooney | i know you have a wip patch follwoing it | |
| 14:49:55 | dansmith | yeah I mean, if that other thing never merges (or someone complains about the format name or something) it would be kinda silly to have pre-merged that in nova | |
| 14:50:12 | dansmith | and it would be an easy backport if we needed to for some reason, so no real need to jump the gun I think | |
| 15:14:27 | opendevreview | Tobias Urdin proposed openstack/nova master: Retry more volume API functions on server error https://review.opendev.org/c/openstack/nova/+/942981 | |
| 15:14:28 | opendevreview | Tobias Urdin proposed openstack/nova master: wip: Reserve volumes when doing instance resize https://review.opendev.org/c/openstack/nova/+/942985 | |
| 17:06:19 | opendevreview | Ghanshyam proposed openstack/nova master: Fix microversion 2.96 for update/rebuild APIs https://review.opendev.org/c/openstack/nova/+/942875 | |
| 17:13:12 | opendevreview | Ghanshyam proposed openstack/nova master: Fix microversion 2.98 doc/tests for update/rebuild APIs https://review.opendev.org/c/openstack/nova/+/942878 | |
| 17:14:00 | opendevreview | Ghanshyam proposed openstack/nova master: Fix microversion 2.98 doc/tests for update/rebuild APIs https://review.opendev.org/c/openstack/nova/+/942878 | |
| #openstack-nova - 2025-03-01 | |||
| 06:16:04 | opendevreview | Takashi Kajinami proposed openstack/nova master: Drop direct dependency on iso8601 https://review.opendev.org/c/openstack/nova/+/943083 | |
| 07:58:07 | opendevreview | Takashi Kajinami proposed openstack/nova master: Drop direct dependency on iso8601 https://review.opendev.org/c/openstack/nova/+/943083 | |
| 14:09:11 | opendevreview | Merged openstack/nova master: libvirt: Add new option to enforce multipath volume connections https://review.opendev.org/c/openstack/nova/+/845660 | |
| 14:47:41 | tkajinam | \o/ | |
| 15:08:26 | opendevreview | Takashi Kajinami proposed openstack/nova master: Migrate MEM_ENCRYPTION_CONTEXT from root provider https://review.opendev.org/c/openstack/nova/+/921814 | |
| 15:08:26 | opendevreview | Takashi Kajinami proposed openstack/nova master: Detect AMD SEV-ES support https://review.opendev.org/c/openstack/nova/+/925685 | |
| 15:10:13 | opendevreview | Takashi Kajinami proposed openstack/nova master: Add hw_mem_encryption_model image property https://review.opendev.org/c/openstack/nova/+/927706 | |
| 15:10:22 | opendevreview | Takashi Kajinami proposed openstack/nova master: libvirt: Launch instances with SEV-ES memory encryption https://review.opendev.org/c/openstack/nova/+/926106 | |
| #openstack-nova - 2025-03-02 | |||
| 23:49:31 | opendevreview | ribaudr proposed openstack/nova master: Update driver to deal with managed flag https://review.opendev.org/c/openstack/nova/+/938405 | |
| 23:49:32 | opendevreview | ribaudr proposed openstack/nova master: Augment the LiveMigrateData object https://review.opendev.org/c/openstack/nova/+/942143 | |
| 23:49:32 | opendevreview | ribaudr proposed openstack/nova master: Add live_migratable flag to PCI device specification https://review.opendev.org/c/openstack/nova/+/942144 | |
| 23:49:33 | opendevreview | ribaudr proposed openstack/nova master: Update manager to allow vfio pci device live migration https://review.opendev.org/c/openstack/nova/+/942145 | |
| 23:49:33 | opendevreview | ribaudr proposed openstack/nova master: Update conductor and filters allowing migration with SR-IOV devices https://review.opendev.org/c/openstack/nova/+/942146 | |
| 23:49:34 | opendevreview | ribaudr proposed openstack/nova master: Update driver to map the targeted address for SR-IOV PCI devices https://review.opendev.org/c/openstack/nova/+/942147 | |
| 23:49:34 | opendevreview | ribaudr proposed openstack/nova master: FUP improve comment accuracy and variable naming for tag removal https://review.opendev.org/c/openstack/nova/+/943124 | |
| #openstack-nova - 2025-03-03 | |||
| 00:09:49 | opendevreview | Callum Dickinson proposed openstack/nova master: Fix image ID in libvirt metadata when unshelving https://review.opendev.org/c/openstack/nova/+/942973 | |
| 03:00:27 | opendevreview | Callum Dickinson proposed openstack/nova master: Add image meta to libvirt XML metadata https://review.opendev.org/c/openstack/nova/+/942766 | |
| 05:03:53 | opendevreview | Callum Dickinson proposed openstack/nova master: Add more flavor metadata to libvirt guest XML https://review.opendev.org/c/openstack/nova/+/942974 | |
| 08:36:16 | opendevreview | Takashi Kajinami proposed openstack/nova master: Drop quota options from the DEFAULT section https://review.opendev.org/c/openstack/nova/+/943131 | |
| 09:04:33 | opendevreview | Tobias Urdin proposed openstack/nova master: wip: Reserve volumes when doing instance resize https://review.opendev.org/c/openstack/nova/+/942985 | |
| 09:08:23 | tobias-urdin | when testing above^ patch i just realized that you cannot reserve a cinder volume when status is in-use, based on the issue described there i guess the only two alternatives to solve the problem in that patch is either 1) add a simple check for volume status and live with the potential race condition between check of volume status and actual _terminate_volume_connections call | |
| 09:08:25 | tobias-urdin | or 2) catch InvalidVolume exceptions directly in _terminate_volume_connections and try to rollback volume attachments and then raise a InstanceFaultRollback exception, anybody else has any better ideas? | |
| 09:37:07 | opendevreview | ribaudr proposed openstack/nova master: FUP improve comment accuracy and variable naming for tag removal https://review.opendev.org/c/openstack/nova/+/943124 | |
| 09:37:07 | opendevreview | ribaudr proposed openstack/nova master: Update driver to map the targeted address for SR-IOV PCI devices https://review.opendev.org/c/openstack/nova/+/942147 | |
| 09:44:11 | sean-k-mooney | tobias-urdin: i have not looked into your patches yet but waht was the problem you were tryign to resolve? | |
| 09:44:34 | sean-k-mooney | tobias-urdin: i vagely saw them coming in last week but didnt have time to read them | |
| 09:46:02 | sean-k-mooney | tobias-urdin: oh ok... so thisi is kind of a cinder bug | |
| 09:46:34 | sean-k-mooney | tobias-urdin: so the problem is that cinder does not knwo that nova is in the middle of doing a resize and nova does not know that cidner wants to do a backup | |
| 09:46:35 | tobias-urdin | sean-k-mooney: if i try to resize and instance it goes to ERROR and needs operator to restore it (shutdown has already been called) because attachment_create() volume API raises InvalidVolume when an attached volume has backing-up status | |
| 09:46:40 | sean-k-mooney | so we can get in a broken state | |
| 09:47:05 | sean-k-mooney | tobias-urdin: well you can resize instnace with cinder volumes | |
| 09:47:21 | sean-k-mooney | that not the problem its because you also happen to have a cinder backup at the same time | |
| 09:48:42 | sean-k-mooney | tobias-urdin: both nova and cidner backup exepct to be the only thing modifying the volume state when doign a resize or backup | |
| 09:49:25 | tobias-urdin | yea, i could just loop volumes and check status in the context and raise InstanceFaultRollback i guess for resize to not hit it, but there would still be a race between me checking the status and attachment code being called in resize | |
| 09:49:46 | sean-k-mooney | that not really the fix | |
| 09:49:58 | tobias-urdin | i was hoping i could reserve the volumes before starting the operation, but my research failed because it didn't accommodate for in-use not being possible on in-use volume :( | |
| 09:50:06 | sean-k-mooney | we either need nova to annotate the volume with somethjing to indicate that we are migrating | |
| 09:50:21 | sean-k-mooney | or we need to have cidner check the status of attached instnace before doing a backup | |
| 09:51:09 | sean-k-mooney | tobias-urdin: is cidner backup changing the state of the volume to something other then inuse | |
| 09:51:22 | tobias-urdin | yes "backing-up" is set | |
| 09:51:30 | sean-k-mooney | right os that also a bug | |
| 09:52:17 | sean-k-mooney | once a volume is attached to a nova instnace we do not exect the voluem status to change unless its via a call to the nova api | |
| 09:52:42 | sean-k-mooney | so form a nova perspecitve it should remain in use | |
| 09:53:02 | sean-k-mooney | it would be fine to have a seperate task_state that backing-up | |
| 09:54:05 | sean-k-mooney | but if cidner want to modify it they need to make the attchment api treat backing-up the same as in-use | |
| 09:54:41 | tobias-urdin | that actually makes more sense | |
| 09:55:24 | sean-k-mooney | we have a bunch of task_state that we translate to "active" because semanticly external service should treat them the same | |
| 09:56:31 | sean-k-mooney | i dont know how to express that in cidner api but i think if they have internal states liek backing-up they may need a similar mechanisum | |