Earlier  
Posted Nick Remark
#openstack-nova - 2025-02-25
15:38:16 sean-k-mooney i can leave a comment to that effect on the reviews but i just notice the patches have been updated
15:38:55 sean-k-mooney i have not reviewd the most recent version yet. wehn i saw the paste only had the pci device table in it i was wondering if this had been missed
15:39:02 sean-k-mooney but i have not looked at the code to confirm
15:39:51 gibi sean-k-mooney: I think (weakly) that having extra tags on the device / pool is not an issue as the pool matching logic should be looking at the requested tags from the request side and ignore any extra on the pool side
15:40:34 gibi this is the a response for the ignored tags comment
15:40:39 sean-k-mooney correct and the ovo defines the tags as a dict of nullable strings
15:40:41 sean-k-mooney https://github.com/openstack/nova/blob/master/nova/objects/pci_device_pool.py#L36
15:40:54 sean-k-mooney so its not an object change
15:41:21 sean-k-mooney however we should keep the summery in the pools small in general to keep the memory overhead in the schduler and rpc size down
15:42:08 gibi wait do we send the Pool across the wire? you just said above scheduler loads it from the DB
15:42:08 sean-k-mooney i think this could be a follow up patch but we likely shoudl filter out managed since we do not have a usecase for it in the schduler currently since managed is not in the alias
15:42:39 sean-k-mooney i belive we send it across the wire in a few cases.
15:42:54 sean-k-mooney we have the schduler resouce view update perodic
15:43:18 sean-k-mooney where the compute manger updates the schduler with info about the instance on the host ectra
15:43:54 sean-k-mooney but its also going to get pulled when we do a hypervior list. which i guess is not over rpc
15:43:58 sean-k-mooney but directly from the db
15:44:19 gibi yeah hypervisor list only goes to RPC if it wants to get the uptime from the compute
15:44:27 gibi anyhow
15:44:37 sean-k-mooney i think that was zen only?
15:44:51 sean-k-mooney also deleteed in newer api versions so im not that worries about that
15:45:19 gibi so for the FF we need to check if pci_stats table is also clean after a tag removal. The ignored_tags thing might wait as it does not seem to break anything
15:46:03 sean-k-mooney yep
15:46:17 sean-k-mooney it would only be in the pool if you opted into the feature anyway
15:46:45 sean-k-mooney for live migration its imporant that that flag is there so we can select a device that supports it in teh pci passthough filter
15:47:59 gibi I fail to see the pci_stats table in my deployment....
15:48:15 sean-k-mooney its not a table
15:48:23 sean-k-mooney its a colum on the compute_node table
15:48:31 gibi aah
15:48:32 gibi OK
15:48:55 sean-k-mooney so its pulled anytime we pull a compute node object unless we are explcitly lazyloading that
15:49:33 sean-k-mooney its saved back every time update aviable resocues commits back the updated values
15:57:14 sean-k-mooney so its updated here https://github.com/openstack/nova/blob/master/nova/compute/resource_tracker.py#L1377-L1382 and then its converted into the db format on compute node save by https://github.com/openstack/nova/blob/master/nova/objects/compute_node.py#L321-L326
16:00:40 bauzas #startmeeting nova
16:00:40 opendevmeet Meeting started Tue Feb 25 16:00:40 2025 UTC and is due to finish in 60 minutes. The chair is bauzas. Information about MeetBot at http://wiki.debian.org/MeetBot.
16:00:40 opendevmeet Useful Commands: #action #agreed #help #info #idea #link #topic #startvote.
16:00:40 opendevmeet The meeting name has been set to 'nova'
16:01:40 gibi sean-k-mooney: https://paste.opendev.org/show/bEWhDvmH5NPNozp8V4pU/ confirmed the pci_stats also cleaned
16:02:12 sean-k-mooney gibi: cool i expected it to be. its just it should not be there at all. but we can adress that in a trivial followup
16:02:20 sean-k-mooney or dicsuss it more after the meeting
16:02:36 bauzas #link https://wiki.openstack.org/wiki/Meetings/Nova#Agenda_for_next_meeting
16:02:42 elodilles o/
16:02:44 bauzas howdy folks, sorry was late
16:03:02 sean-k-mooney o/
16:03:11 bauzas let's start
16:03:23 bauzas #topic Bugs (stuck/critical)
16:03:24 masahito o/
16:03:32 bauzas #info No Critical bug
16:03:39 bauzas #info Add yourself in the team bug roster if you want to help https://etherpad.opendev.org/p/nova-bug-triage-roster
16:04:09 bauzas any bugs to talk ?
16:04:56 bauzas looks not
16:05:02 bauzas #topic Gate status
16:05:12 bauzas #link https://bugs.launchpad.net/nova/+bugs?field.tag=gate-failure Nova gate bugs
16:05:17 bauzas #link https://etherpad.opendev.org/p/nova-ci-failures-minimal
16:05:27 bauzas (I'll leave the next PTL to curate that long list)
16:05:34 bauzas #link https://zuul.openstack.org/builds?project=openstack%2Fnova&project=openstack%2Fplacement&branch=stable%2F*&branch=master&pipeline=periodic-weekly&skip=0 Nova&Placement periodic jobs status
16:05:40 bauzas #info Please look at the gate failures and file a bug report with the gate-failure tag.
16:05:46 bauzas #info Please try to provide meaningful comment when you recheck
16:05:56 bauzas for me, the gate is correct
16:06:30 bauzas yet a few rechecks because of the usual suspects (guest panic and ssh timeouts) but nothing new and putting epoxy-3 at risk
16:06:39 sean-k-mooney bauzas: there is perhaps one
16:06:49 Uggla o/
16:06:58 sean-k-mooney one of the funtional test for vgpu multi type is failing randomly
16:07:08 bauzas hmmm
16:07:15 sean-k-mooney bauzas: i dont have the link but i pingged it in the channel yesterday
16:07:16 bauzas that may be related to the leaky greenlet
16:07:26 sean-k-mooney it triggering the greenlet leak detachtion
16:07:32 sean-k-mooney right it is
16:07:37 bauzas yeah, but that's not new
16:07:40 sean-k-mooney so that a bug in the test
16:07:40 fwiesel o/
16:07:53 sean-k-mooney well that somethign that shoudl be fixed as its causing extra rechecks
16:07:59 bauzas so maybe some side effect happened that would increase the failure rate
16:08:03 sean-k-mooney its not critical but we should not ignore it
16:08:08 bauzas I don't disagree
16:08:18 sean-k-mooney bauzas: if there is an excption in the leaked greenthread
16:08:27 sean-k-mooney it cn cause other test to fail becuase of that
16:08:45 bauzas I can try to take a look on it, particularly given I have another bugfix patch I'd want to be merged before RC1
16:08:47 sean-k-mooney so it cause hard to diagnose inter test interaction which is why we added the leak detection
16:09:00 sean-k-mooney ack its more an fyi
16:09:05 bauzas cool
16:09:20 bauzas #topic Release Planning
16:09:32 bauzas #link https://releases.openstack.org/epoxy/schedule.html
16:09:56 bauzas #info Nova deadlines are set in the above schedule
16:10:07 bauzas #info 2 days before Feature Freeze
16:10:07 elodilles note that there are client library release patches open:
16:10:15 elodilles https://review.opendev.org/c/openstack/releases/+/942534
16:10:21 elodilles https://review.opendev.org/c/openstack/releases/+/942551
16:10:39 elodilles (osc-placement and python-novaclient)
16:11:05 elodilles just an fyi as we have Epoxy-3 now o:)
16:11:06 sean-k-mooney so those have the same freeze deadline as nova right
16:11:08 bauzas noted, I'll review them
16:11:10 sean-k-mooney i.e. thrusday
16:11:18 elodilles yepp
16:11:30 sean-k-mooney but we will want to do a release at m3 to test with them for RC1
16:11:41 elodilles +1
16:12:11 sean-k-mooney we shoudl not haver anything pending for osc-palcement or novaclient that im aware of
16:12:18 sean-k-mooney so we can probly do those effectivly now
16:12:50 sean-k-mooney on clients
16:13:08 sean-k-mooney we have some new api versions this cycle and im not sure we will have osc suprot for those in time
16:13:20 sean-k-mooney so they may get enabled next cycle

Earlier   Later