| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2025-02-24 | |||
| 23:36:25 | opendevreview | melanie witt proposed openstack/nova stable/2024.2: libvirt: Fix regression of listDevices() return type https://review.opendev.org/c/openstack/nova/+/942652 | |
| 23:37:40 | opendevreview | melanie witt proposed openstack/nova stable/2024.1: Reproducer for bug 2098892 https://review.opendev.org/c/openstack/nova/+/942653 | |
| 23:37:41 | opendevreview | melanie witt proposed openstack/nova stable/2024.1: libvirt: Fix regression of listDevices() return type https://review.opendev.org/c/openstack/nova/+/942654 | |
| 23:38:49 | opendevreview | melanie witt proposed openstack/nova stable/2023.2: Reproducer for bug 2098892 https://review.opendev.org/c/openstack/nova/+/942655 | |
| 23:38:50 | opendevreview | melanie witt proposed openstack/nova stable/2023.2: libvirt: Fix regression of listDevices() return type https://review.opendev.org/c/openstack/nova/+/942656 | |
| #openstack-nova - 2025-02-25 | |||
| 00:24:15 | melwitt | fyi elodilles these ^ are fixes for an not-yet-released regression so it would be best to not make releases on these branches until they are merged | |
| 00:35:06 | opendevreview | Merged openstack/nova master: libvirt: direct SPICE console object changes https://review.opendev.org/c/openstack/nova/+/926876 | |
| 01:26:14 | opendevreview | Merged openstack/nova master: libvirt: direct SPICE console database changes https://review.opendev.org/c/openstack/nova/+/926877 | |
| 03:23:02 | opendevreview | Merged openstack/nova master: libvirt: allow direct SPICE connections to qemu https://review.opendev.org/c/openstack/nova/+/924844 | |
| 03:24:04 | sean-k-mooney[m] | mikal: ^ congrats | |
| 03:43:21 | opendevreview | Takashi Kajinami proposed openstack/nova master: Use consistent program name for wsgi scripts and entry points https://review.opendev.org/c/openstack/nova/+/942605 | |
| 03:48:44 | opendevreview | Takashi Kajinami proposed openstack/nova master: Migrate MEM_ENCRYPTION_CONTEXT from root provider https://review.opendev.org/c/openstack/nova/+/921814 | |
| 03:48:45 | opendevreview | Takashi Kajinami proposed openstack/nova master: Detect AMD SEV-ES support https://review.opendev.org/c/openstack/nova/+/925685 | |
| 03:48:46 | opendevreview | Takashi Kajinami proposed openstack/nova master: Add hw_mem_encryption_model image property https://review.opendev.org/c/openstack/nova/+/927706 | |
| 03:48:47 | opendevreview | Takashi Kajinami proposed openstack/nova master: libvirt: Launch instances with SEV-ES memory encryption https://review.opendev.org/c/openstack/nova/+/926106 | |
| 03:50:40 | tkajinam | I know people are busy these days but I really hope I can get feedback about this series ^^^ | |
| 03:50:44 | tkajinam | and https://review.opendev.org/c/openstack/nova/+/845660 | |
| 03:51:53 | tkajinam | https://review.opendev.org/c/openstack/nova/+/940619 is also easy-win to get rid of deprecation warnings | |
| 05:10:08 | sshmlbrg | sean-k-mooney: Are you around? Is nova_context temporary mutation context manager? | |
| 06:29:36 | frickler | sean-k-mooney: I was talking about the igb change that you referenced before, yes. 0.6.3 was done 2 days after it merged, so it should be included. also 22.04 hwe and 24.04 kernels should be kind of synced? | |
| 08:48:14 | mikal | sean-k-mooney: I saw that, but had to cook dinner so the kids didn't resort to cannibalism. Thanks again for all your help. | |
| 08:48:29 | mikal | sean-k-mooney: now to get the client patches merged I suppose. I wonder if I've missed the deadline for that in epoxy... | |
| 09:09:23 | opendevreview | ribaudr proposed openstack/nova master: Add managed flag to PCI device specification https://review.opendev.org/c/openstack/nova/+/937649 | |
| 09:09:24 | opendevreview | ribaudr proposed openstack/nova master: Update driver to deal with managed flag https://review.opendev.org/c/openstack/nova/+/938405 | |
| 11:43:48 | sean-k-mooney | mikal: client freeze is gerneally the saem as FF | |
| 11:45:09 | sean-k-mooney | frickler: the 22.04 hwe kernel is basiclly the kernels form the 3 non lts release until the next lts. 24.04 baseline might be similar but 24.04 hwe will be newer | |
| 11:46:23 | sean-k-mooney | frickler: its not critical but i was hoping that it might help with some of the kernel panic we see although that genearly seam to be related to swtiching form the initramfs so it might not actuly be a "kernel" bug so much as an issue with how we are booting | |
| 11:57:38 | sean-k-mooney | frickler: i like cirros and dfisk image builder (i know cirros does not use that) but on think i hav ebeen meening to look into is bootc images i.e. bootable iamge build with podman and https://github.com/osbuild/bootc-image-builder fedora-minimal is 48MB i wonder how much bigger that woudl be if i added the kernel via the bootc build process | |
| 11:58:50 | sean-k-mooney | i got pretty far with my alpine poc a few years ago but never had time to complete it | |
| 11:59:46 | sean-k-mooney | friday is a hack/hussle day technailly at redhat so i might actuly use it to hack on somethign related to cirros or another minimal image | |
| 12:00:13 | sean-k-mooney | that or ill get distracted and work on feature freeze stuff :) | |
| 12:01:32 | sean-k-mooney | the normal fedora bootc image is like 900 MB which defaute the goal fo a small test image because there are plent fo cloud image out there that are smaller or the same size | |
| 12:48:59 | opendevreview | Douglas Viroel proposed openstack/nova master: Add support for showing scheduler_hints in server details https://review.opendev.org/c/openstack/nova/+/938604 | |
| 14:34:08 | opendevreview | ribaudr proposed openstack/nova master: Add managed flag to PCI device specification https://review.opendev.org/c/openstack/nova/+/937649 | |
| 14:34:08 | opendevreview | ribaudr proposed openstack/nova master: Update driver to deal with managed flag https://review.opendev.org/c/openstack/nova/+/938405 | |
| 14:54:43 | opendevreview | ribaudr proposed openstack/nova master: Add managed flag to PCI device specification https://review.opendev.org/c/openstack/nova/+/937649 | |
| 14:54:43 | opendevreview | ribaudr proposed openstack/nova master: Update driver to deal with managed flag https://review.opendev.org/c/openstack/nova/+/938405 | |
| 15:25:48 | sean-k-mooney | Uggla: can you confirm the tags are proply updated on the comptue node tabel too | |
| 15:25:59 | sean-k-mooney | for https://review.opendev.org/c/openstack/nova/+/937649 | |
| 15:29:13 | sean-k-mooney | Uggla: we do not require it for the manage feature but the tags are includied in the pci_stats column in the ComputeNode table https://github.com/openstack/nova/blob/master/nova/db/main/models.py#L227-L229 | |
| 15:29:29 | sean-k-mooney | we will need that for the live migratable tag | |
| 15:30:01 | sean-k-mooney | i expect the existing logig to proprly update that without you needing to do anything | |
| 15:30:05 | sean-k-mooney | for managed | |
| 15:30:12 | sean-k-mooney | but it woudl be good to confirm | |
| 15:31:03 | gibi | sean-k-mooney: do you mean if the live-migratable flag is removed from the dev_spec then the pci pool containing the matching device should also be updated? | |
| 15:31:08 | Uggla | sean-k-mooney, you mean if this is register in the DB table ? --> https://paste.opendev.org/show/ba4BTb1bDKjCU052R3UP/ | |
| 15:31:28 | gibi | I think that is fairly implict as the pools are memory only and the tag is removed with a nova-compute service restart | |
| 15:31:35 | sean-k-mooney | the schduler does nto use the pci_devices table | |
| 15:31:45 | sean-k-mooney | it uses the pci_stats form the compute node table | |
| 15:31:53 | gibi | ahh | |
| 15:31:57 | gibi | then one more table to look at | |
| 15:32:01 | sean-k-mooney | so the tag for "live migratable" will be stroed in the pci_stats | |
| 15:32:18 | gibi | I assumed pci stats in memory only and not persisted, but then I was wrong | |
| 15:32:21 | gibi | TIL | |
| 15:32:21 | sean-k-mooney | gibi: think of pools as placement inventoies | |
| 15:32:36 | sean-k-mooney | they just have the count and tags instead of traits | |
| 15:32:58 | sean-k-mooney | ya no this is needed for multi cell | |
| 15:33:14 | sean-k-mooney | we cant pass the statc via the scheduler update | |
| 15:33:18 | sean-k-mooney | rpc | |
| 15:33:31 | sean-k-mooney | the scdhluer need to be able to load them form the cell db when creatign the host state object | |
| 15:35:22 | sean-k-mooney | gibi: we dont need to look at managed in the schduer so this is really only relevnet ot the second series but the behvior shoudld be the same. the pools shoudl be in sync with the config | |
| 15:35:45 | gibi | ack | |
| 15:36:30 | sean-k-mooney | https://github.com/openstack/nova/blob/master/nova/pci/stats.py#L66-L79 | |
| 15:36:41 | sean-k-mooney | mangage may be something we should add to the ignored tags | |
| 15:38:16 | sean-k-mooney | i can leave a comment to that effect on the reviews but i just notice the patches have been updated | |
| 15:38:55 | sean-k-mooney | i have not reviewd the most recent version yet. wehn i saw the paste only had the pci device table in it i was wondering if this had been missed | |
| 15:39:02 | sean-k-mooney | but i have not looked at the code to confirm | |
| 15:39:51 | gibi | sean-k-mooney: I think (weakly) that having extra tags on the device / pool is not an issue as the pool matching logic should be looking at the requested tags from the request side and ignore any extra on the pool side | |
| 15:40:34 | gibi | this is the a response for the ignored tags comment | |
| 15:40:39 | sean-k-mooney | correct and the ovo defines the tags as a dict of nullable strings | |
| 15:40:41 | sean-k-mooney | https://github.com/openstack/nova/blob/master/nova/objects/pci_device_pool.py#L36 | |
| 15:40:54 | sean-k-mooney | so its not an object change | |
| 15:41:21 | sean-k-mooney | however we should keep the summery in the pools small in general to keep the memory overhead in the schduler and rpc size down | |
| 15:42:08 | gibi | wait do we send the Pool across the wire? you just said above scheduler loads it from the DB | |
| 15:42:08 | sean-k-mooney | i think this could be a follow up patch but we likely shoudl filter out managed since we do not have a usecase for it in the schduler currently since managed is not in the alias | |
| 15:42:39 | sean-k-mooney | i belive we send it across the wire in a few cases. | |
| 15:42:54 | sean-k-mooney | we have the schduler resouce view update perodic | |
| 15:43:18 | sean-k-mooney | where the compute manger updates the schduler with info about the instance on the host ectra | |
| 15:43:54 | sean-k-mooney | but its also going to get pulled when we do a hypervior list. which i guess is not over rpc | |
| 15:43:58 | sean-k-mooney | but directly from the db | |
| 15:44:19 | gibi | yeah hypervisor list only goes to RPC if it wants to get the uptime from the compute | |
| 15:44:27 | gibi | anyhow | |
| 15:44:37 | sean-k-mooney | i think that was zen only? | |
| 15:44:51 | sean-k-mooney | also deleteed in newer api versions so im not that worries about that | |
| 15:45:19 | gibi | so for the FF we need to check if pci_stats table is also clean after a tag removal. The ignored_tags thing might wait as it does not seem to break anything | |
| 15:46:03 | sean-k-mooney | yep | |
| 15:46:17 | sean-k-mooney | it would only be in the pool if you opted into the feature anyway | |
| 15:46:45 | sean-k-mooney | for live migration its imporant that that flag is there so we can select a device that supports it in teh pci passthough filter | |
| 15:47:59 | gibi | I fail to see the pci_stats table in my deployment.... | |
| 15:48:15 | sean-k-mooney | its not a table | |
| 15:48:23 | sean-k-mooney | its a colum on the compute_node table | |
| 15:48:31 | gibi | aah | |
| 15:48:32 | gibi | OK | |
| 15:48:55 | sean-k-mooney | so its pulled anytime we pull a compute node object unless we are explcitly lazyloading that | |
| 15:49:33 | sean-k-mooney | its saved back every time update aviable resocues commits back the updated values | |
| 15:57:14 | sean-k-mooney | so its updated here https://github.com/openstack/nova/blob/master/nova/compute/resource_tracker.py#L1377-L1382 and then its converted into the db format on compute node save by https://github.com/openstack/nova/blob/master/nova/objects/compute_node.py#L321-L326 | |
| 16:00:40 | bauzas | #startmeeting nova | |
| 16:00:40 | opendevmeet | Meeting started Tue Feb 25 16:00:40 2025 UTC and is due to finish in 60 minutes. The chair is bauzas. Information about MeetBot at http://wiki.debian.org/MeetBot. | |
| 16:00:40 | opendevmeet | Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. | |
| 16:00:40 | opendevmeet | The meeting name has been set to 'nova' | |