Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2025-02-24
19:00:22 sean-k-mooney danfai: https://github.com/openstack/neutron/commit/baaf240ce3f7802fe1431cc13913b9d93fc7f742 that is the ovn bridge name patch
19:01:53 sean-k-mooney sshmlbrg: yep. we will need to add some nova functioanl tests to replciate the manual procedure you followed in the bug report
19:02:03 danfai Thank you very much
19:02:52 sean-k-mooney sshmlbrg: unit test are good to have but for operations like shelve we try to also have functional tests. and for bugs we prefer to create a functional test that show the broken behavior as an addtion patch and then have the fix as a second commit
19:03:48 sean-k-mooney sshmlbrg: without loading all the context im not sure that the finally block is corect
19:04:08 sean-k-mooney sshmlbrg: you should not be modifying the az of the instnace directly
19:04:45 sshmlbrg sean-k-mooney: ok, thanks. I will add functional tests as a first commit
19:04:46 sean-k-mooney sshmlbrg: we do not really use the az colume in the cell database to store the az of the instance anymore.
19:05:31 sean-k-mooney sshmlbrg: cool i would od it be creating a new file in https://github.com/openstack/nova/tree/master/nova/tests/functional/regressions
19:05:45 sean-k-mooney for the bug ill see if i can quickly find an exmaple for you to copy
19:06:11 sean-k-mooney sshmlbrg: perhaps https://github.com/openstack/nova/blob/master/nova/tests/functional/regressions/test_bug_2025480.py
19:06:24 sshmlbrg sean-k-mooney: then will need to change the methods used and add the az argument to them
19:07:04 sean-k-mooney updatign the object in memory may be ok its the save that is a little suspect
19:07:24 sean-k-mooney we have a temporay mutation context manager
19:07:44 sean-k-mooney i that we may want to condier
19:07:53 sean-k-mooney we can dicuss that on the review
19:08:22 sshmlbrg sean-k-mooney: thank you for example! ok, sounds good
19:08:51 sean-k-mooney if you look at similar files in the same directory there shoudl be a boot form volume example
19:09:32 sean-k-mooney or other shelve example so it should not be too hard to create a repoducer following the steps in the bug
19:11:46 sshmlbrg sean-k-mooney: i got it. I am gonna return with changes tomorrow. Have a nice day or evening :)
19:12:43 sean-k-mooney sshmlbrg: https://github.com/openstack/nova/blob/375d95565d594182c5472f710b3f7bd53f0746d4/nova/tests/functional/regressions/test_bug_1675570.py#L26
19:12:47 sean-k-mooney that a better example
19:13:10 sean-k-mooney sshmlbrg: o/
19:14:19 sean-k-mooney sshmlbrg: that actully attaching a server to a shelve offloaded instnace
19:14:35 sean-k-mooney the reason its not failing is cross az attach is allowed by defult
19:14:58 sean-k-mooney so if you were to set that to false in yoru version i woudl eeepct the attach to fail and repoduce the bug :)
19:16:25 sean-k-mooney mikal: https://zuul.openstack.org/status?change=924844&change=926876&change=926877 we will need to do a few rechecks... but we can kick thos off again shortly
19:16:43 sshmlbrg sean-k-mooney: cool idea, I'll look into this
19:17:26 sean-k-mooney sshmlbrg: let us know if you have issues there is a self.flags function aviable on the test case to set fconfig options
19:17:42 sean-k-mooney if you grep for flags you will see examples of how to use it
19:19:42 sean-k-mooney bauzas: RuntimeError: detected leaked greenlets in nova.tests.functional.libvirt.test_vgpu.VGPUMultipleTypesTests.test_create_servers_with_specific_type
19:20:12 sean-k-mooney i dont know how often tthat fails but that ocatinal does
19:21:37 sean-k-mooney mikal: ^ that the error in the funtional test on the third patfch so its not related ot your code
19:24:08 sean-k-mooney Uggla: https://review.opendev.org/c/openstack/releases/+/941862 need your +1 again i updated the version to 4.1.0 based on elodilles comment on the release channel
19:25:39 mikal sean-k-mooney: are you going to do the rechecks or should I?
19:26:14 sean-k-mooney either works ill be finsihing in the next 20 mins or so but ill preodiclly check in
19:26:34 mikal Well, we'
19:26:49 mikal Well, we're still waiting for them to finish right now anyways.
19:27:13 sean-k-mooney ya. if multiple people recheck it wotn kick it out of check
19:27:48 sean-k-mooney i dont it migh kick it out of gate i dont recally so we should be carful in that case
19:29:36 sean-k-mooney mikal: over all the results look pretty green the nova-grenade-multinode failure in gate on the first patch was a kernel panic
19:29:48 sean-k-mooney that not related to yoru code so just bad luck
19:30:51 sean-k-mooney mikal: sometime rechecking at a less busy time help with things like that but its a bug in our cirros image we think
19:31:23 mikal sean-k-mooney: without checking, I feel like cirros hasn't done a release in ages?
19:31:45 mikal Huh, more recent than I expected. September last year.
19:31:53 sean-k-mooney its been a while there is a 6.x branch based on ubuntu 22.04 or maybe 24.04
19:32:06 mikal The author now works at chainguard IIRC.
19:32:10 sean-k-mooney i dont recall if they have compelte the rebase on the 24.04 kernel yet
19:32:47 sean-k-mooney we have been considering other distos for testign but few if any really meet the min ram requirements we have
19:33:26 sean-k-mooney gento recently started providign cloud-images iwth cloud ini but they are like 930+ MBs
19:33:39 sean-k-mooney vs the like 20-50mb of a cirros image
19:33:54 mikal I have been toying with the idea of a specialised UEFI binary for SPICE testing and skipping the OS entirely. I guess it depends what functionality you need from the instance.
19:34:20 mikal Also, I have way more random tangents than I will ever have time to persue.
19:34:28 sean-k-mooney ya so ironic were not supper ok with the idea of alpine because they worried about he use of musle libc
19:34:49 sean-k-mooney nova does not really care about that which is why i was prposin git
19:35:04 sean-k-mooney mikal: for tempest we need a small usbset of utils
19:35:16 sean-k-mooney toybox/busybox mostly covers it
19:35:34 sean-k-mooney although i belive we use gnu core utils version in cirros today
19:36:26 sean-k-mooney mikal: i think frickler has been somehwat invovled in cirros mantaince lately but im not reallly sure
19:37:15 sean-k-mooney frickler: do you know if they are still working on a 0.7.x release with 24.04 kernel and package rebase?
19:37:18 mikal sean-k-mooney: they certainly did the most recent release.
19:39:17 sean-k-mooney mikal: i know we are hoping to do a release with https://github.com/cirros-dev/cirros/pull/122 after epoxy is released
19:39:47 sean-k-mooney before would also be fine but as of expoxy nova will be able to create vms with igb nic which supprot emulated sriov in the guest
19:40:10 sean-k-mooney mikal: we are hopping to be able to do some sriov tesing in ci once our providers are capabliy fo supproting that
19:40:43 sean-k-mooney it will be a while before thats realsitc however
20:31:38 Uggla sean-k-mooney, elodilles, https://review.opendev.org/c/openstack/releases/+/941862 +1 again.
20:36:40 frickler sean-k-mooney: I'm not aware of anyone actively working on cirros, but I could do a bit if needed. that PR should be in 0.6.3 though?
20:39:25 opendevreview Luis Enrique Morales Mendez proposed openstack/nova master: Add 'LOG' to archive_deleted_rows function https://review.opendev.org/c/openstack/nova/+/942441
21:25:49 opendevreview Merged openstack/nova master: Reproducer for bug 2098892 https://review.opendev.org/c/openstack/nova/+/942402
21:57:26 sean-k-mooney frickler: 0.6.3 is using hte latest (at the time) 22.04 hwe kernel
21:57:36 sean-k-mooney frickler: but not 24.04
21:57:56 sean-k-mooney frickler: unless you ment the igb change which might be in 0.6.3
23:25:55 opendevreview Merged openstack/nova master: libvirt: Fix regression of listDevices() return type https://review.opendev.org/c/openstack/nova/+/942334
23:36:24 opendevreview melanie witt proposed openstack/nova stable/2024.2: Reproducer for bug 2098892 https://review.opendev.org/c/openstack/nova/+/942651
23:36:25 opendevreview melanie witt proposed openstack/nova stable/2024.2: libvirt: Fix regression of listDevices() return type https://review.opendev.org/c/openstack/nova/+/942652
23:37:40 opendevreview melanie witt proposed openstack/nova stable/2024.1: Reproducer for bug 2098892 https://review.opendev.org/c/openstack/nova/+/942653
23:37:41 opendevreview melanie witt proposed openstack/nova stable/2024.1: libvirt: Fix regression of listDevices() return type https://review.opendev.org/c/openstack/nova/+/942654
23:38:49 opendevreview melanie witt proposed openstack/nova stable/2023.2: Reproducer for bug 2098892 https://review.opendev.org/c/openstack/nova/+/942655
23:38:50 opendevreview melanie witt proposed openstack/nova stable/2023.2: libvirt: Fix regression of listDevices() return type https://review.opendev.org/c/openstack/nova/+/942656
#openstack-nova - 2025-02-25
00:24:15 melwitt fyi elodilles these ^ are fixes for an not-yet-released regression so it would be best to not make releases on these branches until they are merged
00:35:06 opendevreview Merged openstack/nova master: libvirt: direct SPICE console object changes https://review.opendev.org/c/openstack/nova/+/926876
01:26:14 opendevreview Merged openstack/nova master: libvirt: direct SPICE console database changes https://review.opendev.org/c/openstack/nova/+/926877
03:23:02 opendevreview Merged openstack/nova master: libvirt: allow direct SPICE connections to qemu https://review.opendev.org/c/openstack/nova/+/924844
03:24:04 sean-k-mooney[m] mikal: ^ congrats
03:43:21 opendevreview Takashi Kajinami proposed openstack/nova master: Use consistent program name for wsgi scripts and entry points https://review.opendev.org/c/openstack/nova/+/942605
03:48:44 opendevreview Takashi Kajinami proposed openstack/nova master: Migrate MEM_ENCRYPTION_CONTEXT from root provider https://review.opendev.org/c/openstack/nova/+/921814
03:48:45 opendevreview Takashi Kajinami proposed openstack/nova master: Detect AMD SEV-ES support https://review.opendev.org/c/openstack/nova/+/925685
03:48:46 opendevreview Takashi Kajinami proposed openstack/nova master: Add hw_mem_encryption_model image property https://review.opendev.org/c/openstack/nova/+/927706
03:48:47 opendevreview Takashi Kajinami proposed openstack/nova master: libvirt: Launch instances with SEV-ES memory encryption https://review.opendev.org/c/openstack/nova/+/926106
03:50:40 tkajinam I know people are busy these days but I really hope I can get feedback about this series ^^^
03:50:44 tkajinam and https://review.opendev.org/c/openstack/nova/+/845660
03:51:53 tkajinam https://review.opendev.org/c/openstack/nova/+/940619 is also easy-win to get rid of deprecation warnings
05:10:08 sshmlbrg sean-k-mooney: Are you around? Is nova_context temporary mutation context manager?
06:29:36 frickler sean-k-mooney: I was talking about the igb change that you referenced before, yes. 0.6.3 was done 2 days after it merged, so it should be included. also 22.04 hwe and 24.04 kernels should be kind of synced?
08:48:14 mikal sean-k-mooney: I saw that, but had to cook dinner so the kids didn't resort to cannibalism. Thanks again for all your help.
08:48:29 mikal sean-k-mooney: now to get the client patches merged I suppose. I wonder if I've missed the deadline for that in epoxy...
09:09:23 opendevreview ribaudr proposed openstack/nova master: Add managed flag to PCI device specification https://review.opendev.org/c/openstack/nova/+/937649
09:09:24 opendevreview ribaudr proposed openstack/nova master: Update driver to deal with managed flag https://review.opendev.org/c/openstack/nova/+/938405
11:43:48 sean-k-mooney mikal: client freeze is gerneally the saem as FF
11:45:09 sean-k-mooney frickler: the 22.04 hwe kernel is basiclly the kernels form the 3 non lts release until the next lts. 24.04 baseline might be similar but 24.04 hwe will be newer

Earlier   Later