| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2024-09-17 | |||
| 16:25:02 | noonedeadpunk | yeah, around jsut a bit busy | |
| 16:25:27 | bauzas | like, I don't want nova to just sub the path and see whether there is path | |
| 16:25:33 | sean-k-mooney | so this is just exposing a way to pass path to novnc | |
| 16:25:44 | bauzas | maybe a config option, maybe something like a relnote | |
| 16:26:08 | noonedeadpunk | nova does not sub the path - but it jsut respects whatever user defiens in config | |
| 16:26:09 | bauzas | but I don't want us to not expose that | |
| 16:26:25 | noonedeadpunk | by not respecting query, and not just fqdn | |
| 16:26:33 | bauzas | well your change will parse the qs | |
| 16:26:43 | noonedeadpunk | and append to it | |
| 16:27:09 | sean-k-mooney | so we brifly dicussed having a config option like the exisitng port option for the query sting | |
| 16:27:24 | noonedeadpunk | vs currnet behaviour where query is hardcoded basically | |
| 16:28:08 | sean-k-mooney | for libvirt we decieded that just passing a uri for the connection was better | |
| 16:28:17 | bauzas | well, here you're hard parsing the query with only 'path' | |
| 16:28:17 | noonedeadpunk | well, I'm not sure about config option ,as there could be more usecases whre you wnat to pass smth as admin to novnc | |
| 16:28:24 | sean-k-mooney | so that why i was mostly ok with noonedeadpunk approch as its consitent with that | |
| 16:28:54 | sean-k-mooney | bauzas: there may be other query arges that novnc uses tha tcould be reasoanable to pass | |
| 16:29:02 | noonedeadpunk | bauzas: yeah, but current code will jsut add `?path=?token=<uuid>` | |
| 16:29:04 | sean-k-mooney | so i woudl prefer not to limit it to path | |
| 16:29:37 | bauzas | anyway, as I said, this is a technical detail | |
| 16:29:43 | noonedeadpunk | so if you try to add like anything to the `novncproxy_base_url` - you will end up with invalid token | |
| 16:29:54 | bauzas | I don't oppose to the usecase and I think keeping an URI is important | |
| 16:30:13 | noonedeadpunk | probably I jsut don't get what you're proposing isntead... | |
| 16:30:35 | bauzas | as I said, I only have implementation concerns | |
| 16:30:51 | bauzas | your current patch only accepts 'path' as a qs param | |
| 16:30:59 | noonedeadpunk | but like unit tests shows it should be quite consistent... I can add more test cases if I'll get what these concerns are | |
| 16:31:35 | bauzas | if we restrict to 'path' then we need to document it better than "oh and now you can pass *any* qs" | |
| 16:31:42 | sean-k-mooney | noonedeadpunk: bauzas is askign to make sure it will work with any arg | |
| 16:31:51 | noonedeadpunk | it's not restricted with path? | |
| 16:32:14 | noonedeadpunk | l133 of https://review.opendev.org/c/openstack/nova/+/928839/3/nova/tests/unit/objects/test_console_auth_token.py | |
| 16:32:21 | bauzas | "@item(hotlist):button2 | |
| 16:32:24 | bauzas | doh | |
| 16:32:46 | bauzas | the documentation says "You can also supply extra request arguments" | |
| 16:33:25 | bauzas | anyway, can we just (for the sake of my beer) accept that blueprint as specless and nitpick over the change as much as we want over the Epoxy timeframe ? :) | |
| 16:33:34 | noonedeadpunk | ++ | |
| 16:33:43 | sean-k-mooney | +1 form me also | |
| 16:34:04 | bauzas | any objection ? | |
| 16:34:48 | bauzas | looks not | |
| 16:35:10 | bauzas | #agreed https://blueprints.launchpad.net/nova/+spec/novnc-base-url-respect-extra-params accepted as specless for the Epoxy release | |
| 16:35:17 | bauzas | I'll file the paperwork | |
| 16:35:22 | gibi | OK for me | |
| 16:35:24 | bauzas | that's it for the agenda | |
| 16:35:39 | bauzas | any other bit you'd like to raise ? | |
| 16:35:56 | bauzas | looks not | |
| 16:36:06 | bauzas | my beer won't heat, cool | |
| 16:36:10 | bauzas | thanks all | |
| 16:36:13 | bauzas | #endmeeting | |
| 16:36:14 | opendevmeet | Meeting ended Tue Sep 17 16:36:13 2024 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) | |
| 16:36:14 | opendevmeet | Minutes: https://meetings.opendev.org/meetings/nova/2024/nova.2024-09-17-16.01.html | |
| 16:36:14 | opendevmeet | Minutes (text): https://meetings.opendev.org/meetings/nova/2024/nova.2024-09-17-16.01.txt | |
| 16:36:14 | opendevmeet | Log: https://meetings.opendev.org/meetings/nova/2024/nova.2024-09-17-16.01.log.html | |
| 16:36:17 | sean-k-mooney | o/ | |
| 16:36:22 | elodilles | thanks o/ | |
| 16:38:23 | gibi | o/ | |
| #openstack-nova - 2024-09-18 | |||
| 01:14:48 | opendevreview | Masahito Muroi proposed openstack/nova master: Use boot_roles_count and boot_role_ |
|
| 04:43:48 | opendevreview | OpenStack Proposal Bot proposed openstack/nova master: Imported Translations from Zanata https://review.opendev.org/c/openstack/nova/+/929719 | |
| 06:08:52 | gibi | bauzas: it seems to me we are still blocked https://review.opendev.org/c/openstack/nova/+/928310/comments/b3c9bcb6_9be616a6 | |
| 06:11:45 | bauzas | eek ok I see | |
| 06:13:46 | bauzas | https://github.com/openstack/python-openstackclient/blob/master/openstackclient/compute/v2/server.py#L3875 | |
| 06:14:15 | bauzas | I'm lost now | |
| 06:14:26 | bauzas | we still send admin_password to evacuate | |
| 06:14:39 | bauzas | oh, but that's to the sdk | |
| 06:17:43 | bauzas | and I don't see 7.1.1 here https://docs.openstack.org/releasenotes/python-openstackclient/unreleased.html | |
| 06:18:17 | bauzas | elodilles: ^ | |
| 06:21:39 | bauzas | https://github.com/openstack/python-openstackclient/compare/7.1.0...7.1.1 | |
| 06:22:12 | bauzas | oh fuck, I understand it | |
| 06:22:54 | bauzas | https://github.com/openstack/openstacksdk/blob/master/openstack/compute/v2/server.py#L748 | |
| 06:23:15 | bauzas | this is neither 'password' nor 'admin_password', but just 'admin_pass' | |
| 06:23:27 | bauzas | we lost 3 days basically and we need another fix and another release | |
| 06:23:46 | bauzas | stephenfin: elodilles: frickler: ^ | |
| 06:47:57 | bauzas | gibi: https://review.opendev.org/c/openstack/python-openstackclient/+/929726 | |
| 06:48:18 | bauzas | this is 8.47am and I already have headache | |
| 06:50:29 | bauzas | frickler: elodilles: I'm in favor of exceptionnally rollbacking to OSC6.x for Dalmatian, we are always awfully late for Nova RC1 | |
| 07:00:48 | gibi | bauzas: quickly reproduced the osc issue in a fresh devstack, then applied your patch and now I have proof that it works | |
| 07:01:02 | gibi | thanks for quickly proposing the fix | |
| 07:30:10 | gibi | bauzas: if you are interested in the microversion 2.95 evacuate issue I mentioned in my comment in the osc patch then https://bugs.launchpad.net/nova/+bug/2081023 This is probably just a cosmetic issue. | |
| 07:47:53 | frickler | thx, I commented on this yesterday already in the qa channel, I was under the impression that sean-k-mooney had tested my change, sorry for that. is this option also really named differently between this and what create and rebuild use? might be just an sdk thing, but certainly not helpful | |
| 07:48:25 | frickler | I'm also not really here this week, so try to ping other sdk, release and reqs people as needed | |
| 08:12:50 | bauzas | sorry folks, I was off the laptop last hour | |
| 08:12:52 | bauzas | now I'm back | |
| 08:14:39 | bauzas | so, I'd prefer to rollback the u-c by OSC6 now | |
| 08:16:16 | bauzas | gibi: elodilles ^ | |
| 08:16:19 | bauzas | stephenfin: too ^ | |
| 08:40:50 | danfai_ | Quick question: In nova I saw that the name is sanitized to be used as a hostname. The hostname should then be maximum 63 characters long. In case you use a name that is longer, the last characters are truncated. If you now use the server create call to create multiple VMs, this length will be longer, since the -{index} is appended. Is this supposed to be like this? | |
| 09:30:09 | gibi | bauzas: do you suggest to reopen https://review.opendev.org/c/openstack/requirements/+/929552 ? I have no power to un-abandon it. | |
| 09:37:05 | sean-k-mooney | i can do that now | |
| 09:37:43 | sean-k-mooney | done | |
| 09:37:50 | sean-k-mooney | although it needs a rebase | |
| 09:37:56 | sean-k-mooney | will i do that now | |
| 09:38:05 | sean-k-mooney | and add 7.1.2? | |
| 09:39:03 | sean-k-mooney | sorry 7.1.1 | |
| 09:40:20 | gibi | yeah 7.1.1 is still broken | |
| 09:42:29 | sean-k-mooney | ok updated https://review.opendev.org/c/openstack/requirements/+/929552 | |
| 09:43:59 | gibi | sean-k-mooney: thanks | |
| 09:44:23 | gibi | I pinged the release channel as well | |
| 09:45:16 | sean-k-mooney | looking back at my orgial comment i linked to the code https://review.opendev.org/c/openstack/python-openstackclient/+/929236/comment/d39df785_1f261b9e/ to check the parmater was correct | |
| 09:45:33 | sean-k-mooney | and i misread admin_password as admin_pass | |
| 09:51:05 | bauzas | sorry, I was again off (I have a tech folk in my house for my optic fiber issue) | |
| 09:51:51 | bauzas | sean-k-mooney: stephenfin: I'm really sorry about breaking the OSC7 version, but we can't wait for a new release for like 2 days | |
| 09:52:20 | bauzas | and given https://bugs.launchpad.net/nova/+bug/2081023 I'd prefer to have time for testing it | |
| 10:16:23 | opendevreview | sean mooney proposed openstack/nova master: [DNM] testing unreleased osc https://review.opendev.org/c/openstack/nova/+/929757 | |