| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2024-08-08 | |||
| 17:13:40 | sean-k-mooney | elinux: what problem are you having | |
| 17:19:41 | elinux | sean-k-mooney: I am writing a custom filter for scheduler, so in the process have to access the req object's metadata value, which is not passed in the code by default to the scheduler filter test of host_passes. so I have passed it from build_request object at the function 'def schedule_and_build_instances' in conductor/manage.py file. I did this by simply doing 'request_specs[0].metadata=build_requests[0].instance.metadata' | |
| 17:20:27 | elinux | sean-k-mooney: but when it reached the scheduler manager.py thru the rabbitmq, the spec_obj is loosing the metadata object | |
| 17:20:57 | elinux | sean-k-mooney: so how to pass this value to spec_obj that it retains for checking it in the filter host_pass ? | |
| 17:21:29 | sean-k-mooney | you dont | |
| 17:21:39 | sean-k-mooney | while custom out of tree filters can be written | |
| 17:21:57 | sean-k-mooney | they can only use the contet of the host_state object adn request spec | |
| 17:22:23 | elinux | sean-k-mooney: why cant we pass it like I suggested ? | |
| 17:22:48 | sean-k-mooney | you can in your fork but its not somehting that woudl be supproted by any disto or upstream | |
| 17:22:55 | elinux | sean-k-mooney: what is stripping it when it reaches the scheduler ? | |
| 17:23:27 | elinux | sean-k-mooney: not concerned with the support now. I want it to just make it work for our requirement | |
| 17:23:47 | elinux | sean-k-mooney: any ideas ? | |
| 17:24:28 | elinux | sean-k-mooney: how to make object assigments to a class object persistent across functions ? | |
| 17:24:34 | sean-k-mooney | yes but im not sure i should share them. your asking upstream to help you do somethign we dont supprot :) | |
| 17:24:50 | sean-k-mooney | so this is the request spec object https://github.com/openstack/nova/blob/master/nova/objects/request_spec.py#L46 | |
| 17:25:21 | sean-k-mooney | we provide access to the schduler hint and the instance uuid https://github.com/openstack/nova/blob/master/nova/objects/request_spec.py#L100-L101 | |
| 17:25:30 | sean-k-mooney | but not instance metadata | |
| 17:25:57 | sean-k-mooney | so normlaly i woudl ways your filter should use a scheduler hint, flavor extra spec or image property insted | |
| 17:26:18 | sean-k-mooney | if it must be the server metadata | |
| 17:28:07 | sean-k-mooney | the only way to do it form a filter today woudl to abuse pythons dynmic types | |
| 17:28:49 | elinux | sean-k-mooney: so how about specifying image extra specs and comapring them in the filter ? is that feasible ? | |
| 17:28:50 | sean-k-mooney | basilly implemnt the singelton patther adn do a db lookup in the filter once and asign the metadta into a dynimcaly created filed in the request spec object | |
| 17:29:13 | sean-k-mooney | elinux: yep the request spec has a fully copy of the flavor and image | |
| 17:29:18 | sean-k-mooney | including the extra specs | |
| 17:29:25 | sean-k-mooney | so you can look at either today | |
| 17:30:05 | sean-k-mooney | we just dont provided instance metadata because per instance schduling filter are ment to use scheuler hints | |
| 17:30:12 | sean-k-mooney | so that they will be read only once created | |
| 17:30:39 | sean-k-mooney | elinux: https://docs.openstack.org/nova/latest/reference/scheduler-hints-vs-flavor-extra-specs.html might be useful to read over | |
| 17:30:49 | elinux | sean-k-mooney: can you explain this a bit further "basilly implemnt the singelton patther adn do a db lookup in the filter once and asign the metadta into a dynimcaly created filed in the request spec object" ? | |
| 17:34:13 | elinux | sean-k-mooney: but I still the request's metadata information for testing it in the filter, so that I can take a decision based on its value | |
| 17:34:25 | elinux | *but I still need | |
| 17:37:31 | sean-k-mooney | https://paste.opendev.org/show/825009/ | |
| 17:38:58 | sean-k-mooney | thats a horbile hack but on the first execution of the filter for a given request spec object you can abuse the fact that python will allow you to assign to filed that dont exist at any time to do the lookup form the buildRequest onece and then pass the same data to all other hosts | |
| 17:40:59 | sean-k-mooney | for everyone else watching done ever do that in a out of tree filters that just asking for pain | |
| 17:41:19 | sean-k-mooney | s/done/don't/ | |
| 18:20:15 | opendevreview | Merged openstack/nova stable/2023.1: Drop Fedora support https://review.opendev.org/c/openstack/nova/+/925940 | |
| 18:32:09 | opendevreview | Merged openstack/nova master: libvirt: Remove node device XML validate flags https://review.opendev.org/c/openstack/nova/+/925826 | |
| 20:38:21 | opendevreview | Merged openstack/nova stable/2024.1: [CI] Replace deprecated regex https://review.opendev.org/c/openstack/nova/+/925522 | |
| 23:45:39 | opendevreview | Goutham Pacha Ravi proposed openstack/nova master: DNM: test dependency on devstack-plugin-ceph changes https://review.opendev.org/c/openstack/nova/+/918957 | |
| #openstack-nova - 2024-08-09 | |||
| 00:29:01 | opendevreview | Merged openstack/nova stable/2023.2: [CI] Replace deprecated regex https://review.opendev.org/c/openstack/nova/+/925523 | |
| 04:15:49 | opendevreview | Merged openstack/nova stable/2023.1: [CI] Replace deprecated regex https://review.opendev.org/c/openstack/nova/+/925524 | |
| 05:11:35 | opendevreview | Merged openstack/nova master: libvirt: Ensure swtpm_ioctl is available for vTPM support https://review.opendev.org/c/openstack/nova/+/908546 | |
| 05:11:44 | opendevreview | Merged openstack/nova master: libvirt: Detect vtpm support by libvirt https://review.opendev.org/c/openstack/nova/+/908508 | |
| 05:11:52 | opendevreview | Merged openstack/nova master: Fix guard for NVMeOF volumes https://review.opendev.org/c/openstack/nova/+/895192 | |
| 09:29:47 | elodilles | sean-k-mooney: thanks for the +2+W's on stable regex fixing patches o:) | |
| 09:38:17 | sean-k-mooney | i could not sleep so i tought it would be nice to wake up and have those and a few other small patches merged :) | |
| 10:28:00 | opendevreview | Maxime Lubin proposed openstack/nova-specs master: USB over IP https://review.opendev.org/c/openstack/nova-specs/+/920687 | |
| 15:04:48 | opendevreview | Takashi Kajinami proposed openstack/nova master: libvirt: Report available TPM models https://review.opendev.org/c/openstack/nova/+/909183 | |
| 15:07:13 | opendevreview | Takashi Kajinami proposed openstack/nova master: libvirt: Report available TPM models https://review.opendev.org/c/openstack/nova/+/909183 | |
| 15:21:11 | opendevreview | Takashi Kajinami proposed openstack/nova master: Migrate MEM_ENCRYPTION_CONTEXT from root provider https://review.opendev.org/c/openstack/nova/+/921814 | |
| 15:21:12 | opendevreview | Takashi Kajinami proposed openstack/nova master: Detect AMD SEV-ES support https://review.opendev.org/c/openstack/nova/+/925685 | |
| 16:14:24 | opendevreview | Piotr Czarnik proposed openstack/nova master: Bump websockify version to 0.10.0 due to methods removal in Python3.9 https://review.opendev.org/c/openstack/nova/+/926077 | |
| 18:00:23 | opendevreview | Artom Lifshitz proposed openstack/nova master: Fix s/addtional/additional/ typo https://review.opendev.org/c/openstack/nova/+/926083 | |
| 18:48:44 | opendevreview | Ghanshyam proposed openstack/placement master: DNM: testing latest oslo.policy https://review.opendev.org/c/openstack/placement/+/926088 | |
| 21:27:34 | obrest | Would it be possible for nova to add traits for Intel-AMX for hypervisors where this is available? Similar to how AVX512/AVX2 etc are implemented already? | |
| 21:30:11 | obrest | I guess a patch similar to this is whats needed? https://github.com/openstack/nova/commit/bc784a1c1fa6ae0fa332cfd4dfa35283d3ee2869 | |
| #openstack-nova - 2024-08-10 | |||
| 03:40:47 | opendevreview | Takashi Kajinami proposed openstack/nova master: libvirt: Report available TPM models https://review.opendev.org/c/openstack/nova/+/909183 | |
| 03:44:31 | opendevreview | Takashi Kajinami proposed openstack/nova master: Detect AMD SEV-ES support https://review.opendev.org/c/openstack/nova/+/925685 | |
| 04:21:34 | opendevreview | melanie witt proposed openstack/nova master: DNM testing https://review.opendev.org/c/openstack/nova/+/925635 | |
| 04:21:34 | opendevreview | melanie witt proposed openstack/nova master: DNM testing cont'd https://review.opendev.org/c/openstack/nova/+/925838 | |
| 06:10:38 | opendevreview | Takashi Kajinami proposed openstack/nova master: libvirt: Launch instances with SEV-ES memory encryption https://review.opendev.org/c/openstack/nova/+/926106 | |
| 06:21:11 | opendevreview | Takashi Kajinami proposed openstack/nova master: Detect AMD SEV-ES support https://review.opendev.org/c/openstack/nova/+/925685 | |
| 06:21:11 | opendevreview | Takashi Kajinami proposed openstack/nova master: libvirt: Launch instances with SEV-ES memory encryption https://review.opendev.org/c/openstack/nova/+/926106 | |
| 13:54:58 | opendevreview | Artom Lifshitz proposed openstack/nova master: Functional test test_boot_reschedule_with_proper_pci_device_count https://review.opendev.org/c/openstack/nova/+/760354 | |
| 13:54:58 | opendevreview | Artom Lifshitz proposed openstack/nova master: Fix PCI passthrough race on reschedule (refresh) https://review.opendev.org/c/openstack/nova/+/710848 | |
| #openstack-nova - 2024-08-12 | |||
| 03:17:11 | zhhuabj | hi team, can anyone help review this patch? thanks - https://review.opendev.org/c/openstack/nova/+/920374 | |
| 08:31:48 | songwenping_ | hi, team, create vm with specify compute nodes raises the exception:No nodes matched due to not matching 'force_nodes' value, any advice? | |
| 08:34:48 | songwenping_ | migrate vm to this node is success. | |
| 10:56:39 | opendevreview | Michael Still proposed openstack/nova master: libvirt: Add config option to require secure SPICE. https://review.opendev.org/c/openstack/nova/+/922544 | |
| 10:56:40 | opendevreview | Michael Still proposed openstack/nova master: libvirt: allow direct SPICE connections to qemu https://review.opendev.org/c/openstack/nova/+/924844 | |
| 10:56:40 | opendevreview | Michael Still proposed openstack/nova master: libvirt: Add extra spec for sound device. https://review.opendev.org/c/openstack/nova/+/926126 | |
| 11:02:57 | opendevreview | Amit Uniyal proposed openstack/nova master: Reproducer test for image property hw_architecture https://review.opendev.org/c/openstack/nova/+/926128 | |
| 13:03:16 | opendevreview | Amit Uniyal proposed openstack/nova master: Reproducer test for image property hw_architecture https://review.opendev.org/c/openstack/nova/+/926128 | |
| 14:34:06 | opendevreview | Dan Smith proposed openstack/nova master: Deprecate AMI image formats https://review.opendev.org/c/openstack/nova/+/926144 | |
| 14:34:07 | dansmith | bauzas: ^ | |
| 15:06:26 | sean-k-mooney | dansmith: i think bauzas is on pto for a another week | |
| 15:06:33 | sean-k-mooney | maybe too | |
| 15:06:39 | dansmith | yep, realize now | |
| 15:06:39 | sean-k-mooney | but ill also look at that soon | |
| 15:28:58 | opendevreview | Takashi Kajinami proposed openstack/nova master: Migrate MEM_ENCRYPTION_CONTEXT from root provider https://review.opendev.org/c/openstack/nova/+/921814 | |
| 15:28:59 | opendevreview | Takashi Kajinami proposed openstack/nova master: Detect AMD SEV-ES support https://review.opendev.org/c/openstack/nova/+/925685 | |
| 15:28:59 | opendevreview | Takashi Kajinami proposed openstack/nova master: libvirt: Launch instances with SEV-ES memory encryption https://review.opendev.org/c/openstack/nova/+/926106 | |
| 16:09:44 | opendevreview | Takashi Kajinami proposed openstack/nova master: Migrate MEM_ENCRYPTION_CONTEXT from root provider https://review.opendev.org/c/openstack/nova/+/921814 | |
| 16:09:44 | opendevreview | Takashi Kajinami proposed openstack/nova master: Detect AMD SEV-ES support https://review.opendev.org/c/openstack/nova/+/925685 | |
| 16:09:45 | opendevreview | Takashi Kajinami proposed openstack/nova master: libvirt: Launch instances with SEV-ES memory encryption https://review.opendev.org/c/openstack/nova/+/926106 | |
| 23:31:14 | opendevreview | Michael Still proposed openstack/nova master: libvirt: Add config option to require secure SPICE. https://review.opendev.org/c/openstack/nova/+/922544 | |
| 23:31:15 | opendevreview | Michael Still proposed openstack/nova master: libvirt: allow direct SPICE connections to qemu https://review.opendev.org/c/openstack/nova/+/924844 | |
| 23:31:15 | opendevreview | Michael Still proposed openstack/nova master: libvirt: Add extra spec for sound device. https://review.opendev.org/c/openstack/nova/+/926126 | |
| #openstack-nova - 2024-08-13 | |||
| 02:39:25 | opendevreview | Takashi Kajinami proposed openstack/nova master: Detect AMD SEV-ES support https://review.opendev.org/c/openstack/nova/+/925685 | |
| 02:39:25 | opendevreview | Takashi Kajinami proposed openstack/nova master: libvirt: Launch instances with SEV-ES memory encryption https://review.opendev.org/c/openstack/nova/+/926106 | |
| 14:23:32 | opendevreview | sean mooney proposed openstack/nova master: Skip new image format tests https://review.opendev.org/c/openstack/nova/+/926215 | |
| 14:26:50 | dansmith | gibi_: can you +W this trivial skip patch to unblock the gate (for us and others) ? ^ | |
| 14:30:29 | sean-k-mooney | im not sure that job runs elsewhere | |
| 14:30:36 | sean-k-mooney | but it might i could check | |
| 14:30:38 | dansmith | it runs in lots of places | |
| 14:30:42 | dansmith | glance for one | |
| 14:30:49 | dansmith | also in the ceph plugin | |
| 14:31:01 | sean-k-mooney | oh ok then yes for others too | |
| 14:31:22 | dansmith | I think cinder's ceph import job might be based on it too, I forget | |
| 14:49:29 | gibi_ | dansmith: +A thanks for the tempest tests | |