| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2024-08-10 | |||
| 13:54:58 | opendevreview | Artom Lifshitz proposed openstack/nova master: Functional test test_boot_reschedule_with_proper_pci_device_count https://review.opendev.org/c/openstack/nova/+/760354 | |
| 13:54:58 | opendevreview | Artom Lifshitz proposed openstack/nova master: Fix PCI passthrough race on reschedule (refresh) https://review.opendev.org/c/openstack/nova/+/710848 | |
| #openstack-nova - 2024-08-12 | |||
| 03:17:11 | zhhuabj | hi team, can anyone help review this patch? thanks - https://review.opendev.org/c/openstack/nova/+/920374 | |
| 08:31:48 | songwenping_ | hi, team, create vm with specify compute nodes raises the exception:No nodes matched due to not matching 'force_nodes' value, any advice? | |
| 08:34:48 | songwenping_ | migrate vm to this node is success. | |
| 10:56:39 | opendevreview | Michael Still proposed openstack/nova master: libvirt: Add config option to require secure SPICE. https://review.opendev.org/c/openstack/nova/+/922544 | |
| 10:56:40 | opendevreview | Michael Still proposed openstack/nova master: libvirt: allow direct SPICE connections to qemu https://review.opendev.org/c/openstack/nova/+/924844 | |
| 10:56:40 | opendevreview | Michael Still proposed openstack/nova master: libvirt: Add extra spec for sound device. https://review.opendev.org/c/openstack/nova/+/926126 | |
| 11:02:57 | opendevreview | Amit Uniyal proposed openstack/nova master: Reproducer test for image property hw_architecture https://review.opendev.org/c/openstack/nova/+/926128 | |
| 13:03:16 | opendevreview | Amit Uniyal proposed openstack/nova master: Reproducer test for image property hw_architecture https://review.opendev.org/c/openstack/nova/+/926128 | |
| 14:34:06 | opendevreview | Dan Smith proposed openstack/nova master: Deprecate AMI image formats https://review.opendev.org/c/openstack/nova/+/926144 | |
| 14:34:07 | dansmith | bauzas: ^ | |
| 15:06:26 | sean-k-mooney | dansmith: i think bauzas is on pto for a another week | |
| 15:06:33 | sean-k-mooney | maybe too | |
| 15:06:39 | dansmith | yep, realize now | |
| 15:06:39 | sean-k-mooney | but ill also look at that soon | |
| 15:28:58 | opendevreview | Takashi Kajinami proposed openstack/nova master: Migrate MEM_ENCRYPTION_CONTEXT from root provider https://review.opendev.org/c/openstack/nova/+/921814 | |
| 15:28:59 | opendevreview | Takashi Kajinami proposed openstack/nova master: Detect AMD SEV-ES support https://review.opendev.org/c/openstack/nova/+/925685 | |
| 15:28:59 | opendevreview | Takashi Kajinami proposed openstack/nova master: libvirt: Launch instances with SEV-ES memory encryption https://review.opendev.org/c/openstack/nova/+/926106 | |
| 16:09:44 | opendevreview | Takashi Kajinami proposed openstack/nova master: Migrate MEM_ENCRYPTION_CONTEXT from root provider https://review.opendev.org/c/openstack/nova/+/921814 | |
| 16:09:44 | opendevreview | Takashi Kajinami proposed openstack/nova master: Detect AMD SEV-ES support https://review.opendev.org/c/openstack/nova/+/925685 | |
| 16:09:45 | opendevreview | Takashi Kajinami proposed openstack/nova master: libvirt: Launch instances with SEV-ES memory encryption https://review.opendev.org/c/openstack/nova/+/926106 | |
| 23:31:14 | opendevreview | Michael Still proposed openstack/nova master: libvirt: Add config option to require secure SPICE. https://review.opendev.org/c/openstack/nova/+/922544 | |
| 23:31:15 | opendevreview | Michael Still proposed openstack/nova master: libvirt: allow direct SPICE connections to qemu https://review.opendev.org/c/openstack/nova/+/924844 | |
| 23:31:15 | opendevreview | Michael Still proposed openstack/nova master: libvirt: Add extra spec for sound device. https://review.opendev.org/c/openstack/nova/+/926126 | |
| #openstack-nova - 2024-08-13 | |||
| 02:39:25 | opendevreview | Takashi Kajinami proposed openstack/nova master: Detect AMD SEV-ES support https://review.opendev.org/c/openstack/nova/+/925685 | |
| 02:39:25 | opendevreview | Takashi Kajinami proposed openstack/nova master: libvirt: Launch instances with SEV-ES memory encryption https://review.opendev.org/c/openstack/nova/+/926106 | |
| 14:23:32 | opendevreview | sean mooney proposed openstack/nova master: Skip new image format tests https://review.opendev.org/c/openstack/nova/+/926215 | |
| 14:26:50 | dansmith | gibi_: can you +W this trivial skip patch to unblock the gate (for us and others) ? ^ | |
| 14:30:29 | sean-k-mooney | im not sure that job runs elsewhere | |
| 14:30:36 | sean-k-mooney | but it might i could check | |
| 14:30:38 | dansmith | it runs in lots of places | |
| 14:30:42 | dansmith | glance for one | |
| 14:30:49 | dansmith | also in the ceph plugin | |
| 14:31:01 | sean-k-mooney | oh ok then yes for others too | |
| 14:31:22 | dansmith | I think cinder's ceph import job might be based on it too, I forget | |
| 14:49:29 | gibi_ | dansmith: +A thanks for the tempest tests | |
| 14:49:36 | dansmith | thanks! | |
| 15:44:36 | opendevreview | Artom Lifshitz proposed openstack/nova master: POC: Work around lbvirt reporting offline cores as being on socket 0 https://review.opendev.org/c/openstack/nova/+/926218 | |
| 16:02:42 | sean-k-mooney | @artom that not what we discussed doing to fix that | |
| 16:03:19 | sean-k-mooney | artom_: we dicussed makeign usre we first online all the cores at startup. then gather the info and then offline them when using the cpu state policy | |
| 16:04:26 | artom | I don't think I was there during those discussions :) | |
| 16:04:26 | gibi_ | hehe, just commented that to the review:) | |
| 16:04:36 | artom | But... the effect is the same, no? | |
| 16:05:00 | gibi_ | artom: nova-compute cannot assume that the pcpus are online after a restart | |
| 16:05:14 | artom | Ah, good point. | |
| 16:05:14 | gibi_ | especially as nova-compute offline them | |
| 16:06:35 | sean-k-mooney | artom: please also decorrage the get capablities with https://docs.python.org/3/library/functools.html#functools.lru_cache | |
| 16:06:52 | sean-k-mooney | the content of get_capabilities shoudl never change while the agent is running | |
| 16:07:02 | sean-k-mooney | we done actully need to call libvirt every time | |
| 16:07:16 | artom | Well that's a different thing | |
| 16:07:27 | artom | An improvement, but not related to fixing the bug | |
| 16:07:29 | sean-k-mooney | artom: we need to make this change to fix the bug | |
| 16:07:33 | sean-k-mooney | no its required | |
| 16:07:40 | artom | Explain yourself :) | |
| 16:07:47 | sean-k-mooney | because depenign on the livbirt verion once we turn off the cores the output will change | |
| 16:08:15 | sean-k-mooney | in some cases it will return the cached values form the first invocation in other version it will update and the info will be wrong | |
| 16:08:28 | artom | Oh, so you're saying memoize the entire return value instead of manually preserving the socket IDs? | |
| 16:08:34 | sean-k-mooney | yep | |
| 16:08:45 | artom | OK... can any other caps change while the agent is running? | |
| 16:08:56 | sean-k-mooney | not without breaking nova :) | |
| 16:09:37 | sean-k-mooney | we do not supprot cpu/memory hotplug or chaning the amount of hugepages while nova-comptue is running or chaning the cpu flags your cpu reprot at runtime | |
| 16:10:08 | sean-k-mooney | which is what this funciton is basicaly providing | |
| 16:10:33 | sean-k-mooney | if you want to do any of the above you shoudl restart nova-compute to pick up the change | |
| 16:10:50 | gibi_ | we basically already memoizing caps as there is a self._caps to save it and an early return | |
| 16:10:57 | sean-k-mooney | you proably shoudl not do any of the above on a host with instnaces either | |
| 16:11:14 | sean-k-mooney | oh true | |
| 16:11:22 | artom | There's a cache size limit, though. What happens when we hit it, and end up actually calling libvirt's caps and potentially getting the wrong socket? | |
| 16:11:53 | sean-k-mooney | artom: that now how that work but gibi is write | |
| 16:12:13 | sean-k-mooney | we are intenrlaly making this a proprty/singelton and early outing already | |
| 16:12:19 | sean-k-mooney | https://review.opendev.org/c/openstack/nova/+/926218/1/nova/virt/libvirt/host.py#802 | |
| 16:13:54 | artom | I'll be honest, I understand gibi_'s concern, but the lru_cache thing is confusing me | |
| 16:14:26 | sean-k-mooney | pretent i didn mention it | |
| 16:14:41 | artom | You -1'ed the patch and are asking for it :P | |
| 16:14:53 | sean-k-mooney | i -1 because the rest of the patch is wrong | |
| 16:14:55 | sean-k-mooney | even without htat | |
| 16:15:15 | artom | Is addressing gibi_'s comment enough to fix it? | |
| 16:15:27 | sean-k-mooney | yep | |
| 16:15:30 | artom | \o/ | |
| 16:15:52 | sean-k-mooney | we just neeed to make sure this work if you restart the agent multiple times | |
| 16:22:31 | sean-k-mooney | from an upstream point of view i think we can more or less vlaidate this with unit/funcitonal tests | |
| 16:22:44 | sean-k-mooney | we cant test this in tempest without modifyting the cpu toplogy fo the nodepool vms | |
| 16:22:52 | sean-k-mooney | we could chat to infa about that | |
| 16:23:13 | sean-k-mooney | we just need to hw_cpu_sockets=1 hw_cpu_threads=1 | |
| 16:23:33 | sean-k-mooney | on the nodepool images so that we do not have multipel sockets per numa node | |
| 16:23:51 | sean-k-mooney | to fully test it we would also need multiple numa nodes and maybe pci | |
| 16:24:09 | sean-k-mooney | so realistically i think we are going to have to follow up with third party ci and manual testing | |
| 16:24:32 | sean-k-mooney | and jsut test this with unit/functional test for now | |
| 16:25:24 | sean-k-mooney | we may want to consier if we shoudl alter the libvirt fixutre to emulate the observed behavior but im not sure if that is warrented or not | |
| 16:25:30 | gibi_ | a functional test for upstream is OK to me and we can manual test / whitbox test is downstream | |
| 16:25:35 | sean-k-mooney | i feel like that will be overly invasive | |
| 16:26:08 | gibi_ | sean-k-mooney: yeah, growing this logic into the fixture is too much, just mock the part of the fixture in the test case to simulate it oncec | |
| 16:27:44 | sean-k-mooney | ack we would have to modify https://github.com/openstack/nova/blob/master/nova/tests/fixtures/libvirt.py#L808-L822 | |
| 16:27:50 | sean-k-mooney | to be aware of the online state | |
| 16:28:12 | opendevreview | Stephen Finucane proposed openstack/nova master: hardware: Correct log https://review.opendev.org/c/openstack/nova/+/926223 | |
| 16:28:16 | sean-k-mooney | ... this https://github.com/openstack/nova/blob/master/nova/tests/fixtures/libvirt.py#L808-L847 | |
| 16:28:22 | stephenfin | sean-k-mooney: gibi: dead simple log fix there ^ | |
| 16:29:15 | sean-k-mooney | stephenfin: ah you also explaine what -2 is | |
| 16:29:30 | sean-k-mooney | for a second i tough you were just droping kb | |
| 16:29:49 | stephenfin | yeah, I've just copied what we do in the success case | |