Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2024-07-25
15:00:05 dansmith because to qemu, an iso is raw because it doesn't support it
15:00:36 TheJulia yeah
15:00:39 TheJulia makes sense actually
15:00:41 dansmith and ami/ari/aki images also have to be treated as raw because qemu-img doesn't support them when we're comparing notes
15:01:36 TheJulia yeah
15:01:48 dansmith basically this sort of hack: https://github.com/openstack/nova/blob/master/nova/virt/images.py#L186
15:04:43 andreykurilin sean-k-mooney: er… I cannot find the actual nova’s code that does it, but 403 is automatically propagated from neutron’s call. So my simplified case was totally irrelevant. Sorry for misleading you. It is only about 400 as a part of removeSecurityGroup now.
15:38:25 dansmith ralonsoh: does your comment on the ami snapshot patch mean it solves the problem for your neutron stuff?
15:39:46 dansmith ah looks like it from the neutron DNM patch, cool
15:39:48 dansmith sean-k-mooney: ^
17:07:15 priteau Looks like https://review.opendev.org/c/openstack/nova/+/924734 is ready to merge
17:23:02 frickler dansmith: ^^ do you want to have another look?
17:23:02 gmann sean-k-mooney: andreykurilin: on SG error. I agree to handle both 403 as well 400 in both Add/Remove SG cases which is always better than 500. NOTE: neither 400 or 403 need microversion bump as those are always existing error code from all the APIs so we can just fix this with bug fix with no microversion bump
17:23:36 dansmith frickler: +Wd
17:24:27 gmann sean-k-mooney: andreykurilin: 500 -> '400, 403, 404 or 415' is all ok. https://docs.openstack.org/nova/latest/contributor/microversions.html#id3 "The exception to not needing a microversion when returning a previously unspecified error code is the 400, 403, 404 and 415 cases. "
17:29:31 opendevreview Merged openstack/nova master: Remove AMI snapshot format special case https://review.opendev.org/c/openstack/nova/+/924866
17:29:41 gmann sean-k-mooney: andreykurilin but for 403 we should define new exception which can clearly have msg about neutron access error otherwise user can confuse on nova access issue. Something inherited from PolicyNotAuthorized or Forbidden but a different error msg - https://github.com/openstack/nova/blob/master/nova/exception.py#L191
17:31:22 gmann andreykurilin: just read your last msg about 403 is already propagated. can you check what error msg it say?
17:49:09 gmann andreykurilin: bcz I am not sure where we handle the neutron 403, but it is propagated in both cases addSecurityGroup and removeSecurityGroup ? https://github.com/openstack/nova/blob/master/nova/api/openstack/compute/security_groups.py#L421-L430 https://github.com/openstack/nova/blob/eb5e3374bcb5de3b5986b66438a59c73be7fb596/nova/api/openstack/wsgi.py#L667
18:15:54 andreykurilin gmann: `RESP BODY: {"forbidden": {"code": 403, "message": "rule:update_port is disallowed by policy\nNeutron server returns request_ids: ['req-97c54f6e-6876-4cf4-9657-b8b3be322f57’]”}}`. vs `RESP BODY: {"forbidden": {"code": 403, "message": "Policy doesn't allow os_compute_api:os-security-groups:add to be performed.”}}` in case of Nova’s native policy error.
18:16:26 andreykurilin Despite the fact neutron errors have an extra 'suffix' line with request-id, mo, adding some prefix to error's from neutron should give more visibility of "guilty" side.
18:22:32 andreykurilin gmann: https://github.com/openstack/nova/blob/master/nova/network/neutron.py#L213-L214 neutronclient’s 403 is handled on ‘globally’
18:23:09 gmann andreykurilin: right. did not check that. ++
18:23:20 andreykurilin Yeah, It took me a while to find it
18:24:05 gmann andreykurilin: then you can just add 400 case in Remove SG case
18:24:18 gmann all these handling are so deep in code and hard to find :)
18:26:20 andreykurilin gmann: thank you! I’ll update my patch yesterday with a proper release note.
18:26:35 gmann andreykurilin: ++ thanks
18:34:25 andreykurilin *tomorrow (need to relax )
19:18:10 opendevreview Merged openstack/nova stable/2023.1: Change force_format strategy to catch mismatches https://review.opendev.org/c/openstack/nova/+/924734
20:08:21 opendevreview Jay Faulkner proposed openstack/nova master: [ironic] Factor out metadata and send to ironic https://review.opendev.org/c/openstack/nova/+/923910
21:13:32 JayF sean-k-mooney: https://review.opendev.org/c/openstack/nova/+/923910 + https://review.opendev.org/c/openstack/ironic/+/924887 are tested working in devstack. Still have to write a small migration script and some tempest tests, but wanted to get general agreement on the shape of the change before going further. If you could have a look I'd appreciate it. (/me goes and asks the same of Ironic cores)
21:46:21 opendevreview sean mooney proposed openstack/nova stable/2024.1: Remove AMI snapshot format special case https://review.opendev.org/c/openstack/nova/+/924982
#openstack-nova - 2024-07-26
01:33:15 opendevreview Wenping Song proposed openstack/nova master: remove exception.RescheduledException check as _validate_instance_group_policy doesnot rasie this exception https://review.opendev.org/c/openstack/nova/+/924988
05:29:54 ralonsoh dansmith, yes, thanks. Sorry for not replying yesterday, it was public holiday in some regions of Spain
05:30:20 ralonsoh I think we are good now in Neutron
08:30:39 opendevreview Pavlo Shchelokovskyy proposed openstack/nova master: Fix image conversion check in finish_migration https://review.opendev.org/c/openstack/nova/+/897842
08:36:17 opendevreview sean mooney proposed openstack/nova stable/2023.2: Remove AMI snapshot format special case https://review.opendev.org/c/openstack/nova/+/924999
08:37:48 opendevreview sean mooney proposed openstack/nova stable/2023.1: Remove AMI snapshot format special case https://review.opendev.org/c/openstack/nova/+/925000
08:38:40 sean-k-mooney bauzas: gmann: if ye are around im backporting the fix for the ami snapshot regression
08:39:01 sean-k-mooney bauzas: gmann https://review.opendev.org/c/openstack/nova/+/924982
08:39:03 bauzas cve sage, season 2, episode 203
08:39:09 bauzas saga*
08:39:34 sean-k-mooney once those merged im going to create the release patches
08:39:51 sean-k-mooney and ill add ye to review them
08:40:37 bauzas sean-k-mooney: can you then lookup another stable change ?
08:40:44 bauzas before asking for a stable release
08:40:55 bauzas sean-k-mooney: https://review.opendev.org/c/openstack/nova/+/924514
08:41:05 bauzas and the other backports
08:41:06 sean-k-mooney sure
08:41:17 bauzas we could then create stable releases
08:41:20 bauzas thanks
08:41:21 sean-k-mooney we can include that
08:41:51 sean-k-mooney ill see what else is ready but i would like to do the release either todya or early next week
08:42:05 sean-k-mooney bauzas: when are you on pto again from monday?
08:43:34 bauzas no, I'll start my usuall ~3-week PTO by Friday 2 Aug
08:43:51 bauzas still 5 days to work :)
08:44:32 sean-k-mooney ok i was going to ask if i should get added a release liasion until rene is back
08:44:42 sean-k-mooney but if your around until then no need
08:45:26 sean-k-mooney we can discuss the release then on tuesday and ill prepare the patches based on whats merged monday evening
08:47:00 bauzas ++
09:43:48 jlejeune bauzas: sean-k-mooney: now you have merged all the patchs related to the last CVE, maybe you can review my small fix in unit tests: https://review.opendev.org/c/openstack/nova/+/924148 :)
09:43:56 jlejeune hello BTW :)
10:08:55 sean-k-mooney jlejeune: oh yes we can merge that now and start backproting it too
10:09:07 sean-k-mooney it would be good to include that in the same release
10:09:37 sean-k-mooney bauzas: ^
11:47:02 bauzas sent to the gate ^
11:57:33 jlejeune bauzas: sean-k-mooney: thanks
11:58:14 sean-k-mooney jlejeune: do you want to do the submistion of the cerry-picks once its merged?
11:58:33 sean-k-mooney if not ill do it
12:00:01 jlejeune sean-k-mooney: I will
12:00:28 jlejeune I have to do it over 2023.1 / 2023.2 and 2024.1 right ?
12:00:44 sean-k-mooney yep form newst to oldest
12:01:03 sean-k-mooney so master->2024.1->2023.2->2023.1
12:01:04 jlejeune ok so firt on 2024.1
12:01:09 sean-k-mooney yep
12:01:15 jlejeune got it
12:06:27 opendevreview Merged openstack/nova master: Fix test_vmdk_bad_descriptor_mem_limit and test_vmdk_bad_descriptor_mem_limit_stream_optimized https://review.opendev.org/c/openstack/nova/+/924148
12:16:09 sean-k-mooney jlejeune: ^ :)
12:16:41 sean-k-mooney unit test only fixes like this get to skip all the tempest josb so they are actully really fast to merge
12:21:01 opendevreview Julien Le Jeune proposed openstack/nova stable/2024.1: Fix test_vmdk_bad_descriptor_mem_limit and test_vmdk_bad_descriptor_mem_limit_stream_optimized https://review.opendev.org/c/openstack/nova/+/925011
12:22:45 opendevreview Julien Le Jeune proposed openstack/nova stable/2023.2: Fix test_vmdk_bad_descriptor_mem_limit and test_vmdk_bad_descriptor_mem_limit_stream_optimized https://review.opendev.org/c/openstack/nova/+/925012
12:24:01 opendevreview Julien Le Jeune proposed openstack/nova stable/2023.1: Fix test_vmdk_bad_descriptor_mem_limit and test_vmdk_bad_descriptor_mem_limit_stream_optimized https://review.opendev.org/c/openstack/nova/+/925014
12:24:12 sean-k-mooney jlejeune: the second cherry pick is missing the cherrypcik line form the previous one
12:24:32 sean-k-mooney basically you shoudl have one (cherry picked from commit ...) per branch as you go back
12:24:55 sean-k-mooney the sha shoudl be the full commit sha from the previous cherrypick
12:25:33 jlejeune hm ok, sorry it was my first time
12:25:54 sean-k-mooney its ok
12:26:04 sean-k-mooney i mentioned it because we have a ci job that checks
12:27:42 opendevreview Julien Le Jeune proposed openstack/nova stable/2023.2: Fix test_vmdk_bad_descriptor_mem_limit and test_vmdk_bad_descriptor_mem_limit_stream_optimized https://review.opendev.org/c/openstack/nova/+/925012
12:29:02 opendevreview Julien Le Jeune proposed openstack/nova stable/2023.1: Fix test_vmdk_bad_descriptor_mem_limit and test_vmdk_bad_descriptor_mem_limit_stream_optimized https://review.opendev.org/c/openstack/nova/+/925014
12:30:18 sean-k-mooney jlejeune: we will try and include those in the next release we do next week
12:31:00 jlejeune perfect
12:31:15 sean-k-mooney thanks for fixing this
12:37:06 jlejeune no prob :)
13:18:38 sean-k-mooney bauzas: as i said downstream im goign to call it a day would you mind landing https://review.opendev.org/c/openstack/nova/+/925011 and the other backprot in order
13:50:12 opendevreview Merged openstack/nova stable/2024.1: Fix test_vmdk_bad_descriptor_mem_limit and test_vmdk_bad_descriptor_mem_limit_stream_optimized https://review.opendev.org/c/openstack/nova/+/925011
15:20:26 opendevreview Merged openstack/nova stable/2023.2: Fix test_vmdk_bad_descriptor_mem_limit and test_vmdk_bad_descriptor_mem_limit_stream_optimized https://review.opendev.org/c/openstack/nova/+/925012
15:22:51 opendevreview Dan Smith proposed openstack/nova master: Use format_inspector from oslo https://review.opendev.org/c/openstack/nova/+/925025
15:22:51 opendevreview Dan Smith proposed openstack/nova master: DNM: Test against oslo.utils https://review.opendev.org/c/openstack/nova/+/925026

Earlier   Later