| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2024-07-17 | |||
| 15:40:43 | bauzas | but if you want, just reply to me in the gerrit patch with an example of the exception we return, and then I'll tell you to add a larger comment then on our patch | |
| 15:41:13 | bauzas | but like I said, we try to not `except Exception` unless this is really needed | |
| 15:49:17 | jlejeune | yeah yeah I understand that of course, like I said I've juste copied/pasted what someone else did on other patchs for the same exception :) | |
| 15:49:36 | jlejeune | *on other tests | |
| 15:50:53 | jlejeune | I will check what's the exact exception, it raised when calling subprocess.execute() function | |
| 16:01:23 | bauzas | jlejeune: thanks :) | |
| 16:29:35 | bauzas | can someone just ping me quickly ? that's for a test | |
| 16:29:46 | frickler | bauzas: ping | |
| 16:29:59 | bauzas | frickler: thanks | |
| 20:21:08 | opendevreview | ribaudr proposed openstack/nova master: Amend ShareMappingStatus due to asynchronous call https://review.opendev.org/c/openstack/nova/+/908864 | |
| 20:21:08 | opendevreview | ribaudr proposed openstack/nova master: Amend DB model add a unique constraint. https://review.opendev.org/c/openstack/nova/+/912518 | |
| 20:21:09 | opendevreview | ribaudr proposed openstack/nova master: Attach Manila shares via virtiofs (manila abstraction) https://review.opendev.org/c/openstack/nova/+/831194 | |
| 20:21:09 | opendevreview | ribaudr proposed openstack/nova master: Attach Manila shares via virtiofs (drivers and compute manager part) https://review.opendev.org/c/openstack/nova/+/833090 | |
| 20:21:10 | opendevreview | ribaudr proposed openstack/nova master: Mounting the shares as part of the initialization process https://review.opendev.org/c/openstack/nova/+/880075 | |
| 20:21:10 | opendevreview | ribaudr proposed openstack/nova master: Deletion of associated share mappings on instance deletion https://review.opendev.org/c/openstack/nova/+/881472 | |
| 20:21:11 | opendevreview | ribaudr proposed openstack/nova master: Add metadata for shares https://review.opendev.org/c/openstack/nova/+/850500 | |
| 20:21:12 | opendevreview | ribaudr proposed openstack/nova master: Add share_info parameter to reboot method for each driver (driver part) https://review.opendev.org/c/openstack/nova/+/854823 | |
| 20:21:12 | opendevreview | ribaudr proposed openstack/nova master: Support rebooting an instance with shares (compute manager part) https://review.opendev.org/c/openstack/nova/+/854824 | |
| 20:21:14 | opendevreview | ribaudr proposed openstack/nova master: Add share_info parameter to resume method for each driver (driver part) https://review.opendev.org/c/openstack/nova/+/860284 | |
| 20:21:14 | opendevreview | ribaudr proposed openstack/nova master: Support resuming an instance with shares (compute manager part) https://review.opendev.org/c/openstack/nova/+/860285 | |
| 20:21:16 | opendevreview | ribaudr proposed openstack/nova master: Add helper methods to rescue/unrescue shares https://review.opendev.org/c/openstack/nova/+/860286 | |
| 20:21:16 | opendevreview | ribaudr proposed openstack/nova master: Support rescuing an instance with shares https://review.opendev.org/c/openstack/nova/+/860287 | |
| 20:21:18 | opendevreview | ribaudr proposed openstack/nova master: Allow to mount manila share using Cephfs protocol https://review.opendev.org/c/openstack/nova/+/883862 | |
| 20:21:18 | opendevreview | ribaudr proposed openstack/nova master: Check shares support (compute manager) https://review.opendev.org/c/openstack/nova/+/885751 | |
| 20:21:20 | opendevreview | ribaudr proposed openstack/nova master: Attach Manila shares via virtiofs (API) https://review.opendev.org/c/openstack/nova/+/836830 | |
| 20:21:20 | opendevreview | ribaudr proposed openstack/nova master: Add helper methods to attach/detach shares https://review.opendev.org/c/openstack/nova/+/885753 | |
| 20:21:22 | opendevreview | ribaudr proposed openstack/nova master: Add instance.share_attach notification https://review.opendev.org/c/openstack/nova/+/850501 | |
| 20:21:22 | opendevreview | ribaudr proposed openstack/nova master: Add instance.share_detach notification https://review.opendev.org/c/openstack/nova/+/851028 | |
| 20:21:24 | opendevreview | ribaudr proposed openstack/nova master: Add shares to InstancePayload https://review.opendev.org/c/openstack/nova/+/851029 | |
| 20:21:24 | opendevreview | ribaudr proposed openstack/nova master: Add instance.share_attach_error notification https://review.opendev.org/c/openstack/nova/+/860282 | |
| 20:21:26 | opendevreview | ribaudr proposed openstack/nova master: Add instance.share_detach_error notification https://review.opendev.org/c/openstack/nova/+/860283 | |
| 20:21:26 | opendevreview | ribaudr proposed openstack/nova master: Add libvirt test to ensure metadata are working. https://review.opendev.org/c/openstack/nova/+/852086 | |
| 20:21:28 | opendevreview | ribaudr proposed openstack/nova master: Add virt/libvirt error test cases https://review.opendev.org/c/openstack/nova/+/852087 | |
| 20:21:28 | opendevreview | ribaudr proposed openstack/nova master: Docs about Manila shares API usage https://review.opendev.org/c/openstack/nova/+/871642 | |
| #openstack-nova - 2024-07-18 | |||
| 02:29:07 | opendevreview | zhou zhong proposed openstack/nova master: nova-manage: modify image properties in request_spec https://review.opendev.org/c/openstack/nova/+/924319 | |
| 02:42:24 | opendevreview | zhou zhong proposed openstack/nova master: nova-manage: modify image properties in request_spec https://review.opendev.org/c/openstack/nova/+/924319 | |
| 09:49:52 | bauzas | gibi: other cores : we need a second core approval against https://review.opendev.org/c/openstack/nova-specs/+/907702 | |
| 09:50:07 | bauzas | as a reminder, today EOB is our spec approval freeze day | |
| 10:22:59 | gibi | bauzas: done, I agree we can document the remaining agreements in a follow up to the spec. | |
| 10:23:02 | gibi | so I approved it. | |
| 10:29:54 | mikal | bauzas: ugh, I'm not going to be able to update the kerbside spec before the end of your day. I thought the deadline was tomorrow, and I have most of a prototype but then need to update the spec to match. | |
| 10:30:12 | mikal | bauzas: I wanted to get a working prototype beforehand so I was confident I was describing it correctly. | |
| 10:30:20 | mikal | bauzas: what are my chances of a one or two day extension? | |
| 10:37:28 | opendevreview | Merged openstack/nova-specs master: libvirt: AMD SEV-ES support https://review.opendev.org/c/openstack/nova-specs/+/907702 | |
| 11:42:51 | mikal | Speaking of which, has anyone ever gotten a GET /os-console-auth-tokens/{console_token} to work? I get a 404 which I can't really explain. | |
| 11:51:27 | opendevreview | Andrey Kurilin proposed openstack/nova master: Propagate neutron's error during removeSecurityGroup action https://review.opendev.org/c/openstack/nova/+/924399 | |
| 12:29:05 | opendevreview | Michael Still proposed openstack/nova-specs master: Propose a new API microversion for a spice-direct console. https://review.opendev.org/c/openstack/nova-specs/+/915190 | |
| 12:30:20 | mikal | sean-k-mooney: I've updated the spec. I just got the console access URL stuff you asked for working in a prototype. | |
| 12:30:37 | mikal | sean-k-mooney: sorry it took so long, I had some personal life stuff I've had to deal with in the last week or so. | |
| 12:32:36 | sean-k-mooney | mikal: you dont need to appoliges, life happens | |
| 12:33:23 | mikal | sean-k-mooney: yeah I dunno, I feel like the last month or so has been pretty weird over here. | |
| 12:34:10 | mikal | sean-k-mooney: anyways, I have the flow you wanted working: request console access URL through existing API with new console type -> get URL to kerbside with console access token -> request URL -> kerbside uses token to validate and lookup connection info -> kerbside returns a .vv file for your SPICE client. | |
| 12:34:30 | mikal | sean-k-mooney: the code is not ready to push to gerrit yet, but I am now confident I can make that flow work. | |
| 12:34:51 | mikal | sean-k-mooney: which means arguably there is no API security impact, as the console auth lookup API is pre-existing and already did what I needed | |
| 12:35:20 | sean-k-mooney | do we need a sepreate config option ? CONF.spice.kerbside_base_url or would https://docs.openstack.org/nova/latest/configuration/config.html#serial_console.base_url work | |
| 12:35:31 | sean-k-mooney | sorry not serial | |
| 12:35:54 | sean-k-mooney | https://docs.openstack.org/nova/latest/configuration/config.html#spice.html5proxy_base_url | |
| 12:36:12 | sean-k-mooney | i guess hte name of that is slightly confusing | |
| 12:36:53 | sean-k-mooney | mikal: im basically wonderign if we could rename html5proxy_base_url to proxy_base_url | |
| 12:36:56 | sean-k-mooney | and use it for both | |
| 12:36:56 | mikal | sean-k-mooney: yeah, I wanted to differentiate the two services. | |
| 12:37:18 | mikal | sean-k-mooney: I would be ok with that, but that would come with upgrade work for deployers. | |
| 12:37:39 | sean-k-mooney | do you want to suport haveing both the existing html5 proxy and kerbside at the same time | |
| 12:37:56 | sean-k-mooney | mikal: evenrually when we do a rename we keep the old value for a couple of cycles | |
| 12:38:07 | mikal | sean-k-mooney: actually, yes I suspect people would want that. HTML5 is fine for quick and dirty things, but not for desktop VDI replacement. | |
| 12:38:25 | sean-k-mooney | ok that works for me | |
| 12:38:27 | mikal | That is, if I was building Citrix on OpenStack, I'd probably want both. | |
| 12:40:06 | sean-k-mooney | mikal: ya so to get the port/host infor you will need to call the /os-console-auth-tokens api as admin i belive | |
| 12:40:26 | mikal | sean-k-mooney: yeah, I am assuming the security for that is already correct given that's pre-existing. | |
| 12:40:26 | sean-k-mooney | it would be nice to allow that to be called as the serivce user so that is the only policy change requried | |
| 12:40:45 | mikal | Does that need to be in the spec? | |
| 12:40:47 | sean-k-mooney | but i agree that most of the api change is removed now | |
| 12:41:19 | sean-k-mooney | it woudl be nice to cacue the tin the spec but i would not stirlcly hold a -1 for that alone | |
| 12:41:40 | sean-k-mooney | if you want to respine that is fine but i woudl be ok with a follow up patch post spec freeze too | |
| 12:42:20 | sean-k-mooney | mikal: stricly speaking spec freeze is eob today so im going to finish reviewing this and ill leave a comemnt to that effect regarding policy | |
| 12:42:51 | mikal | sean-k-mooney: yeah, I feel like I am skating on the edges of missing the deadline. I asked bauzas if I could have a day or two extension, but didn't get a reply yet. | |
| 12:43:05 | mikal | I thought the freeze was EOD tomorrow, which is my bad. | |
| 12:44:08 | sean-k-mooney | mikal: so on one hand we premetivly moved it 2 weeks past our normal deadline. on the other given you have a partly wroking poc and you have already adapted the appoch to the direction i asked for i would be ok with extending until the next team meeing via the spec freez process if bauzas is | |
| 12:44:29 | mikal | Oh bugger. I _do_ need a schema change. There is only one port column in the ConsoleAuthToken table and I need two (one for TLS). | |
| 12:44:55 | mikal | I'll tweak the spec now. | |
| 12:45:03 | sean-k-mooney | ok well that is easy to add to the spec i dont think that woudl be contoverial | |
| 12:45:08 | mikal | Look, if I've missed the deadline so be it. Its frustrating but its not the end of the world. | |
| 12:47:01 | opendevreview | Michael Still proposed openstack/nova-specs master: Propose a new API microversion for a spice-direct console. https://review.opendev.org/c/openstack/nova-specs/+/915190 | |
| 12:48:10 | sean-k-mooney | mikal: i think you have some other issues | |
| 12:48:31 | sean-k-mooney | mikal: im not seeing the propsoe chage header | |
| 12:49:07 | mikal | I'm not sure what a "propose change header" is? | |
| 12:49:15 | mikal | Oh you mean in Gerrit? | |
| 12:49:27 | sean-k-mooney | yep it will fail our ci job | |
| 12:49:34 | sean-k-mooney | https://github.com/openstack/nova-specs/blob/master/specs/2024.2-template.rst?plain=1#L92 | |
| 12:50:08 | sean-k-mooney | oh no | |
| 12:50:23 | sean-k-mooney | you have it but you started descibibg the propsoed change in the problem description section | |
| 12:51:22 | sean-k-mooney | lets ignore that for now but basiclly the "Problem description" shoudl descibe the "what" and "why" not the "how" | |
| 12:51:52 | sean-k-mooney | so the discussion of config option or api shoudl be in the propsoe changes btu that not a big deal | |
| 12:51:53 | mikal | So basically everything except the first para of "problem description" should move down? | |
| 12:52:21 | sean-k-mooney | technially yes to the sart of the propsoed changes | |
| 12:52:27 | sean-k-mooney | the usecases section is correct | |
| 12:52:37 | mikal | Done. | |
| 12:52:38 | opendevreview | Michael Still proposed openstack/nova-specs master: Propose a new API microversion for a spice-direct console. https://review.opendev.org/c/openstack/nova-specs/+/915190 | |
| 12:53:19 | sean-k-mooney | cool ill contineu reviewing the new version | |
| 12:53:34 | sean-k-mooney | sofar the content looks fine to me | |