| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2024-07-18 | |||
| 10:30:20 | mikal | bauzas: what are my chances of a one or two day extension? | |
| 10:37:28 | opendevreview | Merged openstack/nova-specs master: libvirt: AMD SEV-ES support https://review.opendev.org/c/openstack/nova-specs/+/907702 | |
| 11:42:51 | mikal | Speaking of which, has anyone ever gotten a GET /os-console-auth-tokens/{console_token} to work? I get a 404 which I can't really explain. | |
| 11:51:27 | opendevreview | Andrey Kurilin proposed openstack/nova master: Propagate neutron's error during removeSecurityGroup action https://review.opendev.org/c/openstack/nova/+/924399 | |
| 12:29:05 | opendevreview | Michael Still proposed openstack/nova-specs master: Propose a new API microversion for a spice-direct console. https://review.opendev.org/c/openstack/nova-specs/+/915190 | |
| 12:30:20 | mikal | sean-k-mooney: I've updated the spec. I just got the console access URL stuff you asked for working in a prototype. | |
| 12:30:37 | mikal | sean-k-mooney: sorry it took so long, I had some personal life stuff I've had to deal with in the last week or so. | |
| 12:32:36 | sean-k-mooney | mikal: you dont need to appoliges, life happens | |
| 12:33:23 | mikal | sean-k-mooney: yeah I dunno, I feel like the last month or so has been pretty weird over here. | |
| 12:34:10 | mikal | sean-k-mooney: anyways, I have the flow you wanted working: request console access URL through existing API with new console type -> get URL to kerbside with console access token -> request URL -> kerbside uses token to validate and lookup connection info -> kerbside returns a .vv file for your SPICE client. | |
| 12:34:30 | mikal | sean-k-mooney: the code is not ready to push to gerrit yet, but I am now confident I can make that flow work. | |
| 12:34:51 | mikal | sean-k-mooney: which means arguably there is no API security impact, as the console auth lookup API is pre-existing and already did what I needed | |
| 12:35:20 | sean-k-mooney | do we need a sepreate config option ? CONF.spice.kerbside_base_url or would https://docs.openstack.org/nova/latest/configuration/config.html#serial_console.base_url work | |
| 12:35:31 | sean-k-mooney | sorry not serial | |
| 12:35:54 | sean-k-mooney | https://docs.openstack.org/nova/latest/configuration/config.html#spice.html5proxy_base_url | |
| 12:36:12 | sean-k-mooney | i guess hte name of that is slightly confusing | |
| 12:36:53 | sean-k-mooney | mikal: im basically wonderign if we could rename html5proxy_base_url to proxy_base_url | |
| 12:36:56 | sean-k-mooney | and use it for both | |
| 12:36:56 | mikal | sean-k-mooney: yeah, I wanted to differentiate the two services. | |
| 12:37:18 | mikal | sean-k-mooney: I would be ok with that, but that would come with upgrade work for deployers. | |
| 12:37:39 | sean-k-mooney | do you want to suport haveing both the existing html5 proxy and kerbside at the same time | |
| 12:37:56 | sean-k-mooney | mikal: evenrually when we do a rename we keep the old value for a couple of cycles | |
| 12:38:07 | mikal | sean-k-mooney: actually, yes I suspect people would want that. HTML5 is fine for quick and dirty things, but not for desktop VDI replacement. | |
| 12:38:25 | sean-k-mooney | ok that works for me | |
| 12:38:27 | mikal | That is, if I was building Citrix on OpenStack, I'd probably want both. | |
| 12:40:06 | sean-k-mooney | mikal: ya so to get the port/host infor you will need to call the /os-console-auth-tokens api as admin i belive | |
| 12:40:26 | mikal | sean-k-mooney: yeah, I am assuming the security for that is already correct given that's pre-existing. | |
| 12:40:26 | sean-k-mooney | it would be nice to allow that to be called as the serivce user so that is the only policy change requried | |
| 12:40:45 | mikal | Does that need to be in the spec? | |
| 12:40:47 | sean-k-mooney | but i agree that most of the api change is removed now | |
| 12:41:19 | sean-k-mooney | it woudl be nice to cacue the tin the spec but i would not stirlcly hold a -1 for that alone | |
| 12:41:40 | sean-k-mooney | if you want to respine that is fine but i woudl be ok with a follow up patch post spec freeze too | |
| 12:42:20 | sean-k-mooney | mikal: stricly speaking spec freeze is eob today so im going to finish reviewing this and ill leave a comemnt to that effect regarding policy | |
| 12:42:51 | mikal | sean-k-mooney: yeah, I feel like I am skating on the edges of missing the deadline. I asked bauzas if I could have a day or two extension, but didn't get a reply yet. | |
| 12:43:05 | mikal | I thought the freeze was EOD tomorrow, which is my bad. | |
| 12:44:08 | sean-k-mooney | mikal: so on one hand we premetivly moved it 2 weeks past our normal deadline. on the other given you have a partly wroking poc and you have already adapted the appoch to the direction i asked for i would be ok with extending until the next team meeing via the spec freez process if bauzas is | |
| 12:44:29 | mikal | Oh bugger. I _do_ need a schema change. There is only one port column in the ConsoleAuthToken table and I need two (one for TLS). | |
| 12:44:55 | mikal | I'll tweak the spec now. | |
| 12:45:03 | sean-k-mooney | ok well that is easy to add to the spec i dont think that woudl be contoverial | |
| 12:45:08 | mikal | Look, if I've missed the deadline so be it. Its frustrating but its not the end of the world. | |
| 12:47:01 | opendevreview | Michael Still proposed openstack/nova-specs master: Propose a new API microversion for a spice-direct console. https://review.opendev.org/c/openstack/nova-specs/+/915190 | |
| 12:48:10 | sean-k-mooney | mikal: i think you have some other issues | |
| 12:48:31 | sean-k-mooney | mikal: im not seeing the propsoe chage header | |
| 12:49:07 | mikal | I'm not sure what a "propose change header" is? | |
| 12:49:15 | mikal | Oh you mean in Gerrit? | |
| 12:49:27 | sean-k-mooney | yep it will fail our ci job | |
| 12:49:34 | sean-k-mooney | https://github.com/openstack/nova-specs/blob/master/specs/2024.2-template.rst?plain=1#L92 | |
| 12:50:08 | sean-k-mooney | oh no | |
| 12:50:23 | sean-k-mooney | you have it but you started descibibg the propsoed change in the problem description section | |
| 12:51:22 | sean-k-mooney | lets ignore that for now but basiclly the "Problem description" shoudl descibe the "what" and "why" not the "how" | |
| 12:51:52 | sean-k-mooney | so the discussion of config option or api shoudl be in the propsoe changes btu that not a big deal | |
| 12:51:53 | mikal | So basically everything except the first para of "problem description" should move down? | |
| 12:52:21 | sean-k-mooney | technially yes to the sart of the propsoed changes | |
| 12:52:27 | sean-k-mooney | the usecases section is correct | |
| 12:52:37 | mikal | Done. | |
| 12:52:38 | opendevreview | Michael Still proposed openstack/nova-specs master: Propose a new API microversion for a spice-direct console. https://review.opendev.org/c/openstack/nova-specs/+/915190 | |
| 12:53:19 | sean-k-mooney | cool ill contineu reviewing the new version | |
| 12:53:34 | sean-k-mooney | sofar the content looks fine to me | |
| 12:56:42 | sean-k-mooney | mikal: by the way if you have not seen this https://review.opendev.org/c/openstack/nova-specs/+/920687 i think that woudl also be very useful to you | |
| 12:56:58 | sean-k-mooney | we may not have time to fully review and approve that todya as well | |
| 12:57:12 | sean-k-mooney | but i think both your fature and that could work nicely togetter going forward | |
| 13:03:52 | mikal | Oh that's interesting. SPICE tunnels USBredir over its transport, and that already works in my prototype | |
| 13:04:17 | mikal | That spec presumably is also proposing to add the same USB devices that I need to add for that to work in SPICE? I shall read the spec. | |
| 13:04:52 | sean-k-mooney | yes and adding image/flavor properies to say how many | |
| 13:05:36 | sean-k-mooney | there is a lot of overlap in some respect although they were happy with the html5 proxy for there usecase | |
| 13:06:04 | sean-k-mooney | form the naming im pretty sure this is for https://shadow.tech/ | |
| 13:06:10 | mikal | The HTML5 proxy supports USB redirection? I find that surprising. | |
| 13:06:53 | sean-k-mooney | mikal: why? it a javascript applcation hosted on a webserver that tunnes the raw spice protocal over a webseocket | |
| 13:07:40 | sean-k-mooney | we are litrally just wrapping the spice tcp connetcion into a websocket and providign that to the browser | |
| 13:07:45 | mikal | So I haven't looked at the websocket proxy much, but the javascript app is definitely missing stuff -- it doesn't support all the compression options that the protocol does for example. Its missing GLZ IIRC. | |
| 13:08:11 | sean-k-mooney | mikal: right but that not a limitaiton fo openstack | |
| 13:08:23 | mikal | That's fair. | |
| 13:08:55 | sean-k-mooney | showdow likely have there own client that they are using with the websocket directly | |
| 13:09:36 | sean-k-mooney | they are defeitly not using horizon's or skylines | |
| 13:10:38 | mikal | Their site definitely mentions apps, but also says they have browser support. | |
| 13:10:59 | mikal | But yeah, they seem to be proposed a relatively overlapping subset of what I am proposing. | |
| 13:11:28 | sean-k-mooney | yep but you can do a lot in in a moddern browser :) | |
| 13:14:08 | sean-k-mooney | anyway if we can enabel both yoru use cases i would be happy too | |
| 13:18:49 | sean-k-mooney | mikal: +1 https://review.opendev.org/c/openstack/nova-specs/+/915190 minor line lenght issue on line 79 and you still need to menation addding the tls_port in the respocne | |
| 13:19:12 | sean-k-mooney | mikal: but if you fix those i think im +2 on the spec | |
| 13:20:14 | sean-k-mooney | i have also resolved teh irrelevent comments form older version so it shoudl be simpler to review now | |
| 13:20:44 | sean-k-mooney | bauzas: gibi can ye review ^ if you have time | |
| 13:20:59 | bauzas | I'll do | |
| 13:31:04 | opendevreview | Michael Still proposed openstack/nova-specs master: Propose a new API microversion for a spice-direct console. https://review.opendev.org/c/openstack/nova-specs/+/915190 | |
| 13:31:04 | mikal | sean-k-mooney: I've done both of those. | |
| 13:33:04 | mikal | sean-k-mooney: all of your comments about docs and so forth seem reasonable to me, but I am not passionate about updating the spec to include them right now given I worry that will derail the review process. | |
| 13:35:07 | mikal | sean-k-mooney: thanks for taking the time to work through the spec with me by the way, I appreciate it. | |
| 13:44:36 | sean-k-mooney | mikal: +2, no worries, happy to collaberate on thigns like this | |
| 13:44:53 | sean-k-mooney | i may or may not be able to comit to reviewing it before feature freeze but ill try as time allows | |
| 13:45:03 | mikal | pep8 hates me. | |
| 13:45:19 | sean-k-mooney | you know you can run that locally via docs right :P | |
| 13:45:59 | mikal | It only reported one error last time, so I thought if I fixed that it wouldn't be angry any more... | |
| 13:46:22 | sean-k-mooney | ah | |
| 13:46:38 | mikal | I have learnt my lesson | |
| 13:46:40 | sean-k-mooney | ya we normaly config it to keep going but that does not alwasy work depending on the tool we use | |
| 13:47:28 | opendevreview | Michael Still proposed openstack/nova-specs master: Propose a new API microversion for a spice-direct console. https://review.opendev.org/c/openstack/nova-specs/+/915190 | |
| 13:47:30 | mikal | Well, it passes locally now so let's see what Zuul thinks. | |
| 13:48:15 | mikal | I really should go to bed, its nearly midnight here. I guess I'll see if this thing is approved in the morning. Thanks again for your help. | |
| 13:57:33 | mikal | sean-k-mooney: it passes CI now, so that's nice. On that note I'm off to bed. | |
| 14:49:45 | bauzas | sean-k-mooney: mikal : I have two comments in https://review.opendev.org/c/openstack/nova-specs/+/915190 | |