Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2024-07-12
17:22:37 melwitt sean-k-mooney: I think I like the second approach more. it turned out to simpler than I expected
18:16:35 opendevreview Merged openstack/nova stable/2023.2: Stabilize iso format unit tests https://review.opendev.org/c/openstack/nova/+/923936
18:16:41 opendevreview Merged openstack/nova stable/2023.1: Add iso file format inspector https://review.opendev.org/c/openstack/nova/+/923733
18:16:51 opendevreview Merged openstack/nova stable/2023.1: fix qemu-img version dependent tests https://review.opendev.org/c/openstack/nova/+/923908
18:39:39 sean-k-mooney melwitt: you have encapulstaed the logic pretty cleanly into the should_enforce function
18:40:50 sean-k-mooney melwitt: im not entirly sure how i feel about caching the keystone client for the limt enfroceer
18:41:31 sean-k-mooney its proably fine if it internally handels updating the auth
18:41:41 sean-k-mooney when a token expires
18:43:11 sean-k-mooney we can have diffent limties per project howver right so w eneed to ensure we are usign the users token to get teh registered limits so we might need to concruct it each time
18:43:36 melwitt sean-k-mooney: yeah, I wasn't totally sure about that but I think it does. we cache most of the clients like placement and neutron IIRC
18:44:03 melwitt sean-k-mooney: oh.. yeah good point. 😆
18:44:17 sean-k-mooney dont we normally passs a diffent context to the client wehn making a call
18:44:21 sean-k-mooney with the user token
18:44:26 melwitt yeah you're right
18:44:54 melwitt I'll need to change that
18:44:55 sean-k-mooney so in stead of needign a new keyston section in the config i thin kwe can use the user token + our service user tooken
18:46:54 sean-k-mooney ignoing th eclinet the patch looks pretty nice to me in general
18:48:54 sean-k-mooney elodilles: thanks for all the work you have done on the iso fromat backport
18:49:00 melwitt I'll revise the spec to the second approach
18:50:22 sean-k-mooney if your happy with that it works for me. ill try and find time to review the spec and patch properly on monday so
18:52:23 melwitt ok I'll have it updated by then. thanks
18:56:58 sean-k-mooney well dont kill your self to do it over the weekend but if we want to do it this cycle we need to get it landed before spec freze which is thrusday
18:57:46 melwitt I did this to myself 😝 but it also won't kill me. it should be easy (tm)
20:21:33 elodilles sean-k-mooney: no problem :) thanks for the fixes :]
21:19:44 opendevreview Elod Illes proposed openstack/nova master: [tools] Ignore bot generated patches https://review.opendev.org/c/openstack/nova/+/924103
21:19:44 opendevreview Elod Illes proposed openstack/nova master: [tools] Backport validator: handle unmaintained https://review.opendev.org/c/openstack/nova/+/924104
21:32:05 opendevreview Merged openstack/nova stable/2023.1: Stabilize iso format unit tests https://review.opendev.org/c/openstack/nova/+/923937
#openstack-nova - 2024-07-13
01:14:15 opendevreview melanie witt proposed openstack/nova master: Add config option [quota]strict_unified_limits https://review.opendev.org/c/openstack/nova/+/924025
01:41:09 opendevreview melanie witt proposed openstack/nova master: Add config option [quota]strict_unified_limits https://review.opendev.org/c/openstack/nova/+/924025
02:02:31 opendevreview melanie witt proposed openstack/nova-specs master: Propose config option to control behavior of unset unified limits https://review.opendev.org/c/openstack/nova-specs/+/923807
02:04:15 opendevreview melanie witt proposed openstack/nova-specs master: Propose config option to control behavior of unset unified limits https://review.opendev.org/c/openstack/nova-specs/+/923807
08:27:08 opendevreview melanie witt proposed openstack/nova master: nova-manage: Add flavor scanning to migrate_to_unified_limits https://review.opendev.org/c/openstack/nova/+/924110
#openstack-nova - 2024-07-15
09:02:39 amorin hey nova team, is there any way to not rely on cell_mappings (from db) but only read data from the config file?
10:58:07 sean-k-mooney amorin: no
10:59:09 sean-k-mooney there is a feature called templated cell db urls
10:59:54 sean-k-mooney that allwos the username and password for the cell to be stored in the config but that woudl require using the same username/password for all cells
11:00:52 sean-k-mooney amorin: https://docs.openstack.org/nova/latest/admin/cells.html#template-urls-in-cell-mappings
11:28:45 jlejeune hello, it seems that since the last patchs related to the bug #2059809, you have added a new dependency with qemu-utils package to be able tu run qemu-img binary, I have two failling tests related to that: nova.tests.unit.image.test_format_inspector.TestFormatInspectors.test_vmdk_bad_descriptor_mem_limit and
11:28:50 jlejeune nova.tests.unit.image.test_format_inspector.TestFormatInspectors.test_vmdk_bad_descriptor_mem_limit_stream_optimized. Are you aware of that ? Maybe a missing dependency in test-requirements.txt ?
11:34:15 jlejeune or maybe these tests are not correctly skipped if qemu-img is not present in PATH
11:34:26 jlejeune for other tests
11:38:16 opendevreview sean mooney proposed openstack/nova master: [DNM] Test bumping guest ram https://review.opendev.org/c/openstack/nova/+/924142
11:43:21 sean-k-mooney jlejeune: this was a preexisting depency
11:43:32 sean-k-mooney oh in the unit test
11:43:58 sean-k-mooney am we added some skip patches
11:44:09 sean-k-mooney to skip if qemu was not there
11:44:21 sean-k-mooney its posible that we have some paths that are still not skipped
11:44:52 jlejeune indeed, in self._create_allocated_vmdk() method in unit test
11:45:09 jlejeune patching if you want
11:45:37 sean-k-mooney you can submit a patch for that if you have time
11:45:45 jlejeune sure, doing
11:45:47 sean-k-mooney its not strictly speaking incorrect
11:46:07 sean-k-mooney it just nova tened to try and have depencies on external tools in our unit tests
11:46:18 sean-k-mooney glance however does not have that concept
11:46:39 sean-k-mooney so when we import the unit tests form glance we gained this depency and we have been trying to relax it to make it optional
11:46:58 sean-k-mooney eventurlaly these tests will be remove form nova and moved to oslo when the image inspector is moved
11:47:31 jlejeune ok get it
11:54:18 amorin sean-k-mooney, that's perfect, it will fit my needs
12:47:48 opendevreview Julien LE JEUNE proposed openstack/nova master: Fix test_vmdk_bad_descriptor_mem_limit and test_vmdk_bad_descriptor_mem_limit_stream_optimized https://review.opendev.org/c/openstack/nova/+/924148
13:42:59 amorin hey again, another question regarding BDM, when booting an instance with a BDM, I cannot find a way to specify the availability-zone field, while if I create the volume before using cinder API, it's available, is it missing on nova side on purpose?
14:53:37 ralonsoh sean-k-mooney, hello! If you have some mins, please check https://review.opendev.org/c/openstack/neutron/+/923962
14:54:10 ralonsoh is that something you (nova team) discussed with the author?
14:56:34 opendevreview Pranali Deore proposed openstack/nova master: DNM: Test glance new location api https://review.opendev.org/c/openstack/nova/+/891207
15:04:53 sean-k-mooney so OVS_HYBRID_PLUG is not intented to be used with ovn
15:05:53 sean-k-mooney ralonsoh: i have not read the patch properly but i wound not normally expect that to be set when using ovn
15:06:22 sean-k-mooney we wait for port binind events dirfferencly for ovn
15:32:58 opendevreview Julien Le Jeune proposed openstack/nova master: Fix test_vmdk_bad_descriptor_mem_limit and test_vmdk_bad_descriptor_mem_limit_stream_optimized https://review.opendev.org/c/openstack/nova/+/924148
17:59:15 sean-k-mooney amorin: yes its not in the api bdm because if the volume is created by nova it will have the same az as the instance and if its a prexisting volume form cinder then it will already be recored on the volume
20:31:09 chris218 Hi, does placement track usage of vcpu/pcpu cores on given node or it's done by nova-compute? I was wondering if it would be possible to run two nova-compute instances on one node with different drivers configured on them
20:33:29 noonedeadpunk nova-compute does report consumption data to the placement iirc
20:34:22 noonedeadpunk well, the tricky thing might be to make nova-compute service to register independently
20:36:35 noonedeadpunk as it relies on hostnames. while in nova.conf you can set different `my_ip` and `host` vars per service, I'm not 100% sure you will be able to do the same trick for hypervisors... As there table is populated by what driver would report as a hostname...
20:37:15 noonedeadpunk and then this will be pushed towards placement
21:07:55 chris218 so... yes but it's complicated
21:47:08 opendevreview Rajat Dhasmana proposed openstack/nova master: Rebuild server: Add offset for iSCSI volumes https://review.opendev.org/c/openstack/nova/+/924184
21:53:34 melwitt amorin: if nova is creating the volume, it will create it in the same AZ as you specify you want to create the instance. it's mentioned here (and maybe also in other docs) https://docs.openstack.org/nova/latest/configuration/config.html#cinder.cross_az_attach
#openstack-nova - 2024-07-16
04:39:37 opendevreview Merged openstack/nova master: hardware: Fix image_meta.id within get_mem_encryption_constraint https://review.opendev.org/c/openstack/nova/+/904197
05:19:14 whoami-rajat hey #openstack-nova , can i have review on this small patch? it's sitting for quite a while https://review.opendev.org/c/openstack/nova/+/889257
07:34:34 amorin melwitt, sean-k-mooney so maybe I misconfigured something because my volume endup in a different AZ when doing my tests, I will double check, thanks for your answers
09:11:32 bauzas_ morning folks
11:25:29 sean-k-mooney amorin: check if you have the cross az attach config option configured to prevent cross az attach
12:47:28 sean-k-mooney bauzas: this is a very short spec form melwitt which we have discussed at previous ptgs https://review.opendev.org/c/openstack/nova-specs/+/923807 will you have time to review that today
12:47:49 bauzas yes, I'm slowing starting back
12:48:03 sean-k-mooney ack melwitt also has a poc implemation up for it
12:52:50 frickler bauzas: Uggla: auniyal: could you please check https://review.opendev.org/c/openstack/releases/+/923118 once again? (osc-placement release)
13:16:23 weanew Hello! I've submitted a bug fix: https://review.opendev.org/c/openstack/nova/+/923395 Could someone review it?
13:21:52 opendevreview Takashi Natsume proposed openstack/nova-specs master: Create specs directory for 2025.1 Epoxy https://review.opendev.org/c/openstack/nova-specs/+/924227
13:36:46 jlejeune hello, can I have some review for my fix in unit tests please: https://review.opendev.org/c/openstack/nova/+/924148 ?
13:39:42 bauzas folks, can we try to not use this channel for asking for some fixes ?
13:40:24 bauzas jlejeune: weanew: if you want, you can add your changes in the Dalmatian etherpad : https://etherpad.opendev.org/p/nova-dalmatian-status
13:49:48 jlejeune bauzas: ok, I didn't create a bug in launchpad for that because it just affects unit tests, is that ok ?
13:57:03 bauzas jlejeune: yup, for internal changes like that, indeed you don't need to add a new Launchpad bug report
13:58:45 jlejeune bauzas: perfect, thanks
14:25:24 bauzas reminder (it was long due) : next nova meeting here in 1.5 hours (1600UTC)
14:55:26 opendevreview Balazs Gibizer proposed openstack/nova master: DNM: test back and forth migration https://review.opendev.org/c/openstack/nova/+/924234
15:00:05 elodilles dansmith sean-k-mooney : i know it's unmaintained, but could you please have a quick look that my thinking was right when resolving conflict in this backport? https://review.opendev.org/c/openstack/nova/+/924083
15:01:26 elodilles conflicts were due to patch to consolidate image creation functions (I111cfc8a5eae27b15c6312957255fcf973038ddf) was added only in zed
15:02:26 elodilles and as far as i understood, now i only had to touch the create_cow_image function, and no need for to change anything in create_image function (nova/virt/libvirt/utils.py)
15:03:23 elodilles as create_cow_image functions handles only the case when there is a backing_file
15:08:32 sean-k-mooney elodilles: a very light reivew, it looks correct but havented dnoe anything more then compare the 2023.1 patch to the yoga version

Earlier   Later