| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2024-03-25 | |||
| 15:35:27 | dansmith | however, | |
| 15:35:51 | dansmith | there's really no slow migration path for existing code.. you can't really inject asyncio stuff at the lower layer, you kinda have to start at the top | |
| 15:36:13 | dansmith | there are some hacks, like making a sync method start an asyncio event loop just to make one async call, etc, but it's pretty heavy and gross, IME | |
| 15:37:59 | sean-k-mooney | sorry was on a call | |
| 15:38:43 | sean-k-mooney | so the hub just means wo can mix asyncio native code and eventlet | |
| 15:39:03 | sean-k-mooney | but without monkeypatching everything it buys us nothing | |
| 15:39:12 | dansmith | yup | |
| 15:39:46 | sean-k-mooney | and to transtation nova to async io while supprotign both hubs we would need to wrap all code that is monkeypatch today behind facde apis | |
| 15:39:55 | sean-k-mooney | and dispatch to the relevent implemention | |
| 15:40:05 | sean-k-mooney | until we could fully drop supprot for the old model | |
| 15:40:12 | sean-k-mooney | which is a long and non trivial thing | |
| 15:40:22 | dansmith | right, which I think I covered above in the " | |
| 15:40:28 | dansmith | rewrite everything" description :) | |
| 15:40:37 | sean-k-mooney | yep more or less | |
| 15:41:22 | dansmith | while everything won't be rewritten, knowing where those seams should go will require inspection on the order of "rewrite everything" IMHO.. we'll have to effectively consider everything needing a rewrite and exclude things we can avoid async'ing | |
| 15:42:20 | sean-k-mooney | yep and it will require use to also pessimies some code paths by adding in the check for "which hub am i using" | |
| 15:42:29 | dansmith | anyway, I have to run to an appointment soon, and I'm sure we'll get more PTG discussion on this..I think we need to sniff-test the switch with devstack in order to earn a report from mnaser with a more realistic set of nodes and load | |
| 15:42:30 | sean-k-mooney | plus the indrection | |
| 15:43:14 | sean-k-mooney | i dont currently have a devstack to playwith but i can proably just hack in an export of the hub env var | |
| 15:43:24 | sean-k-mooney | just to see if we can even deploy any of the existing services with it | |
| 15:43:53 | JayF | I suspect upstream eventlet (which is mostly Herve and friends these days) would consider it a bug if not | |
| 15:43:55 | sean-k-mooney | doing the proper enablement will take more time | |
| 15:44:37 | sean-k-mooney | JayF: Sure but bug are definetly a thing so you know we need to try it an see | |
| 15:45:34 | dansmith | right the point is, mnaser would like to know if it even works for a small deployment before spinning up a test cluster and rally run | |
| 15:46:15 | sean-k-mooney | uc currently clamps to eventlet===0.35.1 so its in 0.35.2 based on the docs ill need to check if eventlet===0.35.1 has it or ill need to bump uc in the patch | |
| 15:46:45 | sean-k-mooney | ok it is in 0.35.1 | |
| 15:47:23 | sean-k-mooney | i have 13 mins before my next meeting give me a sec an ill see if i can hack a dnm patch | |
| 15:48:06 | dansmith | I think you need the latest to get the dns fix IIRC | |
| 15:52:16 | sean-k-mooney | https://review.opendev.org/c/openstack/devstack/+/914108 | |
| 15:52:28 | sean-k-mooney | so ^ is the minimal change i belive | |
| 15:52:57 | sean-k-mooney | it wont enabel it for cli tools like nova-mange | |
| 15:53:08 | sean-k-mooney | but they also dont need eventlet today even if they are patched | |
| 15:53:29 | sean-k-mooney | so we can see if that cannary explode or not and then do somethign better | |
| 18:12:01 | sean-k-mooney | dansmith: so https://review.opendev.org/c/openstack/devstack/+/914108 exploded in keystone manage which is not even ment o use eventlet | |
| 18:12:20 | sean-k-mooney | so thats fun. | |
| 18:12:41 | sean-k-mooney | | File "/opt/stack/data/venv/lib/python3.10/site-packages/eventlet/green/thread.py", line 36, in get_ident | |
| 18:12:43 | sean-k-mooney | 2024-03-25 16:04:04.700 | AttributeError: 'NoneType' object has no attribute 'getcurrent' | |
| 18:14:50 | dansmith | well, this is why I think merging a resolution to do a thing before it is even proven to *run* is a bad idea | |
| 18:16:20 | sean-k-mooney | im pretty sure this si form oslo log or oslo context | |
| 18:16:25 | sean-k-mooney | just tryign to grab the compute id | |
| 18:17:24 | sean-k-mooney | * thread id | |
| 18:17:26 | sean-k-mooney | not compute id | |
| 18:17:49 | sean-k-mooney | but apparnetly just defining the env_var has a sidefect fo doing some kind of patching | |
| 18:17:55 | sean-k-mooney | which i woudl not expect | |
| 18:20:24 | dansmith | if it's not even able to do this without crashing, I suspect we're a long ways from being a drop-in replacement with no stability or performance implications | |
| 18:21:45 | JayF | The first step on the journey tho, no matter how long, is to try it, find the issue, fix it, and get that cycle going. I know hberaud and others are engaged and invested on making this work; it'll be nice to give them fresh data to use towards that goal. | |
| 18:28:55 | dansmith | sure, but whether or not the asyncio hub is a good idea depends on some tests, IMHO | |
| 18:50:17 | gmann | bauzas: sean-k-mooney: read logs for instance action event. I do not think it is API change and should not require microversion bump. there is no change in response fields and It is populating the response with data we have in DB. | |
| 18:50:55 | sean-k-mooney | gmann: ya that was my sense too. | |
| 18:51:11 | sean-k-mooney | we can see if anyone else disagree tomorrow or the ptg | |
| 18:51:12 | gmann | From interop perspective, I think that is what this API is. "there are always possibilities of empty action and events". so it is very easily discoverable items in list | |
| 18:51:38 | gmann | sean-k-mooney: yeah, I will add my opinion in etherpad too and we can discuss in PTG | |
| 19:29:14 | bauzas | gmann: thanks for the short answer, and I'm fine with it, I was opiniating on the same point | |
| 19:36:39 | opendevreview | Merged openstack/nova master: Update contributor guide for 2024.2 Dalmatian https://review.opendev.org/c/openstack/nova/+/913481 | |
| #openstack-nova - 2024-03-26 | |||
| 13:53:55 | opendevreview | Anton Kurbatov proposed openstack/nova master: Fixing the 500 HTTP code in the metadata service for incorrect queries https://review.opendev.org/c/openstack/nova/+/914249 | |
| 15:14:30 | opendevreview | ribaudr proposed openstack/nova master: Fix: Live migrating to a host with cpu_shared_set configured will now update the VM's configuration accordingly. https://review.opendev.org/c/openstack/nova/+/903706 | |
| 15:14:31 | opendevreview | ribaudr proposed openstack/nova master: Test live migration between hosts with differnet cpu_shared_sets https://review.opendev.org/c/openstack/nova/+/913744 | |
| 16:00:40 | bauzas | #startmeeting nova | |
| 16:00:40 | opendevmeet | Meeting started Tue Mar 26 16:00:40 2024 UTC and is due to finish in 60 minutes. The chair is bauzas. Information about MeetBot at http://wiki.debian.org/MeetBot. | |
| 16:00:40 | opendevmeet | Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. | |
| 16:00:40 | opendevmeet | The meeting name has been set to 'nova' | |
| 16:00:49 | Uggla | o/ | |
| 16:01:07 | auniyal | o/ | |
| 16:01:13 | bauzas | sorry guys, I don't have the agenda prepared | |
| 16:01:15 | grandchild | o/ | |
| 16:01:17 | bauzas | but let's start | |
| 16:01:42 | dansmith | o/ | |
| 16:02:11 | bauzas | #link https://wiki.openstack.org/wiki/Meetings/Nova#Agenda_for_next_meeting | |
| 16:02:23 | bauzas | #topic Bugs (stuck/critical) | |
| 16:02:28 | elodilles | o/ | |
| 16:02:33 | bauzas | #info No Critical bug | |
| 16:02:48 | bauzas | #link https://bugs.launchpad.net/nova/+bugs?search=Search&field.status=New 65 new untriaged bugs (+2 since the last meeting) | |
| 16:02:53 | bauzas | #info Add yourself in the team bug roster if you want to help https://etherpad.opendev.org/p/nova-bug-triage-roster | |
| 16:03:08 | bauzas | I don't know who could be the next baton | |
| 16:03:17 | bauzas | but I don't want to take it | |
| 16:03:52 | bauzas | so, anyone interested ? | |
| 16:04:18 | elodilles | next week i can take it, but not before the 2024.1 Caracal release :/ | |
| 16:04:33 | bauzas | #info bug baton is bauzas | |
| 16:04:39 | bauzas | I'm done, I'll take it | |
| 16:04:45 | bauzas | moving on | |
| 16:05:17 | bauzas | #topic Gate status | |
| 16:05:49 | bauzas | #link https://bugs.launchpad.net/nova/+bugs?field.tag=gate-failure Nova gate bugs | |
| 16:05:52 | bauzas | #link https://etherpad.opendev.org/p/nova-ci-failures-minimal | |
| 16:05:54 | dansmith | I haven't been following much gate stuff lately | |
| 16:05:58 | bauzas | #link https://zuul.openstack.org/builds?project=openstack%2Fnova&project=openstack%2Fplacement&pipeline=periodic-weekly Nova&Placement periodic jobs status | |
| 16:06:01 | dansmith | too many other things in the air | |
| 16:06:02 | bauzas | #info Please look at the gate failures and file a bug report with the gate-failure tag. | |
| 16:06:22 | bauzas | #info Please try to provide meaningful comment when you recheck | |
| 16:06:35 | Uggla | bauzas, I can take the bug baton | |
| 16:06:44 | bauzas | nevermind, took it | |
| 16:06:59 | bauzas | I really want a short meeting, I need to take a bit of time off | |
| 16:07:06 | bauzas | moving on | |
| 16:07:10 | bauzas | #topic Release Planning | |
| 16:07:14 | bauzas | #link https://releases.openstack.org/caracal/schedule.html#nova | |
| 16:07:33 | bauzas | #info Caracal GA planned next week | |
| 16:07:44 | bauzas | nothing to relate | |
| 16:07:53 | elodilles | and final rc week is this week | |
| 16:07:57 | bauzas | I've started a new etherpad | |
| 16:08:02 | bauzas | #link https://etherpad.opendev.org/p/nova-dalmatian-status | |
| 16:08:34 | bauzas | #topic vPTG Planning | |