| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2023-08-31 | |||
| 17:21:01 | sean-k-mooney | its running in zuul now so we can just keep an eye on it but i tought this was already merged | |
| 17:21:16 | opendevreview | John Garbutt proposed openstack/nova master: Make compute node rebalance safter https://review.opendev.org/c/openstack/nova/+/887151 | |
| 17:22:26 | johnthetubaguy | melwitt: bauzas sorry, my rebase broke the functional tests without me noticing, I fixed that up now. | |
| 17:22:43 | bauzas | johnthetubaguy: already sent back to the gate | |
| 17:23:01 | johnthetubaguy | thank you. | |
| 17:23:52 | melwitt | dual wielding | |
| 17:23:55 | sean-k-mooney | so given how close this is if it does not merge today i would be open to an FFE for the ironic shard stuff | |
| 17:25:05 | bauzas | we don't need to define a RFE process | |
| 17:25:36 | bauzas | the ironic shard one can be late approved IMHO, one core is already giving his go, and two patches of 4 are already +W | |
| 17:25:52 | bauzas | eventually, the change surface is quite restricted to the ironic driver | |
| 17:26:14 | sean-k-mooney | well more just indrectly noting that today is thehnicall feature freeze | |
| 17:26:35 | sean-k-mooney | but as you note it had +2 across the borad | |
| 17:26:36 | bauzas | so, provided JayF or other ironic folks can hardly stress-test this thing and can provide bugfixes those 2 weeks, I'm good | |
| 17:26:49 | melwitt | this patch has only one +2 but was +W'ed, was that intentional? https://review.opendev.org/c/openstack/nova/+/887151 | |
| 17:26:51 | bauzas | sean-k-mooney: I'm very well aware of today's FF :) | |
| 17:27:07 | johnthetubaguy | in perfect timing, I am going to the beach tomorrow... (obvs to celebrate feature freeze with an ice cream) | |
| 17:27:22 | bauzas | melwitt: doh, my fault ! | |
| 17:27:28 | sean-k-mooney | johnthetubaguy: nice | |
| 17:27:35 | sean-k-mooney | johnthetubaguy: enjoy it | |
| 17:27:49 | sean-k-mooney | im also not planning to be here at this time tomrorrow evening | |
| 17:28:18 | bauzas | melwitt: I don't know why but when I proxy'd your +W on the dependent patch, I messed up and added it too to the top patch | |
| 17:28:24 | johnthetubaguy | Thanks for the reviews, I am back Monday if there is stuff to help push it across the line | |
| 17:28:28 | bauzas | apologies, no pun intended | |
| 17:28:37 | melwitt | ah ok | |
| 17:29:34 | bauzas | https://etherpad.opendev.org/p/nova-bobcat-blueprint-status tells me we are mostly done with all the blueprints we were able to review | |
| 17:29:57 | bauzas | except the large manila series and the ephemeral storage | |
| 17:32:39 | bauzas | so, again, we still have some patches requiring second +2 on https://review.opendev.org/q/topic:ironic-shards and https://review.opendev.org/q/topic:bp%252Funified-limits-nova-tool-and-docs | |
| 17:32:47 | bauzas | for me, my day is almost over | |
| 17:33:03 | bauzas | but I can hang for a bit | |
| 17:37:37 | zer0c00l | I think this change in libvirt 9.5.0 (shipped with centos stream 9) breaks nova, (atleast yoga) https://github.com/libvirt/libvirt/commit/a2ae3d299cf Any one seen this before? | |
| 17:39:29 | sean-k-mooney | zer0c00l: with what network backend | |
| 17:39:46 | sean-k-mooney | calico? | |
| 17:40:09 | sean-k-mooney | the intree network backends do not create taps nor does os-vif | |
| 17:40:19 | sean-k-mooney | they are only created by libvirt | |
| 17:41:07 | sean-k-mooney | zer0c00l: i am not aware of any supported backend where the tap is precreated | |
| 17:41:19 | sean-k-mooney | so i dont think this will impact nova | |
| 17:41:20 | zer0c00l | sean-k-mooney: yeah we are running calico | |
| 17:41:47 | sean-k-mooney | well even in the calico case libvirt is ment to create the tap | |
| 17:42:07 | sean-k-mooney | calico just manges the routing | |
| 17:54:10 | sean-k-mooney | calico is apprently still using vif type tap https://github.com/projectcalico/calico/blob/cf7fa35475eba84f5afcd7f53ac7d07dcb403202/networking-calico/networking_calico/plugins/ml2/drivers/calico/test/lib.py#L66C31-L66C34 | |
| 17:54:27 | JayF | bauzas: Yeah, I am dedicating at least one full day next week to testing sharding in devstack, and potentially writing a tempest test if I get far enough :) | |
| 17:54:37 | sean-k-mooney | vif type tap is not supported by our os-vif code so its usign the legacy fallback | |
| 17:55:23 | sean-k-mooney | https://github.com/openstack/nova/blob/master/nova/virt/libvirt/vif.py#L595-L596 | |
| 17:55:47 | sean-k-mooney | https://github.com/openstack/nova/blob/master/nova/virt/libvirt/vif.py#L420-L430 | |
| 17:56:20 | sean-k-mooney | https://github.com/openstack/nova/blob/master/nova/virt/libvirt/designer.py#L44-L55 | |
| 17:57:12 | sean-k-mooney | zer0c00l: with that said the tap was always ment to be created by libvirt so it sound like calico might have been doing things it shoudl not have been | |
| 17:57:35 | zer0c00l | sean-k-mooney: Thanks for looking into this. :( | |
| 17:58:07 | sean-k-mooney | we could proably correct this with a bug fix | |
| 17:58:23 | sean-k-mooney | jsut setting managed='no' | |
| 17:58:45 | sean-k-mooney | here https://github.com/openstack/nova/blob/master/nova/virt/libvirt/vif.py#L427 | |
| 17:59:26 | sean-k-mooney | the problem is that the there is no way to test this really upstream | |
| 17:59:38 | sean-k-mooney | well beyond unit/fucntional tests | |
| 17:59:44 | sean-k-mooney | but we dont have any calico ci | |
| 18:00:09 | sean-k-mooney | calico should be the only backend using vif_type=tap | |
| 18:00:24 | sean-k-mooney | but im not sure if we woudl need a config option in the workarounds section for this or not | |
| 18:00:51 | zer0c00l | sean-k-mooney: yeah, my team member is doing exactly that. | |
| 18:01:00 | sean-k-mooney | im kind of reluctant to set managed='no' because that might eb a security issue | |
| 18:01:07 | zer0c00l | if self.target_dev is not None: | |
| 18:01:07 | zer0c00l | dev.append(etree.Element("target", dev=self.target_dev, managed=self.managed)) | |
| 18:02:22 | sean-k-mooney | zer0c00l: can you file a bug for this. | |
| 18:02:47 | zer0c00l | sean-k-mooney: i will do that. thank you. | |
| 18:08:28 | sean-k-mooney | johnthetubaguy: JayF https://review.opendev.org/c/openstack/nova/+/886980/7/nova/conf/ironic.py should that really be mutable? | |
| 18:09:02 | JayF | I think that's an astute observation by you, and it's likely better not mutable | |
| 18:09:16 | JayF | sean-k-mooney: I can add a follow up to flip it back if you wanna land that? | |
| 18:09:33 | sean-k-mooney | im not going to hold the series on that but ya a follow up would likely be a good idea | |
| 18:09:54 | JayF | ack, I might wait for it to land and do the follow up directly against master, just to ensure I don't accidentally restack the whole set | |
| 18:10:03 | JayF | but I am making a note in my calendar to check for it tomorrow morning | |
| 18:10:06 | sean-k-mooney | we have 2 +2 on everything now | |
| 18:10:15 | sean-k-mooney | so ill add a +w to that shortly | |
| 18:10:17 | JayF | exactly why I don't wanna risk accidentally re-pushing them :D | |
| 18:10:23 | sean-k-mooney | im just going to review the one patch i did not look at | |
| 18:10:48 | sean-k-mooney | heheh -R is useful to prevent change but ya we can fix this after FF | |
| 18:11:11 | JayF | I'd love to learn that trick anyway :D | |
| 18:12:28 | sean-k-mooney | it just prevents it doing any rebases | |
| 18:14:45 | sean-k-mooney | ok food just arrived. i skimed the 3rd patch and didnt see anything at a glance so im going to rely on the other reviwes and i added +w to the second patch | |
| 18:15:00 | sean-k-mooney | so the seriese shoudl have +2w all the way | |
| 18:16:17 | sean-k-mooney | melwitt: ill try and find time later tonight to look at https://review.opendev.org/q/topic:bp%252Funified-limits-nova-tool-and-docs | |
| 18:16:28 | melwitt | Uggla: re: your service token question from earlier. I dunno if you are using a "[manila]" conf section or similar, but the get_sdk_adapter helper "as-is" only considers a conf section for the given service type. the nova/service_auth.py is a helper method that will use the [service_user] conf group (allowing for sharing of the settings and not have to duplicate them for each service's conf section, for example) | |
| 18:16:46 | sean-k-mooney | if other get to it before me however dont wait for my review | |
| 18:16:48 | sean-k-mooney | o/ | |
| 18:19:41 | melwitt | sean-k-mooney: thanks � seeya later | |
| 18:19:41 | melwitt | sean-k-mooney: thanks 🙏 seeya later | |
| 18:22:21 | melwitt | Uggla: I _think_ if you added send_service_user_token = True in the [manila] section alongside the other [manila] auth it will work as-is (assuming you are wanting to send a service user token with a request). to make it work with [service_user] I think you would have to update get_sdk_adapter to accept an auth'ed session (for example Session(auth=service_auth.get_auth_plugin()) and then pass that to Connection(session=<session>) | |
| 18:22:21 | melwitt | https://docs.openstack.org/openstacksdk/latest/user/connection.html#from-existing-authenticated-session | |
| 18:55:20 | zer0c00l | sean-k-mooney: FYI https://bugs.launchpad.net/nova/+bug/2033681 | |
| 19:06:09 | opendevreview | Merged openstack/nova master: Deprecate ironic.peer_list https://review.opendev.org/c/openstack/nova/+/883346 | |
| 19:06:32 | opendevreview | Merged openstack/nova master: Add function to get all attachments in Cinder.API module https://review.opendev.org/c/openstack/nova/+/881457 | |
| 19:06:40 | opendevreview | Merged openstack/nova master: Reproducer for dangling bdms https://review.opendev.org/c/openstack/nova/+/889947 | |
| 21:00:23 | opendevreview | Merged openstack/nova master: Limit nodes by ironic shard key https://review.opendev.org/c/openstack/nova/+/886980 | |
| 21:00:31 | opendevreview | Merged openstack/placement master: Modify the comment that is confused https://review.opendev.org/c/openstack/placement/+/809948 | |
| 21:02:26 | opendevreview | Merged openstack/nova master: Delete dangling bdms https://review.opendev.org/c/openstack/nova/+/882284 | |
| 21:02:34 | opendevreview | Merged openstack/nova master: Update serial console example client for py3 https://review.opendev.org/c/openstack/nova/+/878080 | |
| 21:02:43 | opendevreview | Merged openstack/nova master: Remove unused mocks https://review.opendev.org/c/openstack/nova/+/867789 | |
| 21:02:50 | opendevreview | Merged openstack/nova master: Fix tox docs target https://review.opendev.org/c/openstack/nova/+/891033 | |
| 21:48:44 | sean-k-mooney | melwitt: o/ | |
| 21:49:43 | melwitt | sean-k-mooney: o/ | |
| 21:50:48 | sean-k-mooney | so the way the doc and porting tool are managing vcpu quota is not correct | |
| 21:50:51 | sean-k-mooney | https://review.opendev.org/c/openstack/nova/+/891646/5/nova/cmd/manage.py#3461 | |
| 21:51:13 | sean-k-mooney | but i think we can adress both of those issues in a followup patch | |
| 21:51:45 | sean-k-mooney | when migrating the quota on flavor.vcpu it should not be mapped 1:1 to the vcpu resouce class limit exclively | |