| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2023-08-22 | |||
| 16:52:10 | sean-k-mooney | the reason i mentioned the depend on mechanics is i have seen it cause merge conflict in the ci jobs that done repoduce locally | |
| 16:52:15 | sean-k-mooney | which can be very hard to debug | |
| 16:52:23 | dansmith | kgube: here's an example of how it should work these days: https://review.opendev.org/c/openstack/nova/+/650172 | |
| 16:52:27 | sean-k-mooney | i.e. using depend on in the same repo | |
| 16:53:19 | kgube | dansmith: thanks! | |
| 16:59:26 | spencerh` | sean-k-mooney: I am curious about the history with nova and libvirt tsc frequency. Is there a link to a discussion or is it possible to summarize concerns? Not expecting to get this in this cycle, but this patch has been critical for us. | |
| 16:59:35 | sean-k-mooney | kgube: the VolumesExtendAttachedTest test in tempest in the nfs job is skiped by hte way | |
| 16:59:49 | sean-k-mooney | kgube: so its not actully being tested by that job | |
| 17:00:13 | sean-k-mooney | spencerh`: bascially it comes done to the fact it will break live migration | |
| 17:00:30 | sean-k-mooney | we do not have the ablity to schdule based on the clock rate fo the hsot cpus | |
| 17:01:10 | sean-k-mooney | and if we allwo you to set the tsc_frequency via a host config option then we need rpc change to check comaptiablity | |
| 17:01:19 | spencerh` | The tsc frequency doesn't have to match the host capabilities on our cpus. Maybe that's vendor specific? | |
| 17:01:33 | sean-k-mooney | this is also not somethign that should chagne over the life time of the vm so it should not be a host level opation but rather an image property | |
| 17:01:58 | spencerh` | In my experience, it's the opposite: when invtsc is enabled, not setting tsc frequency will break live migration. | |
| 17:02:01 | sean-k-mooney | as far as ia am aware it cant exceed the host frequency on intel | |
| 17:02:29 | sean-k-mooney | a requicemnet if invtsc is that live migration is only supproted between hosts with the same frequesncy yes | |
| 17:02:37 | sean-k-mooney | and seting it in the xml is the workaroudn for aht | |
| 17:02:51 | sean-k-mooney | https://blueprints.launchpad.net/nova/+spec/config-tsc-freq | |
| 17:03:22 | sean-k-mooney | that is the blueprint that was propsed for adding invTSC orginally | |
| 17:03:53 | dansmith | spencerh`: I imagine anything like this will need a spec and discussion where we can make sure the experts in a given area have time to opine about such a change | |
| 17:04:06 | dansmith | spencerh`: so that's a good place to document the how and why, the impacts and other considerations | |
| 17:04:44 | spencerh` | Sounds good! Sorry, I'm not familiar with the spec process, but I'll be happy to talk about our environment and why we need this. Thanks for the background! | |
| 17:05:12 | kgube | sean-k-mooney, yeah, I will try to make a change that enables it in the job and make this dependent on the NFS driver support change. | |
| 17:05:25 | dansmith | spencerh`: https://specs.openstack.org/openstack/nova-specs/ | |
| 17:06:01 | spencerh` | dansmith: ty! | |
| 17:06:05 | sean-k-mooney | spencerh`: i started reviewing your code change by the way. you have a lot of random formatingin changes in it that should be remvoed | |
| 17:06:40 | spencerh` | Oh no. Probably because I enabled autopep8. I will fix | |
| 17:07:15 | sean-k-mooney | autopep8 shoudl not make these changes | |
| 17:07:22 | sean-k-mooney | we have it enabeld in ci | |
| 17:08:48 | spencerh` | Strange. Maybe my local instance is using different settings. There were fewer lines of diff before I messed it up this morning. I'll get that fixed. | |
| 17:21:24 | opendevreview | Spencer Harmon proposed openstack/nova master: libvirt tsc_frequency https://review.opendev.org/c/openstack/nova/+/891924 | |
| 17:23:09 | spencerh` | Looks better now. Sorry about that. (But no rush to review) | |
| 18:35:47 | sean-k-mooney | spencerh`: what is your usecase for enabeling the invtsc by the way | |
| 18:36:39 | sean-k-mooney | im just wonderign if the hpet provided by https://review.opendev.org/c/openstack/nova/+/605902 is enouch for your usecase of if you really need the tsc time source | |
| 18:38:31 | spencerh` | Haha it is very similar. I work at blizzard and we're running game servers on that have invtsc as a requirement (for lower latency/better performance). It's not windows specific, though. We're running various flavors of linux for the guests. | |
| 18:39:36 | spencerh` | Oh sorry. I conflated what you said with the spec. | |
| 18:40:02 | spencerh` | No, I don't think this will provide what's required for libvirt to live migrate with invtsc enabled. | |
| 18:40:18 | sean-k-mooney | yes we added invtsc and htpe for blizzard specicifcally in the past | |
| 18:40:41 | sean-k-mooney | right it does not i was asking can invtsc be disabled and use the hpet instead | |
| 18:41:17 | sean-k-mooney | the invtsc flag tells the guest tha tthe TSC is stable and wont change frequency | |
| 18:41:31 | spencerh` | I'll have to benchmark that to see if it solves the same issues that invtsc does. AFAIK, these are not fungible as far as the workload is concerned. | |
| 18:42:04 | sean-k-mooney | they gerneally shoudl be if the workload is not direfctly calling the TSC | |
| 18:42:17 | spencerh` | The workload does directly call the tsc. | |
| 18:42:21 | sean-k-mooney | the tsc is often used because its really fast to read | |
| 18:42:39 | sean-k-mooney | but its also generally not the most stable time source espcially in a vm | |
| 18:42:41 | sean-k-mooney | ack | |
| 19:34:57 | sean-k-mooney | dansmith: the lazy load serise all looks good overal. i had one of two nits inlien but they are all approved now | |
| 19:35:46 | sean-k-mooney | do you know off the top of your head what "trusted_certs" is used for in the instance. is that related to trusted boot? | |
| 19:51:44 | melwitt | sean-k-mooney: it's for this https://specs.openstack.org/openstack/nova-specs/specs/rocky/implemented/nova-validate-certificates.html | |
| 19:52:29 | sean-k-mooney | possibly but why would nova have the certs | |
| 19:53:11 | sean-k-mooney | i would expect that to be a propry of the image and there for in the instnace_system_metadata rather then the instance table | |
| 19:54:08 | sean-k-mooney | oh its form a join | |
| 19:54:11 | sean-k-mooney | ya its that | |
| 19:54:14 | sean-k-mooney | """This change will update the InstanceExtra schema to support a trusted_certs column, """ | |
| 20:04:02 | opendevreview | sean mooney proposed openstack/nova master: introduce global greenpool https://review.opendev.org/c/openstack/nova/+/873061 | |
| 20:05:08 | sean-k-mooney | i have 7 failing funcitonal tests i need to update but i think that is passing everythign else | |
| 20:11:15 | dansmith | sean-k-mooney: ack thanks | |
| 22:45:18 | opendevreview | Spencer Harmon proposed openstack/nova master: libvirt tsc_frequency https://review.opendev.org/c/openstack/nova/+/891924 | |
| 22:54:14 | opendevreview | Merged openstack/nova master: Avoid lazy-loading in resize and rebuild/evacuate https://review.opendev.org/c/openstack/nova/+/891336 | |
| 23:53:04 | opendevreview | melanie witt proposed openstack/nova master: Enable use of native threads in scatter_gather_cells https://review.opendev.org/c/openstack/nova/+/650172 | |
| #openstack-nova - 2023-08-23 | |||
| 04:02:18 | opendevreview | melanie witt proposed openstack/nova master: Enable use of native threads in scatter_gather_cells https://review.opendev.org/c/openstack/nova/+/650172 | |
| 11:08:22 | opendevreview | Alexey Stupnikov proposed openstack/nova master: Catch processutils exception by mount() properly https://review.opendev.org/c/openstack/nova/+/892496 | |
| 14:01:31 | opendevreview | sean mooney proposed openstack/nova master: introduce global greenpool https://review.opendev.org/c/openstack/nova/+/873061 | |
| 14:01:51 | sean-k-mooney | gibi: dansmith melwitt ^ i think thats the best i can do | |
| 14:02:27 | sean-k-mooney | if you figure out how to adress the remaining 7 test failures when im raising for greenlets too let me know | |
| 14:02:42 | sean-k-mooney | but i think we coudl proceed with this as is and still get most of the benifit | |
| 14:02:58 | sean-k-mooney | 7 possible leaks is a lot better then the 300+ i started with | |
| #openstack-nova - 2023-08-24 | |||
| 01:21:27 | opendevreview | melanie witt proposed openstack/nova master: Enable use of native threads in scatter_gather_cells https://review.opendev.org/c/openstack/nova/+/650172 | |
| 02:07:18 | opendevreview | Ghanshyam proposed openstack/nova master: Add service role context in policy tests https://review.opendev.org/c/openstack/nova/+/864594 | |
| 02:14:08 | opendevreview | Ghanshyam proposed openstack/nova master: Add service role context in policy tests https://review.opendev.org/c/openstack/nova/+/864594 | |
| 02:33:56 | opendevreview | Ghanshyam proposed openstack/nova master: Add service role in server_external_events API https://review.opendev.org/c/openstack/nova/+/892633 | |
| 02:47:14 | opendevreview | Ghanshyam proposed openstack/nova master: Add service role in assisted_volume_snapshots APIs https://review.opendev.org/c/openstack/nova/+/892635 | |
| 02:50:26 | opendevreview | Merged openstack/nova master: Remove a lazy load on every server show https://review.opendev.org/c/openstack/nova/+/891352 | |
| 03:25:40 | opendevreview | OpenStack Proposal Bot proposed openstack/nova master: Imported Translations from Zanata https://review.opendev.org/c/openstack/nova/+/891648 | |
| 05:28:37 | opendevreview | Ghanshyam proposed openstack/nova master: Add service role in assisted_volume_snapshots APIs https://review.opendev.org/c/openstack/nova/+/892635 | |
| 05:55:40 | opendevreview | Ghanshyam proposed openstack/nova master: Add service role in server_external_events API https://review.opendev.org/c/openstack/nova/+/892633 | |
| 06:17:53 | opendevreview | Ghanshyam proposed openstack/nova master: Default os-assisted-volume-snapshots APIs to service role https://review.opendev.org/c/openstack/nova/+/892635 | |
| 14:27:12 | kashyap | Can anyone give W+1 to this? - https://review.opendev.org/c/openstack/nova/+/886825/ | |
| 14:28:45 | kashyap | (Pick next min libvirt / QEMU versions for "C" (2024) release) | |
| 14:29:02 | kashyap | dansmith++ For doing the rechecks on the patch below! | |
| 14:30:35 | dansmith | below? | |
| 14:51:26 | kashyap | Sorry, I mean the patch that follows the above (https://review.opendev.org/c/openstack/nova/+/887255/6) | |
| 14:56:41 | gibi | ohh this reminds me of https://meetings.opendev.org/meetings/nova/2023/nova.2023-08-22-16.00.log.html#l-22 from the last meeting. kashyap could you check it if you have time? | |
| 16:50:26 | opendevreview | Merged openstack/nova master: Pick next min libvirt / QEMU versions for "C" (2024) release https://review.opendev.org/c/openstack/nova/+/886825 | |
| 18:39:28 | opendevreview | Merged openstack/nova master: Avoid lazy-loads on server create https://review.opendev.org/c/openstack/nova/+/891520 | |
| 19:56:21 | JayF | I'm getting strange errors when running Nova unit tests locally; tracebacks during test discovery > AttributeError: 'EntryPoint' object has no attribute 'module_name' | |
| 22:41:57 | JayF | Circling back, I wonder if this is a tox version thing? Are you all still expecting 3? When I activated the tox venv and did a pip install -e . in the nova checkout, left the venv and re-ran tox the tests ran | |
| 23:04:03 | opendevreview | sean mooney proposed openstack/nova master: introduce global greenpool https://review.opendev.org/c/openstack/nova/+/873061 | |
| 23:40:23 | opendevreview | Merged openstack/nova master: Avoid lazy-loads in resize https://review.opendev.org/c/openstack/nova/+/891605 | |
| #openstack-nova - 2023-08-25 | |||
| 01:07:56 | opendevreview | melanie witt proposed openstack/nova master: block_device: Add encryption attributes to swap disks https://review.opendev.org/c/openstack/nova/+/884312 | |
| 01:59:47 | opendevreview | sean mooney proposed openstack/nova master: remove untils.spawn_n https://review.opendev.org/c/openstack/nova/+/892722 | |
| 02:51:06 | opendevreview | Natz cheng proposed openstack/nova master: Updated links in documentation to be safe links https://review.opendev.org/c/openstack/nova/+/892724 | |
| 03:33:41 | opendevreview | OpenStack Proposal Bot proposed openstack/nova master: Imported Translations from Zanata https://review.opendev.org/c/openstack/nova/+/891648 | |
| 03:54:54 | opendevreview | melanie witt proposed openstack/nova master: block_device: Add encryption attributes to swap disks https://review.opendev.org/c/openstack/nova/+/884312 | |
| 08:07:38 | dvo-plv | sean-k-mooney, Hello | |
| 08:08:01 | dvo-plv | I would like to talk regarding issue, which you mentioned here: https://review.opendev.org/c/openstack/neutron/+/869510 | |
| 08:12:48 | kashyap | gibi: Just saw your ping earlier; will check (the bug https://bugs.launchpad.net/nova/+bug/2023035) | |
| 08:13:45 | gibi | kashyap: thanks! | |
| 08:20:42 | kashyap | gibi: Related: Can you get unblock the Workflow-1 here? : https://review.opendev.org/c/openstack/nova/+/871968 | |
| 08:21:09 | kashyap | Elod is on PTO and that W-1 doesn't apply (as he did based on a comment from Amit, and Amit took back his -1) | |