| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2023-08-21 | |||
| 15:53:30 | opendevreview | Dan Smith proposed openstack/nova master: Avoid lazy-loads in resize https://review.opendev.org/c/openstack/nova/+/891605 | |
| 15:53:34 | dansmith | gibi: guh, sorry forgot to update the log assertion in the test ^ | |
| 16:03:22 | admin1 | how to populate placment resource-classes | |
| 16:04:35 | sean-k-mooney | admin1: its done automaticaly by placement when the placement api starts for all standard resouce classes | |
| 16:05:54 | admin1 | ok . i will try to reboot all placement containers ( openstack-ansible ) and see if it repopulates | |
| 16:07:16 | sean-k-mooney | https://github.com/openstack/placement/blob/master/placement/objects/resource_class.py#L209-L253 | |
| 16:07:49 | sean-k-mooney | that gets called here https://github.com/openstack/placement/blob/master/placement/deploy.py#L129-L158 | |
| 16:08:42 | sean-k-mooney | whihc is the entry point of the wsgi service here https://github.com/openstack/placement/blob/master/placement/wsgi.py#L147 | |
| 16:23:22 | sean-k-mooney | dansmith: one nit in https://review.opendev.org/c/openstack/nova/+/891340 but +2 | |
| 16:23:57 | sean-k-mooney | gibi: dan uploaded a revsions since you last reviewed so it lost your +2 | |
| 16:31:26 | opendevreview | Merged openstack/nova master: [functional] Don't leak running live migration https://review.opendev.org/c/openstack/nova/+/892126 | |
| 16:40:02 | admin1 | sean-k-mooney, that worked .. many thanks .. | |
| 16:40:29 | sean-k-mooney | for what its worth looking at the code i dont see any way that service can start without populating the db | |
| 16:40:49 | sean-k-mooney | so i assume there was a db connection string config issue or similar | |
| 16:41:04 | sean-k-mooney | perhaps the database was not creted when the contaienr was started or somethign like that | |
| 22:18:10 | opendevreview | Merged openstack/nova master: Remove n-v ceph live migration job from gate https://review.opendev.org/c/openstack/nova/+/889992 | |
| 23:21:13 | opendevreview | Spencer Harmon proposed openstack/nova master: libvirt tsc_frequency https://review.opendev.org/c/openstack/nova/+/891924 | |
| #openstack-nova - 2023-08-22 | |||
| 02:01:52 | opendevreview | melanie witt proposed openstack/nova master: DNM test ephemeral encryption + resize: qcow2, raw, rbd https://review.opendev.org/c/openstack/nova/+/862416 | |
| 03:28:29 | opendevreview | OpenStack Proposal Bot proposed openstack/nova master: Imported Translations from Zanata https://review.opendev.org/c/openstack/nova/+/891648 | |
| 08:27:01 | dvo-plv | Hello Nova folks. maybe you will have a chance to review https://review.opendev.org/c/openstack/nova/+/876075 | |
| 09:29:43 | opendevreview | Danylo Vodopianov proposed openstack/nova master: Napatech SmartNIC support https://review.opendev.org/c/openstack/nova/+/859577 | |
| 09:34:21 | opendevreview | Danylo Vodopianov proposed openstack/nova master: Napatech SmartNIC support https://review.opendev.org/c/openstack/nova/+/859577 | |
| 09:39:02 | auniyal | hi dvo-plv, I am a newbie in Nova and have tried to review your patch some times, but it's seems complex. Will it be possible (if you consider) to break or segregate it into different relation patches? It might be helpful for others too. | |
| 09:40:05 | opendevreview | Danylo Vodopianov proposed openstack/os-vif master: Openvswitch driver was extended https://review.opendev.org/c/openstack/os-vif/+/859574 | |
| 11:24:47 | sean-k-mooney | auniyal: i dont really sea how you would split up dvo-plv's patches there are pretty small as is | |
| 11:27:48 | dvo-plv | I can move tests coverage into another patch and maybe some other features of it will be useful | |
| 11:28:15 | dvo-plv | if it will be useful* | |
| 11:39:22 | sean-k-mooney | test coverage should not be in diffent patches | |
| 11:45:00 | auniyal | sean-k-mooney ack | |
| 11:54:08 | opendevreview | Pierre Riteau proposed openstack/nova master: Fix a couple of typos https://review.opendev.org/c/openstack/nova/+/892300 | |
| 12:28:36 | opendevreview | sean mooney proposed openstack/nova master: introduce global greenpool https://review.opendev.org/c/openstack/nova/+/873061 | |
| 12:51:21 | opendevreview | sean mooney proposed openstack/nova master: introduce global greenpool https://review.opendev.org/c/openstack/nova/+/873061 | |
| 13:34:59 | dansmith | gibi: can you re-+2 this? I forgot to update the log level in the test since you last saw: https://review.opendev.org/c/openstack/nova/+/891340 | |
| 13:43:42 | gibi | dansmith: done | |
| 13:43:46 | dansmith | thanks | |
| 15:12:31 | sean-k-mooney | hum interesting https://review.opendev.org/c/openstack/nova/+/873061?tab=change-view-tab-header-zuul-results-summary | |
| 15:12:41 | sean-k-mooney | so the devstack jobs all passed | |
| 15:14:14 | sean-k-mooney | all the leaked greentrheads are in 3 moudles nova.tests.unit.virt.libvirt nova.tests.unit.test_service.TestWSGIService and nova.tests.unit.test_wsgi.TestWSGIServer | |
| 15:15:43 | sean-k-mooney | the functionaltests are similar so its proably that the relevent code that is leakign the greenthreads is shared. | |
| 15:50:33 | gibi | nova weekly meeting will start here in 10 minutes. I will be your host today and I try to do a quick meeting. | |
| 16:00:59 | gibi | #startmeeting nova | |
| 16:00:59 | opendevmeet | Meeting started Tue Aug 22 16:00:59 2023 UTC and is due to finish in 60 minutes. The chair is gibi. Information about MeetBot at http://wiki.debian.org/MeetBot. | |
| 16:00:59 | opendevmeet | Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. | |
| 16:00:59 | opendevmeet | The meeting name has been set to 'nova' | |
| 16:01:04 | auniyal | \o | |
| 16:01:05 | gibi | o/ | |
| 16:01:10 | sean-k-mooney | o/ | |
| 16:01:11 | dansmith | o/ | |
| 16:01:11 | gmann | o/ | |
| 16:01:18 | dansmith | when does bauzas get back? 2024? | |
| 16:01:25 | sean-k-mooney | i think monday | |
| 16:01:31 | sean-k-mooney | but i didnt check whcih year | |
| 16:01:39 | dansmith | "Monday, 2024" | |
| 16:02:23 | gibi | yepp 28th of Aug he is back | |
| 16:02:49 | gibi | so you will get rid of me being the chair after this meeting :) | |
| 16:03:16 | gibi | lets start | |
| 16:03:25 | gibi | #topic Bugs (stuck/critical) | |
| 16:03:32 | gibi | I don't see any critical bug | |
| 16:03:47 | gibi | #link https://bugs.launchpad.net/nova/+bugs?search=Search&field.status=New 43 new untriaged bugs (+3 since the last meeting) | |
| 16:03:52 | gibi | #info bug baton is on PTO (bauzas please pass it forward after the summer period) | |
| 16:04:09 | gibi | is there any bugs we need to discuss? | |
| 16:04:41 | andrewbonney | If anyone could assess https://bugs.launchpad.net/nova/+bug/2023035 it would be appreciated as it's blocking us upgrading to 2023.1 without using old config workarounds | |
| 16:05:16 | opendevreview | Merged openstack/nova master: Log excessive lazy-loading behavior https://review.opendev.org/c/openstack/nova/+/891340 | |
| 16:05:44 | dansmith | \o/ | |
| 16:06:39 | gibi | andrewbonney: I see you know about the workaround | |
| 16:07:16 | andrewbonney | Yeah, just doesn't feel ideal if it's easily patchable | |
| 16:07:20 | gibi | andrewbonney: I did not look deeper but it seems the one of the recent comment shows what is the difference between the two host cpus | |
| 16:07:40 | dansmith | isn't this a libvirt thing anyway? | |
| 16:08:05 | gibi | could be | |
| 16:08:51 | dansmith | I guess it says libvirt version is the same on both ends, so hmm | |
| 16:08:54 | gibi | `cpu_mode = host-model` so I guess it is difference between the model | |
| 16:09:03 | dansmith | maybe we could get kashyap to look at this | |
| 16:09:31 | andrewbonney | We'd be happy to provide any other debug if it's useful | |
| 16:09:31 | sean-k-mooney | there are many factor that can cause it to fail | |
| 16:10:19 | sean-k-mooney | do you have diffent kernel version on the diffent hosts | |
| 16:10:41 | sean-k-mooney | this kid of sound like perhaps some of the mitigations that are enabeld are not the same on both | |
| 16:10:50 | andrewbonney | The testing we did found that the running XML for a guest failed in the virsh hypervisor-cpu-compare on the same host it was running on | |
| 16:11:08 | andrewbonney | Where cpu-compare worked | |
| 16:11:57 | sean-k-mooney | and do you have the patchs that we mreged recently to update how we did the cpu compatiblity checks | |
| 16:12:27 | andrewbonney | This was using b9089ac from 2023.1 | |
| 16:12:27 | sean-k-mooney | namely https://review.opendev.org/c/openstack/nova/+/869950 | |
| 16:12:44 | andrewbonney | Yes, we think that caused it | |
| 16:12:47 | sean-k-mooney | ok that should be in that then | |
| 16:13:24 | gibi | OK. I will ask kashyap to look at it when he is back | |
| 16:13:25 | sean-k-mooney | well that is usign the new api | |
| 16:13:37 | sean-k-mooney | that the libvirt folks told use to use | |
| 16:13:41 | dansmith | andrewbonney: is it simple to just revert that patch from what you have to see? | |
| 16:14:12 | andrewbonney | Yes I could do that tomorrow and update the bug, but given what we tested with virsh command line I think it proves it already | |
| 16:14:34 | dansmith | but yeah, we probably need to dig deeper if this is the new api we're supposed to be using and it's not doing what we want.. not sure if that means we need to do something different or not | |
| 16:14:41 | andrewbonney | It felt like the guest XML that was being put into the new API was wrong, but I don't know libvirt enough to be sure | |
| 16:14:42 | dansmith | but kashyap would probably be a good person to chase that down | |
| 16:14:57 | andrewbonney | Thanks. Don't want to take up all your meeting time :) | |
| 16:15:04 | gibi | OK, moving on | |
| 16:15:12 | gibi | any other bug to discuss? | |
| 16:16:05 | gibi | #topic Gate status | |
| 16:16:22 | dansmith | definitely improving | |
| 16:16:40 | gibi | glad to hear that | |
| 16:16:50 | dansmith | one of my patches merged today with a single +W and no rechecks | |
| 16:16:54 | dansmith | which was pretty shocking :) | |
| 16:17:30 | gibi | we also merged one functional improvement https://review.opendev.org/c/openstack/nova/+/892126 | |