Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2023-08-22
16:13:41 dansmith andrewbonney: is it simple to just revert that patch from what you have to see?
16:14:12 andrewbonney Yes I could do that tomorrow and update the bug, but given what we tested with virsh command line I think it proves it already
16:14:34 dansmith but yeah, we probably need to dig deeper if this is the new api we're supposed to be using and it's not doing what we want.. not sure if that means we need to do something different or not
16:14:41 andrewbonney It felt like the guest XML that was being put into the new API was wrong, but I don't know libvirt enough to be sure
16:14:42 dansmith but kashyap would probably be a good person to chase that down
16:14:57 andrewbonney Thanks. Don't want to take up all your meeting time :)
16:15:04 gibi OK, moving on
16:15:12 gibi any other bug to discuss?
16:16:05 gibi #topic Gate status
16:16:22 dansmith definitely improving
16:16:40 gibi glad to hear that
16:16:50 dansmith one of my patches merged today with a single +W and no rechecks
16:16:54 dansmith which was pretty shocking :)
16:17:30 gibi we also merged one functional improvement https://review.opendev.org/c/openstack/nova/+/892126
16:17:39 gibi hopefully that will help too
16:17:48 dansmith yeah, which sounds like may have more impact than it appears, which is cool
16:18:07 dansmith I'll be looking for functional failures in the gate queue once that has soaked for a while
16:18:11 gibi I will check the functional results later this week to see if the common issues are disappeared or not
16:18:16 gibi yeah
16:18:17 gmann yeah, hopefully it does not go worst during release time, current gate stability is much better
16:18:59 dansmith yep, and if we can get some +Ws on these, they'll further reduce some of our runtime loading: https://review.opendev.org/q/topic:reduce-lazy-loads
16:19:22 dansmith during periods of high load, it can take a bit to execute a lazy load, and it's all unnecessary
16:20:25 dansmith but yeah, summary is we're in a much better place than we were.. not enough to consider it done, but enough to not be very fearful of release time I think :)
16:20:27 gibi yepp, those are easy wins
16:20:54 gibi #info Please look at the gate failures and file a bug report with the gate-failure tag.
16:20:59 sean-k-mooney i can try and take a look at them
16:21:03 gibi moving on
16:21:14 gibi #topic Release Planning
16:21:36 gibi we have 2 weeks before Feature Freeze
16:22:05 gibi I expect bauzas will start a feature tracking pad as soon as he is back
16:22:28 gibi any features we need to discuss here?
16:24:03 gibi then moving on
16:24:14 gibi #topic Stable Branches
16:24:29 gibi elodilles_pto is off
16:25:02 gibi is there any stable topic to discuss?
16:26:23 gibi #topic Open discussion
16:26:28 gibi nothing on the agenda
16:26:41 opendevreview Spencer Harmon proposed openstack/nova master: libvirt tsc_frequency https://review.opendev.org/c/openstack/nova/+/891924
16:26:42 gibi any other topics to bring up?
16:27:09 kgube Yes
16:27:18 gibi go ahead
16:27:27 kgube I sould have mentioned this with the features maybe
16:27:33 gibi no worries
16:27:52 kgube I'm still working on the NFS online resize feature
16:28:15 sean-k-mooney didnt we say no to exposing the tsc_frequency in the past...
16:28:52 spencerh` Sorry for noise; didn't mean to interrupt. Trying to get tests working. Maybe a topic for next week?
16:29:09 kgube And there is a change for nova that has open dependencies in Cinder: https://review.opendev.org/c/openstack/nova/+/873560
16:30:02 kgube So bauzas listed it as "Action from owner required" in the feature tracking pad
16:30:10 sean-k-mooney kgube: so that likely will have to be next cycle
16:30:13 dansmith kgube: is tere a nova spec for that side?
16:30:22 kgube yes
16:30:30 sean-k-mooney it was not approved this cycle i think
16:30:32 kgube the spec has been merged
16:30:34 sean-k-mooney maybe last cyle
16:30:40 dansmith okay I can't find it
16:31:12 sean-k-mooney oh it was
16:31:13 kgube https://review.opendev.org/c/openstack/nova-specs/+/877233
16:31:20 sean-k-mooney https://specs.openstack.org/openstack/nova-specs/specs/2023.2/approved/use-extend-volume-completion-action.html
16:31:24 gibi https://review.opendev.org/c/openstack/nova-specs/+/877233
16:31:41 dansmith got it, wrong topic
16:32:02 kgube Anyway, the Cinder team has been slow with reviews
16:32:04 gibi does the nova side of this breaks anything without the cinder dependency?
16:32:04 sean-k-mooney ok well we can review what is the status of the cinder side
16:32:21 sean-k-mooney i dont belive so
16:32:22 kgube The is a +1, but not from the core
16:32:27 dansmith if the cinder side isn't going to be merged ASAP, I think we probably need to punt
16:32:36 dansmith and not waste time reviewing the nova side in the last two weeks
16:32:58 kgube hm, okay
16:33:57 gibi I agree
16:34:22 sean-k-mooney so if we merged the nova code the cinder volume would never be in extending so it would not break anything but i also dont like ahvign dead code espeicly when it has an api microverion
16:35:13 sean-k-mooney so ya i think we would likely want to merge both in the same release
16:35:42 sean-k-mooney strictly speaking old nova and new cinder or old cinder and new nova shoudl work with each other
16:36:13 dansmith yeah, but since it requires an api change,
16:36:44 dansmith I think we should not presumptively merge this because cinder might change their definition of what the event means, when it comes, etc and then we end up with a thing we have to technically support for no reason
16:36:47 sean-k-mooney + compute service change and min version check
16:36:51 kgube It's a bit frustrating because the Cinder change has been ready for review for weeks, and even on top of their feature tracking etherpad: https://etherpad.opendev.org/p/cinder-2023.2-bobcat-features
16:36:57 dansmith I think we've always expected these to merge in the dependent service first
16:37:10 kgube but I guess they have been very busy
16:37:16 dansmith sean-k-mooney: right, there are REST API changes, implicit RPC ones, service versions, etc
16:37:18 sean-k-mooney certenly with neutron we have
16:37:35 dansmith kgube: yeah, I definitely understand your frustration
16:37:40 gibi kgube: yes, this is frustrating
16:37:58 sean-k-mooney kgube: do you have depends on or tempest/devestack covergae to show this working by any chance
16:38:33 sean-k-mooney this is feeling more like an early pre milestone 1 type of change then the next two weeks
16:39:00 sean-k-mooney but if you have already staged the patches with depends on and can show this working in ci then that more compleing
16:39:37 kgube sean-k-mooney: It is covered by the existing online volume extend tests if you run them on an affected driver
16:39:47 dansmith no devstack change that I see
16:40:05 sean-k-mooney we do not have a cinder nfs job in novas gate
16:40:06 dansmith kgube: right, but we need to see them running against the proper driver and this change
16:40:46 sean-k-mooney the depend on relation ship si not quite right althoguh its close
16:40:52 dansmith I guess the nfs job on this patch maybe? https://review.opendev.org/c/openstack/cinder/+/873889/7?tab=change-view-tab-header-zuul-results-summary
16:40:54 kgube There is a devstack-nfs job
16:40:58 sean-k-mooney https://review.opendev.org/c/openstack/cinder/+/873686/9 woudl be the patch to make the nfs driver work
16:41:23 dansmith that patch has depends-on relationships to cinder itself, which is weird
16:41:38 sean-k-mooney ya so that patch should depend on either the nova patch
16:41:45 sean-k-mooney ro the nova patch should ideally depend on it
16:41:53 dansmith well, not reall,y
16:42:01 dansmith because you need to run a cinder patch to see that job
16:42:11 sean-k-mooney the nova patch depens on the cinder client patch which depends on https://review.opendev.org/c/openstack/cinder/+/873557/8
16:42:13 dansmith it looks like every patch in the stack depends on the thing below it or something?

Earlier   Later