| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2023-08-01 | |||
| 10:40:13 | dvo-plv | sean-k-mooney, Uggla Hello. Could you please make addotional review after merge conflict fix https://review.opendev.org/c/openstack/nova/+/876075 | |
| 10:57:48 | sean-k-mooney | dvo-plv: still looks ok to me | |
| 10:58:54 | dvo-plv | Do i have to get one more vote for merge ? | |
| 11:00:50 | sean-k-mooney | yes perhasp bauzas can review it before they go on pto. otherwise dansmith or melwitt will be on later or gmann. | |
| 11:01:37 | dvo-plv | bauzas, dansmith melwitt Maybe you will have a chance to review patchset ? https://review.opendev.org/c/openstack/nova/+/876075 | |
| 11:16:07 | frickler | I have a follow-up question to last weeks console log discussion: how can I check whether libvirtd is actually using virtlogd? so far the only test I've found is to write lots of data to the log and see if it gets cycled at 2M size | |
| 11:16:47 | frickler | (and I found that it doesn't work in kolla because virtlogd isn't running there, but that's a deployment issue) | |
| 11:30:06 | sean-k-mooney | you can configure it in qemu.conf | |
| 11:31:13 | sean-k-mooney | stdio_handler = "file" or stdio_handler = "logd" | |
| 11:31:40 | sean-k-mooney | # The backend to use for handling stdout/stderr output from | |
| 11:31:42 | sean-k-mooney | # QEMU processes. | |
| 11:31:52 | sean-k-mooney | although that may not be entirly correct | |
| 11:32:30 | sean-k-mooney | that might just handel the instance log al /var/log/libvirt/qemu/instnace-* | |
| 11:43:46 | sean-k-mooney | frickler: looking at the libvirt code i think stdio_handler in qemu.conf is what contols this | |
| 11:43:56 | sean-k-mooney | i have not found anything else that appears relevent | |
| 11:50:11 | opendevreview | Merged openstack/nova master: Add nova-tox-functional-py310 to gate jobs https://review.opendev.org/c/openstack/nova/+/881339 | |
| 11:50:46 | sean-k-mooney | odd somethign merged. | |
| 15:54:54 | auniyal | HI sean-k-mooney, can you please review and merge stable branch patches from here https://etherpad.opendev.org/p/release-liaison-PatchesToReview | |
| 15:57:12 | auniyal | elodilles- can we merge this https://review.opendev.org/c/openstack/nova/+/877500 ? | |
| 16:03:25 | sean-k-mooney | i have limited review time so i can but i wont be able to prioritsie it. ill review as i get time | |
| 16:07:41 | auniyal | ack, | |
| 17:49:54 | opendevreview | Merged openstack/nova stable/zed: Reproduce bug 1995153 https://review.opendev.org/c/openstack/nova/+/882315 | |
| 18:32:46 | frickler | melwitt: is there anything missing except reviews on https://review.opendev.org/c/openstack/nova/+/888513? got a customer that seems affected by this, too | |
| 18:37:18 | melwitt | frickler: nope, just needs reviews. it doesn't have test coverage but that's just bc I couldn't think of a meaningful test for it. I'll add a comment on the review to that effect | |
| 18:43:23 | frickler | yes, I don't see how you could test that, either. fwiw we saw this after upgrading y->z | |
| 18:48:23 | sean-k-mooney | without poisoning the decorator to detech nesting or somehting like that im not sure iether | |
| 18:49:04 | sean-k-mooney | that said i feel like this si reversing our normal pattern | |
| 18:50:01 | sean-k-mooney | i.e. we normally decorat the generic inner function and then call it form the less geneeric singel use functions | |
| 18:50:45 | melwitt | the generic function isn't executing the query though. it's just returning a query object. you need the session manager to wrap the actual query execution | |
| 18:51:06 | sean-k-mooney | ya which makes this diffent then our normal pattern | |
| 18:51:20 | sean-k-mooney | so i think the pathc makes sense | |
| 18:52:00 | sean-k-mooney | your moving the reader decorator to where the execute happens | |
| 18:54:22 | melwitt | oh, yeah. I agree the query building helper function is different than the usual pattern (which is probably part of why this happened) | |
| 18:55:38 | melwitt | that said, it's been like this for a very long time so I'm not sure what more recent thing could have made the problem occur more often, or otherwise got people to report it | |
| 18:56:54 | sean-k-mooney | the only way i cna think to test this is to make _flavor_get_query_from_db a spy and assert that the read context is heald before and after callign it | |
| 18:58:51 | sean-k-mooney | we are usign this context manager as a decorrator correct https://github.com/openstack/nova/blob/a6126881244da66edc59028ea0ef21741c6fd492/nova/db/api/api.py#L23 | |
| 18:58:59 | melwitt | yeah.. I was kinda thinking if there's a way we could test for this generically like for everything. something like a spy | |
| 18:59:39 | frickler | the only change on that file from yoga to zed is https://review.opendev.org/c/openstack/nova/+/837156/1/nova/objects/flavor.py , but I don't understand enough alchemy to see how that might affect things | |
| 19:00:10 | frickler | might of course also be something happening somewhere else | |
| 19:00:26 | sean-k-mooney | frickler this is more likely to be realted to sqlachemy version i think | |
| 19:17:59 | sean-k-mooney | melwitt: frickler maybe im too tired to think of a clear test case but i dont see anything wrong with the patch so +2 | |
| 19:19:15 | melwitt | thanks sean-k-mooney | |
| 21:15:54 | opendevreview | Merged openstack/nova master: Add integrated job to test the Nova RBAC old defaults https://review.opendev.org/c/openstack/nova/+/883557 | |
| 21:16:01 | opendevreview | Merged openstack/nova stable/zed: Save cell socket correctly when updating host NUMA topology https://review.opendev.org/c/openstack/nova/+/882316 | |
| 21:41:45 | opendevreview | Merged openstack/nova master: Add online migration for Instance.compute_id https://review.opendev.org/c/openstack/nova/+/884752 | |
| 21:41:54 | dansmith | work starting to pay off ^ | |
| 22:06:06 | gmann | \o/ | |
| #openstack-nova - 2023-08-02 | |||
| 00:23:25 | opendevreview | melanie witt proposed openstack/nova master: block_device: Add encryption attributes to swap disks https://review.opendev.org/c/openstack/nova/+/884312 | |
| 00:23:25 | opendevreview | melanie witt proposed openstack/nova master: libvirt: Configure and teardown ephemeral encryption secrets https://review.opendev.org/c/openstack/nova/+/826754 | |
| 00:23:26 | opendevreview | melanie witt proposed openstack/nova master: imagebackend: Add support to libvirt_info for LUKS based encryption https://review.opendev.org/c/openstack/nova/+/826755 | |
| 00:23:26 | opendevreview | melanie witt proposed openstack/nova master: Add encryption support to convert_image https://review.opendev.org/c/openstack/nova/+/870934 | |
| 00:23:27 | opendevreview | melanie witt proposed openstack/nova master: Support create with ephemeral encryption for qcow2 https://review.opendev.org/c/openstack/nova/+/870932 | |
| 00:23:27 | opendevreview | melanie witt proposed openstack/nova master: Support resize with ephemeral encryption for qcow2 https://review.opendev.org/c/openstack/nova/+/870933 | |
| 00:23:28 | opendevreview | melanie witt proposed openstack/nova master: Add hw_ephemeral_encryption_secret_uuid image property https://review.opendev.org/c/openstack/nova/+/870935 | |
| 00:23:29 | opendevreview | melanie witt proposed openstack/nova master: Add encryption support to qemu-img rebase https://review.opendev.org/c/openstack/nova/+/870936 | |
| 00:23:29 | opendevreview | melanie witt proposed openstack/nova master: Support snapshot with ephemeral encryption for qcow2 https://review.opendev.org/c/openstack/nova/+/870937 | |
| 00:23:31 | opendevreview | melanie witt proposed openstack/nova master: Support rebuild and unshelve with ephemeral encryption https://review.opendev.org/c/openstack/nova/+/870939 | |
| 00:23:31 | opendevreview | melanie witt proposed openstack/nova master: WIP Support rescue with ephemeral encryption https://review.opendev.org/c/openstack/nova/+/873675 | |
| 00:23:33 | opendevreview | melanie witt proposed openstack/nova master: libvirt: Introduce support for qcow2 with LUKS https://review.opendev.org/c/openstack/nova/+/772273 | |
| 00:23:33 | opendevreview | melanie witt proposed openstack/nova master: WIP libvirt: Introduce support for raw with LUKS https://review.opendev.org/c/openstack/nova/+/884313 | |
| 00:23:35 | opendevreview | melanie witt proposed openstack/nova master: WIP libvirt: Introduce support for rbd with LUKS https://review.opendev.org/c/openstack/nova/+/889912 | |
| 00:31:59 | opendevreview | melanie witt proposed openstack/nova master: DNM test ephemeral encryption + resize: qcow2, raw, rbd https://review.opendev.org/c/openstack/nova/+/862416 | |
| 00:40:31 | opendevreview | melanie witt proposed openstack/nova master: DNM test ephemeral encryption + resize: qcow2, raw, rbd https://review.opendev.org/c/openstack/nova/+/862416 | |
| 05:22:39 | auniyal | thanks sean-k-mooney | |
| 08:15:02 | opendevreview | suzhengwei proposed openstack/nova master: rename 'recreate' to 'evacuate' https://review.opendev.org/c/openstack/nova/+/883810 | |
| 08:39:35 | dvo-plv | bauzas, dansmith melwitt Hello, maybe you will have a chance today to review patchset ? https://review.opendev.org/c/openstack/nova/+/876075 | |
| 11:03:14 | opendevreview | Merged openstack/nova stable/wallaby: Fix segment-aware scheduling permissions error https://review.opendev.org/c/openstack/nova/+/884830 | |
| 12:09:12 | opendevreview | Amit Uniyal proposed openstack/nova master: [WIP] add healthcheck utils and constants https://review.opendev.org/c/openstack/nova/+/829469 | |
| 12:09:12 | opendevreview | Amit Uniyal proposed openstack/nova master: add healthcheck endpoint to proxy commands https://review.opendev.org/c/openstack/nova/+/830703 | |
| 13:17:19 | opendevreview | Amit Uniyal proposed openstack/nova master: [WIP] add healthcheck manager to manager base https://review.opendev.org/c/openstack/nova/+/827844 | |
| 13:17:19 | opendevreview | Amit Uniyal proposed openstack/nova master: [WIP] add healthcheck tracker to nova context https://review.opendev.org/c/openstack/nova/+/829468 | |
| 13:17:20 | opendevreview | Amit Uniyal proposed openstack/nova master: [WIP] add healthcheck utils and constants https://review.opendev.org/c/openstack/nova/+/829469 | |
| 13:17:20 | opendevreview | Amit Uniyal proposed openstack/nova master: add healthcheck endpoint to proxy commands https://review.opendev.org/c/openstack/nova/+/830703 | |
| 14:23:47 | opendevreview | ribaudr proposed openstack/nova master: Allow config to support virtiofs (driver) https://review.opendev.org/c/openstack/nova/+/886522 | |
| 14:23:48 | opendevreview | ribaudr proposed openstack/nova master: Attach Manila shares via virtiofs (db) https://review.opendev.org/c/openstack/nova/+/831193 | |
| 14:23:48 | opendevreview | ribaudr proposed openstack/nova master: Attach Manila shares via virtiofs (objects) https://review.opendev.org/c/openstack/nova/+/839401 | |
| 14:23:49 | opendevreview | ribaudr proposed openstack/nova master: Attach Manila shares via virtiofs (manila abstraction) https://review.opendev.org/c/openstack/nova/+/831194 | |
| 14:23:51 | opendevreview | ribaudr proposed openstack/nova master: Attach Manila shares via virtiofs (drivers and compute manager part) https://review.opendev.org/c/openstack/nova/+/833090 | |
| 14:23:52 | opendevreview | ribaudr proposed openstack/nova master: Mounting the shares as part of the initialization process https://review.opendev.org/c/openstack/nova/+/880075 | |
| 14:23:52 | opendevreview | ribaudr proposed openstack/nova master: Deletion of associated share mappings on instance deletion https://review.opendev.org/c/openstack/nova/+/881472 | |
| 14:23:53 | opendevreview | ribaudr proposed openstack/nova master: Add metadata for shares https://review.opendev.org/c/openstack/nova/+/850500 | |
| 14:23:53 | opendevreview | ribaudr proposed openstack/nova master: Add share_info parameter to reboot method for each driver (driver part) https://review.opendev.org/c/openstack/nova/+/854823 | |
| 14:23:54 | opendevreview | ribaudr proposed openstack/nova master: Support rebooting an instance with shares (compute manager part) https://review.opendev.org/c/openstack/nova/+/854824 | |
| 14:23:55 | opendevreview | ribaudr proposed openstack/nova master: Add share_info parameter to resume method for each driver (driver part) https://review.opendev.org/c/openstack/nova/+/860284 | |
| 14:23:55 | opendevreview | ribaudr proposed openstack/nova master: Support resuming an instance with shares (compute manager part) https://review.opendev.org/c/openstack/nova/+/860285 | |
| 14:23:56 | opendevreview | ribaudr proposed openstack/nova master: Add helper methods to rescue/unrescue shares https://review.opendev.org/c/openstack/nova/+/860286 | |
| 14:23:56 | opendevreview | ribaudr proposed openstack/nova master: Support rescuing an instance with shares (driver part) https://review.opendev.org/c/openstack/nova/+/860287 | |
| 14:23:58 | opendevreview | ribaudr proposed openstack/nova master: Support rescuing an instance with shares (compute manager part) https://review.opendev.org/c/openstack/nova/+/860288 | |
| 14:23:58 | opendevreview | ribaudr proposed openstack/nova master: Allow to mount manila share using Cephfs protocol https://review.opendev.org/c/openstack/nova/+/883862 | |
| 14:24:00 | opendevreview | ribaudr proposed openstack/nova master: Check shares support (compute manager) https://review.opendev.org/c/openstack/nova/+/885751 | |
| 14:24:00 | opendevreview | ribaudr proposed openstack/nova master: Check shares support (only API exception) https://review.opendev.org/c/openstack/nova/+/885752 | |
| 14:24:02 | opendevreview | ribaudr proposed openstack/nova master: Attach Manila shares via virtiofs (API) https://review.opendev.org/c/openstack/nova/+/836830 | |
| 14:24:02 | opendevreview | ribaudr proposed openstack/nova master: Check shares support (API) https://review.opendev.org/c/openstack/nova/+/850499 | |
| 14:24:04 | opendevreview | ribaudr proposed openstack/nova master: Add helper methods to attach/detach shares https://review.opendev.org/c/openstack/nova/+/885753 | |
| 14:24:04 | opendevreview | ribaudr proposed openstack/nova master: Add instance.share_attach notification https://review.opendev.org/c/openstack/nova/+/850501 | |
| 14:24:06 | opendevreview | ribaudr proposed openstack/nova master: Add instance.share_detach notification https://review.opendev.org/c/openstack/nova/+/851028 | |
| 14:24:06 | opendevreview | ribaudr proposed openstack/nova master: Add shares to InstancePayload https://review.opendev.org/c/openstack/nova/+/851029 | |
| 14:24:08 | opendevreview | ribaudr proposed openstack/nova master: Add instance.share_attach_error notification https://review.opendev.org/c/openstack/nova/+/860282 | |
| 14:24:08 | opendevreview | ribaudr proposed openstack/nova master: Add instance.share_detach_error notification https://review.opendev.org/c/openstack/nova/+/860283 | |
| 14:24:10 | opendevreview | ribaudr proposed openstack/nova master: Add libvirt test to ensure metadata are working. https://review.opendev.org/c/openstack/nova/+/852086 | |